mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-16 14:02:32 +02:00
Code Issues Projects Releases Wiki Activity

MDL-37003 Fix repeated line in update notification email

Browse Source 
There was a problem experienced after 2.4.0 release because the version
of the 2.4.0 release was the same as 2.5dev release. So the version
value matched twice in the loop and the line was repeated in the email.
This commit is contained in:
David Mudrák 2012-12-06 00:03:25 +01:00 committed by Eloy Lafuente (stronk7)
parent d2713eff38
commit fa1415f193
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/pluginlib.php
View File

@ -1250,9 +1250,15 @@ class available_update_checker {
foreach ($componentupdates as $componentupdate) {
if ($componentupdate->version == $componentchange['version']) {
if ($component == 'core') {
// in case of 'core' this is enough, we already know that the
// $componentupdate is a real update with higher version
$notifications[] = $componentupdate;
// In case of 'core', we already know that the $componentupdate
// is a real update with higher version ({@see self::get_update_info()}).
// We just perform additional check for the release property as there
// can be two Moodle releases having the same version (e.g. 2.4.0 and 2.5dev shortly
// after the release). We can do that because we have the release info
// always available for the core.
if ((string)$componentupdate->release === (string)$componentchange['release']) {
$notifications[] = $componentupdate;
}
} else {
// Use the plugin_manager to check if the detected $componentchange
// is a real update with higher version. That is, the $componentchange