mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-05-07 00:36:01 +02:00
Code Issues Projects Releases Wiki Activity

MDL-50612 grades: remove gradepass if there is no grading

Browse Source
This commit is contained in:
Marina Glancy 2015-07-03 15:05:30 +08:00
parent 7dc5dac678
commit fc55273e0f
1 changed files with 8 additions and 0 deletions

8
course/moodleform_mod.php

@ -142,6 +142,7 @@ abstract class moodleform_mod extends moodleform {
} }
} }
$hasgradeitems = false;
$items = grade_item::fetch_all(array('itemtype'=>'mod', 'itemmodule'=>$modulename,'iteminstance'=>$instance, 'courseid'=>$COURSE->id)); $items = grade_item::fetch_all(array('itemtype'=>'mod', 'itemmodule'=>$modulename,'iteminstance'=>$instance, 'courseid'=>$COURSE->id));
//will be no items if, for example, this activity supports ratings but rating aggregate type == no ratings //will be no items if, for example, this activity supports ratings but rating aggregate type == no ratings
if (!empty($items)) { if (!empty($items)) {
@ -151,6 +152,8 @@ abstract class moodleform_mod extends moodleform {
if ($mform->elementExists($elname)) { if ($mform->elementExists($elname)) {
$mform->hardFreeze($elname); // prevent removing of existing outcomes $mform->hardFreeze($elname); // prevent removing of existing outcomes
} }
} else {
$hasgradeitems = true;
} }
} }
@ -167,6 +170,11 @@ abstract class moodleform_mod extends moodleform {
} }
} }
if (!$hasgradeitems && $mform->elementExists('gradepass')) {
// Remove form element 'Grade to pass' since there are no grade items (when rating not selected).
$mform->removeElement('gradepass');
}
if ($gradecat === false) { if ($gradecat === false) {
// items and outcomes in different categories - remove the option // items and outcomes in different categories - remove the option
// TODO: add a "Mixed categories" text instead of removing elements with no explanation // TODO: add a "Mixed categories" text instead of removing elements with no explanation