From fcfa24f341a9e16ecb73385e8b5147f1a27f372d Mon Sep 17 00:00:00 2001
From: Sara Arjona <sara@moodle.com>
Date: Thu, 16 Dec 2021 17:22:55 +0100
Subject: [PATCH] MDL-73342 rss_client: Disable the block by default

Co-authored by: Amaia Anabitarte <amaia@moodle.com>
---
 blocks/rss_client/db/install.php | 33 ++++++++++++++++++++++++++++++++
 blocks/rss_client/db/upgrade.php | 13 ++++++++++++-
 blocks/rss_client/version.php    |  2 +-
 3 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 blocks/rss_client/db/install.php

diff --git a/blocks/rss_client/db/install.php b/blocks/rss_client/db/install.php
new file mode 100644
index 00000000000..ecf840492ed
--- /dev/null
+++ b/blocks/rss_client/db/install.php
@@ -0,0 +1,33 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * RSS client block installation.
+ *
+ * @package    block_rss_client
+ * @copyright  2021 Amaia Anabitarte <amaia@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+/**
+ * Perform the post-install procedures.
+ */
+function xmldb_block_rss_client_install() {
+    global $DB;
+
+    // Disable rss_client on new installs by default.
+    $DB->set_field('block', 'visible', 0, ['name' => 'rss_client']);
+}
diff --git a/blocks/rss_client/db/upgrade.php b/blocks/rss_client/db/upgrade.php
index f6eb7858a01..c9a6305cbb4 100644
--- a/blocks/rss_client/db/upgrade.php
+++ b/blocks/rss_client/db/upgrade.php
@@ -31,7 +31,7 @@ defined('MOODLE_INTERNAL') || die();
  * @return boolean
  */
 function xmldb_block_rss_client_upgrade($oldversion) {
-    global $CFG;
+    global $CFG, $DB;
 
     // Automatically generated Moodle v3.6.0 release upgrade line.
     // Put any upgrade step following this.
@@ -45,5 +45,16 @@ function xmldb_block_rss_client_upgrade($oldversion) {
     // Automatically generated Moodle v3.9.0 release upgrade line.
     // Put any upgrade step following this.
 
+    if ($oldversion < 2021121600) {
+        // From Moodle 4.0, this block has been disabled by default in new installations.
+        // If the site has no instances of this block, it will disabled during the upgrading process too.
+        $totalcount = $DB->count_records('block_instances', ['blockname' => 'rss_client']);
+        if ($totalcount == 0) {
+            $DB->set_field('block', 'visible', 0, ['name' => 'rss_client']);
+        }
+
+        upgrade_block_savepoint(true, 2021121600, 'rss_client', false);
+    }
+
     return true;
 }
diff --git a/blocks/rss_client/version.php b/blocks/rss_client/version.php
index 59b31dab00c..7896ae4574d 100644
--- a/blocks/rss_client/version.php
+++ b/blocks/rss_client/version.php
@@ -24,6 +24,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2021052500;        // The current plugin version (Date: YYYYMMDDXX).
+$plugin->version   = 2021121600;        // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires  = 2021052500;        // Requires this Moodle version.
 $plugin->component = 'block_rss_client'; // Full name of the plugin (used for diagnostics)