From 8a43e402470d1553ad241938c0fd68cca40b50c8 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:35:50 +0200 Subject: [PATCH 1/6] MDL-61957 gradereport_grader: Implement privacy API --- .../grader/classes/privacy/provider.php | 187 ++++++++++++++++++ .../grader/lang/en/gradereport_grader.php | 22 +++ grade/report/grader/tests/privacy_test.php | 111 +++++++++++ 3 files changed, 320 insertions(+) create mode 100644 grade/report/grader/classes/privacy/provider.php create mode 100644 grade/report/grader/tests/privacy_test.php diff --git a/grade/report/grader/classes/privacy/provider.php b/grade/report/grader/classes/privacy/provider.php new file mode 100644 index 00000000000..167de2d2efd --- /dev/null +++ b/grade/report/grader/classes/privacy/provider.php @@ -0,0 +1,187 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_grader. + * + * @package gradereport_grader + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_grader\privacy; + +defined('MOODLE_INTERNAL') || die(); + +use \core_privacy\local\metadata\collection; +use \core_privacy\local\request\transform; +use \core_privacy\local\request\writer; + +require_once $CFG->libdir.'/grade/constants.php'; + + +/** + * Privacy Subsystem for gradereport_grader implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements + \core_privacy\local\metadata\provider, + \core_privacy\local\request\user_preference_provider { + + /** + * Returns meta data about this system. + * + * @param collection $itemcollection The initialised item collection to add items to. + * @return collection A listing of user data stored through this system. + */ + public static function get_metadata(collection $items) : collection { + // There are several user preferences (shared between different courses). + // Show/hide toggles preferences. + $items->add_user_preference('grade_report_showcalculations', 'privacy:metadata:preference:grade_report_showcalculations'); + $items->add_user_preference('grade_report_showeyecons', 'privacy:metadata:preference:grade_report_showeyecons'); + $items->add_user_preference('grade_report_showaverages', 'privacy:metadata:preference:grade_report_showaverages'); + $items->add_user_preference('grade_report_showlocks', 'privacy:metadata:preference:grade_report_showlocks'); + $items->add_user_preference('grade_report_showuserimage', 'privacy:metadata:preference:grade_report_showuserimage'); + $items->add_user_preference('grade_report_showactivityicons', 'privacy:metadata:preference:grade_report_showactivityicons'); + $items->add_user_preference('grade_report_showranges', 'privacy:metadata:preference:grade_report_showranges'); + $items->add_user_preference('grade_report_showanalysisicon', 'privacy:metadata:preference:grade_report_showanalysisicon'); + // Special rows preferences. + $items->add_user_preference('grade_report_rangesdisplaytype', 'privacy:metadata:preference:grade_report_rangesdisplaytype'); + $items->add_user_preference('grade_report_rangesdecimalpoints', 'privacy:metadata:preference:grade_report_rangesdecimalpoints'); + $items->add_user_preference('grade_report_averagesdisplaytype', 'privacy:metadata:preference:grade_report_averagesdisplaytype'); + $items->add_user_preference('grade_report_averagesdecimalpoints', 'privacy:metadata:preference:grade_report_averagesdecimalpoints'); + $items->add_user_preference('grade_report_meanselection', 'privacy:metadata:preference:grade_report_meanselection'); + $items->add_user_preference('grade_report_shownumberofgrades', 'privacy:metadata:preference:grade_report_shownumberofgrades'); + // General preferences. + $items->add_user_preference('grade_report_quickgrading', 'privacy:metadata:preference:grade_report_quickgrading'); + $items->add_user_preference('grade_report_showquickfeedback', 'privacy:metadata:preference:grade_report_showquickfeedback'); + $items->add_user_preference('grade_report_studentsperpage', 'privacy:metadata:preference:grade_report_studentsperpage'); + $items->add_user_preference('grade_report_showonlyactiveenrol', 'privacy:metadata:preference:grade_report_showonlyactiveenrol'); + $items->add_user_preference('grade_report_aggregationposition', 'privacy:metadata:preference:grade_report_aggregationposition'); + $items->add_user_preference('grade_report_enableajax', 'privacy:metadata:preference:grade_report_enableajax'); + + // There is also one user preference which can be defined on each course. + $items->add_user_preference('grade_report_grader_collapsed_categories', 'privacy:metadata:preference:grade_report_grader_collapsed_categories'); + + return $items; + } + + /** + * Store all user preferences for the plugin. + * + * @param int $userid The userid of the user whose data is to be exported. + */ + public static function export_user_preferences(int $userid) { + $preferences = get_user_preferences(); + foreach ($preferences as $name => $value) { + $prefname = null; + $prefdescription = null; + $transformedvalue = null; + switch ($name) { + case 'grade_report_showcalculations': + case 'grade_report_showeyecons': + case 'grade_report_showaverages': + case 'grade_report_showlocks': + case 'grade_report_showuserimage': + case 'grade_report_showactivityicons': + case 'grade_report_showranges': + case 'grade_report_showanalysisicon': + case 'grade_report_shownumberofgrades': + case 'grade_report_quickgrading': + case 'grade_report_showonlyactiveenrol': + case 'grade_report_showquickfeedback': + case 'grade_report_enableajax': + $prefname = $name; + $transformedvalue = transform::yesno($value); + break; + case 'grade_report_meanselection': + $prefname = $name; + switch ($value) { + case GRADE_REPORT_MEAN_ALL: + $transformedvalue = get_string('meanall', 'grades'); + break; + case GRADE_REPORT_MEAN_GRADED: + $transformedvalue = get_string('meangraded', 'grades'); + break; + } + break; + case 'grade_report_rangesdecimalpoints': + case 'grade_report_averagesdecimalpoints': + case 'grade_report_studentsperpage': + $prefname = $name; + $transformedvalue = $value; + break; + case 'grade_report_rangesdisplaytype': + case 'grade_report_averagesdisplaytype': + $prefname = $name; + switch ($value) { + case GRADE_REPORT_PREFERENCE_INHERIT: + $transformedvalue = get_string('inherit', 'grades'); + break; + case GRADE_DISPLAY_TYPE_REAL: + $transformedvalue = get_string('real', 'grades'); + break; + case GRADE_DISPLAY_TYPE_PERCENTAGE: + $transformedvalue = get_string('percentage', 'grades'); + break; + case GRADE_DISPLAY_TYPE_LETTER: + $transformedvalue = get_string('letter', 'grades'); + break; + } + break; + case 'grade_report_aggregationposition': + $prefname = $name; + switch ($value) { + case GRADE_REPORT_AGGREGATION_POSITION_FIRST: + $transformedvalue = get_string('positionfirst', 'grades'); + break; + case GRADE_REPORT_AGGREGATION_POSITION_LAST: + $transformedvalue = get_string('positionlast', 'grades'); + break; + } + break; + default: + if (strpos($name, 'grade_report_grader_collapsed_categories') === 0) { + $prefname = 'grade_report_grader_collapsed_categories'; + $courseid = substr($name, strlen('grade_report_grader_collapsed_categories')); + $transformedvalue = $value; + $course = get_course($courseid); + $prefdescription = get_string( + 'privacy:request:preference:'.$prefname, + 'gradereport_grader', + (object) [ + 'name' => $course->fullname, + ] + ); + } + } + + if ($prefname !== null) { + if ($prefdescription == null) { + $prefdescription = get_string('privacy:metadata:preference:'.$prefname, 'gradereport_grader'); + } + writer::export_user_preference( + 'gradereport_grader', + $prefname, + $transformedvalue, + $prefdescription + ); + } + } + } +} diff --git a/grade/report/grader/lang/en/gradereport_grader.php b/grade/report/grader/lang/en/gradereport_grader.php index 67d867750b4..2cd5dbb218a 100644 --- a/grade/report/grader/lang/en/gradereport_grader.php +++ b/grade/report/grader/lang/en/gradereport_grader.php @@ -33,6 +33,28 @@ $string['grader:manage'] = 'Manage the grader report'; $string['grader:view'] = 'View the grader report'; $string['pluginname'] = 'Grader report'; $string['preferences'] = 'Grader report preferences'; +$string['privacy:metadata:preference:grade_report_aggregationposition'] = 'Whether the category and course total columns are displayed first or last in the gradebook reports'; +$string['privacy:metadata:preference:grade_report_averagesdecimalpoints'] = 'The number of decimal points to display for each average or whether the overall decimal points setting for the category or grade item is used (inherit).'; +$string['privacy:metadata:preference:grade_report_averagesdisplaytype'] = 'Whether the average (mean) is displayed as real grades, percentages or letters, or whether the display type for the category or grade item is used (inherit).'; +$string['privacy:metadata:preference:grade_report_enableajax'] = 'Whether to add a layer of AJAX functionality to the grader report, simplifying and speeding up common operations'; +$string['privacy:metadata:preference:grade_report_grader_collapsed_categories'] = 'List of gradebook categories to be collapsed'; +$string['privacy:metadata:preference:grade_report_meanselection'] = 'Whether cells with no grade should be included when calculating the average (mean) for each category or grade item'; +$string['privacy:metadata:preference:grade_report_quickgrading'] = 'Whether to display a text input box for each grade, allowing many grades to be edited at the same time'; +$string['privacy:metadata:preference:grade_report_rangesdecimalpoints'] = 'The number of decimal points to display for each range or whether the overall decimal points setting for the category or grade item is used (inherit)'; +$string['privacy:metadata:preference:grade_report_rangesdisplaytype'] = 'Whether the range is displayed as real grades, percentages or letters, or whether the display type for the category or grade item is used (inherit)'; +$string['privacy:metadata:preference:grade_report_showactivityicons'] = 'Whether to show the activity icons next to activity names'; +$string['privacy:metadata:preference:grade_report_showanalysisicon'] = 'Whether to show grade analysis icon by default. If the activity module supports it, the grade analysis icon links to a page with more detailed explanation of the grade and how it was obtained.'; +$string['privacy:metadata:preference:grade_report_showaverages'] = 'Whether to display an additional row with the average (mean) for each category and grade item'; +$string['privacy:metadata:preference:grade_report_showcalculations'] = 'Whether a calculator icon for each grade item and category with a visual indicator that a grade item is calculated is displayed or not when editing is turned on'; +$string['privacy:metadata:preference:grade_report_showeyecons'] = 'Whether to display the show/hide icon for each grade for controlling its visibility to the student'; +$string['privacy:metadata:preference:grade_report_showlocks'] = 'Whether to display a lock/unlock icon for each grade for controlling if the grade can be automatically updated by the related activity when editing is turned on'; +$string['privacy:metadata:preference:grade_report_shownumberofgrades'] = 'Whether to display in brackets after each average the number of grades used when calculating the average'; +$string['privacy:metadata:preference:grade_report_showonlyactiveenrol'] = 'Whether to display only active enrolled users (not suspended) in gradebook report or all the enrolled users'; +$string['privacy:metadata:preference:grade_report_showquickfeedback'] = 'Whether to display a feedback text input box with a dotted border for each grade, allowing the feedback for many grades to be edited at the same time'; +$string['privacy:metadata:preference:grade_report_showranges'] = 'Whether to display an additional row with the range for each category and grade item'; +$string['privacy:metadata:preference:grade_report_showuserimage'] = 'Whether to show the user\'s profile image next to the name'; +$string['privacy:metadata:preference:grade_report_studentsperpage'] = 'The number of students displayed per page in the grader report'; +$string['privacy:request:preference:grade_report_grader_collapsed_categories'] = 'You have some gradebook categories collapsed in the "{$a->name}" course'; $string['summarygrader'] = 'A table with the names of students in the first column, with assessable activities grouped by course and category across the top.'; $string['useractivitygrade'] = '{$a} grade'; $string['useractivityfeedback'] = '{$a} feedback'; diff --git a/grade/report/grader/tests/privacy_test.php b/grade/report/grader/tests/privacy_test.php new file mode 100644 index 00000000000..2be84b674bc --- /dev/null +++ b/grade/report/grader/tests/privacy_test.php @@ -0,0 +1,111 @@ +. + +/** + * Unit tests for the gradereport_grader implementation of the privacy API. + * + * @package gradereport_grader + * @category test + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +defined('MOODLE_INTERNAL') || die(); + +use \core_privacy\local\metadata\collection; +use \core_privacy\local\request\writer; +use \core_privacy\local\request\approved_contextlist; +use \core_privacy\local\request\deletion_criteria; +use \gradereport_grader\privacy\provider; + +/** + * Unit tests for the gradereport_grader implementation of the privacy API. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class gradereport_grader_privacy_testcase extends \core_privacy\tests\provider_testcase { + + /** + * Basic setup for these tests. + */ + public function setUp() { + $this->resetAfterTest(true); + } + + + /** + * Ensure that export_user_preferences returns no data if the user has no data. + */ + public function test_export_user_preferences_not_defined() { + $user = \core_user::get_user_by_username('admin'); + provider::export_user_preferences($user->id); + + $writer = writer::with_context(\context_system::instance()); + $this->assertFalse($writer->has_any_data()); + } + + /** + * Ensure that export_user_preferences returns single preferences. + * These preferences can be set on each course, but the value is shared in the whole site. + */ + public function test_export_user_preferences_single() { + // Add some user preferences. + $user = $this->getDataGenerator()->create_user(); + $this->setUser($user); + set_user_preference('grade_report_showcalculations', 1, $user); + set_user_preference('grade_report_meanselection', GRADE_REPORT_MEAN_GRADED, $user); + set_user_preference('grade_report_studentsperpage', 50, $user); + + // Validate exported data. + provider::export_user_preferences($user->id); + $context = context_user::instance($user->id); + $writer = writer::with_context($context); + $this->assertTrue($writer->has_any_data()); + $prefs = $writer->get_user_preferences('gradereport_grader'); + $this->assertCount(3, (array) $prefs); + $this->assertEquals( + get_string('privacy:metadata:preference:grade_report_showcalculations', 'gradereport_grader'), + $prefs->grade_report_showcalculations->description + ); + $this->assertEquals(get_string('meangraded', 'grades'), $prefs->grade_report_meanselection->value); + $this->assertEquals(50, $prefs->grade_report_studentsperpage->value); + } + + /** + * Ensure that export_user_preferences returns preferences. + */ + public function test_export_user_preferences_multiple() { + // Create a course and add a user preference. + $user = $this->getDataGenerator()->create_user(); + $this->setUser($user); + $course = $this->getDataGenerator()->create_course(); + $collapsed = serialize(['aggregatesonly' => array(), 'gradesonly' => array()]); + set_user_preference('grade_report_grader_collapsed_categories'.$course->id, $collapsed, $user); + + // Validate exported data. + provider::export_user_preferences($user->id); + $context = context_user::instance($user->id); + $writer = writer::with_context($context); + $this->assertTrue($writer->has_any_data()); + $prefs = $writer->get_user_preferences('gradereport_grader'); + $this->assertCount(1, (array) $prefs); + $this->assertEquals( + get_string('privacy:request:preference:grade_report_grader_collapsed_categories', 'gradereport_grader', ['name' => $course->fullname]), + $prefs->grade_report_grader_collapsed_categories->description + ); + } +} From 7509d232bc898ba4ad3f77e3d22be9a3a7c3c568 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:36:40 +0200 Subject: [PATCH 2/6] MDL-61957 gradereport_history: Implement privacy API --- .../history/classes/privacy/provider.php | 46 +++++++++++++++++++ .../history/lang/en/gradereport_history.php | 1 + 2 files changed, 47 insertions(+) create mode 100644 grade/report/history/classes/privacy/provider.php diff --git a/grade/report/history/classes/privacy/provider.php b/grade/report/history/classes/privacy/provider.php new file mode 100644 index 00000000000..0aec74f2c66 --- /dev/null +++ b/grade/report/history/classes/privacy/provider.php @@ -0,0 +1,46 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_history. + * + * @package gradereport_history + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_history\privacy; + +defined('MOODLE_INTERNAL') || die(); + +/** + * Privacy Subsystem for gradereport_history implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements \core_privacy\local\metadata\null_provider { + + /** + * Get the language string identifier with the component's language + * file to explain why this plugin stores no data. + * + * @return string + */ + public static function get_reason() : string { + return 'privacy:metadata'; + } +} diff --git a/grade/report/history/lang/en/gradereport_history.php b/grade/report/history/lang/en/gradereport_history.php index 0d35fdd61e7..22eb19811c8 100644 --- a/grade/report/history/lang/en/gradereport_history.php +++ b/grade/report/history/lang/en/gradereport_history.php @@ -46,6 +46,7 @@ $string['historyperpage_help'] = 'This setting determines the number of history $string['loadmoreusers'] = 'Load more users...'; $string['pluginname'] = 'Grade history'; $string['preferences'] = 'Grade history preferences'; +$string['privacy:metadata'] = 'The Grade history report only shows data stored in other locations.'; $string['revisedonly'] = 'Revised grades only'; $string['revisedonly_help'] = 'Only show grades which have been revised. From 2d84d30d1717c11eac4a0b128c4202c14901c9b0 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:36:58 +0200 Subject: [PATCH 3/6] MDL-61957 gradereport_outcomes: Implement privacy API --- .../outcomes/classes/privacy/provider.php | 46 +++++++++++++++++++ .../outcomes/lang/en/gradereport_outcomes.php | 1 + 2 files changed, 47 insertions(+) create mode 100644 grade/report/outcomes/classes/privacy/provider.php diff --git a/grade/report/outcomes/classes/privacy/provider.php b/grade/report/outcomes/classes/privacy/provider.php new file mode 100644 index 00000000000..c5c096303ec --- /dev/null +++ b/grade/report/outcomes/classes/privacy/provider.php @@ -0,0 +1,46 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_outcomes. + * + * @package gradereport_outcomes + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_outcomes\privacy; + +defined('MOODLE_INTERNAL') || die(); + +/** + * Privacy Subsystem for gradereport_outcomes implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements \core_privacy\local\metadata\null_provider { + + /** + * Get the language string identifier with the component's language + * file to explain why this plugin stores no data. + * + * @return string + */ + public static function get_reason() : string { + return 'privacy:metadata'; + } +} diff --git a/grade/report/outcomes/lang/en/gradereport_outcomes.php b/grade/report/outcomes/lang/en/gradereport_outcomes.php index e22b0e4cd41..c0f95346074 100644 --- a/grade/report/outcomes/lang/en/gradereport_outcomes.php +++ b/grade/report/outcomes/lang/en/gradereport_outcomes.php @@ -28,5 +28,6 @@ $string['courseoutcomes'] = 'Course outcomes'; $string['coursespecoutcome'] = 'Course outcomes'; $string['eventgradereportviewed'] = 'Grade outcomes report viewed'; $string['pluginname'] = 'Outcomes report'; +$string['privacy:metadata'] = 'The Grade outcomes report only shows data stored in other locations.'; $string['outcomes:view'] = 'View the outcomes report'; $string['usedgradeitem'] = 'Number of grade items'; From 36b88f19aec07b6ec65952e3a36ff3d84762b943 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:37:20 +0200 Subject: [PATCH 4/6] MDL-61957 gradereport_overview: Implement privacy API --- .../overview/classes/privacy/provider.php | 46 +++++++++++++++++++ .../overview/lang/en/gradereport_overview.php | 1 + 2 files changed, 47 insertions(+) create mode 100644 grade/report/overview/classes/privacy/provider.php diff --git a/grade/report/overview/classes/privacy/provider.php b/grade/report/overview/classes/privacy/provider.php new file mode 100644 index 00000000000..407f059fb65 --- /dev/null +++ b/grade/report/overview/classes/privacy/provider.php @@ -0,0 +1,46 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_overview. + * + * @package gradereport_overview + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_overview\privacy; + +defined('MOODLE_INTERNAL') || die(); + +/** + * Privacy Subsystem for gradereport_overview implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements \core_privacy\local\metadata\null_provider { + + /** + * Get the language string identifier with the component's language + * file to explain why this plugin stores no data. + * + * @return string + */ + public static function get_reason() : string { + return 'privacy:metadata'; + } +} diff --git a/grade/report/overview/lang/en/gradereport_overview.php b/grade/report/overview/lang/en/gradereport_overview.php index 54c178f023e..3ee4be1267b 100644 --- a/grade/report/overview/lang/en/gradereport_overview.php +++ b/grade/report/overview/lang/en/gradereport_overview.php @@ -25,4 +25,5 @@ $string['eventgradereportviewed'] = 'Grade overview report viewed'; $string['gradesoverview'] = 'Grades overview'; $string['pluginname'] = 'Overview report'; +$string['privacy:metadata'] = 'The Grade overview report only shows data stored in other locations.'; $string['overview:view'] = 'View the overview report'; From e8d0133ed5d45c0cfe97fd0e64efe42cec6238f3 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:37:35 +0200 Subject: [PATCH 5/6] MDL-61957 gradereport_singleview: Implement privacy API --- .../singleview/classes/privacy/provider.php | 46 +++++++++++++++++++ .../lang/en/gradereport_singleview.php | 1 + 2 files changed, 47 insertions(+) create mode 100644 grade/report/singleview/classes/privacy/provider.php diff --git a/grade/report/singleview/classes/privacy/provider.php b/grade/report/singleview/classes/privacy/provider.php new file mode 100644 index 00000000000..ba123677f6a --- /dev/null +++ b/grade/report/singleview/classes/privacy/provider.php @@ -0,0 +1,46 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_singleview. + * + * @package gradereport_singleview + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_singleview\privacy; + +defined('MOODLE_INTERNAL') || die(); + +/** + * Privacy Subsystem for gradereport_singleview implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements \core_privacy\local\metadata\null_provider { + + /** + * Get the language string identifier with the component's language + * file to explain why this plugin stores no data. + * + * @return string + */ + public static function get_reason() : string { + return 'privacy:metadata'; + } +} diff --git a/grade/report/singleview/lang/en/gradereport_singleview.php b/grade/report/singleview/lang/en/gradereport_singleview.php index c798ccc68d7..e6a913b2474 100644 --- a/grade/report/singleview/lang/en/gradereport_singleview.php +++ b/grade/report/singleview/lang/en/gradereport_singleview.php @@ -51,6 +51,7 @@ $string['overrideall'] = 'Override all grades'; $string['overridefor'] = 'Override for {$a}'; $string['overridenone'] = 'Do not override any grades'; $string['pluginname'] = 'Single view'; +$string['privacy:metadata'] = 'The Grade single view report only shows data stored in other locations.'; $string['savegrades'] = 'Saving grades'; $string['save'] = 'Save'; $string['savegradessuccess'] = 'Grades were set for {$a} items'; From c01040214a78830744a666f77270ed3ef4aec4bc Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Thu, 12 Apr 2018 10:38:01 +0200 Subject: [PATCH 6/6] MDL-61957 gradereport_user: Implement privacy API --- .../report/user/classes/privacy/provider.php | 76 +++++++++++++++++ .../report/user/lang/en/gradereport_user.php | 1 + grade/report/user/tests/privacy_test.php | 81 +++++++++++++++++++ 3 files changed, 158 insertions(+) create mode 100644 grade/report/user/classes/privacy/provider.php create mode 100644 grade/report/user/tests/privacy_test.php diff --git a/grade/report/user/classes/privacy/provider.php b/grade/report/user/classes/privacy/provider.php new file mode 100644 index 00000000000..d569dc6c2ac --- /dev/null +++ b/grade/report/user/classes/privacy/provider.php @@ -0,0 +1,76 @@ +. + +/** + * Privacy Subsystem implementation for gradereport_user. + * + * @package gradereport_user + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +namespace gradereport_user\privacy; + +defined('MOODLE_INTERNAL') || die(); + +use \core_privacy\local\metadata\collection; +use \core_privacy\local\request\transform; +use \core_privacy\local\request\writer; + +require_once $CFG->libdir.'/grade/constants.php'; + + +/** + * Privacy Subsystem for gradereport_user implementing null_provider. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class provider implements + \core_privacy\local\metadata\provider, + \core_privacy\local\request\user_preference_provider { + + /** + * Returns meta data about this system. + * + * @param collection $itemcollection The initialised item collection to add items to. + * @return collection A listing of user data stored through this system. + */ + public static function get_metadata(collection $items) : collection { + // User preferences (shared between different courses). + $items->add_user_preference('gradereport_user_view_user', 'privacy:metadata:preference:gradereport_user_view_user'); + + return $items; + } + + /** + * Store all user preferences for the plugin. + * + * @param int $userid The userid of the user whose data is to be exported. + */ + public static function export_user_preferences(int $userid) { + $prefvalue = get_user_preferences('gradereport_user_view_user', null, $userid); + if ($prefvalue !== null) { + $transformedvalue = transform::yesno($prefvalue); + writer::export_user_preference( + 'gradereport_user', + 'gradereport_user_view_user', + $transformedvalue, + get_string('privacy:metadata:preference:gradereport_user_view_user', 'gradereport_user') + ); + } + } +} diff --git a/grade/report/user/lang/en/gradereport_user.php b/grade/report/user/lang/en/gradereport_user.php index 953b1e7969c..e30cbdef5ff 100644 --- a/grade/report/user/lang/en/gradereport_user.php +++ b/grade/report/user/lang/en/gradereport_user.php @@ -27,5 +27,6 @@ $string['pluginname'] = 'User report'; $string['user:view'] = 'View your own grade report'; $string['myself'] = 'Myself'; $string['otheruser'] = 'User'; +$string['privacy:metadata:preference:gradereport_user_view_user'] = 'Whether to view report as current user or another user in the gradebook reports'; $string['tablesummary'] = 'The table is arranged as a list of graded items including categories of graded items. When items are in a category they will be indicated as such.'; $string['viewas'] = 'View report as'; diff --git a/grade/report/user/tests/privacy_test.php b/grade/report/user/tests/privacy_test.php new file mode 100644 index 00000000000..b44f8bff378 --- /dev/null +++ b/grade/report/user/tests/privacy_test.php @@ -0,0 +1,81 @@ +. + +/** + * Unit tests for the gradereport_user implementation of the privacy API. + * + * @package gradereport_user + * @category test + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +defined('MOODLE_INTERNAL') || die(); + +use \core_privacy\local\metadata\collection; +use \core_privacy\local\request\writer; +use \gradereport_user\privacy\provider; + +/** + * Unit tests for the gradereport_user implementation of the privacy API. + * + * @copyright 2018 Sara Arjona + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class gradereport_user_privacy_testcase extends \core_privacy\tests\provider_testcase { + + /** + * Basic setup for these tests. + */ + public function setUp() { + $this->resetAfterTest(true); + } + + /** + * Ensure that export_user_preferences returns no data if the user has no data. + */ + public function test_export_user_preferences_not_defined() { + $user = \core_user::get_user_by_username('admin'); + provider::export_user_preferences($user->id); + + $writer = writer::with_context(\context_system::instance()); + $this->assertFalse($writer->has_any_data()); + } + + /** + * Ensure that export_user_preferences returns single preferences. + * These preferences can be set on each course, but the value is shared in the whole site. + */ + public function test_export_user_preferences_single() { + // Define a user preference. + $user = $this->getDataGenerator()->create_user(); + $this->setUser($user); + set_user_preference('gradereport_user_view_user', 1, $user); + + // Validate exported data. + provider::export_user_preferences($user->id); + $context = context_user::instance($user->id); + $writer = writer::with_context($context); + $this->assertTrue($writer->has_any_data()); + $prefs = $writer->get_user_preferences('gradereport_user'); + $this->assertCount(1, (array) $prefs); + $this->assertEquals( + get_string('privacy:metadata:preference:gradereport_user_view_user', 'gradereport_user'), + $prefs->gradereport_user_view_user->description + ); + $this->assertEquals(get_string('yes'), $prefs->gradereport_user_view_user->value); + } +}