15 Commits

Author SHA1 Message Date
Sam Hemelryk
5f5776c1e6 MDL-37500 cache: integration review touchups.
Issues:
1. Fix setType calls
2. Changing from default to all and editing again, default is still selected.
3. Uncheck all options causes error.
4. Doesn't seem to be restricting based upon option.
5. Picked all and got coding error with the database thing.
6. Bad title: https://github.com/samhemelryk/moodle/commit/wip-MDL-37500-m25#L1R157
7. Amend comments - should only be removed once 2.5 is the minimum version for an upgrade.
8. Document the defaultsharing option.

Outcomes:
1. Fixed - copy paste error.
2. Fixed - mforms was applying the default value despite a value being provided. A quirk of elements with array names.
3. Fixed - validation now requires at least one option to be selected.
4. Fixed - issue rose from definitions not being re-parsed. cache/admin.php now reparses the first time a user visits the page.
5. Fixed - better purging of definitions when working with them anonymously. Unit test added.
6. Fixed - new string added and used.
7. Fixed - comments amended.

New issue to address parsing of definitions during upgrade.
New issue to add debugging notice if definition sets only one possible sharing option and that option is user input.
2013-05-07 12:49:12 +12:00
Sam Hemelryk
46e17f04c7 MDL-37500 cache: implemented sharing options and gui 2013-05-07 11:57:37 +12:00
Sam Hemelryk
acf49f4b9a MDL-39312 cache: interfaces for managing lock instances.
Bug: There was no way to create an instance of a lock plugin for use
within Moodle.
Solution: Implemented management interfaces as part of cache/admin.php
to allow for instances to be added and deleted.
This was done in along the same lines of adding store instances.
2013-04-30 16:26:34 +12:00
Damyon Wiese
c65bf47276 Merge branch 'wip-mdl-38851' of git://github.com/rajeshtaneja/moodle 2013-04-24 11:39:13 +08:00
Rajesh Taneja
81dd294f06 MDL-38851 Admin: Fixed setType notice for cache 2013-04-24 11:18:30 +08:00
Damyon Wiese
3e8e66f454 Merge branch 'wip-MDL-39294-m25' of git://github.com/samhemelryk/moodle 2013-04-23 08:59:10 +08:00
Sam Hemelryk
0153e4e686 MDL-39294 cache: added missing setType calls to admin forms 2013-04-23 09:41:40 +12:00
Sam Hemelryk
dbd2ea4e1f MDL-38565 cache: session caches now function as expected
This change is a large change to the way sessions are handled
within MUC after it was discovered that session did not function
as expected when any store other than the default session store
was being used.
As part of this change the session loader has been largely
customised in order to consolidate session data for the loader.
The unit tests have also being greatly increased to provide
better coverage for sessions.
2013-04-19 10:11:48 +12:00
Eloy Lafuente (stronk7)
f35f07e9f7 MDL-38719 forms: add some missing types.
This just adds some missing types to different places
causing phpunit tests to fail.
2013-03-26 12:13:40 +01:00
Sam Hemelryk
7d18285720 MDL-36939 cache: instance form validation now handles errors properly 2012-12-07 08:38:05 +13:00
Sam Hemelryk
26ce56fddf MDL-25290 cache: renaming to better separate store plugins from lock plugins 2012-10-08 09:53:52 +13:00
Sam Hemelryk
170f821b9d MDL-25290 cache: Fixed things up per coding style 2012-10-08 09:53:52 +13:00
Sam Hemelryk
167ad91e86 MDL-25290 cache: Added UI to view the cache lock setups and tidied up a couple of things 2012-10-08 09:53:51 +13:00
Sam Hemelryk
6fec18203b MDL-25290 cache: Renamed plugin from cache => cachestore 2012-10-08 09:53:51 +13:00
Sam Hemelryk
8139ad13a5 MDL-25290 cache: Implemented Cache API aka MUC 2012-10-08 09:53:50 +13:00