58 Commits

Author SHA1 Message Date
Huong Nguyen
0795b579fa MDL-74814 forms: Fix accessibility issue in edit profile page
- Fixed legend tag issue
 - Modified the passwordunmask Javascript hide/unhide the password field by CSS class
2022-10-17 09:31:53 +07:00
Jun Pataleta
6efeecd126 Merge branch 'MDL-75910-master' of https://github.com/andrewnicols/moodle 2022-10-10 11:07:27 +08:00
Simey Lameze
f1be9b6544 MDL-75910 core_form: Allow editor field to set a hidden label
When an editor is used in a form as part of a group, it is missing its
label element.

This happens because there is no inline template for the editor, and
therefore it reverts to using the old `toHtml` function. The legacy
function does not cater to the editor being in a group, and therefore
does not add the hidden label.

In addition, the hiddenLabel attribute was missing from the editor
element. This is a semi-standard element but must be added to each
supporting element.

Both the missing inline template for the editor, and the hidden label
attribute must be present:
- If the hidden label attribute is not present, then the standard inline
  template will add a visible label within the group.
- If the inline editor template is missing, then the label is not shown
  at all.
2022-10-06 22:53:47 +08:00
Paul Holden
a366cb4d5c MDL-61395 forms: style frozen tag element values. 2022-09-26 11:15:20 +01:00
Marina Glancy
33f81c73c3 MDL-74969 core_form: same style for headers without shortforms 2022-07-01 10:19:16 +02:00
Jun Pataleta
7dfb64c7cb MDL-74073 core: Fix collapsesections accessibility
* Fix focus outline
* Set aria-expanded state accordingly
* Set aria-expanded in the template to false by default as the default
mode of the link is to expand all the sections.

Reference:
https://www.w3.org/TR/wai-aria-practices-1.1/#disclosure
2022-03-16 14:09:14 +08:00
Jun Pataleta
3314000eaf MDL-74090 core: Proper RTL/LTR display of collapsed icons 2022-03-05 00:45:32 +08:00
Bas Brands
2faf5e8e48 MDL-72737 theme_boost: update for section header styles 2022-03-01 12:01:59 +01:00
Susanna Zanatta
7825f31607 MDL-73142 filepicker: improved contrast in allowed file types list
Changed bootstrap class from text-muted to text-dark to bring the
contrast of listed file extensions above the Level AA pass mark.
2021-11-24 16:11:58 +00:00
Simey Lameze
6c515b820b MDL-72687 form: only add legend tag if a label is set 2021-11-02 11:19:24 +08:00
Paul Holden
cf99ea1a46 MDL-72462 forms: style checkbox/radio field labels consistently.
Fixes small regression from 942dc9de that moved indentation of form
fields to the label node, but only for those labels with specific
class.
2021-09-27 18:23:51 +01:00
Bas Brands
11288e1598 MDL-71947 theme_boost: fix styles for vertical forms 2021-06-24 12:30:02 +02:00
Marina Glancy
960bb02482 MDL-71039 core_form: support valuehtmlcallback in autocomplete inline 2021-03-04 13:39:05 +01:00
Mihail Geshoski
3ac452047f MDL-47410 behat: Support selection from the datetime selector element
Adds behat support for selecting date and time from a datetime selector
element. The passed values should represent a textual date and time
description wrapped in '##' (e.g. '##first day of January 2020 08:00##',
'##1 Jan 2020 10:30##'). Also, the value 'disabled' is valid and can be
used to disable the datetime selector element.
2021-02-11 12:04:46 +08:00
Mihail Geshoski
b7bef8f297 MDL-47410 behat: Support date selection from the date selector element
Adds behat support for selecting a date from the date selector element.
The passed values should represent a textual date description wrapped
in '##' (e.g. '##first day of January 2020##', '##1 Jan 2020##'). Also,
the value 'disabled' is valid and can be used to disable the date
selector element.
2021-02-11 11:58:44 +08:00
Mihail Geshoski
d46f1a3ef4 MDL-47410 form: Add data-fieldtype attribute to checkbox inline element
Includes the data-fieldtype attribute to the checkbox inline form
element. This element does not extend the parent inline element
template due to its specific nature and therefore this attribute was
missing.
2021-02-11 11:36:27 +08:00
Jun Pataleta
e3457dc4aa MDL-70288 core: Remove duplicate labels for checkbox elements
* If there's a label, the text will serve as the description of  the
element.
2021-02-02 13:11:58 +08:00
Jun Pataleta
1d685419d4 MDL-69422 core: Convert required and help button container to div
* A span element cannot have a div as a child.
2020-11-27 23:16:03 +08:00
Bas Brands
4d181cafa5 MDL-69453 core_form: improve form UI icons and alignment 2020-11-11 13:46:00 +01:00
Shamim Rezaie
424e61d559 MDL-69649 form: Fix labels for defaultcustom form elements 2020-09-28 23:41:29 +10:00
Eloy Lafuente (stronk7)
b2cc7d93f3 Merge branch 'MDL-68844-master' of https://github.com/roland04/moodle 2020-06-02 00:08:35 +02:00
Shamim Rezaie
9c60fd18a7 MDL-68353 form: filepicker label fix 2020-05-29 14:50:32 +10:00
Shamim Rezaie
4ceff26fdf MDL-68353 admin: Not use label tag in admin setting elements when needed 2020-05-29 14:37:05 +10:00
Shamim Rezaie
f792b0ace4 MDL-68353 form: filemanager label fix 2020-05-29 14:37:01 +10:00
Shamim Rezaie
5dad4a95ac MDL-68353 form: Only include the size attribute if there is a size set 2020-05-29 13:17:08 +10:00
Shamim Rezaie
c2e48a1d85 MDL-68353 form: Removed the size attribute
The size attribute does not work with the checkbox input type.
2020-05-29 13:17:08 +10:00
Shamim Rezaie
e2aefa3ba8 MDL-68353 core: do not output empty labels 2020-05-29 13:17:08 +10:00
Mikel Martín
22a80863d5 MDL-68844 formslib: Fix inline layout for static elements 2020-05-27 13:18:35 +02:00
Ruslan Kabalin
50bf320f4d MDL-68592 formslib: Fix inline layout for nested groups 2020-05-03 21:02:30 +01:00
Shamim Rezaie
27d4e606de MDL-68269 form: fieldset in group elements should be full width 2020-03-30 18:29:23 +11:00
Pau Ferrer Ocaña
e6faed9bf0 MDL-68108 formslib: Add element password inline template 2020-03-18 08:45:04 +01:00
Andrew Nicols
e55d14e8d2 Merge branch 'MDL-68146' of https://github.com/stronk7/moodle 2020-03-11 11:33:25 +08:00
Eloy Lafuente (stronk7)
8aee741e24 MDL-68146 forms: remove duped help and advanced icons in checkboxes
They are exceptionally shown later, after the checkbox text already.

This is a fix for the regression introduced by MDL-63424.
2020-03-10 22:59:36 +01:00
Shamim Rezaie
acbbe930eb MDL-67968 form: not to put empty label when no label is available 2020-03-06 19:58:25 +11:00
Shamim Rezaie
8fe311a3a5 MDL-67968 form: grouped element label fix 2020-03-06 19:58:25 +11:00
Luca Bösch
ee2bcf3645 MDL-63424 form: allow checkboxes to have req icon. 2020-01-24 17:34:48 +01:00
Tobias Reischmann
556c4f3309 MDL-66543 forms: Make (hard) frozen textareas readonly (or disabled) 2019-10-24 13:44:15 +02:00
Tim Hunt
36f90f3ef0 MDL-66750 formslib selects: handle size attribute properly 2019-09-23 12:14:11 +01:00
sam marshall
109c77d37d MDL-38555 Forms: Prevent multiple clicking of submit button 2019-09-02 11:46:12 +01:00
Peter
02754b5165 MDL-65595 core: Remove the nowrap from the form's radio template 2019-07-31 08:15:00 +08:00
Marina Glancy
521989ec56 MDL-65217 form: id for error area 2019-04-29 14:23:27 +02:00
Peter
cb28132dce MDL-65069 mod_forum: Remove unused code and additional dev docs.
Additional updates to setting default subscription value for discussions
2019-04-24 12:01:37 +08:00
Peter
e455d6f483 MDL-65069 core_form: Expose the form's submit's class attribute
Exposed the submit button's class attribute so it can be overriden by
custom classes provided by the programmer.
2019-04-24 10:29:30 +08:00
Marina Glancy
e66acce81a MDL-64151 form: autocomplete element remove last choice
This is the same situation as was in MDL-56864 but now in 'course', 'autocomplete' and 'select' elements
- if the element allows multiple selection it is impossible to remove the last element
2019-04-11 10:00:22 +02:00
Mathew May
5db1ce5331 MDL-64506 templates: BS2 pull-x -> BS4 float-x 2019-04-03 19:47:13 +08:00
Mathew May
485932602d MDL-64506 theme: Move templates from lib/form 2019-04-03 10:07:41 +08:00
Mathew May
e969e96279 MDL-64506 theme: Create empty form templates 2019-04-03 10:07:41 +08:00
Bas Brands
716b5ffa09 MDL-62069 Theme boost: force 100% width on accepted filetypes 2018-04-26 13:17:26 +02:00
Davo Smith
766d6f9a61 MDL-53848 form: hide entire group if hideIf test is applied to the group 2017-08-17 14:52:10 +01:00
David Mudrák
8b493eb09d MDL-53240 filetypes: Enhance the filetypes element with a types browser 2017-06-01 09:20:07 +02:00