As a result of fixing the auth plugins config storage in MDL-12689, many
settings would be falsely reported as new ones by
admin/upgradesettings.php. We do not want to confuse admins so we try to
reduce the bewilderment by pre-populating the config_plugins table with
default values. This should be done only for disabled auth methods. The
enabled methods have their settings already stored, so reporting actual
new settings for them is valid.
It has never been guaranteed that settings.php would always be included
from inside the core\plugininfo\auth::load_settings() scope only.
Alternative fix would be to use $plugininfo->name but I think it is
better to be explicit here (same as we are explicit with setting names,
strings etc).
Some auth plugins used to have a mix of the legacy style of plugin names
in config_plugins table (such as 'auth/mnet') and the new correct
style (such as 'auth_mnet'). Attempting to rename the setting plugin via
low level SQL UPDATE could lead to duplicate key violation.
The patch introduces a new helper function to safely migrate the old
settings to the new ones, eventually informing the admin about the
values mismatch.
version = planned 2015051100 release version
requires= current 2015050500 rc1 version
Note: On purpose, the course format social wrong version (2015102100)
has been kept unmodified. Looking forward a solution right now.
From now on, all English strings use the new syntax. They are not
eval()'ed any more and the only valid placeholders are {$a} and
{$a->foobar}. No extra quotes escaping, dollar sign escaping and putting
double percent signs.
The modified files were exported from AMOS database repository in the
new syntax and were re-ordered by stringid. Standard GNU/GPL and PHPdoc
blocks are added. Where there was no copyright note so far, I added the
default one with Martin Dougiamas as the copyright holder.
Live long and prosper.
* Extended set_config()
* Implemented get_config() which takes over $CFG loading in setup.php
* admin/auth.php has special handling if post vars starting in pluginconfig_
* admin/auth.php print_auth_lock_options() prints a form fragment -- being called from most plugins now
* user/edit.php follows the new convention when locking down fields, both javascript UI and on POST.
* admin/auth: More solid checking for auth GET/POST var.
* admin/auth: print_auth_lock_options() now handles user field mapping options for LDAP and similar modules
* admin/auth: user mapping options have moved to config_plugins table
* auth/ldap module has migrated to using new field mapping vars -- simplified config.html a lot
* auth settings migration to config_plugins
exposes the wide array of authentication possibilities.
Authentication now has it's own page separate from other variables.
Most of this work was done by Petri Asikainen <paca@sci.fi>, who started
these changes off.
I've done some cleanups and additions which is why I'm checking it in.
It's all working pretty well at the moment but could use some testing.
Thanks, Petri! :-)
pluggable modules in the 'auth' directory.
Everything is done through authentication_user_login in lib/moodlelib.php
As well as the old default "email" confirmation, I added a new type of
confirmation "none", which basically does no confirmation at all.
