104 Commits

Author SHA1 Message Date
Paul Holden
6acc34a097 MDL-77081 forms: PHP8.1 compatibility for group/textarea elements.
See related changes in b0a83aa7, we can no longer pass null values
to some string related methods.
2023-01-31 10:51:20 +00:00
Marina Glancy
a5f92c041e MDL-74853 various: add second parameter to htmlentities functions
Default value of the $flag argument changed in PHP 8.1 from ENT_COMPAT to ENT_QUOTES | ENT_SUBSTITUTE
To ensure consistent behavior across different PHP version the second parameter is now required for the functions:
htmlspecialchars(), htmlentities(), htmlspecialchars_decode(), html_entity_decode() and get_html_translation_table()
2022-11-28 16:12:32 +01:00
Marina Glancy
4b99c6a795 MDL-76102 lib: PEAR - passing null to str functions is deprecated 2022-10-27 07:36:26 +02:00
Amaia Anabitarte
d9967a5763 MDL-73601 lib: Normalize readme_moodle.txt file name 2022-02-01 18:10:36 +01:00
Huong Nguyen
46aece2b63 MDL-71126 Quiz: Manual grading page size preference can get stuck at 0
Including in this change:
 - New positiveint regex rule to check if the value is a positive integer
2021-05-14 17:01:45 +07:00
Eloy Lafuente (stronk7)
599567977f MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
2021-02-26 11:55:24 +01:00
Kordan
c8e67bac6b MDL-70711 form: deleted useless if block
get_magic_quotes_gpc() always return false since PHP 5.3 so (1 == get_magic_quotes_gpc()) is never verified.
This allows me to safetly delete what I dropped out.
2021-01-28 08:48:55 +01:00
Mathew May
062dc67e4e MDL-65747 libraries: Remove the pear/CHAP library 2019-07-10 08:42:19 +08:00
Shamim Rezaie
706c5b3acd MDL-65506 forms: get the correct value for advcheckbox fields in js 2019-06-26 20:56:42 +10:00
Mathew May
b71e734b27 MDL-65746 libraries: Remove pear/RADIUS lib 2019-06-10 08:28:43 +08:00
Marina Glancy
f82c9d8d06 MDL-65217 form: option to randomise element ids 2019-04-29 14:23:27 +02:00
Jake Dallimore
c87010baca MDL-62947 core_form: fix remote code execution exploit in QuickForms
Applies the patch found upstream:
https://github.com/pear/HTML_QuickForm/commit/
d3a6d5c44dedf3c164c6c79198e4ef479bcedcd2 and make util methods static
for php7 compatibility.
2018-09-05 12:12:19 +08:00
Marina Glancy
e3e3e0abb7 MDL-60281 forms: PHP7.2 deprecations in PEAR 2017-10-16 09:37:20 +08:00
Marina Glancy
62a3c42947 MDL-56110 forms: debug message for php 7.1 compat
Follow up for MDL-55123
2016-10-13 09:18:34 +08:00
Dan Poltawski
0ddc7e5582 MDL-48766 lib: remove unused pear::Net::GeoIP
This was used for the previous geoip database.
2016-09-19 08:59:39 +01:00
Marina Glancy
721e2def56 MDL-55123 forms: do not call non-static methods statically
this breaks in PHP7.1
2016-09-12 12:06:18 +08:00
Rajesh Taneja
1ebda3eb8c MDL-50484 lib_formslib: Persistant input should have different id
Persistant input is appended for frozen elements
and should have different id then the actual element
2016-02-19 14:00:04 +08:00
David Monllao
3e51b0ad7e MDL-52826 forms: Using id attr
Switch from custom id references to the element's id attribute.

Extra fix to get rid of an unnecessary call to getValidationScript().
2016-01-29 10:15:25 +08:00
David Monllao
2edb12ec30 MDL-52826 forms: Move global functions to self-contained 2016-01-22 15:43:08 +08:00
Dan Poltawski
1bd60ff6a5 MDL-52285 auth: Add constructors for backwards compat
These are very unlikely to be used but just to be safe..
2015-12-10 10:34:29 +00:00
Marina Glancy
4a89e83b80 MDL-52285 auth: use __construct() for constructors 2015-12-10 13:40:42 +08:00
Marina Glancy
32fada5cb2 MDL-52081 forms: indicate usage of grandparent constructor 2015-12-10 13:38:04 +08:00
Marina Glancy
1a0df5535e MDL-52081 forms: Use __construct() for constructors 2015-12-10 13:38:01 +08:00
Damyon Wiese
60a1ea56d9 MDL-51247 forms: All new aria-pimped autocomplete mform element.
Supports static list of options - or options fetched via ajax.
Has options for single,multi and tags support.
2015-10-14 16:22:44 +01:00
Mark Nelson
112117c00e MDL-51523 core: upgraded Auth_RADIUS to 1.1.0 2015-10-04 13:53:17 -07:00
Dave Cooper
3004a92332 MDL-49534 libraries: Removed pear/HTTP/WebDav 2015-04-02 11:05:42 +02:00
Brian Barnes
8b5f402151 MDL-46467 forms: Labels have "for" attribute even when frozen 2015-01-27 14:30:22 +13:00
Dan Poltawski
a90674fc9c MDL-47496 lib: remove XML_Parser library
It has been flagged as deprecated for many years and no longer used.
2014-10-05 14:28:33 +01:00
Dan Poltawski
528ed758e6 MDL-40267 forms: fix utf8 string length rules 2013-11-05 10:20:22 +08:00
Petr Škoda
383d414478 MDL-42381 remove unused pear OLE library and other pear excel writer leftovers 2013-10-18 14:52:11 +02:00
Tim Lock
9c390d62ed MDL-41908 QuickForm: Fix PEAR Non-static method error 2013-10-01 09:53:26 +09:30
Eloy Lafuente (stronk7)
07c4a94952 MDL-38373 Use correct PEAR->loadExtension()
Current use is wrong (static) and leads to strict standards notice.
2013-03-16 11:43:03 +01:00
Justin Filip
565c0da9c9 MDL-37625 auth_radius Updated to latest version (1.5.0) of included PEAR Crypt_CHAP library. 2013-01-22 10:42:09 -05:00
Eloy Lafuente (stronk7)
e801c74c54 Merge branch 'w51_MDL-37183_m25_excelcleanup' of git://github.com/skodak/moodle 2013-01-08 23:30:19 +01:00
Petr Škoda
8e7591654a MDL-35356 improve worksheet exports
This patch removes deprecated PEAR excel export lib in favour of newer PHPExcel,
the ODS exporter implementation is finished and a test script is included.

The default Excel format is now 2007, file extension is changed automatically
to match excel format.
2013-01-06 18:15:20 +01:00
Petr Škoda
301ebbe512 MDL-37183 remove ancient unused excel library 2012-12-20 22:26:59 +01:00
Petr Skoda
66b3302dec MDL-32405 workaround for non-static PEAR::raise_error() and fixed -1 debug support 2012-04-15 17:02:26 +02:00
Petr Skoda
caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Petr Skoda
68a7c9a696 MDL-32095 some more E_STRICT fixes 2012-03-26 11:47:15 +02:00
Petr Skoda
fabbf4398b MDL-32094 some nasty quickforms hacks that should help with E_STRICT
Note: we have stopped tracking our QuickForms hacks long ago.
2012-03-18 18:39:37 +01:00
Davo Smith
9f9c794733 MDL-29147 Quickform fixed insertElementBefore to ignore duplicate unnamed elements 2012-02-27 20:05:39 +00:00
Tim Hunt
3bbac90b2a MDL-31469 formslib: fix invalid for="" attributes on optional dates 2012-02-02 18:38:01 +00:00
Tim Hunt
820b41e34f MDL-30168 formslib: untangle automatic id generation.
Previously, we had overridden the _generateId method in almost all
subclasses; and then we mostly, but not always; ignored the value that
was generated there, and instead generated new (nicer) values in
MoodleQuickForm_Renderer::renderElement. Of course, that is not really a
logical place to (re)generate ids.

I have fixed the code so that the _generateId method now uses the 'nice
id' algorithm from renderElement. This should make the whole code flow
more logical.

This make all our overriding of _generateId unnecessary.

We do need a special _generateId for radio buttons, because you often
have different radio buttons with the same name but different values.

This change should only change the ids on radio, checkbox and
advcheckbox elements. Previously, those were essentially random, so I
don't think anyone could have been relying on the particular values.

This commit also has new unit tests, first to test the basic _generateId
algorithm, and then to create and render an example form (including some
tricky things like repeat_elements) and chech the acutal ids in the
generated HTML.
2011-12-23 11:51:45 +00:00
Eloy Lafuente (stronk7)
a7fc769154 Merge branch 'w42_MDL-29914_m22_codesniffer' of git://github.com/skodak/moodle 2011-10-25 16:34:04 +02:00
Eloy Lafuente (stronk7)
bad48c0cbc MDL-29881 pear/console/getopt - deleting one more occurrence 2011-10-25 16:21:35 +02:00
Petr Skoda
9845bd201f MDL-29914 remove unused CodeSniffer lib 2011-10-25 09:14:29 +02:00
Petr Skoda
c34724de75 MDL-29881 remove old apd profiling
Profiling is now handled via xhprof extension and new profiling UI.
2011-10-23 10:45:35 +02:00
Marina Glancy
7b5702b681 MDL-19907 rewrote validation for required fields in forms, including support for editor field. Added parameter to use strict (no spaces) required fields validation 2011-07-29 13:51:26 +08:00
Petr Skoda
431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Petr Skoda
735b8252ea fixed incorrect line endings 2010-09-28 13:19:13 +00:00