28070 Commits

Author SHA1 Message Date
Sara Arjona
08d1538313 Merge branch 'MDL-70282-oauth2_improve_error' of https://github.com/leonstr/moodle 2021-02-09 11:04:54 +01:00
Sara Arjona
1d6b734108 Merge branch 'MDL-70173-master' of git://github.com/rezaies/moodle 2021-02-09 08:29:13 +01:00
Shamim Rezaie
6df239900e MDL-70173 core: Use a meaningful first level header 2021-02-09 16:16:09 +11:00
Shamim Rezaie
c0e3a4108c MDL-70173 output: All pages should have a heading
In MDL-63040, it was decided that the page header for the dashboad page
should be removed.
However, Based on Success Criteria 1.3.1 and 2.4.6 from the WebAIM's
WCAG 2 Checklist, all pages should have an <h1> element.
So I put an sr-only heading on the dashboard and all other pages, where
no page header is shown.
2021-02-09 16:16:09 +11:00
Shamim Rezaie
b0b3a53521 MDL-70173 output: use an empty alt to hide user pic from screen readers
There is no need to use WAI-ARIA to hide images from screen readers.
See https://www.w3.org/WAI/tutorials/images/decorative/
2021-02-09 16:16:09 +11:00
Andrew Nicols
f5e348ac3e Merge branch 'MDL-69898' of https://github.com/paulholden/moodle 2021-02-08 10:48:29 +08:00
Andrew Nicols
98a261b6ea Merge branch 'MDL-70614' of git://github.com/paulholden/moodle 2021-02-08 10:34:46 +08:00
Andrew Nicols
5cef15ea60 Merge branch 'MDL-70725-master' of git://github.com/sarjona/moodle 2021-02-08 10:33:52 +08:00
Andrew Nicols
6995888454 Merge branch 'MDL-69748-master' of git://github.com/rezaies/moodle 2021-02-04 11:51:57 +08:00
Shamim Rezaie
a321181fe6 MDL-69748 core: Fix hideif issue with array elements
Changed the element selector to get all array elements,
whether named or unnamed. The previus selector was only
working for elements that thir names were like name="something[]".
It was not working for name="something[a]" elements.
2021-02-04 14:37:40 +11:00
Andrew Nicols
0377b0f9fa Merge branch 'MDL-64866-master' of git://github.com/ilyatregubov/moodle 2021-02-04 11:37:01 +08:00
Andrew Nicols
031509861b Merge branch 'MDL-70579' of git://github.com/paulholden/moodle 2021-02-04 09:28:22 +08:00
Sara Arjona
407133af76 Merge branch 'MDL-70315' of git://github.com/paulholden/moodle 2021-02-03 16:04:16 +01:00
Sara Arjona
1e5a862c93 Merge branch 'MDL-70316-master' of git://github.com/mihailges/moodle 2021-02-03 15:29:23 +01:00
Eloy Lafuente (stronk7)
3d276111e1 Merge branch 'MDL-70711-master' of git://github.com/kordan/moodle 2021-02-03 13:03:50 +01:00
Sara Arjona
09cfed9186 Merge branch 'MDL-70439-master' of https://github.com/DinhHien0307/moodle 2021-02-03 13:03:02 +01:00
Sara Arjona
3abda98a2d Merge branch 'MDL-70163' of git://github.com/paulholden/moodle 2021-02-03 12:25:28 +01:00
Sara Arjona
a35c197a4a Merge branch 'MDL-66769-master' of git://github.com/ilyatregubov/moodle 2021-02-03 09:32:30 +01:00
Ilya Tregubov
dde8a5b62c MDL-66769 core_h5p: Clean up orphaned h5p records task. 2021-02-03 10:10:30 +02:00
Andrew Nicols
a35c7f5dce Merge branch 'MDL-70583-cli-progress' of https://github.com/brendanheywood/moodle 2021-02-03 08:27:05 +08:00
Brendan Heywood
ded82b7f5b MDL-70583 cli: Allow progress bars to be rendered in cli scripts 2021-02-02 22:07:14 +11:00
Andrew Nicols
1432180138 Merge branch 'MDL-70304-master' of git://github.com/ilyatregubov/moodle 2021-02-02 15:31:52 +08:00
Sara Arjona
f756d2afbe Merge branch 'MDL-70288-master-2' of git://github.com/junpataleta/moodle 2021-02-02 07:59:28 +01:00
Ilya Tregubov
e174f19db6 MDL-70304 core: updated adapter.js to 7.4.0 2021-02-02 08:58:30 +02:00
Jun Pataleta
e3457dc4aa MDL-70288 core: Remove duplicate labels for checkbox elements
* If there's a label, the text will serve as the description of  the
element.
2021-02-02 13:11:58 +08:00
Eloy Lafuente (stronk7)
43b36f6d68 Merge branch 'MDL-46256' of https://github.com/timhunt/moodle 2021-02-01 23:20:01 +01:00
Eloy Lafuente (stronk7)
cd4d387936 Merge branch 'MDL-70648-master' of git://github.com/lameze/moodle 2021-02-01 19:13:47 +01:00
Paul Holden
a01397bdce MDL-69898 admin: link to config changes report from logged event. 2021-02-01 09:14:06 +00:00
Paul Holden
43adc7a333 MDL-70614 user: consistent roles spacing in course profile. 2021-02-01 07:55:04 +00:00
Andrew Nicols
793f131019 MDL-70734 behat: Increase the WebDriver Curl timeout 2021-01-31 18:21:41 +08:00
Jake Dallimore
9a4cfdeabb Merge branch 'MDL-66979-master-7' of git://github.com/andrewnicols/moodle 2021-01-29 15:41:03 +08:00
Andrew Nicols
bead2a1d96 MDL-66979 behat: Add a step to set a timeout factor for a test 2021-01-29 14:15:24 +08:00
Eloy Lafuente (stronk7)
adc8204a83 MDL-66979 behat: Goutte driver doesn't implement setTimeouts()
Also, change:

get_real_timeout(30000)

to:

get_real_timeout(30) * 1000

because the original functions are defined to use seconds, and
having the 1000 around will help us detecting cases in the case
of a hypothetical review of uses.
2021-01-29 14:15:20 +08:00
Eloy Lafuente (stronk7)
653101964d MDL-66979 behat: Goutte driver doesn't implement setTimeouts()
Also, change:

get_real_timeout(30000)

to:

get_real_timeout(30) * 1000

because the original functions are defined to use seconds, and
having the 1000 around will help us detecting cases in the case
of a hypothetical review of uses.
2021-01-28 12:23:05 +01:00
Leon Stringer
5070f0d7ce MDL-70282 oauth: Improve error information
If the request to the OAuth 2 token endpoint fails show the response
body the endpoint returned with its HTTP status (when debug: DEVELOPER).
If no response is available show any error returned by Curl.  Previously
none of this information was available making troubleshooting difficult.

If a token refresh fails in \core\oauth2\refresh_system_tokens_task an
exception is now thrown so that the result is shown as "Fail" on
admin/tasklogs.php?filter=core\oauth2\refresh_system_tokens_task
2021-01-28 10:00:18 +00:00
Eloy Lafuente (stronk7)
2eebe68cad Merge branch 'MDL-66979-master-7' of git://github.com/andrewnicols/moodle 2021-01-28 09:07:39 +01:00
Kordan
c8e67bac6b MDL-70711 form: deleted useless if block
get_magic_quotes_gpc() always return false since PHP 5.3 so (1 == get_magic_quotes_gpc()) is never verified.
This allows me to safetly delete what I dropped out.
2021-01-28 08:48:55 +01:00
Andrew Nicols
5d8e4e9fd4 MDL-66979 behat: Set script timeout with timeout factor 2021-01-28 15:27:50 +08:00
Andrew Nicols
991c8a9e78 MDL-66979 behat: Handle driver stop failure properly
An case was found where the webdriver stop() call could fail in an
AfterScenario hook, leading to a complete rerun if no other errors were
experienced.
2021-01-28 15:07:52 +08:00
Sara Arjona
9975f5e2dc MDL-70725 oauth2: move expectException to separate method 2021-01-27 17:52:55 +01:00
Víctor Déniz
d0e99460e7 Merge branch 'MDL-70585' of git://github.com/paulholden/moodle 2021-01-27 10:52:58 +00:00
hiendinh
c3b7e5fe16 MDL-70439 Profile: Indicate user email address settings on own profile 2021-01-27 13:37:18 +07:00
Mihail Geshoski
db758db533 MDL-70316 core: Update the emoji categories in the emoji picker 2021-01-27 13:37:03 +08:00
Mihail Geshoski
adb66d4b03 MDL-70316 core: Document emoji-data upgrade and update version in core 2021-01-27 13:37:02 +08:00
Mihail Geshoski
517069bc8e MDL-70316 core: Upgrade emoji-data to 6.0.0 2021-01-27 13:35:44 +08:00
Mihail Geshoski
e840aa653a MDL-70316 core: Update the categories in the emoji data generator script
The emoji categories were modified in the newer versions of the
emoji-data library. Therefore, the category list in $categorysortorder
needs to be updated with the correct category names in order to properly
sort the categories in the generated emoji data file.
2021-01-27 13:35:44 +08:00
Mihail Geshoski
609cc46be3 MDL-70316 core: Detect category name changes in the emoji data generator
The emoji data generator script is enabled to detect inconsistencies
between the emoji category names used in the emoji-data library and the
ones used in Moodle. These inconsistencies should be fixed, as soon as
they are detected upon library upgrade.
2021-01-27 13:35:44 +08:00
Paul Holden
5ece7e75d7 MDL-70163 core: fix attachment validation when localrequestdir absent.
Switch the order of operations performed when collating list of paths
from which a user can include attachments.

First collect all normalised/absolute paths then filter empty entries,
which fixes an issue where $CFG->localrequestdir could be defined but
not exist. This would lead to an empty string being passed to strpos
which triggered a PHP warning.

Co-authored-by: Peter Burnett <peterburnett@catalyst-au.net>
2021-01-25 19:53:26 +00:00
Andrew Nicols
05fca85d8e MDL-66979 behat: Warn about old behat.yml file location 2021-01-23 20:43:20 +08:00
Paul Holden
81fdd46315 MDL-70585 course: deeper clean of path names in course export.
This fixes an issue on those systems that don't fully support unicode
characters within zip structures, which subsequently led to broken
links when browsing downloaded course content.
2021-01-22 08:15:16 +00:00