3356 Commits

Author SHA1 Message Date
Ilya Tregubov
0de64aa81b
MDL-78833 gradereport_grader: Propery align averages and ranges row.
Depending on editing mode or grade display type it can be right or
left aligned
2023-09-12 16:25:01 +08:00
Jun Pataleta
8b8efffd7e
Merge branch 'MDL-78779-master' of https://github.com/andrewnicols/moodle 2023-09-08 22:14:27 +08:00
Ilya Tregubov
b8826a7a21
MDL-78082 gradereport_grader: Remove xpath from Behat. 2023-09-08 22:13:11 +08:00
Shamim Rezaie
56abfc2d22 MDL-78082 gradereport_grader: Acceptance test for locking 2023-09-07 05:46:55 +10:00
Shamim Rezaie
8e73a9ec19 MDL-78082 core_grades: Incomplete Grade Item Handling Enhanced
Problem:
In grade_edittree_column_status::get_category_cell, an assumption was
made that $category->grade_item is always populated. However, this was
not guaranteed, leading to potential issues.

Solution:
To ensure $category->grade_item availability, a $category->load_grade_item();
call was introduced in grade_edittree_column_status::get_category_cell.
This guarantees safe usage of $category->grade_item.

Furthermore, in grade_edit_tree::build_html_tree, $category->get_grade_item()
was replaced with $category->load_grade_item() for enhanced reliability
and potential performance improvement.

Explanation:
These changes enhance robustness and efficiency in gradebook.
Addressing incomplete grade item handling improves code reliability and
user experiences.
2023-09-06 22:20:39 +10:00
Shamim Rezaie
4cf11157c2 MDL-78082 core_grades: Fix locking inconsistency
Problem:
In Moodle 4.2, an unintended change in behaviour occurred when locking
and unlocking grade items. Previously, in Moodle 4.1, locking a grade
item and then subsequently unlocking the grade item left specific grades
for students still locked if they were being locked individually.
However, in Moodle 4.2, the unintended change caused the individual
grades to be unlocked along with the grade item.

Solution:
To address this issue, I modified the set_locked calls in action.php to
pass the cascade parameter as false. Now, when locking or unlocking a
grade item, only the grade item itself is affected, leaving individual
grades unchanged. I have also modified the locking behaviour in the
grade_category class. So, similarly, when locking or unlocking a grade
category, the change applies only to the grade items and grade
categories within the category, without expanding to individual grades.

Explanation:
By making this change, we ensure that the locking mechanism behaves as
expected, providing a consistent and desirable user experience. Locking
and unlocking a grade item or category will no longer inadvertently
affect individual grades, preserving their locked status and avoiding
loss of data when unlocking a grade item associated with the total mark
of a category.
2023-09-06 22:20:39 +10:00
Shamim Rezaie
09ef2d0aa5 MDL-78082 core_grades: lock/unlock all option for grade categories
A lock/unlock option is added to the context menu of the grade
categories again. But it is only used as an auxiliary tool to lock or
unlock all the grade items within the category.
2023-09-06 22:20:39 +10:00
Shamim Rezaie
b208ea26d1 MDL-78082 core_grades: Hide lock/unlock options for grade categories
Problem:
The grade_categories table lacks a 'locked' field, making it technically
impossible to lock grade categories. In Moodle 4.1, the "category total"
column could be locked (from the edit category form), but locking grade
categories directly was not supported.

Solution:
In response to the issue, the lock/unlock feature for grade categories
has been removed. Since the grade_categories table does not have the
necessary 'locked' field, attempting to implement category locking would
be infeasible. As a result, the feature has been removed from the
interface to avoid confusion.

Explanation:
By removing the lock/unlock feature for grade categories, we ensure that
users no longer encounter non-functional options and prevent any
potential misunderstandings about the locking behaviour. Additionally,
this change aligns the user interface with the underlying database
schema and eliminates any misleading functionality.
2023-09-06 22:19:40 +10:00
Shamim Rezaie
a1cf8f143a MDL-78082 gradereport_grader: Enter should submit the form
Problem:
Previously, when users pressed the Enter key while interacting with the
grader report, instead of submitting the form, a table column was
inadvertently expanded or collapsed. This behaviour occurred due to the
expand/collapse buttons lacking an explicit 'type' attribute within the
form. As a result, these buttons were mistakenly treated as submit
buttons.

Solution:
In this commit, we have addressed the issue by ensuring that the
expand/collapse buttons now have the correct 'type' attribute set,
explicitly identifying them as non-submit buttons. This adjustment
prevents them from interfering with form submission unintentionally.

Explanation:
By making this fix, we improve the user experience in the grade book,
allowing users to navigate and interact with the interface more
smoothly. Pressing the Enter key will now trigger the form submission as
expected, rather than inadvertently activating expand/collapse actions.
2023-09-06 22:18:40 +10:00
Andrew Nicols
1629a219e9
MDL-78779 gradereport_user: Replace wait steps with expectations 2023-09-06 12:40:45 +08:00
Andrew Nicols
9366a7cf2d
Merge branch 'MDL-79045-master' of https://github.com/junpataleta/moodle 2023-09-01 10:46:34 +08:00
Jun Pataleta
e3633dc719
MDL-79045 grade: Don't enclose grade user_heading in $OUTPUT->heading()
Do not enclose \core_grades_renderer::user_heading() in
$OUTPUT->heading() and enclose the user's name in the user heading in
<h2> tags instead.
- Having <div> inside <h2> results in errors in HTML validation.
- Enclosing the whole user heading in <h2> results in the other
elements in the user heading (Message, Add to contacts) to be announced
to screen readers which can result in confusion.
2023-08-31 09:21:41 +08:00
Jun Pataleta
cc7bc1a553
Merge branch 'MDL-79064-master' of https://github.com/andrewnicols/moodle 2023-08-29 13:32:45 +08:00
Andrew Nicols
70f9c1c595
Merge branch 'MDL-78106-master' of https://github.com/kevpercy/moodle 2023-08-29 13:32:44 +08:00
Andrew Nicols
af7719682d
MDL-79064 core: Update all get_strings as uses 2023-08-29 10:57:54 +08:00
Kevin Percy
3f9dd2f210 MDL-78106 gradereport_grader: Force direction when clicking sort arrow 2023-08-28 10:03:10 +08:00
Kevin Percy
a9ea85a15d MDL-78106 gradereport_grader: Fixed sort arrow size in grader report 2023-08-28 10:00:15 +08:00
Sara Arjona
8a40192a84
MDL-78291 behat: Fix behat tests with subpanels 2023-08-25 18:48:14 +02:00
Jun Pataleta
7b94cd0a4b
Merge branch 'MDL-79079' of https://github.com/paulholden/moodle 2023-08-25 10:44:48 +08:00
Huong Nguyen
398bb78fa7
Merge branch 'MDL-78533' of https://github.com/paulholden/moodle 2023-08-24 15:35:14 +07:00
Huong Nguyen
dc9b012d81
Merge branch 'MDL-78502' of https://github.com/paulholden/moodle 2023-08-24 15:29:37 +07:00
Andrew Nicols
5a44292a05
Merge branch 'MDL-78291-master' of https://github.com/ferranrecio/moodle 2023-08-24 14:39:37 +08:00
Jun Pataleta
dfadf21e2f
Merge branch 'MDL-77640-master-latest' of https://github.com/kevpercy/moodle 2023-08-24 10:23:17 +08:00
Kevin Percy
f7732a74e4 MDL-77640 gradebook: Updated behat for add items menu 2023-08-23 15:58:07 +08:00
Jun Pataleta
47ca66a776
Merge branch 'MDL-78097-fix' of https://github.com/sarjona/moodle 2023-08-22 15:52:29 +08:00
Ferran Recio
174125dabc MDL-78291 core_courseformat: fix cm visibility behats 2023-08-22 09:39:13 +02:00
Mathew May
8237f98814 MDL-78100 gradereport_grader: Behat filter clicking 2023-08-22 14:30:57 +08:00
Sara Arjona
8db9d6dd02
MDL-78097 grade: Improve behat to add columns to compare with
Until MDL-75081 is fixed, you cannot assert table contents by specifying
just a single column.
2023-08-22 08:12:28 +02:00
Kevin Percy
4f9e931993 MDL-77640 gradebook: Moved add items to new tertiary nav dropdown 2023-08-22 11:50:34 +08:00
Sara Arjona
316cf48a42
Merge branch 'MDL-78097-min' of https://github.com/Chocolate-lightning/moodle 2023-08-21 13:22:04 +02:00
Paul Holden
b0d1d885b1
MDL-79079 grade: prevent default click event when toggling category. 2023-08-21 12:00:45 +01:00
Paul Holden
bdfe13c4fd
MDL-78533 grade: relax param type of itemname in external structures.
Ensure it conforms to the same format as allowed for course modules.
2023-08-21 10:53:40 +01:00
Paul Holden
604f3fbab9
MDL-78502 grade: consider only those export formats user can access. 2023-08-21 10:46:53 +01:00
Huong Nguyen
ff8b735d4f
Merge branch 'MDL-78436-master' of https://github.com/kevpercy/moodle 2023-08-21 09:45:57 +07:00
Huong Nguyen
2c3c259b5a
Merge branch 'MDL-78100' of https://github.com/Chocolate-lightning/moodle 2023-08-21 09:40:33 +07:00
Eloy Lafuente (stronk7)
8e5d5ad8db
Merge branch 'MDL-78684-master-fix-2' of https://github.com/lameze/moodle 2023-08-17 19:54:39 +02:00
Jun Pataleta
ea1a3e0749
MDL-78684 gradereport_grader: Increase window size during Behat run 2023-08-17 21:32:54 +08:00
Simey Lameze
79488ae624 MDL-78684 behat: fix behat failures 2023-08-17 20:37:40 +08:00
Simey Lameze
1d3fc472af
MDL-78684 behat: remove tab and set the focus to the user search field
This commit also does few things:
- Adds the I change window size step back to avoid future randoms.
- Increase the download limit size on a couple of download steps that
have been failing randomly.
- Adds missing @core_grades to tertiary_navigation_searching.feature.
2023-08-17 13:49:12 +02:00
Jun Pataleta
04ee9570ac
Merge branch 'MDL-75762-master' of https://github.com/laurentdavid/moodle 2023-08-17 09:20:12 +02:00
Andrew Nicols
b71bec8475
Merge branch 'MDL-78684-master' of https://github.com/andelacruz/moodle 2023-08-17 09:12:36 +02:00
Jun Pataleta
3cfaa97d63
Merge branch 'MDL-78922-master' of https://github.com/ilyatregubov/moodle 2023-08-17 09:11:46 +02:00
Sara Arjona
272109c19a
Merge branch 'MDL-78858' of https://github.com/paulholden/moodle 2023-08-17 09:09:15 +02:00
Mathew May
b1063f5891 MDL-78097 grade: Allow the initials bar to pass current page params 2023-08-17 09:41:53 +08:00
Mathew May
9f5e343d73 MDL-78100 gradereport_grader: Clear all button to reset filters 2023-08-17 09:00:07 +08:00
Ilya Tregubov
8490867291
MDL-78922 core_grades: Add missed element to category modal. 2023-08-16 16:44:00 +08:00
Kevin Percy
d949243af7 MDL-78436 gradebook: Require override to add feedback 2023-08-15 14:13:03 +08:00
Laurent David
da2f2c9c45 MDL-75762 core_courseformat: Fix accessibility issue
* Reverse the changes in MDL-74740 to fix left drawer issue (drawer
was scrolling with the page)
2023-08-14 07:23:12 +02:00
Ilya Tregubov
25312f1692
MDL-78790 gradereport_grader: Fix sorting. 2023-08-10 18:32:23 +07:00
Jun Pataleta
ad81e6f315
Merge branch 'MDL-78561-master' of https://github.com/kevpercy/moodle 2023-08-10 18:32:23 +07:00