skodak
19be539627
MDL-10066 move testmodforumlib.php into mod/forum/simpletest/
2007-06-09 16:55:31 +00:00
skodak
cdbbd26f80
MDL-10064 global $CFG in unit test files is non standard, it is recommended to use MOODLE_INTERNAL test in all library files
2007-06-09 16:32:36 +00:00
skodak
52f81103d3
MDL-10063 simpletestlib.php included from majority of unit tests - let's include it once from the test runner itself
2007-06-09 16:17:33 +00:00
skodak
02e6a9731f
MDL-9866 reverting previous incorrect fix for include() in simpletest library; patching grade unit tests instead
2007-06-09 15:03:05 +00:00
skodak
2bb0dbf71d
MDL-10062 - unit test of raw grade load_text() improved
2007-06-09 14:29:07 +00:00
skodak
4cf1b9be9d
MDL-10062 - changes in raw grade handling of feedback and information
...
improved grade_update() function
2007-06-09 14:16:20 +00:00
anthonyforth
44968276c1
Fix for MDL-9942
2007-06-08 09:19:41 +00:00
martinlanghoff
97e9803b48
moodlelib:moodle_request_shutdown() - only call apache_child_terminate if child_terminate is true - MDL-9350
...
Apparently there _is_ a PHP ini setting controlling
it -- defaults to off.
2007-06-07 21:22:20 +00:00
nicolasconnault
1c307f2186
grade_item idnumber now self generated if needed.
...
deleted flag implemented in grade_item::update method
added GRADE_TYPE_NONE to gradelib and updated grade_item object
Implemented multiple items (generation of itemnumber when not explicitly given)
2007-06-07 12:45:24 +00:00
skodak
c5b5f18dc1
MDL-9516 update_grade() inline docs
2007-06-07 08:34:04 +00:00
skodak
b67ec72f57
MDL-9516 update_grade(); now required $source of grading to allow modification of original grades in activities through grade_updated event
2007-06-06 23:04:24 +00:00
skodak
13127313d3
fixed unit grade tests - missing grade types
2007-06-06 22:15:40 +00:00
skodak
75e1038756
fixing uninitilaized scale problems in last commit
2007-06-06 19:16:37 +00:00
skodak
b919d68049
fixed mnod typo
2007-06-06 07:59:55 +00:00
toyomoyo
43a8e6aa49
fixing a typo
2007-06-06 02:45:39 +00:00
skodak
612607bd47
MDL-9516 new central grading function update_grade(); to be improved/tested more tomorrow
2007-06-05 22:58:37 +00:00
toyomoyo
4d40aa144a
grade import temporary buffer tables and encoding/import form changes
2007-06-05 09:28:15 +00:00
nicolasconnault
210611f6ee
MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib)
2007-06-05 08:50:24 +00:00
toyomoyo
1b63e57388
adding a usermodified field to post table
2007-06-05 05:40:10 +00:00
nicolasconnault
bbac4ae7c5
MDL-9972 Removed the __destruct() method, which was not needed. Also fixed a few bugs that caused notices in PHP5.
2007-06-05 01:19:09 +00:00
nicolasconnault
ffa6e8d3c0
MDL-9629 Category edit page now supports creation of a new category for selected items or categories.
2007-06-05 00:39:01 +00:00
nicolasconnault
de5284f26d
MDL-9137 Almost finished the edit category page. The only remaining issue is some sort of endless loop starting in grade_category::set_as_parent. Big issue...
2007-06-01 08:01:47 +00:00
nicolasconnault
ec4560cc58
MDL-9137 Removed hidden field from grade_categories and added deleted field to grade_items. Also added 2 images in pix/i
2007-06-01 04:46:24 +00:00
nicolasconnault
5fad506139
MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented.
2007-06-01 04:02:37 +00:00
nicolasconnault
88e794d6c8
MDL-9628 Move work on the category edit page
2007-05-31 08:57:05 +00:00
nicolasconnault
0fc7f62445
MDL-9506 MDL-9137 MDL-9629
...
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!
2007-05-31 03:15:43 +00:00
nicolasconnault
5bfa0d793a
Implemented a test version of the gradebook category edit page, and developed the get_edit_tree method in grade_tree. Items can be successfully moved up and down, and a "move" button lets the user select a source element, then a destination box. All actions use POST.
2007-05-30 08:48:11 +00:00
nicolasconnault
c3096060de
MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around.
2007-05-30 05:47:26 +00:00
nicolasconnault
a3d5594248
MDL-9506 Refactored grade_tree::get_tree by doing the following:
...
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
jamiesensei
dc1f768351
reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
2007-05-29 06:27:38 +00:00
jamiesensei
d65cb30f63
reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
2007-05-29 06:14:09 +00:00
jamiesensei
24a905f98b
fixed bug in parsing urls
2007-05-29 06:14:09 +00:00
nicolasconnault
646323549e
MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now.
2007-05-29 04:07:04 +00:00
nicolasconnault
de420c11c5
MDL-9317 Applying Petr's second patch
2007-05-29 00:56:44 +00:00
jamiesensei
099f7fb6ca
added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE.
2007-05-28 14:25:40 +00:00
skodak
7bddd4b787
MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup
2007-05-28 08:55:15 +00:00
skodak
37db0ab8f8
MDL-9960 update_record() does not store NULLs; I hope it will not break anything
2007-05-28 08:49:40 +00:00
skodak
b5b65852c6
apply magic quotes before using var in sql query in fetch_all_using_this()
2007-05-28 08:20:07 +00:00
nicolasconnault
c91ed4be0d
MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
...
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
2007-05-28 08:00:19 +00:00
nicolasconnault
d990776605
MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected.
2007-05-28 02:05:21 +00:00
nicolasconnault
526e1a8a25
MDL-9506 Corrected a number of small errors in unit tests and classes.
2007-05-28 01:26:58 +00:00
jamiesensei
3673f6bc3b
added more phpdoc comments for hardFreezeAllVisibleExcept
2007-05-28 00:50:11 +00:00
jamiesensei
56015454dd
new method hardFreezeAllVisibleExcept
2007-05-28 00:46:11 +00:00
skodak
271c7a98bc
MDL-9959 debugging() shows warnings when called from call_user_func() functions
...
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
2007-05-27 22:55:52 +00:00
jamiesensei
9368476553
MDL-9734 fix for clean_param PARAM_LOCALURL bug
2007-05-27 11:19:04 +00:00
jamiesensei
64360ee7b5
made hardFreeze work properly for a whole form. New paramater in moodleform constructor 'editable' defaults to true. If true then display form as normal. If false then hardFreeze whole form. Now displays form without an submit buttons. If form is hard frozen no data is ever passed to get_data.
2007-05-27 05:01:51 +00:00
jamiesensei
7d8ea28668
MDL-9891 new 'clonepermissionsfrom' key in access.php
2007-05-27 04:53:02 +00:00
skodak
19e7f33384
MDL-9643 some more polishing
2007-05-26 13:11:54 +00:00
skodak
7458bee224
MDL-9643 some more polishing
2007-05-26 12:59:13 +00:00
anthonyforth
ae8fda4cb1
Fix for bug MDL-9942
2007-05-25 09:55:08 +00:00
