590 Commits

Author SHA1 Message Date
Sam Hemelryk
80c1289773 MDL-25637 Fixed whitespace 2011-01-24 16:20:30 +08:00
Aparup Banerjee
b692e4aa29 Performance MDL-25637 moved static count/sizeof functions out of for loop conditions 2011-01-24 14:51:21 +08:00
Helen Foster
f085c3eccb MDL-21250 capital letters removal 2010-12-08 19:47:46 +00:00
Helen Foster
bea9531a78 MDL-25475 lang string update thanks to Inaki Arenaza and Angelo Pappano 2010-12-01 12:17:44 +00:00
David Mudrak
42ae4ff290 MNet: fixed wrong column name in SQL cleanup code 2010-11-26 09:20:16 +00:00
David Mudrak
ee4cd8f16d Prevent MNet error message when multiple records for the user are found in mnet_session table 2010-11-26 09:20:06 +00:00
David Mudrak
35d76df31d MDL-25367 user images are sent a received over MNet during SSO again 2010-11-26 09:19:55 +00:00
Inaki
40293947bb auth/cas: MDL-25062 CAS authentication plugin does not validate the CAS server certificate
If we enable the server validation but don't specify a certificate file path
flag the error and don't let the user save the settings.
2010-11-18 00:57:06 +00:00
Inaki
387d1dc0d5 auth/cas: MDL-25062 CAS authentication plugin does not validate the CAS server certificate
The CAS protocol security model requires that you verify the cas server
certificate before you trust the answer (valid authentication and username
etc.).

Credit goes to Joachim Fritschi for reporting it and providing a patch.
2010-11-18 00:12:23 +00:00
Petr Skoda
7415aed103 MDL-11728 finally defining the exact meaning of is_internal() in auth plugins
internal means "uses password hash for user authentication", there is a new is_synchronised_with_external() method that indicates if moodle should automatically sync user info with external system after login; I have also improved the default for prevent_local_passwords() which is now defaulting to !is_internal()
2010-11-14 02:01:59 +00:00
David Mudrak
8bda7ceca1 Fixed MNet strings that explicitly talk about Moodle site
The remote site can be Mahara site, too.
2010-11-12 09:36:50 +00:00
Petr Skoda
4e56afdfb4 attempt to fix mnet jumping issue when already logged in as guest 2010-11-11 09:39:41 +00:00
David Mudrak
4d0552e8ea MDL-25052 Do not display 'All hosts' as the identity provider at login form 2010-11-09 15:39:07 +00:00
Petr Skoda
03ea0b32cc MDL-20210 dod not stop login process when can not connect to auth/db external database 2010-10-22 09:07:02 +00:00
Inaki
e494a7615e auth/cas MDL-24789 phpCAS single sign-on module client needs updating due to security issues
Upgraded phpCAS to 1.1.3 (latest stable version), which fixes them.
2010-10-21 08:22:21 +00:00
Petr Skoda
22a8fbdcf9 MDL-22739, MDL-23772 improved changeme hack + finally fixing the delayed changeme effect 2010-10-11 07:55:24 +00:00
Petr Skoda
8a8f1c7cd6 MDL-10137 rewritten cookie test on login page, username cookie is not required any more - hopefully this will be more reliable test 2010-10-10 17:30:28 +00:00
Petr Skoda
17c70aa007 MDL-16723 automatic redirects to https when loginhttps enabled - this solves accidental usage of http version + it also solves recent navigation regressions + fixed regression from PAGE conversions + deprecated old httpsrequired() and $HTTPSPAGEREQUIRED 2010-10-10 15:04:19 +00:00
David Mudrak
672bbc791d MDL-24425 mnet: fixed SQL DISTINCT from a table containing text field 2010-10-07 16:11:42 +00:00
Petr Skoda
bc31625aba MDL-24356 fixed DML conversion - based on patch by Jay Knight 2010-09-27 09:41:59 +00:00
Petr Skoda
1dffbae2da MDL-24321 switching to stdClass in /auth/ 2010-09-21 08:09:22 +00:00
Helen Foster
0d9926b3f5 MDL-24203 typo fix thanks to Koen Roggemans 2010-09-17 12:25:19 +00:00
Petr Skoda
5c7bc383ce fixed phpdocs type 2010-09-17 10:44:56 +00:00
Petr Skoda
cc2202299f MDL-24253 we need to udpate shibboleth to use new session api 2010-09-17 10:43:15 +00:00
Petr Skoda
fb81718414 replaced forbidden font tags 2010-09-17 10:39:29 +00:00
Petr Skoda
f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Petr Skoda
dd88de0ebd MDL-14679 fixed remaining old style update_record()s 2010-09-03 18:01:25 +00:00
Petr Skoda
a9637e7df4 MDL-14679 fixed a lot more old style uses of insert_record() 2010-09-03 17:47:41 +00:00
Inaki
b44ff4e45b MDL-23864 auth/cas Coding error: Undefined index REQUEST_URI in auth/cas/CAS/CAS.php
Patch our local copy (and record the change) while upstream fixes it (see
https://issues.jasig.org/browse/PHPCAS-81 )
2010-09-03 16:54:03 +00:00
Petr Skoda
389d17f9cc MDL-23985 removing all make_user_dir() and get_user_directories() usage 2010-08-29 09:50:36 +00:00
Petr Skoda
082ec753b5 MDL-23985 commenting out non-working code - we need to use new file api to get user pix 2010-08-29 09:45:31 +00:00
Petr Skoda
629e12fd81 MDL-23927 do not use = 'guest' because we have CFG->siteguest AND it matches any other username with accents and different case in MySQL 2010-08-25 08:43:42 +00:00
Petr Skoda
99f9f85f00 MDL-23489 auth plugins can specify own edit profile url - patch submitted by Jay Knight + tweaking change password url to use new moodle_url at the same time, it is backwards compatible, custom plugins may still use string url for now 2010-08-18 22:07:00 +00:00
Petr Skoda
28bd3d9ad3 MDL-23824 CLI script improvements - just define('CLI_SCRIPT', true) before require config.php; all incorrect uses of cli and web scripts are detected; refactored cron script - now in two separate sctipts; fix cli inline docs and help - we have to sudo to apache account; standardised cli script locations in auth plugins 2010-08-17 12:33:30 +00:00
Inaki
3e5f4b870e auth/ldap MDL-23652 Error in auth_ldap_sync_users.php
We need to specify a valid user id in the call to role_assign(). And we only
have to make the call if the user has been added successfully, not
otherwise.

Also make sure we lowercase the memberuser and group distinguished names
before comparing them. Depending on the LDAP server we can get mixed case
values for the DNs, and the user may have specified the creators group/ou
name in a different case.

By the way, this has been broken for ages (since the auth cleanup in 1.8, in
2007!). It's a bit strange nobody noticed before :-O

Credit goes to Joe Chryst.
2010-08-07 00:40:16 +00:00
Inaki
6328442a73 auth/cas MDL-23645 CAS single sign-on module needs updating due to security issues
Upgraded phpCAS to 1.1.2 and fixed https://issues.jasig.org/browse/PHPCAS-73 ,
as reported by Fred Woolard in MDL-23126 (the fix will be in upstream in the
next release)

Credit goes to Johan Reinalda.
2010-08-06 21:22:54 +00:00
Petr Skoda
dfcc827ed3 adding missing page context 2010-08-02 14:14:37 +00:00
Inaki
1298e78b24 auth/cas MDL-23371 Still some bits missing from setting name convertion. 2010-07-26 15:24:50 +00:00
Petr Skoda
ab0c6f1291 MDL-23371 reverting last commit in this file, this was most probably unintentional copy/paste from cas plugin - we need to act quickly because this was breaking installs 2010-07-26 06:51:25 +00:00
Inaki
840fcf0c30 auth/cas MDL-23371 Add missing detection of PHP LDAP module like we do in auth/ldap 2010-07-25 22:55:45 +00:00
Inaki
fcf46da1c5 auth/ldap cas/ldap MDL-23371 auth/ldap and auth/cas refactor
They now share most of the code again, this time via subclassing, and they
share some code with enrol/ldap. They have also gained some features and a few
fixes.
2010-07-25 22:36:15 +00:00
Inaki
8dcf8888fe auth/ldap MDL-23418 LDAP version setting reset to version 2
As authentication and enrolment plugins now have a version number, the LDAP
version number setting was "shadowed" by the plugin version number. So we
rename the LDAP setting name to ldap_version, et voila!
2010-07-21 13:09:11 +00:00
Jonathan Harker
355593f123 MDL-19418 Fix up a couple of stray deprecated ereg and eregi_replace calls. 2010-07-20 06:13:18 +00:00
Jonathan Harker
7785dc2e9f lib, auth, webservice: MDL-20876 fix deprecated split() calls. 2010-07-20 01:38:54 +00:00
David Mudrak
54f6978168 MDL-22787 MNet: Fixed remaining usage of dropped mnet_enrol_assignments table 2010-07-17 22:34:35 +00:00
David Mudrak
152a2273be MDL-22787 MNet: Fixing regressions in auth_mnet caused by changes in enrol_mnet
This smells - IMHO auth_enrol should not do anything with the enrolment
related information. These two plugins seem to be tied too much...
2010-07-17 22:34:12 +00:00
Dan Marsden
1aa66713a5 LDAP Auth MDL-23331 fix global calls - thanks to Federico Botti for report/fix 2010-07-16 12:07:09 +00:00
David Mudrak
bf36ee9b2b NOMDL MNet: Remote application like Mahara does not send user's lang attribute 2010-07-13 13:14:37 +00:00
David Mudrak
09c1b1a214 MDL-23220 Fixed undefined configuration value - thanks to Dan Marsden for the patch 2010-07-13 11:29:35 +00:00
David Mudrak
94cf0a1e56 MDL-23245 Fixed plugin type of auth_mnet in config_plugins table 2010-07-13 11:14:29 +00:00