9685 Commits

Author SHA1 Message Date
Dan Marsden
ed98c4e98e SCORM MDL-23776 check for attempts that have passed as well as completed status 2010-08-11 23:57:03 +00:00
Dan Marsden
50412dc1ec SCORM MDL-23775 update grades in gradebook when grading method changes. 2010-08-11 23:39:19 +00:00
Andreas Grabs
a24bfe0804 MDL-23479 - Adding support for dependitem 2010-08-11 20:42:17 +00:00
Tim Hunt
72d9358afd quiz secure mode MDL-23712 secure mode breaks the quiz navigation
This commit also fixes some other secure window problems.
2010-08-11 20:25:31 +00:00
Tim Hunt
f2cb0c3d48 quiz NOBUG whitespace fix. 2010-08-11 20:15:18 +00:00
Tim Hunt
f6d726c27a quiz javascript NOBUG missing ;s 2010-08-11 20:15:05 +00:00
Tim Hunt
d04f623be4 quiz editing MDL-23705 the edit icon after the question name disappears some times.
It is worse with some themes and some browsers.
You can still edit by clicking the question name, but that is not obvious.
I moved the edit icon to the left.
2010-08-11 19:38:16 +00:00
Andreas Grabs
b8baf0ad03 MDL-23275 - Feedback error also when update a question 2010-08-11 19:25:58 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
c6764f5a2e quiz with password MDL-23699 starting an attempt was broken. 2010-08-11 17:30:44 +00:00
Tim Hunt
c0934fc42a quiz 'secure' window MDL-23713 securewindow_access_rule::make_review_link was broken. 2010-08-11 17:20:05 +00:00
Tim Hunt
150ce06891 quiz MDL-23711 was testing canattempt before canpreview, which is the wrong way round.
Meat that admins saw a Start attempt button, when they should have seen Start preview.
2010-08-11 16:57:34 +00:00
Tim Hunt
1be4990421 quiz summary MDL-23700 logic for whether to show the marks column was wrong. 2010-08-11 16:54:32 +00:00
Tim Hunt
36fa6cb133 quiz NOBUG fatal error on the review page.
I am pretty sure this check is not necessary, preload_question_states will have loaded enough information.
2010-08-11 16:54:07 +00:00
Tim Hunt
690510bd3d quiz NOBUG fix some JavaScript errors. 2010-08-11 16:31:52 +00:00
Sam Hemelryk
97b4ec5e20 mod lesson MDL-23753 Fixed use of $this outside object scope 2010-08-11 08:39:11 +00:00
Dongsheng Cai
89e2569b0f "MDL-22950 fixed filearea" 2010-08-11 07:25:20 +00:00
Tim Hunt
38c9edd0a0 quiz nav NOBUG whitespace and comment clean-up. 2010-08-10 13:30:32 +00:00
Dongsheng Cai
fe6ce23489 MDL-16094 File storage conversion Quiz and Questions 2010-08-10 09:56:48 +00:00
Petr Skoda
bce08d9a37 MDL-23739 improved ajax headers - now using application/json with the exception of YUI upload 2010-08-10 08:50:08 +00:00
Dongsheng Cai
c67a139c66 "MDL-23375, fixed the js error on IE" 2010-08-10 05:49:52 +00:00
Tim Hunt
a26246eac2 quiz attempt UI NOBUG need accesshide text in the quiz navigation to say if a question has been flagged. 2010-08-09 17:10:25 +00:00
Petr Skoda
7efcb7358f MDL-23726 fixed phpdocs - credit goes to Henning Bostelmann 2010-08-09 16:14:52 +00:00
Andrew Davis
e9860baaf9 glossary MDLSITE-953 made glossary autolinker use entry id instead of the entry itself when linking to entries 2010-08-09 13:00:17 +00:00
Aparup Banerjee
8f639ad1bb lesson MDL-23525 fixed unintialized variable. 2010-08-09 09:17:56 +00:00
Andrew Davis
d2e09d60d7 rating MDL-23586 made mod data delete ratings when an instance is deleted 2010-08-09 08:46:52 +00:00
Dongsheng Cai
e8a4928ddd "MDL-23375, fixed chat action links and beep sound" 2010-08-09 08:31:39 +00:00
Tim Hunt
d39ba35c34 quiz overview report MDL-17569 you should be see essay questions that need grading in the report. 2010-08-06 18:09:48 +00:00
Tim Hunt
8b7d4fb70e quiz editing MDL-19766 fixed page load flicker of things revealed later by JavaScript. 2010-08-06 17:55:33 +00:00
Eloy Lafuente
8b494c68d3 MDL-19936 backup - added restore of eval->best and form->accumulative 2010-08-06 16:13:58 +00:00
Eloy Lafuente
a713e27db0 MDL-19936 backup - added missing "scale" annotation in accumulative subplugin 2010-08-06 16:12:59 +00:00
Eloy Lafuente
9ee45db967 MDL-23479 backup - restore of workshop activity. MDL-19936 2010-08-06 16:11:42 +00:00
Eloy Lafuente
4d6743f777 MDL-19936 backup - tiny problem on encoding of workshop interlinks 2010-08-06 16:05:03 +00:00
Tim Hunt
207d145dda quiz delays MDL-20956 don't let overdue attempts + delays block students.
Suppose a quiz has a 60 min time limit, and an enforced delay of 60 mins between attempts.

Suppose a sudent starts an attempt, and then closes their browser, and then comes back 2 hours later. When they try to restart the quiz, it is submitted immediately by the timer.

Now they are blocked out for the next hour.

After this change, they would no longer be blocked, becuse if their attemtp had been submitted at the end of the first hour, then they would already have waited an hour.

That is, we compare the current time with both $lastattempt->timefinish + $delay and $lastattempt->timestart + $timelimit + $delay.
2010-08-06 11:41:50 +00:00
Aparup Banerjee
1112c9ed4e lesson MDL-23525 more bugs fixed to pagetypes. 2010-08-06 08:16:08 +00:00
Aparup Banerjee
59e2121e16 theme MDL-23363 config setting showblocksonmodpages (theme settings) & usages now removed 2010-08-06 06:20:28 +00:00
Sam Hemelryk
73eba4be68 navigation MDL-20276 Fixed use of override_active_url. 2010-08-06 05:49:47 +00:00
Aparup Banerjee
b5e1ffe456 assignment MDL-23684 renamed a variable causing confusion 2010-08-06 03:49:11 +00:00
Aparup Banerjee
8efd9deb32 assignment MDL-23680 fixed upload single not displaying response file to student. 2010-08-06 03:32:11 +00:00
Eloy Lafuente
51ea278bf0 MDL-23479 backup - example assignment offline subplugin support 2010-08-06 02:29:43 +00:00
Eloy Lafuente
1e7dc21300 MDL-23479 backup - assignment revised & old code deleted (but restore logs). Support for subpluggins added 2010-08-06 02:27:36 +00:00
Andrew Davis
5196df589b survey MDL-23324 survey form generation was assuming that subquestions would always have the same type as their parent question. this lead to data being put in the wrong columns 2010-08-06 02:23:53 +00:00
Tim Hunt
c68287a928 mod_quiz / navigation MDL-20276 replace make_active with override_active_url
It doesn't work, but I am committing it, so Sam H can take a look.
2010-08-05 18:15:17 +00:00
Tim Hunt
1724eb719d quiz navigation: NOBUG link should be imperative, edit quiz, not editing quiz. 2010-08-05 17:38:21 +00:00
Tim Hunt
fc3472d5ed quiz manual grading NOBUG fix performance issue with printing the user picture. 2010-08-05 15:35:45 +00:00
Tim Hunt
ea906bb45c quiz reports MDL-21111 Quiz duration is reported in years if Time Finish is before Time Start
Suppose you have two load-balanced servers with badly-synchronised clocks, and
a student does a really quick quiz attempt.

Then it is possible that quiz_attemtp.timestart is greater than quiz_attemtp.timefinish.
And these columns are unsigned (on MySQL) so timefinish - timestart is compulted as
a number close to 2^64, which is about 42 times the age of the universe.

Do the subtraction in PHP instead. (But we still need to compute a duration columnin PHP
because sometimes we sort on it.)
2010-08-05 12:43:13 +00:00
Sam Hemelryk
3db7b87807 forum MDL-23671 Fixed defaults for forum maxattachments 2010-08-05 07:40:53 +00:00
Andrew Davis
8e1e3c146d survey MDL-23324 fixed an SQL error for postgres 2010-08-05 06:34:51 +00:00
Andrew Davis
3ce4270a20 survey MDL-23324 reworked the downloading of survey results 2010-08-05 05:39:31 +00:00
Andrew Davis
b83bdae639 survey MDL-23324 refactored some code that had been left behind during prior refactoring 2010-08-05 05:38:15 +00:00