Andrew Nicols
5b03e6e38c
MDL-81520 mod_assign: Update tests to not extend assign_provider test
2024-12-11 12:30:22 +08:00
Andrew Nicols
55126be4ad
MDL-81520 core: Fix test finality
2024-12-11 12:30:21 +08:00
Huong Nguyen
b058b6681c
Merge branch 'MDL-83643-404' of https://github.com/lameze/moodle into MOODLE_404_STABLE
2024-11-28 09:21:16 +07:00
Andrew Nicols
e871b6fc71
Merge branch 'MDL-83551-404' of https://github.com/lameze/moodle into MOODLE_404_STABLE
2024-11-21 12:26:12 +08:00
Andrew Nicols
c6942c9bb7
MDL-81521 core: Update all possibly data providers to be static
...
Note: Some data providers could not be automatically be converted to
being static. These will be handled in a separate issue.
2024-11-18 10:24:55 +08:00
Simey Lameze
afe848bcc6
MDL-83643 behat: make manual completion scenario names unique
2024-11-13 07:18:01 +08:00
Simey Lameze
89e18f1381
MDL-83551 behat: make duplicated scenario names unique
2024-11-13 06:50:56 +08:00
Tim Hunt
bc8b2d8b63
MDL-81612 assign: show current value when editing a student's extension
...
Also, if there is not currently an extension set, the set extension form
will default to whatever is the latest out of the due date, the cut-off date
and midnight tonight (in the server time-zone).
2024-09-19 16:02:12 +01:00
Tim Hunt
ba94804e81
MDL-81612 assign: test generation of extensions
...
Also, some other improvements.
* In Behat you can now use either idnumber of name to identify an
assignment you are generating things for.
* create_submission generator methods now wants the cmid in $data['cmid']
not the confusingly named 'assignid'. The old name is accepted, but
generates a debugging warning. (That will fail the test, but in a way
that explains how to fix it.)
2024-09-19 16:02:12 +01:00
Huong Nguyen
bc1324af4d
Merge branch 'MDL-68676-404' of https://github.com/rhell4/moodle into MOODLE_404_STABLE
2024-09-11 15:50:10 +07:00
Shamim Rezaie
452d92d9bb
MDL-81909 mod_assign: fix test_attempt_reopen_method_untilpass
2024-09-05 03:27:03 +10:00
Huong Nguyen
850b4a5f56
Merge branch 'MDL-82669-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-08-08 08:58:43 +07:00
Paul Holden
84c134f7c0
MDL-82669 mod_assign: remove Atto reliance workaround for Behat.
...
See 8fe80e743c for context, and 802ff3e2e3 for additonal comments.
2024-08-02 10:33:34 +01:00
Paul Holden
aa8f7a6a39
MDL-82669 editor: remove reliance on Atto editor in Behat scenarios.
2024-08-02 10:33:34 +01:00
Paul Holden
3452312c8c
MDL-82611 mod_assign: capability check before exporting grade link.
2024-07-26 21:20:40 +01:00
Sara Arjona
54ec6416b4
Merge branch 'MDL-78388-404' of https://github.com/djarran/moodle into MOODLE_404_STABLE
2024-07-09 11:47:34 +02:00
djarrancotleanu
6ad723885c
MDL-78388 course: Copy permissions when duplicating module
2024-07-03 13:49:00 +10:00
Sara Arjona
ff2164fd3d
Merge branch 'MDL-79231-404' of https://github.com/davewoloszyn/moodle into MOODLE_404_STABLE
2024-06-25 16:13:01 +02:00
Rossco Hellmans
375c921a69
MDL-68676 mod_assign: check accessallgroups in can_edit_submission()
...
In can_edit_submission() when the assign group mode is SEPARATEGROUPS
check if the user has the moodle/site:accessallgroups capability before
checking if they are a shared groupmember. Due to the teamsubmission
setting students might not be in a group but can still submit, which
means they are not returned in get_shared_group_members().
2024-06-22 13:44:59 +10:00
David Woloszyn
d5be1b502f
MDL-79231 mod_assign: Fix Tiny menu in fullscreen mode
2024-06-20 14:32:57 +10:00
Sara Arjona
5fbdb37d60
Merge branch 'MDL-81730-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-06-19 13:31:39 +02:00
Eloy Lafuente (stronk7)
091b458c52
MDL-81522 phpunit: Add missing void return type to all tests #2
...
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.
The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.
All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
2024-06-11 12:18:05 +02:00
Eloy Lafuente (stronk7)
1093256560
MDL-81522 phpunit: Add missing void return type to all tests
...
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.
All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
2024-06-11 12:18:04 +02:00
meirzamoodle
e23f603c41
MDL-81890 assign: confirm_sesskey fixed in view_fix_rescaled_null_grades
2024-06-06 22:06:28 +08:00
Huong Nguyen
608f7d6aa0
Merge branch 'MDL-81955-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-06-04 10:33:46 +07:00
Andrew Nicols
f0445d5cac
MDL-68262 assignfeedback_editpdf: Correct args to make_request_directory
2024-05-30 09:54:08 +07:00
Andrew Nicols
b19ce46723
MDL-68262 assignfeedback_editpdf: Update unit test for latest coding style
2024-05-29 16:19:41 +08:00
Andrew Nicols
370843c967
MDL-68262 assignfeedback_editpdf: Switch to request dirs
2024-05-29 16:19:41 +08:00
Andrew Nicols
45808a99b4
Merge branch 'MDL-82004-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-05-28 14:31:42 +08:00
Paul Holden
aca3ad2008
MDL-82004 assignsubmission_onlinetext: no concatenation in lang strings.
2024-05-23 13:08:22 +01:00
Huong Nguyen
64ad970e5e
Merge branch 'MDL-81862-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-05-23 08:47:48 +07:00
Paul Holden
c889381be2
MDL-81862 mod_assign: add activity field files for backup/restore.
2024-05-21 09:06:01 +01:00
Ilya Tregubov
1e07a5eef6
Merge branch 'MDL-81318-404' of https://github.com/paulholden/moodle into MOODLE_404_STABLE
2024-05-21 12:49:20 +08:00
Paul Holden
20d6ffb9ee
MDL-81730 assignsubmission_file: deterministic submission file order.
2024-05-20 20:16:18 +01:00
Paul Holden
dbffeb334b
MDL-81955 assignfeedback_editpdf: ensure ghostscript present in tests.
2024-05-17 10:25:27 +01:00
Paul Holden
ffe67fc6df
MDL-81318 assignsubmission_onlinetext: ignore blank content download.
2024-05-15 09:33:18 +01:00
Simey Lameze
7a4ea4dd65
MDL-70441 mod_assign: change condition to check if variable is not empty
2024-05-15 09:15:16 +08:00
David Balch
f9ab045794
MDL-70441 assign: Freeze workflow states not available to user.
...
Prior to this, a custom grader role that has mod/assign:grade but not
mod/assign:releasegrades or mod/assign:managegrades would see a select
with only the states available to them - not the current state, and
could reset a grade from released to Not marked/In marking/Marking
completed.
2024-05-14 12:55:00 +08:00
Tim Hunt
aa1dc46bc8
MDL-81423 assign: improve valdation message for submissionstatement
2024-05-03 10:33:46 +01:00
Mark Johnson
6c484f9fc8
MDL-81611 assign: Close session early in gradingpanel fragment
2024-04-25 16:14:26 +01:00
Jun Pataleta
8b976e77ce
MDL-81616 upgrade: add the 4.4.0 separation line to all upgrade scripts
2024-04-23 15:24:02 +10:00
Jun Pataleta
a180dba314
MDL-81549 versions: bump all versions and requires near release
2024-04-17 00:03:29 +08:00
Huong Nguyen
f64fda43d5
MDL-4188 behat: Turn off course welcome message
...
Turn off the course welcome message,
so we can easily test other messages.
2024-04-04 20:13:47 +07:00
Ilya Tregubov
1c604c9cb4
Merge branch 'MDL-81190' of https://github.com/paulholden/moodle
2024-03-15 08:41:58 +08:00
Andrew Nicols
9cdc5850c5
Merge branch 'MDL-75952' of https://github.com/stronk7/moodle
2024-03-12 10:45:02 +08:00
Paul Holden
e2de6e4584
MDL-81190 mod_assign: correct context argument to format string.
2024-03-11 16:56:32 +00:00
Sara Arjona
80fe231e74
Merge branch 'MDL-79672' of https://github.com/paulholden/moodle
2024-03-11 17:35:53 +01:00
Eloy Lafuente (stronk7)
361dfe8145
MDL-75952 general: Since php81, refection->setAccessible() is no-op
...
Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php
As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
2024-03-10 21:15:00 +01:00
Jun Pataleta
3278ce7aba
Merge branch 'MDL-65292' of https://github.com/stronk7/moodle
2024-03-08 08:00:41 +08:00
Simey Lameze
503cd95b9f
MDL-79990 behat: custom step to verify assign grading data
...
This commit also optimise the new behat test.
2024-03-07 09:43:53 +08:00
