7086 Commits

Author SHA1 Message Date
Lars Bonczek
a48d11dd7d MDL-63753 course: Show stealth activity links to non-editing teachers 2024-06-26 12:57:36 +02:00
Sara Arjona
9e1eec783c
Merge branch 'MDL-82207' of https://github.com/stronk7/moodle 2024-06-26 12:27:19 +02:00
Ilya Tregubov
435619ac90 Merge branch 'MDL-81866-main' of https://github.com/sarjona/moodle 2024-06-26 10:16:36 +08:00
Sara Arjona
cf7cc40f4b
MDL-81866 course: Fix behat errors after improving reset 2024-06-25 12:59:26 +02:00
Sara Arjona
7402706c59
MDL-81866 course: Improve workflow for reset course
The following changes have been done to improve the reset course:
- Reset course button moved to sticky footer. Select default and
deselect all buttons set as secondary and left at the end of the form
- Adjusted page layout to a standardized format, centering the form for
improving presentation and recolocating the Reset course button away
from the bottom-right corner
- Changed page layout to standard, to display the form centered and
avoid having the Reset course button in the right bottom corner
- Modal added before resetting a course, asking user for confirmation
- Reset course buttons displayed with danger styling, because they
remove information
- All sections are expanded by default
- Default options are selected by default
2024-06-25 12:59:25 +02:00
Paul Holden
e8ae5222d6
MDL-82024 format_topics: toggle un/highlight section icon correctly. 2024-06-24 19:40:22 +01:00
Eloy Lafuente (stronk7)
ad5fe71868
MDL-82207 phpunit: fix various @covers annotations (take#1)
This fixes various (not all) wrong @covers annotations that
are reported as warnings by PHPUnit when it's run with
code-coverage enabled.

When possible, the preferred solution is to change to
@covers at class level, that is the recommended way.

If multiple classes are involved, then a mix of @coversDefaultClass
and @covers at method level are used (always trying to use the
minimum needed patch).

This is the first of a series of issues created as sub-tasks
of MDL-82142.
2024-06-24 12:07:39 +02:00
ferranrecio
f166b15b28 MDL-81769 core_courseformat: prevent delegated section modules actions 2024-06-21 12:41:09 +02:00
Huong Nguyen
c53b23e47e
Merge branch 'MDL-82202' of https://github.com/paulholden/moodle 2024-06-20 10:20:48 +07:00
Sara Arjona
72f0d10e11
Merge branch 'MDL-80745-main' of https://github.com/rezaies/moodle 2024-06-19 08:48:40 +02:00
Huong Nguyen
ebae7fbae4
Merge branch 'MDL-81523' of https://github.com/stronk7/moodle 2024-06-19 09:52:10 +07:00
Shamim Rezaie
37eae68cdb MDL-80745 core_course: group selector renderer for actionbar in course 2024-06-19 00:41:05 +10:00
Paul Holden
7ab967202c
MDL-82202 course: correct last access report entity column callback.
Ensure it works when being aggregated.
2024-06-17 14:27:01 +01:00
James C
7dca6d0e3b MDL-78080 course: Duplicate section: Duplicate by section id, not num 2024-06-17 12:51:33 +12:00
James C
7cde0e9984 MDL-78080 course: Duplicate section: No duplicate option for section 0 2024-06-17 12:51:33 +12:00
James C
f00a6caaaf MDL-78080 course: Duplicate section: Don't copy deleted activities 2024-06-17 12:51:33 +12:00
James C
ef02908013 MDL-78080 course: Duplicate section: Copy section summary files 2024-06-17 12:51:13 +12:00
James C
23567ce725 MDL-78080 course: Duplicate section: Copy custom section options 2024-06-17 12:48:22 +12:00
James C
acf5e44fde MDL-78080 course: Duplicate section: Fix course_update_section params 2024-06-17 12:47:16 +12:00
Eloy Lafuente (stronk7)
674497a12c
MDL-81523 phpunit: Add all missing setUp/tearDown parent calls
All setUp(), tearDown(), setUpBeforeClass() and tearDownAfterClass()
must, always, call to parent, to ensure that everything is properly
set and cleaned.

While in a lot of situations this is not needed (parents may not
have anything to run), with PHPUnit >= 10 this can become more
important because we are going to move the reset code from current
placement @ runBare() to setUp()/tearDown().

Note that all the changes performed in this commit have been detected
and fixed by moodle-cs (ParentSetUpTearDownSniffTest).
2024-06-14 16:04:57 +02:00
Ilya Tregubov
788f0e6f0a NOBUG: Add upgrade notes 2024-06-14 08:56:53 +08:00
Huong Nguyen
5970d38755
Merge branch 'MDL-81332-main' of https://github.com/andelacruz/moodle 2024-06-12 13:15:05 +07:00
Jun Pataleta
bb1cddb140
Merge branch 'MDL-81681-main' of https://github.com/sarjona/moodle 2024-06-12 10:57:20 +08:00
Huong Nguyen
96d29ef71b
Merge branch 'MDL-81522' of https://github.com/stronk7/moodle 2024-06-12 08:46:31 +07:00
Laurent David
9381343c78 MDL-81510 core_courseformat: Fix activity highlight in index
* When directly accessing the module with the #module-xxx anchor
we should highlight the module as the current page item.
2024-06-11 12:34:20 +02:00
Eloy Lafuente (stronk7)
4f7631113c
MDL-81522 phpunit: Add missing void return type to all tests #2
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
2024-06-11 11:55:08 +02:00
Eloy Lafuente (stronk7)
01148a0816
MDL-81522 phpunit: Add missing void return type to all tests
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
2024-06-11 11:55:07 +02:00
Angelia Dela Cruz
ff8d888c49 MDL-81332 core_course: Behat test for grade and activity reports display 2024-06-11 15:25:21 +08:00
Sara Arjona
e18aefa69e
Merge branch 'MDL-81676-main' of https://github.com/aanabit/moodle 2024-06-10 16:07:28 +02:00
Sara Arjona
6764cc71ac
Merge branch 'MDL-81648-main' of https://github.com/roland04/moodle 2024-06-10 15:49:46 +02:00
Amaia Anabitarte
267a474154 MDL-81676 core_course: Rename data-sectionid to data-sectionnum
Activity chooser is saving section number in a data attribute called
data-sectionid. We should use data-sectionnum instead to make it easier
to understand.
2024-06-10 15:42:09 +02:00
Sara Arjona
4f3712505d
Merge branch 'MDL-81675-main' of https://github.com/aanabit/moodle 2024-06-10 12:38:46 +02:00
Sara Arjona
94adf2ae31
Merge branch 'MDL-70972-main' of https://github.com/PhMemmel/moodle 2024-06-10 12:33:18 +02:00
Laurent David
ed029faf06 MDL-81510 core_courseformat: Do not reset the scroll position
* Revert the change made in MDL-75762 which would wait and change
  course index selection depending on the actual scroll position
2024-06-07 09:38:54 +02:00
Laurent David
91d89170f7 MDL-81510 core_courseformat: Expand course section to show activity
* When a course activity is specified via an anchor in the URL we
should expand the course content containing the activity
* When we point to a specific activity via an anchor in the URL we should
expand the course index (section) surrounding the actitity.
2024-06-07 09:38:54 +02:00
Sara Arjona
79c85ab22d
MDL-81681 course: Make reactive the section page 2024-06-07 09:35:05 +02:00
Sara Arjona
8aef5e6574
MDL-81681 course: Revert changes done in MDL-81575
Now that the section page is reactive, these changes are not
required anymore.
2024-06-07 09:34:11 +02:00
Jun Pataleta
c42c94279a
NOBUG: Add upgrade notes 2024-06-06 22:30:24 +08:00
Jun Pataleta
6439a4d2b8
Merge branch 'MDL-82045-main' of https://github.com/andrewnicols/moodle 2024-06-06 22:02:37 +08:00
Huong Nguyen
7934aa46ce
Merge branch 'MDL-81749-main' of https://github.com/aanabit/moodle 2024-06-06 22:02:36 +08:00
meirzamoodle
40b2fb9a31
MDL-81890 course: Fix sesskey checks 2024-06-06 22:02:35 +08:00
Huong Nguyen
3086b220be
Merge branch 'MDL-81397' of https://github.com/paulholden/moodle 2024-06-06 22:02:33 +08:00
Andrew Nicols
847e1098da
MDL-82045 course: Destroy copy course modal instead of hiding it 2024-06-06 10:03:44 +08:00
Amaia Anabitarte
be267a625d MDL-81675 course: Prevent creating subsections into subsections 2024-06-05 16:29:16 +02:00
Amaia Anabitarte
f185fdca52 MDL-81749 core_completion: Let custom rules to return failed state 2024-06-05 15:55:04 +02:00
Paul Holden
90a4216446
MDL-81397 courseformat: define section editing capabilities.
This ensures consistency for current page instance, when rendering
content in response to fragment AJAX requests.
2024-06-04 09:00:11 +01:00
Philipp Memmel
9ca4975d0d MDL-70972 format_singleactivity: Apply new behavior to behat test 2024-06-04 06:29:05 +00:00
Philipp Memmel
63c0495c86 MDL-70972 format_singleactivity: Show activities when creating course
Co-authored-by: Laurent David <lmedavid@gmail.com>
2024-06-04 04:29:06 +00:00
Huong Nguyen
6e1197d0bf
Merge branch 'MDL-73735_duplicate-line-course-rest-php' of https://github.com/ziegenberg/moodle 2024-06-03 11:52:23 +07:00
Mikel Martín
932b094134 MDL-81648 course: Add new sectiondelegatemodule class
- Created sectiondelegatemodule abstract class for those delegated sections
managed by a module
- This class will override get_parent_section from the base class, retrieving
the parent section from the module
2024-05-31 10:50:20 +02:00