find the solution. No hacks, no replicating the table object, I just tweaked
the table class itself to help us.
I 'll post at SC#187 about this, but the bug is now totally fixed.
This is obviously a copy/paste artifact from mod/quiz/report/overview/report.php,
but notice that over there is non-trivial processing going on over there with the
sortorder array!
The sortorder can be used directly in queries, just stick an "ORDER BY " in front.
at SC#187 postid 1104 with a small addition, EXCEPT the //HACK ALERT part.
Where does that leave us? The popup does not die anymore, BUT:
1. It throws a notice about $sort not being defined (to be expected)
2. It doesn't use the correct sortorder ($sort is not defined, so default sort)
Please see the discussion at SC#187 before doing more work on this.
Changing get_records_sql() for one record ALWAYS and associated foreach() to
a get_record_sql() without foreach. Please be considerate with copy/paste. ;-)
Users can now be assigned to multiple groups. Thanks Yu!
Break out the Bob Marley!!
Otherwise groups work more or less like they did before.
This has been pretty well tested by Yu and myself, but since Yu started
uncovering lots of existing groups bugs it's possible there may be still
a few corner cases still lurking here and there.
Please help test this thoroughly for 1.6!!
Fixed the annoying "...and the 1 Journals you had..." message when you have
no Journals at all, because I was tired of seeing it.
count(false) is 1 and not 0.
Complete refactoring of the system that was really awful (my fault!).
Now everything is in its place and working like a charm, making things really
easier to be implemented and amplied. Bug 3678
(http://moodle.org/bugs/bug.php?op=show&bugid=3678)
(http://moodle.org/mod/forum/discuss.php?d=26530)
Note: Everything is merged from stable but the quiz module because it has
other changes not merged for now. I've skyped a message to Gustav about it.
Merged from MOODLE_15_STABLE
(http://moodle.org/mod/forum/discuss.php?d=24110)
This was just a simple matter of cleaning up, no GROUP BY was needed.
Now let's see about the similar hornet's nest that we disturbed in Quiz...
