I 'm debugging some PHP5 notices which aren't just notices, they imply
there's a bug somewhere here? Or maybe an inconsistency in parameter types
of the variables being passed around...
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
Many thanks to Mike Churchward for his work on this and persevering
with sending updated versions to me. :-)
Shane and I have polished it up, rewritten a few parts (display-related)
and here it is, finally in CVS!
I think there will still need to be some optimisation for the SQL,
since it's still pretty intensive. Perhaps some sort of caching in
the session that gets modified along with the database whenever
something gets read.
However if there are problems the whole thing can be switched off
in the forum module config so this is not crucially urgent.
Also told upload class to not complain if there isn't a file selected.
These patches are maintained in an publicly accessible Arch repository, see: http://lists.eduforge.org/cgi-bin/archzoom.cgi/arch-eduforge@catalyst.net.nz--2004-MIRROR/moodle--eduforge--1.3.3
Index of arch patches in this commit:
arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-81
2004-09-19 23:48:54 GMT
Penny Leach <penny@catalyst.net.nz>
fix for forum to print out messages including virus stuff and increase in time before redirect as there is more to read
Full logs:
Revision: moodle--eduforge--1.3.3--patch-81
Archive: arch-eduforge@catalyst.net.nz--2004
Creator: Penny Leach <penny@catalyst.net.nz>
Date: Mon Sep 20 11:48:54 NZST 2004
Standard-date: 2004-09-19 23:48:54 GMT
Modified-files: mod/forum/lib.php mod/forum/post.php
New-patches: arch-eduforge@catalyst.net.nz--2004/moodle--eduforge--1.3.3--patch-81
Summary: fix for forum to print out messages including virus stuff and increase in time before redirect as there is more to read
Keywords:
All the page headers work correctly also on the site course.
On the site page the modules don't require login unless necessary or required by $CFG->forcelogin.
These are the changes from MOODLE_13_STABLE, merged into trunk
The tag MOODLE_13_MERGED on the MOODLE_13_STABLE branch now refers to this point
The biggest changes here are the fixes for HTML editor in all standard modules
Logs now include a field called modid which contains the coursemodule id.
This makes it now possible to
- see complete logs per-activity
- do backup/restore of logs
The upgrade process will currently try to scan all the old logs and
rebuild this field based on available data (especially forums).
STILL TO DO: alter all the non-forum modules to send the coursemodule id
