28147 Commits

Author SHA1 Message Date
Sara Arjona
187801ccf5 Merge branch 'MDL-70966-master' of git://github.com/marinaglancy/moodle 2021-03-03 09:30:41 +01:00
Andrew Nicols
3cda34adf2 Merge branch 'MDL-70268-master-2' of git://github.com/peterRd/moodle 2021-03-03 12:23:04 +08:00
Peter Dias
63cb8999ce MDL-70268 core: Update the oauthlib to exclude scope if none provided 2021-03-03 12:03:40 +08:00
Sander Wind
c9855a8b20 MDL-70668 auth: Fix secret validation during user confirmation
Co-authored-by: Michael Hawkins <michaelh@moodle.com>
2021-03-02 23:44:24 +01:00
Jun Pataleta
e86504fbcf Merge branch 'MDL-70457' of https://github.com/stronk7/moodle 2021-03-02 17:39:36 +08:00
Víctor Déniz
b1bbfbbbdb Merge branch 'MDL-70172-master' of git://github.com/rezaies/moodle 2021-03-02 09:16:41 +00:00
Sara Arjona
b64ee9ecf3 Merge branch 'MDL-70877' of https://github.com/stronk7/moodle 2021-03-02 09:29:17 +01:00
Jun Pataleta
2b113fd93c Merge branch 'MDL-70876' of https://github.com/stronk7/moodle 2021-03-02 16:02:52 +08:00
Eloy Lafuente (stronk7)
ece2fe5da1 Merge branch 'MDL-70899-master' of git://github.com/marinaglancy/moodle 2021-03-01 20:20:46 +01:00
Shamim Rezaie
612a1741f6 MDL-70172 output: pages with main logo should have a first-level header 2021-03-02 05:35:14 +11:00
Sara Arjona
f5bee1b704 Merge branch 'MDL-68735' of https://github.com/stronk7/moodle 2021-03-01 16:17:19 +01:00
Eloy Lafuente (stronk7)
76e5b1b59d Merge branch 'MDL-70913-master' of git://github.com/sarjona/moodle 2021-03-01 14:21:59 +01:00
Sara Arjona
9e5655b7c7 MDL-70913 core_badges: Use and update properly sortorder
Sortorder field in badge_external_backpack was updated with a wrong
value. This patch fixes this behaviour and adds sortorder as
sorting criteria for displaying the list of site backpacks.

In the phpunit method reviewed for covering this, a couple of
assertEquals() calls have been changed too to put the expected value
first.
2021-03-01 13:04:00 +01:00
Eloy Lafuente (stronk7)
b7d3e56d7e Merge branch 'MDL-70931-master-xmldbeol' of git://github.com/mudrd8mz/moodle 2021-03-01 10:00:27 +01:00
Eloy Lafuente (stronk7)
ac9b920981 Merge branch 'MDL-70964-master-enfix' of git://github.com/mudrd8mz/moodle 2021-03-01 09:33:49 +01:00
Marina Glancy
612c230709 MDL-70966 various: Under PHP8 empty string is no longer equals to 0 2021-02-28 19:16:09 +01:00
Eloy Lafuente (stronk7)
08ae245926 MDL-70876 php80: 5th param removed from custom error handlers
It was deprecated in php72 and now it's gone.

Have used this regexp to find all the uses in core:

ag set_error_handler | uniq

And then checked all them manually, that parameter was not
being used in the 3 methods where we are removing it.
2021-02-26 13:08:27 +01:00
Eloy Lafuente (stronk7)
0dea9a80c8 MDL-68735 env: Moodle 3.8.x, 3.9.x and 3.10.x do not support PHP 8.0 2021-02-26 13:07:59 +01:00
Marina Glancy
a7553de7ad MDL-70877 php: remove final functions __clone and __wakeup
Implementing these functions as final does not prevent the object to be
cloned or serialized, so the comment to them was wrong.
However having these functions not public breaks in PHP 8.0.
It still does not make sense to clone or serialise file_system or external_settings classes
but there are a lot of classes in moodle that should not be cloned, no reason to have
a specific solution here.
2021-02-26 13:07:52 +01:00
Eloy Lafuente (stronk7)
599567977f MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
2021-02-26 11:55:24 +01:00
David Mudrák
0c9eaeff59 MDL-70964 lang: Use the fixed strings in tests 2021-02-25 16:20:58 +01:00
Jun Pataleta
2024a32283 Merge branch 'MDL-70169-master' of git://github.com/lameze/moodle 2021-02-25 12:30:22 +08:00
Eloy Lafuente (stronk7)
aa1c493a2a Merge branch 'MDL-70828-master' of git://github.com/abgreeve/moodle 2021-02-24 11:14:25 +01:00
Adrian Greeve
cb69d6389c MDL-70828 performance: Allow session locking issue to be turned off.
If a developer has debugging on then they will recieve all debugging
messages for locking whether wanted or not. We already have a setting
to display these messages.
2021-02-24 11:26:08 +08:00
Eloy Lafuente (stronk7)
6cf59943ca Merge branch 'MDL-52817' of git://github.com/paulholden/moodle 2021-02-23 19:07:56 +01:00
Eloy Lafuente (stronk7)
90f1c55191 MDL-70314 lib: Remove a few more hidden files and add instructions 2021-02-23 18:40:29 +01:00
Eloy Lafuente (stronk7)
e5c163a48b Merge branch 'MDL-70314' of https://github.com/Chocolate-lightning/moodle 2021-02-23 18:33:29 +01:00
Mathew May
9bd5c31d11 MDL-70314 lib: Change XLSX wrapper to no change the default styles
This is required due to changes in the base library see #1712
Summary is that if a column already has styling it can't be overpowered.
2021-02-22 15:32:09 +08:00
Mathew May
d41210cf0f MDL-70314 lib: Apply Moodle specific phpspreadsheet changes 2021-02-22 15:28:40 +08:00
Mathew May
1ee8dd7f6f MDL-70314 lib: Upgrade PhpSpreadsheet to 1.16.0 2021-02-22 15:28:40 +08:00
Marina Glancy
f4fb91aecb MDL-70920 core: prevent calls to call_user_fun_array() with assoc array 2021-02-21 22:22:21 +01:00
Paul Holden
b2d19cc29f MDL-52817 dml: implement driver methods for SQL group concatenation. 2021-02-19 15:31:00 +00:00
Marina Glancy
1e03a240b5 MDL-64554 form: reset form change checker before triggering submit event 2021-02-18 13:04:14 +01:00
Jun Pataleta
28dadc2fb9 Merge branch 'MDL-47410-master' of git://github.com/andrewnicols/moodle 2021-02-18 11:21:23 +08:00
Andrew Nicols
7d5b808e3e Merge branch 'MDL-64554-master' of git://github.com/andrewnicols/moodle 2021-02-18 11:16:40 +08:00
Andrew Nicols
79731372c3 MDL-64554 core_form: Rename class for dynamic form 2021-02-18 11:16:21 +08:00
Andrew Nicols
d6e50d14d2 Merge branch 'MDL-64554-master' of git://github.com/andrewnicols/moodle 2021-02-18 10:21:55 +08:00
Andrew Nicols
ab70110a74 MDL-64554 core_form: CI fixes 2021-02-18 10:10:08 +08:00
Andrew Nicols
708ae8aa0f MDL-47410 behat: Perform exact match for date_time selectors 2021-02-18 09:34:45 +08:00
Víctor Déniz
4e26c93473 Merge branch 'MDL-70536-reset-page-cli' of https://github.com/brendanheywood/moodle 2021-02-18 00:31:39 +00:00
David Mudrák
70b0df5891 MDL-70931 xmldb: Generate install.xml files with EOL and EOF
As discussed in MDLSITE-6397, all Moodle code files should end with
single Unix-style end of line character. Files created and edited
through the XMLDB editor should follow this rule, too.
2021-02-17 20:59:19 +01:00
Marina Glancy
3045005295 MDL-64554 core_form: Move strings to outputrequirements.lib 2021-02-17 18:07:01 +01:00
Marina Glancy
440073ff20 MDL-64554 user: make private files editor modal/ajax form 2021-02-17 18:06:57 +01:00
Marina Glancy
72be49c473 MDL-64554 core_form: new API for modal forms 2021-02-17 18:06:49 +01:00
Eloy Lafuente (stronk7)
a72ea10b84 Merge branch 'MDL-70552-master' of git://github.com/ilyatregubov/moodle 2021-02-17 10:26:20 +01:00
Ilya Tregubov
729688b379 MDL-70552 core_message: Show popup for teachers when anonymous
user completed feedback.
2021-02-17 08:42:52 +02:00
Andrew Nicols
ab024ac209 Merge branch 'MDL-47410-master' of git://github.com/mihailges/moodle 2021-02-17 09:34:22 +08:00
Eloy Lafuente (stronk7)
166add5c8c Merge branch 'MDL-69562_master' of https://github.com/dvdcastro/moodle 2021-02-16 22:32:56 +01:00
Eloy Lafuente (stronk7)
56a5136cc0 Merge branch 'MDL-70525_master' of https://github.com/TomoTsuyuki/moodle 2021-02-16 19:56:09 +01:00
Eloy Lafuente (stronk7)
3d117c1934 Merge branch 'MDL-48269-master-4' of git://github.com/junpataleta/moodle 2021-02-16 19:45:44 +01:00