218 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
361dfe8145
MDL-75952 general: Since php81, refection->setAccessible() is no-op
Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php

As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
2024-03-10 21:15:00 +01:00
Jun Pataleta
3278ce7aba
Merge branch 'MDL-65292' of https://github.com/stronk7/moodle 2024-03-08 08:00:41 +08:00
Simey Lameze
3406032a3d
MDL-68674 behat: make content bank steps more specific 2024-02-29 09:40:45 +07:00
Eloy Lafuente (stronk7)
29a541724f
MDL-65292 style: Fix all the function declaration ordering
This has been generated running the following Sniff,
part of the Moodle's CodeSniffer standard:
- PSR2.Methods.MethodDeclaration

It just ensures all the function declarations have
the correct order for:
- abstract and final.
- visibility (public, protected, private).
- static.

So, all the lines modified by this commit are function declarations
and the only changes are in the positions of those keywords.
2024-02-28 23:47:47 +01:00
Eloy Lafuente (stronk7)
ba1f804ffa
MDL-65292 style: Fix all function declarations white space
This has been generated running the following Sniffs, all
them part of the Moodle's CodeSniffer standard:
- PSR12.Functions.ReturnTypeDeclaration
- PSR12.Functions.NullableTypeDeclaration
- moodle.Methods.MethodDeclarationSpacing
- Squiz.Whitespace.ScopeKeywordSpacing

All them are, exclusively, about correct spacing, so the changes
are, all them, only white space changes.

Only exceptions to the above are 3 changes what were setting the
return type in a new line, and, when that happens, the closing
parenthesis (bracket) has to go to the same line than the colon.
2024-02-28 23:33:26 +01:00
Amaia Anabitarte
b21d8e6f34 MDL-80025 core_contentbank: Update delete button colour to text-danger 2023-11-20 09:50:58 +01:00
Paul Holden
212d668c7a
MDL-79840 contentbank: fix references to invalid icon images. 2023-10-25 08:44:30 +01:00
Jun Pataleta
94bc2cd38b
MDL-79551 versions: bump all versions and requires near release 2023-10-04 13:57:17 +08:00
Paul Holden
d7db5f08b0
MDL-79534 contenttype_h5p: correct fallback file used for icons. 2023-09-28 17:39:28 +01:00
Víctor Déniz
0b838f6977 MDL-79323 lang: Fix Behat tests regressions after merging en_fix strings 2023-09-19 13:42:10 +01:00
Andrew Nicols
48bc688ccd
MDL-78324 core: Convert modals to use new static methods
This commit takes all modals which were not using the legacy
ModalFactory.create triggers and migrates them to the new Modal.create
method.
2023-09-09 00:04:11 +08:00
Andrew Nicols
af7719682d
MDL-79064 core: Update all get_strings as uses 2023-08-29 10:57:54 +08:00
Ilya Tregubov
7144dccdd8
Merge branch 'MOODLE_master_MDL-74773' of https://github.com/danielneis/moodle 2023-08-03 09:18:42 +08:00
Daniel Neis Araujo
a7a3f585ce MDL-74773 contentbank: add notification when updating and creating 2023-08-02 14:14:45 -03:00
Daniel Neis Araujo
d124df500c MDL-76338 contentbank: copy content in content bank 2023-07-28 17:05:57 -03:00
Amaia Anabitarte
0d11cf1bc9 MDL-78183 core_contentbank: Improve error handling 2023-07-07 12:21:24 +02:00
Ilya Tregubov
59cd47c02f
Merge branch 'MDL-62859' of https://github.com/paulholden/moodle 2023-06-01 10:12:14 +08:00
Sara Arjona
fabdff8fbd Merge branch 'MDL-78211' of https://github.com/paulholden/moodle 2023-05-22 17:41:37 +02:00
Sara Arjona
35f3790599 Merge branch 'MDL-78226' of https://github.com/paulholden/moodle 2023-05-22 17:29:16 +02:00
Paul Holden
c5d1f72dca
MDL-62859 javascript: replace user preference calls with new methods. 2023-05-22 13:51:39 +01:00
Paul Holden
802b638b6c
MDL-78226 contentbank: verify presence of bank heading element. 2023-05-11 23:15:29 +01:00
Paul Holden
69a3863ce3
MDL-78211 contentbank: fix context option when formatting categories. 2023-05-10 17:38:53 +01:00
Paul Holden
280ed5b62f
MDL-77667 contentbank: display course fullnames in context navigation. 2023-05-10 16:05:17 +01:00
Jun Pataleta
02ba4ceefa Merge branch 'MDL-77940' of https://github.com/stronk7/moodle 2023-04-19 17:43:23 +08:00
Eloy Lafuente (stronk7)
061c9d7ba0 MDL-77940 versions: bump all versions and requires near release
version = 2023042400 release version
requires= 2023041800 current rc1 version
2023-04-18 18:08:09 +02:00
Paul Holden
b4b88da77d
MDL-77935 contentbank: avoid phpunit crashes during isolated tests.
Simplify the test for allowed contexts by removing problematic use of
data provider annotation.

See: https://github.com/sebastianbergmann/phpunit/issues/2739
2023-04-17 09:26:16 +01:00
Sara Arjona
bdc106e840 Merge branch 'MDL-76859-master' of https://github.com/sarjona/moodle 2023-04-13 16:24:20 +02:00
Marina Glancy
9ffbcce0ac MDL-77164 various: fix mustache template name 2023-04-13 09:43:15 +01:00
Petr Skoda
43b56a90d9 MDL-76859 h5p: Fix behat failures
- Only resize if the H5P EmbedCommunicator is defined (otherwise, it was causing a
JS error)
- An unnecessary image has been removed from the greeting-card.h5p fixture package.
That way, the text will always be displayed (even if the iframe is still not
resized). Instead of replacing the original greeting-card-887.h5p file, I've
renamed it to greeting-card.h5p, to remove these ugly and unnecessary numbers
at the end of the file name).
2023-04-12 12:26:23 +02:00
Sara Arjona
36f5355865 Merge branch 'MDL-77764' of https://github.com/paulholden/moodle 2023-03-30 16:31:15 +02:00
Paul Holden
fd3180c5d3
MDL-77762 contentbank: always provide exit button when appropriate.
If the current user can access the content bank in the context of the
current item, then provide link back to it.
2023-03-27 18:08:55 +01:00
Paul Holden
5ed9c1da14
MDL-77764 contentbank: add field label to context selection element. 2023-03-27 16:51:52 +01:00
Sara Arjona
70bcda2ef8 Merge branch 'MDL-77666' of https://github.com/paulholden/moodle 2023-03-23 17:53:38 +01:00
Shamim Rezaie
5c9142eee4 MDL-76246 contentbank: fix behat failure 2023-03-22 20:59:14 +11:00
Paul Holden
f6310247cb
MDL-77666 contentbank: format category names for display. 2023-03-16 23:04:35 +00:00
Andrew Nicols
511401f4f6 MDL-77559 js: Rebuild all JS with Node 16 2023-03-09 09:53:19 +08:00
Andrew Nicols
33b1e41f13 MDL-75012 js: Full build of all grunt things 2023-03-02 11:55:32 +08:00
Andrew Nicols
68169e1fb9 Merge branch 'MDL-77020' of https://github.com/paulholden/moodle 2023-02-20 09:52:39 +08:00
Paul Holden
7c432c0ffb MDL-77020 behat: refer to search input fields by name/role.
Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
2023-02-16 10:56:28 +00:00
Andrew Nicols
892d75be7c Merge branch 'MDL-76878' of https://github.com/paulholden/moodle 2023-02-16 10:42:37 +08:00
Sara Arjona
ca37dd3baf MDL-76691 core_h5p: Add core lib changes after upgrading it
Apart from applying the points described in readme_moodle.txt, the following
changes have been done too:

- The parameter $folderName from the method libraryToString() have been removed
and a new method, libraryToFolderName() has been added to the H5PCore API.
References to libraryToString() with the $folderName set to true have been
replaced to the new method.
- missing-main-library has been added and replaces in some cases to
missing-required-library.
- The framework saveLibraryData method must be called before saveLibrary
(h5p.classes.php file has been patched to leave the original order because
libraryid is required to save the itemid).
- The getLibraryId() method from H5PCore has been rewritten to use MUC, in
order to avoid PHPUnit failures.
2023-02-06 16:48:07 +01:00
Paul Holden
75ab52d902 MDL-76878 user: amend permission callbacks for preference definitions.
Ensure those preferences that are used for storing state can always be
updated via web service requests for the current user.
2023-01-20 10:05:21 +00:00
Andrew Nicols
a3cc26f8bb MDL-76583 core: Update uses of external_* classes 2023-01-19 07:34:09 +08:00
Jun Pataleta
00bae8b8a4 MDL-76403 versions: bump all versions and requires near release 2022-11-23 09:45:23 +08:00
Andrew Nicols
d396af9393 MDL-76120 behat: Swap click on select option to set field
Recent versions of Marionette do not like to click on the option
element so we must always use the set field option.
2022-10-28 20:53:22 +08:00
Tim Hunt
797b9fbd62 MDL-75548 misc: final Required parameter follows optional notices 2022-08-22 15:20:13 +01:00
Daniel Neis Araujo
3f83f35a5c MDL-73119 contentbank: Add pluginfile callback to content type plugins 2022-08-16 14:23:33 -03:00
Sujith Haridasan
73d604369d MDL-71062 core: Step 1 deprecation of print_error function 2022-07-13 08:20:54 +05:30
Jun Pataleta
0999f65f71 Merge branch 'MDL-74630-master' of https://github.com/aanabit/moodle 2022-06-21 10:12:33 +08:00
aya.saad
ec1e17a73b MDL-70223 h5p: fix invalid id when adding h5p activity 2022-06-05 09:20:16 +02:00