4663 Commits

Author SHA1 Message Date
Sara Arjona
1aba368aa9 Merge branch 'master_MDL-75874' of https://github.com/matheusot/moodle 2022-11-10 16:22:11 +01:00
Jun Pataleta
8013961452 Merge branch 'master_MDL-75126-allow-multiple-bulk-action-41' of https://github.com/catalyst/moodle-MDL-72752 2022-11-10 22:09:12 +08:00
Matheus Rodrigues
caf6b655e6 MDL-75874 aiken_html: correctly display HTML chars for Aiken questions
Updates the Aiken Format class to process answers correctly, enabling
support for special HTML characteres such as <, >, and &.

Co-authored-by: Leticia Luz <leticia.adrielli.luz@gmail.com>
2022-11-10 09:56:52 -03:00
Safat Shahin
cf7d6131ad MDL-75126 core_question: Deprecate get_bulk_action_key
This commit will deprecate get_bulk_action_key and move
the implementation in the get_key method entirely by
making this an absract method.
2022-11-10 23:41:03 +11:00
Safat Shahin
c3245f6f52 MDL-75126 core_question: Allow multiple bulk action from qbank plugins
This commit implements the bulk action api to allow multiple bulk
actions from the qbank plugins instead of one. Any qbank plugin
wants to implement bulk action can now define an array of bulk
actions as a plugin feature.
2022-11-10 00:34:48 +11:00
Sara Arjona
15ea80e12d Merge branch 'MDL-76169-master' of https://github.com/andrewnicols/moodle 2022-11-04 12:06:38 +03:00
Andrew Nicols
723f33031b Merge branch 'MDL-74035-master' of https://github.com/andrewnicols/moodle 2022-11-04 12:06:38 +03:00
Sara Arjona
add46e3112 Merge branch 'MDL-76169-master' of https://github.com/andrewnicols/moodle 2022-11-04 12:06:36 +03:00
Andrew Nicols
92d17a73b5 MDL-76169 question: Use correct action menu step 2022-11-04 15:51:22 +08:00
Safat Shahin
8c13965658 MDL-74035 qbank_viewquestionname: In place editing
This commit will implement in place editing for the
qbank view where users with permission can edit the
title of the questions from the quesion bank view.
2022-11-04 12:03:42 +08:00
Andrew Nicols
bcbdb8764a MDL-76169 question: General behat fixes
Whilst amending these tests I discovered some other minor fixes to be
made.
2022-11-03 21:39:15 +08:00
Andrew Nicols
8ffbaad330 MDL-76169 question: Use action menu steps consistently 2022-11-03 21:39:15 +08:00
Andrew Nicols
3d70f457cb MDL-76169 mod_quiz: Add quiz question bank behat resolver 2022-11-03 21:39:15 +08:00
Shamim Rezaie
8ddc2a5fed Merge branch 'master_MDL-75306-lastused-41' of https://github.com/catalyst/moodle-MDL-72752 2022-11-02 12:57:09 +11:00
Andrew Nicols
d396af9393 MDL-76120 behat: Swap click on select option to set field
Recent versions of Marionette do not like to click on the option
element so we must always use the set field option.
2022-10-28 20:53:22 +08:00
Marina Glancy
a34b4ebdc3 MDL-76112 various: can not pss null as 3rd param to preg_split
This produces notices in PHP 8.1
2022-10-28 10:51:20 +02:00
Safat Shahin
9c89fba92a MDL-75306 qbank_usage: Last used column
This commit will implement Last used column
and filterable object.
2022-10-28 10:21:09 +11:00
Jake Dallimore
08f2f2dc72 Merge branch 'MDL-75727' of https://github.com/timhunt/moodle 2022-10-25 11:55:45 +08:00
Tim Hunt
06c63f7aa1 MDL-75727 question regrading: fix each attempt builds on last
This fixes a regression caused by MDL-74752. If you regraded
a subsequent quiz attempt in a quiz using the 'Each attempt
builds on last' option, then the student's response could get lost.
2022-10-12 11:10:55 +01:00
Jake Dallimore
4576a34bec Merge branch 'MDL-73424-master' of https://github.com/marinaglancy/moodle 2022-10-12 11:51:40 +08:00
Marina Glancy
41b93bd7e5 MDL-73424 general: Internal methods must have same type as parent
Otherwise the error is thrown in PHP8.1
2022-10-10 16:46:13 +02:00
Anupama Sarjoshi
050853c9fe MDL-75431 qbank: fix tests with CodeRunner installed 2022-10-10 09:25:13 +01:00
Jun Pataleta
9b0f435569 Merge branch 'MDL-75818' of https://github.com/mkassaei/moodle 2022-10-06 10:14:07 +08:00
Andrew Nicols
b90c862c25 MDL-75752 question: Bind contextid param in comment backup
In source_sql, unmapped values must be bound using the
backup_helper::is_sql_param() function.
2022-10-06 09:06:12 +08:00
Andrew Nicols
29e1f713b6 Merge branch 'MDL-75752' of https://github.com/timhunt/moodle 2022-10-06 09:02:07 +08:00
Mahmoud Kassaei
9ba4b5f306 MDL-75818 qtype_multichoice: site-wide default for showstandardinstruction 2022-10-05 17:04:22 +01:00
Tim Hunt
9ab7828fe2 MDL-75351 question comments: don't hard-code system context id 2022-09-30 18:44:01 +02:00
Tim Hunt
57ee14cced MDL-75752 question comments: fix backup query so it uses the index
This should greatly improve the performance.
2022-09-29 10:51:28 +02:00
Andrew Nicols
f54d6b0144 Merge branch 'MDL-74883' of https://github.com/timhunt/moodle 2022-09-29 11:58:10 +08:00
Andrew Nicols
392bf7d58a MDL-75744 qtype_gapselect: Remove unnecessary javascript tag 2022-09-27 12:46:01 +08:00
Andrew Nicols
fc8fbb3f64 Merge branch 'MDL-75744-master' of https://github.com/NashTechOpenUniversity/moodle 2022-09-27 12:37:39 +08:00
Eloy Lafuente (stronk7)
9dcf7b0202 Merge branch 'MDL-74762-Master' of https://github.com/catalyst/moodle-MDL-72752 2022-09-21 14:26:01 +02:00
Nathan Nguyen
5b8fa8ee72 MDL-74762 qbank_statistics: fix unit test failure with Oracle DB 2022-09-21 12:14:02 +10:00
Jun Pataleta
50fe735e5a Merge branch 'MDL-75777' of https://github.com/stronk7/moodle 2022-09-20 15:12:34 +08:00
Víctor Déniz
06ba397c1c Merge branch 'MDL-74941-master' of https://github.com/lucaboesch/moodle 2022-09-20 08:08:55 +01:00
Steve Bader
0e18ad33a1 MDL-74941 qtype_calculated: Copy dataset from previous question version 2022-09-20 08:11:04 +02:00
Luca Bösch
27093b1893 MDL-74941 qtype_calculated: Fix for usage calculation
The patch for the helper functions is by Nathan Nguyen
<nathannguyen@catalyst-au.net> whom I wish to thank.
2022-09-20 08:10:55 +02:00
Ilya Tregubov
b6425b9ce1 Merge branch 'MDL-75065-master' of https://github.com/devlionco/moodle 2022-09-19 14:00:49 +04:00
Eloy Lafuente (stronk7)
839c2e5c18 MDL-75777 phpunit: Move tests to use correct names and ns (take#6)
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
2022-09-19 11:01:21 +02:00
Jun Pataleta
a4c97a7d7c Merge branch 'MDL-75757' of https://github.com/stronk7/moodle 2022-09-19 13:02:02 +08:00
Eloy Lafuente (stronk7)
6be384ee8f MDL-75757 phpunit: Add some tolerance to a few failing assertions
Recently, PHPUnit (all versions) did some changes about how the
comparators worked and this has caused some float comparisons
to stop working.

We need to move them to assertEqualsWithDelta(), allowing a small
tolerance to workaround the floats comparison problem.

0.00001 has been decided. And applied to all the similar assertions
within the unittest function, so if more cases are added to them
better be copied with the agreed tolerance.
2022-09-18 15:55:36 +02:00
Nathan Nguyen
f02c16c445 MDL-74762 qbank_statistics: improve performance loading the data
This issue greatly improves the performance of displaying statistics in
the question bank.

1. The required quiz statistics are now pre-computed by a scheduled task.

2. Cached statistics in the database are now never cleaned up, so the
   pre-computed stats are always available.

3. The way the cached statistics are loaded for each question
   that is being displayed is now a bit more efficient.

4. Related to that, there is a new callback which activities can implement,
   if they want their question statistics to be included in the ones shown
   in the question bank.

Note, there is still further improvement possible to load the statistics
for all questions being displayed in bulk. However, that must wait for a
future issue, MDL-75576. The other improvements in this issue are
significant and we did not want to delay releasing them.

Co-authored-by: Jonathan Champ <jrchamp@ncsu.edu>
Co-authored-by: Tim Hunt <t.j.hunt@open.ac.uk>
2022-09-16 21:34:00 +10:00
hieuvu
aee466c0fc MDL-75744 gapselect: remove empty choices option. 2022-09-15 15:43:57 +07:00
Mahmoud Kassaei
1edb5f7581 MDL-75051 Questions: Selecting idnumber in the question bank,
the copy/pasting, includes extraneous text in Chrome
2022-09-09 10:11:45 +01:00
Jun Pataleta
1138811649 MDL-73376 qbank: Remove uniqueidentifier fragment argument
The uniqueidentifier argument is only needed by the version selector and
can be set within the output fragment function using it. There's no need
for it to be a parameter when calling the output fragment function.
2022-09-01 14:56:20 +08:00
Safat Shahin
497a644b48 MDL-73376 qbank_comment: Version selection in modal
This commit implements version selection in the comment
modal to allow users to change the version of question
using that dropdown.
2022-09-01 11:43:55 +10:00
Sara Arjona
996b5c7d75 Merge branch 'MDL-75312' of https://github.com/paulholden/moodle 2022-08-17 12:26:38 +02:00
Petr Skoda
2f70b320bb MDL-75237 qformat_blackboard_six: sanitise blackboard import file paths 2022-08-12 04:14:18 +02:00
Petr Skoda
3e61730463 MDL-75237 qformat_blackboard_six: Revert MDL-72029
This reverts commit 3cafb305ded.
2022-08-12 04:14:18 +02:00
Anton
5e27f3a7b2 MDL-75065 qbank_editquestion: fix creating simple calculated question 2022-08-10 09:44:27 +03:00