87 Commits

Author SHA1 Message Date
Petr Škoda
1c74b26090 MDL-40220 use new core_component::get_plugin_directory() 2013-07-16 22:38:38 +02:00
David Mudrak
54941685e3 MDL-29148 MNet - improved handling of a verification function return code 2011-08-29 01:48:55 +02:00
David Mudrak
82c3f5d848 Do not record encrypted XML-RPC responses in error_log
Such an information is not readable anyway and it make debugging
actually harder. If somebody needs it, they can uncomment the line.
2010-11-26 09:20:28 +00:00
David Mudrak
d82d272037 NOMDL MNet: fixed incorrect usage of get_record() in permission_to_call()
When $CFG->mnet_all_hosts_id was set, the get_record() returned multiply
records and produced warnings. Also, get_record_sql() == true was just
ugly.
2010-11-09 15:38:50 +00:00
Petr Skoda
81322e6483 fixed integer casting syntax error 2010-09-17 19:42:31 +00:00
David Mudrak
53d15f925b NOMDL MNet improved debugging - do not not call get_string() for non-localized error messages 2010-07-17 22:18:20 +00:00
Penny Leach
d234faf3a4 mnet MDL-22267 updated mnet_server_faultand mnet_server_exception string handling
This is so that mnet_server_fault doesn't have to call get_string (in
case of coding exception)
2010-05-01 15:53:45 +00:00
Petr Skoda
ae58632885 MDL-22053 removing relative paths from get_plugin|component_directory() because we can be only sure that the absolute paths exists such as in case of $CFG->themedir outside of dirroot; commeting out some simpletes_ stuff which does not seem to be used any more 2010-04-10 23:21:18 +00:00
Penny Leach
71f61c41f3 mnet MDL-15505 added new mnet_debug function and started migrating to it 2010-02-05 03:56:45 +00:00
Penny Leach
48fb39411f mnet MDL-21098 small fixes - ss out issue and edge case simultaneous keyswap loop 2010-02-05 03:56:22 +00:00
Penny Leach
287efec6f6 mnet MDL-21276 get rid of all the $MNET* globals 2010-02-02 03:13:40 +00:00
Penny Leach
cd8f1cf656 mnet MDL-16858 verify the signature in the xmlrpc response 2010-02-02 02:13:25 +00:00
Penny Leach
5f27814116 mnet MDL-21473 xmlrpc client should check in the remote_ rpc tables 2010-01-29 02:59:27 +00:00
Penny Leach
8586dbe2a5 mnet MDL-21473 make new tables for remote functions that don't exist locally
I also fixed up two columns in the existing table that had underscores in them
2010-01-28 22:46:34 +00:00
Penny Leach
d2ac37c1ab mnet MDL-21261 mnet overhaul - adding and removing files I missed in the last big commit 2010-01-28 20:17:12 +00:00
Penny Leach
de260e0f7b mnet MDL-21261 large overhaul. This commit changes:
- The way that mnet rpc functions are registered.  Plugins must now
  create db/mnet.php which is an array, similar to services.php.  This
  *replaces* the old mnet_publishes() functions.  version.php must be
  bumped to trigger this.

- More information about each rpc-available function is stored in the
  database, including the class it belongs to, the file it is found in,
  and whether or not it is static.  Methods that are not static must be
  in a class with a constructor that takes no arguments (this can easily
  be achieved with a small wrapper if necessary)

- The xmlrpc dispatcher has been rewritten to remove all the
  dependencies on hardcoded information about auth,mnet,portfolio and
  repository, and just use the information in the database.

- The old hardcoded hidden mnet/testclient.php has been moved to the
  Admin menu under "Development" and rewritten.

- The xmlrpc introspection method profiling is now using php and zend
  reflection - which is a lot nicer than the old way, which was using a
  php-based php parser.  This fixes some inconsistent handling of
  methods without arguments that were advertising their return value as
  the only method parameter.  While this is a *fix*, it breaks BC
  slightly - the old 1.9 broken mnet/testclient.php will now not work
  properly with 2.0

- Dangerous mode is still supported, but old mod/*/rpclib.php is
  now unsupported, due to the fact that any plugin can export mnet
  functions with db/mnet.php.  This is a slight BC break.

Still TODO:

- TEST TEST TEST
- Document the two small BC breaks in release notes
- Document the contract for db/mnet.php
2010-01-28 05:25:50 +00:00
Penny Leach
c0b22a3f96 mnet MDL-21294 fixed some errors in the new mnet exception stuff
I think I must have tested mnet client/server around the wrong way
2010-01-13 03:46:45 +00:00
Penny Leach
939ea0bc44 mnet MDL-21294 change errors to exceptions in mnet server 2010-01-13 01:08:38 +00:00
Petr Skoda
af0e9032f9 MDL-21319 preventing debug output and cookies in mnet xmlrpc server script 2010-01-12 10:59:08 +00:00
Penny Leach
f4b58166b6 mnet MDL-17169 trim the raw xmlrpc response before passing it to the xml parser
merged from MOODLE_19_STABLE
2010-01-11 01:02:43 +00:00
Penny Leach
edf1fc350a portfolio: MDL-20892 moved portfolio/type/* plugins to portfolio/* 2009-11-18 13:27:38 +00:00
Andrew Davis
6959330979 all MDL-20821 Removed more deprecated functions 2009-11-18 06:05:10 +00:00
Petr Skoda
1d42298086 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 12:22:45 +00:00
jerome
88d9e9d90e mnet MDL-10935 fix unicode character when the remote site send the course name for updating enrolment, merged from 19 2009-02-06 00:46:37 +00:00
mjollnir_
1cc8e4c13d Fixed misnamed variable I believe I was introduced in 1.33 2009-01-29 10:58:41 +00:00
jerome
46c8e3b0d6 MDL-15352: trivial change, add a clear error message when can't retirve listing 2008-10-24 05:36:59 +00:00
jerome
659054c521 MDL-15352: doesn't use anymore mnet system function, implemeted new mnet function, remote moodle service will appear into the peer service 2008-10-23 08:14:24 +00:00
jerome
ef378cdcf4 MDL-15352: doesn't use anymore mnet system function, implemeted new mnet function, remote moodle service will appear into the peer service 2008-10-23 08:14:23 +00:00
jerome
d3dfe9aecb MDL-15352: first version of remote moodle plugin 2008-10-22 04:04:23 +00:00
peterbulmer
c8a6dfee9b Typo correction in comment 2008-10-07 22:25:48 +00:00
peterbulmer
334e66c1c2 MDL16286 - bugfixes
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:19:45 +00:00
peterbulmer
8d60e9427d MDL16286 - redefine function boundaries.
Better defined what the decrypt / signature functions do & brought a lot of the error-exits together


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:19:04 +00:00
peterbulmer
34ebb3cfa2 MDL-16286 MDL-16285 better variable names and improved structure
Another one of those diffs that is a little more understandable when ignoring whitespace changes.


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:18:28 +00:00
peterbulmer
4399f32491 Created commit f319290: MDL-16285 MDL-16286 - Farm menial statements out to function
& improve variable names


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:17:34 +00:00
peterbulmer
469b60c52d MDL-16285 Renamed generic variable
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:16:59 +00:00
peterbulmer
aad3a24ced MDL-16286 MDL16285 add comment & invert logic flow
(This diff is best viewed ignoring whitespace changes)
Ignore logic flow so that errors are dealt with first


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:16:22 +00:00
peterbulmer
99112dfece MDL-16286 farm permission-to-call checks out to a function
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 04:04:22 +00:00
peterbulmer
99677c349f MDL-16286 Remove redundant lines and improve variable names
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 03:47:04 +00:00
peterbulmer
8263d8d7ca MDL-16286 minor formatting adjustment
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-28 03:45:22 +00:00
peterbulmer
250f84d6b1 MDL-16301 - use better variable 2008-09-07 04:59:37 +00:00
peterbulmer
988b0b2260 MDL-16301 - bugfix for earlier commit 2008-09-07 04:55:44 +00:00
peterbulmer
454a6e7c4d MDL-16301 - address issue
Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-07 03:19:35 +00:00
peterbulmer
5f6b28faf2 MDL-16286 separate strip wrappers() to decrypt() and check_sig()
additionally unfold logic inverstion around encrypted if block
To view this diff more effectively, consider setting 'ignore whitespace'

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-07 03:18:53 +00:00
peterbulmer
c7c556156a MDL-16286 MDL-16285 Bring 'signed by old key' logic together
and add appropriate comments


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-07 03:16:18 +00:00
peterbulmer
2a75520f71 MDL-16285 unfold logic inversion
Ignoring whitespace this patch is 4 lines of -, and 3 lines of +, if you want to understand what the diff is, I highly recommend looking at it without whitespace changes visible.

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
2008-09-07 03:15:35 +00:00
mjollnir_
ea676d6e67 MDL-16351 - make mnet_server_fault detect when it's being passed a full string rather than an 'mnet' string key 2008-09-05 12:24:11 +00:00
mjollnir_
a5248bee7b MDL-16289 - actually unpack xmlrpc errors rather than just whinge the payload is unencrypted 2008-09-02 14:11:53 +00:00
mjollnir_
b91b274b92 MDL-16180 - add portfolio support to mnet 2008-08-30 11:25:29 +00:00
skodak
600be0625e MDL-16163 disable mnet scripts properly if mnet not enabled 2008-08-21 20:43:25 +00:00
mjollnir_
e64de55dec MDL-16157 - fixing arguments to mnet_get_public_key 2008-08-21 14:45:28 +00:00