389 Commits

Author SHA1 Message Date
Adrian Greeve
b0c6dc1cac MDL-34465 - lib - Replacing get_context_instance with context_XXXX::instance (group 8) 2012-07-27 10:10:46 +08:00
Andrew Davis
fb80cb2aa4 MDL-13629 grade: added some unit tests to clarify the handling of droplow and improved apply_limit_rules() 2012-07-25 09:35:28 +08:00
Frederic Massart
455dc0de61 MDL-18301 Gradebook: Added feature for components to control grade visibility 2012-07-06 09:52:46 +08:00
Petr Skoda
4ca04fb58b MDL-32569 remove remaining references to simpletest and improve events test 2012-04-21 17:08:30 +02:00
Petr Skoda
6b04fdc0b6 MDL-32400 improve module generators
Module generators are using standard *_add_instance() methods which helps with testing, it also updates grades and calendar events if used.
2012-04-15 14:16:59 +02:00
Petr Skoda
bd42a2657e MDL-32323 do try to fetch all other grade objects with existing test fields 2012-04-11 22:56:27 +02:00
Petr Skoda
15db9f7d66 MDL-32323 do try to fetch grades with existing test fields 2012-04-11 22:41:37 +02:00
Petr Skoda
948d46da34 MDL-32323 add grade tests 2012-04-10 15:27:10 +02:00
Petr Skoda
caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Petr Skoda
e2bb3c9275 MDL-32094 some more E_STRICT fixes 2012-03-18 20:40:20 +01:00
Petr Skoda
f20edd5208 MDL-32094 fix various E_STRICT compatibility problems 2012-03-18 18:37:24 +01:00
Andrew Davis
ca540697f1 MDL-31362 grade: removed GRADE_UPDATE_ITEM_DELETED as it is not genuinely being used anywhere 2012-03-03 10:00:01 +07:00
Eloy Lafuente (stronk7)
cee44e2d96 Merge branch 'MDL-31363_grade_constants' of git://github.com/andyjdavis/moodle
Conflicts:
	lib/grade/constants.php
2012-02-28 12:37:44 +01:00
Andrew Davis
0e7f31b42b MDL-31363 grade: removed 3 constants that are not being used anywhere 2012-02-23 08:51:19 +07:00
Eloy Lafuente (stronk7)
11ce79b05d MDL-30999 whitespace fix 2012-02-20 12:17:33 +01:00
Eloy Lafuente (stronk7)
a4d7604977 MDL-30999 grade phpdocs - change some inline @see by correct @link 2012-02-20 12:09:50 +01:00
Andrew Davis
a153c9f2fe MDL-30999 grade: updated Grade API phpdocs 2012-02-14 14:04:19 +07:00
sam marshall
ad275cb4ad MDL-28643 Fix debugging message when deleting activity with grade completion 2011-08-10 11:02:56 +01:00
Petr Skoda
431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Eloy Lafuente (stronk7)
1b42e67747 MDL-25708 recordsets - fix lib/grade/xxx stuff 2011-01-25 19:59:00 +01:00
Petr Skoda
99d19c13ae MDL-25855 some more missing filelib includes 2011-01-23 18:34:41 +01:00
Petr Skoda
c3b1c4f097 MDL-25713 fixing trailing whitespace 2010-12-27 12:04:26 +01:00
andyjdavis
fc61acce12 gradebook MDL-25713 now closing the recordset even when theres a problem 2010-12-23 10:07:08 +08:00
andyjdavis
2f9ea7d78e gradebook MDL-25713 switched grade_object fetch_all_helper() over to using a recordset 2010-12-20 16:39:46 +08:00
Andrew Davis
2b574cc4e0 gradebook MDL-24330 massively reduced grade objects unit tests execution time so I can actually run them 2010-12-10 03:05:49 +00:00
Andrew Davis
b146d98455 gradebook MDL-24504 made grade item sorting work and prevented a bunch of sortorder shuffling 2010-10-04 08:05:05 +00:00
Petr Skoda
365a594107 MDL-24321 switching to stdClass in /lib/ 2010-09-21 08:07:44 +00:00
Petr Skoda
7c109ea3f0 MDL-24276 "static abstract" combination is deprecated since PHP 5.2, replacing with our coding_style exception 2010-09-19 18:43:52 +00:00
Petr Skoda
c10244114a spelling improvements 2010-09-18 10:46:53 +00:00
Petr Skoda
22a9b6d873 fixed phpdocs and marked methods as static 2010-09-18 10:43:50 +00:00
Andrew Davis
bfc7353d96 gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change pt 2 2010-09-17 03:08:45 +00:00
Andrew Davis
f64e29e133 gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change 2010-09-17 03:02:27 +00:00
Petr Skoda
f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Andrew Davis
59ee314414 gradebook MDL-24045 added a guard for when the user report is accessed outside of a course context 2010-09-02 02:38:29 +00:00
Andrew Davis
7bac377763 gradebook MDL-23543 made gradebook not display items with gradetype of no grade 2010-08-03 07:22:27 +00:00
Petr Skoda
7ad5a62727 MDL-21249 improved php docs and adding direct access prevention in editors 2010-07-25 13:56:54 +00:00
Andrew Davis
e40eabb5d9 gradebook MDL-23181 committing grade item patch 2010-07-14 08:51:19 +00:00
Petr Skoda
64f93798d4 MDL-22950 adding new component column to the files table, unfortunately this change requires changes in all 2.0dev code, please review all custom code that was already upgraded to 2.0; fixing multiple problems and regressions in mod/assignment 2010-07-03 13:37:13 +00:00
Andrew Davis
79b260cc88 gradebook MDL-21596 altered grade_category::set_properties() to try to intelligently set a default for weight and extra credit as a work around for those two properties sharing a single column 2010-06-08 02:10:21 +00:00
David Mudrak
f829c8d07f MDL-22062 Grade item's idnumber can be added from the calculation form
Before this patch, if activity module used multiply grade items (as
workshop does), the method add_idnumber() returned false because it
required empty idnumber in course_modules. The patch makes this check
only for grade_items with itemnumber 0.
2010-06-05 19:53:29 +00:00
Andrew Davis
992cfb1101 gradebook MDL-22139 fixed a typo in a comment 2010-06-01 09:27:47 +00:00
Petr Skoda
f7d515b6d3 fixed silly comment typos 2010-05-21 18:57:05 +00:00
David Mudrak
3869ab1ac6 MDL-21695 gradebook: Extra credit help strings
String aggregationcoefextraweight is used when editing an item which is
aggregated by Mean of grades (with extra credit) and was reworded to
Extra credit weight (because in fact it is the weight of the extra
credit - if it equals zero, the grade is not extra)

String aggregationcoefextrasum is used for Sum of grades and Simple
weighted mean of grades, meaning a checkbox extra credit yes/no

String aggregationcoefextra is used in the header of table Categories
and items (either Simple view or Full view). It must contain the information
about both meanings of aggregation.

AMOS BEGIN
 HLP grade/aggregationcoefcombo.html,[aggregationcoefextra_help,core_grades]
 HLP grade/aggregationcoefextra.html,[aggregationcoefextraweight_help,core_grades]
 HLP grade/aggregationcoefextrasum.html,[aggregationcoefextrasum_help,core_grades]
AMOS END
2010-05-21 13:46:28 +00:00
Tim Hunt
79312a06e4 grades: MDL-22098 silly bug that leads to bad performance problems in the grader report. 2010-04-15 16:37:05 +00:00
Tim Hunt
26e3ae92f2 grade import: MDL-21987 Problem with repeated imports of the same grade.
The thanks to Petr (skodak).

Here is what I learned while working on this:

1. when explicitly setting the final grade (manual edit or import),
   it is important that ->overridden gets set, and it should get set
   to the time when the override was done.

2. but only on certainly sorts of grade item, and the condition for
   setting the flag is different when it is the feedback being changed
   or the grade being changed, hence the two different tests
   is_overridable_item and is_overridable_item_feedback.

3. but, if the grade and feedback is not actually changed, then the ->overridden
   timestamp should not be changed. (That was the bit that was buggy.)
2010-03-31 13:50:56 +00:00
Petr Skoda
b16b5857f0 MDL-21790 fixed dml conversion regression - credit goes to Evan Irving-Pease for the patch and discovery, thanks 2010-03-10 08:42:44 +00:00
Andrew Davis
1762a2642a gradebook MDL-21514 Ironed out a bug with hiding course totals 2010-02-12 03:39:40 +00:00
Andrew Davis
61541a5a46 gradebook MDL-21218 Improved the hiding/displaying of category and course totals when they contain hidden items 2010-02-08 06:27:04 +00:00
Andrew Davis
d90aa63419 grader report MDL-21367 when an item is unhidden its category should unhide to 2010-02-03 02:31:46 +00:00
Andrew Davis
a25bb902f0 grader report MDL-19704 Added ability to hide course and category totals without hiding anything else 2010-01-11 07:35:40 +00:00