10992 Commits

Author SHA1 Message Date
Sam Marshall
15e48a1a49 Forum MDL-25170 Discussion move feature should have button so you don't do it by accident (again) 2010-11-15 10:41:26 +00:00
Petr Skoda
8082d3abf7 MDL-25187 upgrade log debugging to use new DML style
all credit goes to Eloy Lafuente (stronk7)
2010-11-15 07:38:02 +00:00
Petr Skoda
e47c78f929 MDL-25031, MDL-25198 fixed use of proper table prefixes in blocks upgrade and fixed invalid DML call in questions ugprade 2010-11-15 05:52:33 +00:00
Dongsheng Cai
675e7a425b MDL-25198, fixed incorrect sql, protect question image migration code by field_exists check 2010-11-15 02:54:31 +00:00
Petr Skoda
7415aed103 MDL-11728 finally defining the exact meaning of is_internal() in auth plugins
internal means "uses password hash for user authentication", there is a new is_synchronised_with_external() method that indicates if moodle should automatically sync user info with external system after login; I have also improved the default for prevent_local_passwords() which is now defaulting to !is_internal()
2010-11-14 02:01:59 +00:00
Tim Hunt
e4b54c79e0 question export MDL-25088 followup - remove no-longer-used function. 2010-11-12 12:07:22 +00:00
Tim Hunt
9203b70576 question deletion MDL-25173 when a question is deleted, all the associated files must be deleted. 2010-11-12 11:29:53 +00:00
Petr Skoda
2e24dd645e MDL-25174 adding a workaround for old passwords that were hashed with magic quotes 2010-11-12 10:13:40 +00:00
David Mudrak
628c78409c New icon for portfolio export and improving its position
The old icon was considered "temporary" (according to Penny) and it was
not very clear. Hopefully this one is a bit better.
2010-11-12 08:52:55 +00:00
Sam Hemelryk
d9e0726431 lib MDL-1975 Users who have been auto logged in by guest are now redirected to login on capability exceptions rather than being shown the exception. 2010-11-12 07:53:55 +00:00
Sam Hemelryk
d067fc474c javascript MDL-25013 YUI modules are now recursively loaded and a stacktrace stored when this occurs 2010-11-12 05:26:47 +00:00
Andrew Davis
078397d28e gradebook MDL-21907 grader report group view was being limited to groups in the course's default grouping 2010-11-12 04:00:45 +00:00
Petr Skoda
07c53c4a48 MDL-25174 adding a workaround for old passwords that were hashed with magic quotes 2010-11-12 02:36:20 +00:00
Eloy Lafuente
96c726b663 MDL-24924 course/import - plugin not available anymore. Killed! 2010-11-11 22:52:17 +00:00
Tim Hunt
5d548d3e0a question bank MDL-24995 clean up a lot of deprecated code to do with moving questions around.
This should also fix MDL-25172, MDL-23021 and MDL-23073. In other words, moving questions between categories should now work.
2010-11-11 21:54:22 +00:00
Tim Hunt
d2af10140a forum files MDL-25167 files in the post file area were not moved when the post was moved or deleted.
Also, I refactord some code out of forum_move_post and into a new method file_storage::move_area_files_to_new_context. I hope that is OK.
2010-11-11 18:58:06 +00:00
Tim Hunt
057815f341 formslib editor NOBUG delete unused global file reference. 2010-11-11 18:33:11 +00:00
David Mudrak
ac6d26bbd1 Portfolio export link displays title plus obsolete code cleanup 2010-11-11 18:24:49 +00:00
David Mudrak
0ce579fe89 Portfolio strings changed to reflect the heading of the next page
Plus fixed some typos in the portfolio library
2010-11-11 18:04:27 +00:00
Tim Hunt
a9efae50e3 question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.
There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
2010-11-11 17:32:25 +00:00
David Mudrak
d39c651378 Fixed trivial typo in debugging message text 2010-11-11 16:46:41 +00:00
David Mudrak
76116d2e16 MDL-24693 Flickr.com portfolio plugin fixed 2010-11-11 13:33:13 +00:00
David Mudrak
bf0fc3c057 Improved portfolio export summary layout 2010-11-11 13:32:57 +00:00
Sam Hemelryk
09ecc227a3 navigation MDL-24990 Wrapped link to assign roles in categories within proper capability check. 2010-11-11 08:58:46 +00:00
Petr Skoda
dfd9f745b1 MDL-21963 rewritten progress bar internals, hopefully working now properly 2010-11-11 07:56:49 +00:00
Andrew Davis
d38755249d message MDL-25148 using method on $PAGE to allow or disallow popup notifications 2010-11-11 06:11:43 +00:00
Petr Skoda
f11f7b41df MDL-25152 guest logging can be disabled now 2010-11-11 06:11:13 +00:00
Andrew Davis
e7f93d5cb5 message MDL-25148 added method to $PAGE to allow or disallow popup notifications 2010-11-11 06:06:11 +00:00
Petr Skoda
0ed26d1288 MDL-25150 new debugusers setting 2010-11-11 05:27:34 +00:00
Sam Hemelryk
ed1d72ea70 navigation MDL-25142 Fixed up differences in navigation between guest and normal user.
As part of this patch I also introduced a new method in accesslib can_access_course that can be used
to check a users access to a course.
I also fixed a minor issue with guest access flag caching in require_login
2010-11-11 03:37:56 +00:00
Sam Hemelryk
215d7cb84e NOBUG: Improved docs for concat functions within mysql_native_moodle_database.php 2010-11-11 01:57:35 +00:00
Petr Skoda
090b958641 no return necessary after exception thrown 2010-11-11 00:39:53 +00:00
David Mudrak
f4a2817ac5 MNet upgrade: missing required not null value
The column description in mnet_service table is set to not null and no
value is set for the insert_record(). We must explicitly provide the
empty string if the description is not defined in db/mnet.php file.
2010-11-10 16:01:23 +00:00
Sam Hemelryk
bac233d326 backup MDL-22184 Scheduled backups are now possible again through cron.
AMOS BEGIN
 MOV [move scheduledsetup,core_backup],[automatedsetup,core_backup]
 MOV [scheduledsettings,core_backup],[automatedsettings,core_backup]
 MOV [scheduledstorage,core_backup],[automatedstorage,core_backup]
 MOV [scheduledstoragehelp,core_backup],[automatedstoragehelp,core_backup]
 MOV [scheduledbackupsinactive,core],[automatedbackupsinactive,core_backup]
 MOV [scheduledbackupstatus,core],[automatedbackupstatus,core_backup]
 CPY [schedule,core],[automatedbackupschedule,core_backup]
 MOV [backupschedulehelp,core],[automatedbackupschedulehelp,core_backup]
AMOS END
2010-11-10 06:07:43 +00:00
Petr Skoda
45ff8a80d3 MDL-24955 improved detection of available self enrol plugins 2010-11-10 02:14:27 +00:00
Sam Marshall
3dfe69c927 Unit tests MDL-24980 Disable obsolete portfolio tests until such time as somebody can fix them 2010-11-09 17:10:34 +00:00
Sam Marshall
702a206cd3 Unit tests MDL-24993 Disable obsolete portfolio tests until such time as somebody can fix them 2010-11-09 17:09:13 +00:00
David Mudrak
9dbc2e7b4a MDL-25111 MNet: fixed typo in the callback function name
Credit goes to Hubert Chathi.
2010-11-09 13:11:28 +00:00
David Mudrak
03276af682 MDL-25072 reverted theme's disablecourseajax to enablecourseajax property 2010-11-09 11:55:37 +00:00
David Mudrak
b31b2d842d MDL-14790 ajax delete confirmation box now uses the same wording as the non-ajax confirmation page 2010-11-09 11:55:26 +00:00
David Mudrak
8b2918a425 MDL-25072 convert $CFG->disablecourseajax to $CFG->enablecourseajax 2010-11-09 11:55:11 +00:00
Andrew Davis
305adb1023 message MDL-25114 corrected some code doc 2010-11-09 06:47:53 +00:00
Andrew Davis
a6de5ed53a message MDL-25114 tried to make the message provider not found error info more helpful 2010-11-09 06:12:04 +00:00
Andrew Davis
60dd7688a8 message MDL-25114 tried to provide a more helpful error message for when code sending a message supplied an unknown component or event name 2010-11-09 06:01:20 +00:00
Petr Skoda
cdfb6ba850 MDL-25072 themes may disable ajax course edit 2010-11-09 01:28:43 +00:00
Sam Marshall
9d81733d4c Admin MDL-23244 Portfolio/repo admin pages use nested forms, which are illegal HTML and cause first dropdown on page to break 2010-11-08 17:12:03 +00:00
Tim Hunt
855f9c3930 question bank MDL-24312 problem when deleting a course with orphaned categories.
When there was a question category whose parent had somehow been deleted from the question bank, while the child category was still there, then that gave an error because a DB query was still referring to the question_categories.courese coloumn, that was changed to contextid in moodle 1.9.

Fix thanks to Mahmoud Kassaei.
2010-11-08 15:55:45 +00:00
Tim Hunt
4673212416 xml import/export MDL-25103 was not working due to out-of-memory errors when calling xmltidy, which broke XML wellformedness.
The solution is to not tidy the XML. The XML generated is already quite well laid out, and if we want it better, we should fix that, rather than trying to load the whole file into memory to reformat it.

Also, while investigating this, I found that we were not handling the mime-type of the exported file very elegantly, so I added a new mime_type method (defaults to getting the mime type of the file extension).
2010-11-08 15:51:10 +00:00
Tim Hunt
2284c694ee weblib NOBUG Add a comment to clarify that moodle_url deals with $CFG->admin for you. 2010-11-08 13:33:08 +00:00
Sam Marshall
fc2b6316f1 Unit tests MDL-24980 Initial fix (no fully working yet) for portfolioaddbutton test 2010-11-08 11:07:09 +00:00