117 Commits

Author SHA1 Message Date
tjhunt
3e3e5a4030 Renamed column question_sessions->comment at Eloy's request since comment is a DB reserved word.
I have not been able to test this fully, because I cannot assign roles (e.g. Student and Teacher) in 1.7dev at the moment to test a student answering an essay question then a teacher grading it. However, I have tested as much as possible as admin and cannot get any errors.
2006-08-24 16:44:15 +00:00
tjhunt
3ebdddf70f MDL-4816 Fix silly error in my commit for this bug. 2006-08-24 11:37:10 +00:00
tjhunt
c82f76d050 MDL-4816 Short answer question type considers '100' and '100.' to be the same Actually, this may have affected other question types too. 2006-08-23 21:17:23 +00:00
tjhunt
ef82286874 Bug #6293 - Cannot regrade a question when a teacher has added a comment with a ' - Merged from MOODLE_16_STABLE. Stupid, wreched, datalib. Why can't datalib take care of addslashes, so the whole of the rest of the code can forget about it? That is how a database abstraction layer should work. I know, it is pointless to moan about it, but it has just cost me 3 hours, so I feel I have earned the right to moan. 2006-08-18 22:34:54 +00:00
tjhunt
865b753486 Code cleanup. Merged from MOODLE_16_STABLE. 2006-08-18 22:26:04 +00:00
tjhunt
1780811d55 Added todo. 2006-08-18 08:14:47 +00:00
tjhunt
1d723a169a Bug #6267 - questionlib.php delete_question infinite loop with rantom questions. Thanks to mbockol at carleton dot edu. Merged from MOODLE_16_STABLE. 2006-08-16 16:17:18 +00:00
tjhunt
a21567892f Refactor how question types register themselves with the question bank. This change makes it easier for 3rd party question types to control their destiny, but is also backwards compatible, in that old 3rd party plugins will still work. See http://moodle.org/mod/forum/discuss.php?d=51796 for more details. 2006-08-15 21:25:38 +00:00
tjhunt
1b8a7434e2 Bug 6239 - Allow questions to have some teacher-supplied commentary.
While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590, and is why this patch makes the codebase 523 lines smaller.
2006-08-11 14:59:18 +00:00
tjhunt
93eb0ea339 Fix comment. 2006-08-10 21:33:53 +00:00
tjhunt
5a14d563b9 Bug #5972 - Some question types mark a blank answer inconsistently.
Also, cleaned up the marking code for numerical and short answer questions, partly by making the base-class method more useful.

Rewrote the way the way short answer questions do wildcard matching to be more robust, Unicode safe, and generally not suck.

This is a big change, so I am pleased to report I tested it using my new Selinium  test suite. See: http://moodle.org/mod/forum/discuss.php?d=51161
2006-08-04 16:53:43 +00:00
tjhunt
bdfad57b83 Added information to a comment. 2006-07-28 10:55:37 +00:00
tjhunt
d7444d442f Bug #6033 - missing string for unknown questiontype. Also tidied up some messy code. Merged from MOODLE_16_STABLE. 2006-07-18 15:34:24 +00:00
tjhunt
062a7522c2 Bug 6111 - Rewrite the code for making an indented list of question categories, becase the existing code was so horrible. Merged from MOODLE_16_STABLE. 2006-07-14 15:36:29 +00:00
tjhunt
ec23db087c Bug 6031 - missing parameter for warningmissingtype in libquestionlib.php. Merged from MOODLE_16_STABLE. 2006-07-06 11:09:24 +00:00
tjhunt
82b5d7cd8e Bug #5922 - comment from manualgraded questions lost during regrade. Thanks to Jean-Michel Vedrine for the fix. Merged from MOODLE_16_STABLE. 2006-06-28 11:45:11 +00:00
tjhunt
5e60643e1b Bug 5889 - Regrading a quiz wipes student answers. Thanks to Jean-Michel Vedrine for the fix. Merged from MOODLE_16_STABLE. 2006-06-26 11:23:32 +00:00
danstowell
87075ec1cd Fixed typo which caused images in questions to fail to display if NOT using slasharguments 2006-06-23 15:06:23 +00:00
gustav_delius
36be25f6e5 Introduce question_attempts table, closing bug 5468
Fixed incorrect check for whether to update state or insert new one in save_question_session()
Deal with manually graded states correctly during regrading
Increase state sequence number during manual grading
Supplied missing userid to quiz_save_best_grade() during manual grading
2006-05-13 16:57:17 +00:00
thepurpleblob
6cb4910c58 Merged from STABLE 2006-05-08 10:39:14 +00:00
thepurpleblob
9c802dff19 Bunch of category functions moved to question/editlib.php 2006-05-02 12:26:36 +00:00
thepurpleblob
947217d725 Small clean up, and fix a link to a required file for robustness. 2006-05-02 09:04:38 +00:00
gustav_delius
2b44d03f81 Error message for when a questiontype is missing is prepended to question text. 2006-04-30 17:33:00 +00:00
gustav_delius
2e9b6d157c Fixed bug 5192 2006-04-30 16:15:04 +00:00
gustav_delius
ca56222d50 Fixed and simplified the logic in the response processing. Remove the walking through previous graded states. 2006-04-30 11:45:14 +00:00
gustav_delius
c4c11af898 Now that the shuffling within a question can be controlled also at question level the default at the module level needs to be set to true, otherwise people can not test the question setting. 2006-04-30 08:11:49 +00:00
skodak
6cf4cbbdf9 added FIX ME notice for inclusion of format.php 2006-04-22 17:21:21 +00:00
thepurpleblob
2784b98278 Don't compare floats for equality! Bug #5176 2006-04-13 10:29:20 +00:00
gustav_delius
da1cc5a44e Fixed problem with slashes, bug 5177 2006-04-13 00:37:14 +00:00
gustav_delius
cbe20043b5 Whenever a question is edited the version field is set to question_hash(), see bug 2958. 2006-04-10 22:10:32 +00:00
gustav_delius
848d886edb Small change to question_print_comment_box() to allow multiple boxes on one page 2006-04-09 22:48:58 +00:00
gustav_delius
1d7e093418 Small fix so that unattempted questions would never be marked 2006-04-09 21:35:44 +00:00
gustav_delius
7c404f9b2b Fixed some small xhtml problems and removed a warning 2006-04-08 14:20:52 +00:00
gustav_delius
2a2aba273f submit button for teacher comment is now included in question_print_comment_box 2006-04-08 08:22:18 +00:00
gustav_delius
b6e907a245 Manual grading 2006-04-07 16:00:29 +00:00
gustav_delius
755bddf118 Improvements to response history. Three small bug fixes. 2006-04-06 19:59:02 +00:00
gustav_delius
3a5a6f59a3 Introduce field for teacher comments, in preparation for manual grading 2006-04-06 16:42:00 +00:00
gustav_delius
0a5b58af89 Many bugfixes accummulated during CVS outage, more to come. 2006-04-05 05:53:18 +00:00
gustav_delius
bc2feba364 Some preparation for manual grading 2006-03-27 17:38:30 +00:00
gustav_delius
d23e3e11dd Moved the code for basing new attempts on previous attempts from questions to quiz and fixed the bug reported at http://moodle.org/mod/forum/discuss.php?d=42029#194212 in the process 2006-03-26 07:59:43 +00:00
gustav_delius
5cb9076a58 Removed warning when deleting questions with no states 2006-03-25 21:07:11 +00:00
gustav_delius
4eda4eecbd Added question type that is used if a question of unknown type is encountered.
Also removed some of the unnecessary calls to name()
2006-03-24 21:21:59 +00:00
gustav_delius
ca252edb1d Setting title attribute on questiontype icons so that tooltips show the question type name 2006-03-24 20:02:42 +00:00
gustav_delius
aaae75b04f Renaming question/questiontypes/ to question/types/ as requested by Martin 2006-03-24 19:54:13 +00:00
gustav_delius
643ec47d32 Renaming question/questiontypes/ to question/types/ as requested by Martin 2006-03-24 19:31:46 +00:00
gustav_delius
0429cd86c3 Deleting attempts properly now 2006-03-22 18:27:28 +00:00
gustav_delius
4dca7e51ca Some minor improvements in the handling of review options, the setting of timestamp, and improvements to the documentation 2006-03-22 17:22:36 +00:00
thepurpleblob
8511669cb9 Added function for matching/checking question grades on quiz import. 2006-03-22 16:27:46 +00:00
thepurpleblob
e9de436630 Split out grade option list generation, so it can be used in import/export too. 2006-03-22 14:43:55 +00:00
gustav_delius
6040798269 Abolished the qtype integers. The question types are now indexed by their name as specified by their directory name. This will avoid a lot of confusion in future when we have plugable question types. 2006-03-21 23:08:36 +00:00