Commit Graph

63 Commits

Author SHA1 Message Date
cc3dbaaa30 MDL-21249 improved php docs package+subpackage info in mod/lesson 2010-07-25 10:54:39 +00:00
b3daa92632 fixed coding style to match other modules 2010-07-25 09:30:09 +00:00
d16d35dc80 localised error message and adding correct continue link 2010-07-25 09:25:48 +00:00
6524006ba0 fixed undefined actions and dumb redirects 2010-07-25 09:23:25 +00:00
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
448052a5fd mod-lesson MDL-21006 Refactored renderer->header method, removed logic to function in locallib 2009-12-18 03:50:38 +00:00
649cf95d0b MDL-21147 renamed find_renderer back to get_renderer() - there are no more collisions with those magic getters 2009-12-17 14:06:22 +00:00
56cbc53b76 MDL-21143 theme renderers related refactoring, it should detect more problems now, there is also a list of core renderer subtypes, hopefully the api changes are improvements 2009-12-17 13:45:54 +00:00
0a4abb7306 mod-lesson MDL-21006 Huge refactoring of the lesson code
The following are notable changes made in this commit
* Lesson page type are now class based and extend an abstract class. This includes a class for the page type and a class for the creating/editing a instance of this page.
* Converted all forms to mforms
* Action script located in mod/action/* were worked into the above so far less switch statements and the action directory will be removed.
* Implements a custom renderer
* Converted everything to use page, output, and custom renderer methods
* Replaced all deprecated methods incl. print_textarea conversions
* Tried to cut down on excessive DB calls.
Things worth noting:
* The focus of this patch was on cleaning up the module not rewriting it, as such I have organized NOT rewritten. There are still many areas in the module where the code could be greatly improved however to do so would require a rethink/rewrite
2009-12-16 02:00:48 +00:00
afc9bd4ea3 MDL-20927 fixed module login issue 2009-11-21 23:50:14 +00:00
472e56620e MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 15:17:21 +00:00
86342d631f MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 15:03:10 +00:00
c69499369e mod-lesson MDL-20259 Created callback methods to expand navigation and settings blocks
Also fixed up minor bugs and added calls set_url
2009-09-16 06:22:12 +00:00
f7e6b8624a MDL-19812 Converted all print_footer() calls 2009-08-06 14:14:24 +00:00
1858ba0c67 "MDL-14129, fix print_error" 2008-06-12 11:52:15 +00:00
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
5491947aa1 NO CODE CHANGES. Just added PHPdoc comments at the top of lesson files. 2006-09-30 19:49:40 +00:00
d1b025d013 Moved high scores logic out of view.php into highscores.php
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
6e1ff5c8fb MDL-6477: Added roles support.
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
c5a2e12f08 Added $Id$ to files
Header is not printed for all actions.  Related to MDL-5403
Some redundant code removed
First attempt at separating logic and presentation in action continue (continue.html)
2006-09-06 04:04:42 +00:00
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00
a1d0b3eb81 [BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons. Had to change arguments for this function as well which is the edit in view.php.
lesson.php how checks for teacher editing priv for all actions except for continue.  This is just in case the user hacks the URL.
2006-05-15 19:14:22 +00:00
97d2756c65 [New Feature] Tabbed navigation added to lesson (similar to quiz)
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
62eda6ea18 NEW: Progress bar option. Now a progress bar can be optionally displayed at the bottom of the lesson page.
NEW: Display Left Menu IF.  The left menu will only display if the student has a grade better than the one set in the lesson settings.  This is nice to allow only students who are reviewing the lesson to have access to the left menu.

BUG FIX: In Windows IE, the content was being aligned center.  Now, the content is explicitly aligned to left as default.
BUG FIX: High Scores variable was not spelled correctly at the End of Lesson.

ADDED: Div tags around branch tables.  This will allow users to choose to display them or not or move them around

CHANGED: converted more of the links to the stylized button.  Also, removed a lot of forms and javascript and replaced it with links with the variables in the href.
CHANGED: the slide show styles have been moved to the style sheet.
CHANGED: removed the CDC comments

Other minor changes have been made to the code as well.
2005-10-24 23:06:43 +00:00
271fea974f Tabs are out.
(all the module was using them, please change your editor settings to 4 spaces)
2005-05-16 22:41:19 +00:00
0a2c2599b6 Now lesson->name supports filterall 2005-04-24 16:46:51 +00:00
6656bf0af1 Security fixes
Fixed up styles handling to be more standard (the themes include them
already so no need for modules to do it)
2005-03-30 03:07:39 +00:00
d1465c3d12 Naming, people, naming ... keep it clear but minim 2005-03-30 02:59:41 +00:00
845a17e6f0 all the actions in lesson.php are now defined in mod/lesson/lessonactions/ 2005-03-30 00:49:18 +00:00
c32bc595bd on multichoice questions with multianswer, the code was not cleaning the variables correctly. Now sends the array through a foreach and then clean_param on each element in the array. Fix is around line 855. 2005-03-29 22:38:27 +00:00
801697d170 insertpage and updatepage now clean params correctly (i hope) 2005-03-10 20:34:32 +00:00
ac8e16be13 Bye. Now all those tabs are out 2005-03-05 00:09:39 +00:00
ff2978cea0 updated the time code to refect the new view 2005-02-25 19:11:12 +00:00
6899d8973f removed an echo and a comment 2005-02-23 22:24:46 +00:00
49584784ac fixed up leftmenu some more 2005-02-23 00:52:29 +00:00
ec81373f50 In order to ensure that when a teacher hides a resource or an activity that students really can't get at it, even if they know the direct links to its pages, I have given an optional third argument $cm to the functions require_login() and require_course_login(). Pages showing information about a particular course module now pass the course module object in this third argument. The login functions will then test if either the course module is visible or the user is a teacher. If neither is the case then the user is redirected to the course homepage after being shown a message "Sorry, this activity is currently hidden".
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
2005-02-16 10:40:48 +00:00
078ab023be array/object initialization and made essay question type work with unanswered lesson flow 2005-02-09 22:34:14 +00:00
fafd89a0f1 Removed $THEMEs and stuff.
I'm a little worried about this spaghetti code ... it's a mess!
2005-02-09 15:36:29 +00:00
a710d8c616 Improved feedback after an action (on redirect) and also put a
navigation check link up the top.
2005-02-09 15:21:56 +00:00
b7daa75d08 most changes in continue section. Took it out of slideshow. Made some display changes with display left (not style sheet dependent now) 2005-02-04 19:30:19 +00:00
f862f00d54 variable cleaning and sesskey updates 2005-01-27 21:36:12 +00:00
eb65aeb7fd security updates: parameter cleaning 2005-01-26 00:22:51 +00:00
8061400e0f updated essay and short answer code to work with quotes (single and double) 2004-12-01 21:02:07 +00:00
db22702089 endofcluster pages are not displayed anymore, shortanswer wrong answers are interpreted correctly, added user answer tracking to attempts so it can be used later by report.php, essays are no longer insterted into an essay table... now kept in the useranswer field in attempts, fixed a problem with grading numerical questions, modified to work with modattempts option, fixed a problem with grading matching questions and fixed addpage so that it displays multichoice with the multianswer option 2004-11-01 20:15:11 +00:00
d19d9ef16d Fixed some problems with matching 2004-09-21 22:11:00 +00:00
839f2456bb XHTML compliance
- fixed (hopefully) all <img> tags
- global replace on <br> to <br />
- &amp; in URLs
- got the forum module XHTML compliant
Julian Sedding
2004-09-16 17:13:57 +00:00
5e7856af58 Added a lot of new features to lesson mod. Check them out :)
MarkNielsen
2004-09-15 20:32:24 +00:00
41905731b7 fixed capitalization and quoting of attribute values 2004-09-12 16:24:41 +00:00
a9ef4a630a closed <input /> <br /> <hr /> 2004-09-12 14:41:49 +00:00
8544774f37 Slightly improved version for checking short answers. 2004-09-10 21:38:15 +00:00