martinlanghoff
aebfa1546e
weblib: print_user()/print_user_picture() optimisations
...
print_user_picture() was forcing an unneeded dbquery
if you need an imagealt. And who doesn't need one these days.
So - teach print_user_picture() to take either $userid
_or_ $userobj as the first parameter. If that first
parameter has the fields we need, never touch the db.
In other words, only touch the DB as a last resort.
There is a bit of ugliness in testing whether we have
the fields or not, because these fields are inconsistently
with/without NOT NULL in the DB definitions. So we cannot
use isset() because it barfs on nulls. And we cannot use empty()
because it will match both on "missing key" and ''.
And while at it, silence warnings that we are missing string
for the year(s). Also fixes a missing string bug in really boring
courses that noone's visitied in many years ;-)
2007-09-19 07:19:35 +00:00
martinlanghoff
b1178725a8
weblib: switchroles_form() user_login_string() handle the new switchroles
...
The switched role data bits have moved to a
different place in the session. Trivial to fix here.
2007-09-19 07:06:17 +00:00
martinlanghoff
0532aec946
weblib:update_course_icon() - remove access control from here
...
Access control for the course icon display should happen
at the page level, as we'll need to ask "can edit?" quite
a few times in the page.
The fact that this is weblib should be a good hint that
functions that print html should not be doing access control...
2007-09-19 06:52:52 +00:00
skodak
e193724e38
MDL-11295 editorshortcutshelpbutton breaking xhtml strict
2007-09-15 19:36:31 +00:00
martinlanghoff
cf1348caae
PERF logging - move handling to moodle_request_shutdown()
...
By moving the performance profile logging to the very
end of PHP processing, we cover more pages, notably those
that don't end up with a footer or a redirect, like file
serving.
This should improve quality of our performance logs, and
help catch some piggies...
2007-09-12 02:57:26 +00:00
martinlanghoff
3446daa3da
redirect() - log performance profiling info
...
Many heavy pages end in a redirect. Log their profiling data!
Thanks to Matt Clarkson for spotting the problem.
2007-09-12 02:57:08 +00:00
moodler
3a1ac34002
Fixed some notices on some custom pages
2007-08-31 03:45:59 +00:00
moodler
7b0d5cd551
Merged fixes for MDL-7425 from 1.8 stable
2007-08-30 06:01:57 +00:00
moodler
432038e084
The home page is the only exception to the rule of navigation
2007-08-27 09:40:14 +00:00
moodler
0ae31f38fb
Removed unnecessary BR
2007-08-27 05:17:11 +00:00
moodler
c77f9f07db
Don't include AJAX libraries is AJAX is off across the site
2007-08-27 04:36:09 +00:00
mattc-catalyst
e683967738
MDL-10888: groupings - added function to get all grouping members, cleaned up some notices
2007-08-26 23:47:24 +00:00
skodak
e6260a456b
MDL-10635 improved performance of update_course_icon() and friends; fixed parameter of iseditting() - removed $userid which was not used and did not make much sense there anyway
2007-08-25 11:28:37 +00:00
nicolasconnault
54c0f82b1d
MDL-10970 Reverted changes
2007-08-24 12:45:16 +00:00
nicolasconnault
364fffda3b
MDL-10723 Removed all uses of print_navigation() throughout moodle, the function call is now entirely deprecated.
2007-08-24 04:22:30 +00:00
skodak
5adad31057
MDL-10937 upgraded html purifier to 2.1.1
2007-08-21 22:06:47 +00:00
mattc-catalyst
43b49d039d
MDL-10888: groupings - make 'jump to...' menu respect groupmembersonly flag
2007-08-21 03:18:19 +00:00
skodak
9d66deb3ce
MDL-10383 - some more refactoring and new grouping related functions for modules
2007-08-20 13:56:39 +00:00
Martin Langhoff
13534ef716
cvsimport fixups
2007-08-29 13:10:11 +12:00
nicolasconnault
f1af7aaaf5
MDL-10870 All files updated to new build_navigation() method.
2007-08-17 07:25:47 +00:00
skodak
c4e953e69e
MDL-10383 - group edit form refactoring and minor bugfixing
2007-08-15 20:33:17 +00:00
urs_hunkler
3b9b99e018
$THEME->htmleditorpostprocess merged from 1.8
2007-08-12 09:58:23 +00:00
tjhunt
df4c79e232
Accessing wrong field of $mod from course.modinfo. Merged from MOODLE_17_STABLE.
2007-08-10 10:37:30 +00:00
moodler
f31701c4ab
Removing the langdir stuff from themes
2007-08-09 10:09:34 +00:00
moodler
b211809549
More support for right-to-left languages MDL-10768
2007-08-09 08:40:02 +00:00
nicolasconnault
a067e30df5
MDL-9775 Reverting Urs' dot, so that martin can play around with this issue.
2007-08-06 05:49:49 +00:00
urs_hunkler
48bfa2e0c9
Nicolas' changes to custom_corners has broken the theme. I decided to use the same method as clearfix by adding a "." and not a " ". Some additional CSS is needed either way.
2007-08-05 10:31:57 +00:00
luizlaydner
5557c75a9f
- added block support for tag pages
2007-08-03 21:41:09 +00:00
nicolasconnault
206ab18470
MDL-9775 Added inside the <div></div> for class="bt" and class="bb", for custom corners theme
...
MDL-10702 Finished fixing the CSS
2007-08-03 11:55:28 +00:00
nicolasconnault
2e3987a935
MDL-10674 and MDL-10675 finished
2007-08-01 14:08:50 +00:00
moodler
80c3fd51ee
Merged fix for doc links MDL-10670 from 1.8 stable
2007-07-31 16:19:53 +00:00
urs_hunkler
70244cc2cd
MDL-10075 - changes done following Petr's patch and optional_param with default ltr
2007-07-29 20:46:05 +00:00
urs_hunkler
3572b8b1ee
removed <br /> in sitelink
2007-07-25 14:50:37 +00:00
tjhunt
e344003ad6
MDL-10589 - make the forum subscribe link a post form button.
2007-07-24 17:17:52 +00:00
tjhunt
9d308cb4d0
Improve javadocs.
2007-07-23 16:54:16 +00:00
skodak
d049fd45a5
MDL-10566 do not redirect when dubug message printed; do not redirect also in DEBUG_ALL mode when error found - the DEBUG_DEVELOPER is not used by all developers all the time ;-)
2007-07-22 17:34:41 +00:00
urs_hunkler
e1d02e7e0f
corrected an error in the sideblock structure for custom corners
2007-07-18 21:06:40 +00:00
urs_hunkler
966c9a686c
corrected a wrong closing div
2007-07-18 19:51:11 +00:00
urs_hunkler
53c914f8e2
added a wrapper div to be able to handle content shorter than the side columns
2007-07-18 15:41:26 +00:00
skodak
8ce0363638
MDL-8096 fixed & in htmlarea httpsrequired parameter - xhtml strict fix
2007-07-15 15:15:30 +00:00
nicolasconnault
4ba9941c4b
MDL-10386 Refactored the grader report file (index.php), and extracted the grade_report_grader class out of it. The index file now only calls upon the class' main methods. Certain elements and code blocks in the class can be abstracted for other reports (such as the paging, sorting arrows and several general purpose variables).
2007-07-12 16:36:38 +00:00
skodak
f8e6e4dbea
MDL-10226 improved regrading of final grades - optimised db access, partial regrading when raw grade updated
2007-07-08 14:57:19 +00:00
tjhunt
21988c8e20
Small improvement to print_table. Lets you apply a class attribute to particular table rows.
2007-07-06 11:29:25 +00:00
toyomoyo
eca3af25cb
MDL-7077, MDL-10181, adding notes for students
2007-07-05 06:53:17 +00:00
mattc-catalyst
3b27b0fe21
MDL-9615: Correct incorrect use of term breadcrumbs
...
- $crumbs -> $navlinks
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:40:48 +00:00
nicolasconnault
82b4da8649
MDL-10210 Added the grader report admin settings, and its corresponding language strings. Few other minor edits.
2007-07-04 10:01:20 +00:00
urs_hunkler
a04c3b55b9
working on MDL-10322 :: tabs. I added a space before the closing </li> to close the gap between the li elements used without images. I don't know why this space is necessary.
2007-07-03 20:17:54 +00:00
mchurch
89676f4dea
Bug MDL-8520. Adding target= to the prev/next and logs buttons.
2007-06-28 19:18:11 +00:00
skodak
a33c44c4b9
MDL-10276 Text cleaning trouble
2007-06-27 11:58:33 +00:00
mchurch
12c1f0abea
Fixing update_group_button and update_groups_button. They were no longer calling valid URL's.
2007-06-25 20:50:17 +00:00
