jamiesensei
2280e147c5
MDL-12418 "Item Analysis shows duplicate responses for Multiple Choice questions with LaTeX in answers" This problem was caused by the formatting of questions in get_actual_responses. Now formatting is done in response_summary rather than get_actual_response which returns an array of unformatted strings.
...
Have fixed the formatting in responses report and in statistics report to use the correct formatting for the question type.
Created new functions format_responses and format_response. format_responses works on an array and normally just walks through the array calling format_response.
2008-11-28 10:14:19 +00:00
tjhunt
f24493ec9b
random essay questions: MDL-8648 Allow essay questions to be selected by random question.
...
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.
The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.
I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
jamiesensei
bbf4f440ee
MDL-15326 "allow for per report capabilities to replace mod/quiz:viewreports"
2008-11-25 12:11:27 +00:00
jamiesensei
a832c5e151
MDL-5241 edited comments that had not been updated.
2008-11-21 10:02:49 +00:00
tjhunt
9101efd312
cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.
...
For something that has been deprecated for over two years, they were still used in a lot of places!
2008-11-13 08:40:57 +00:00
jamiesensei
664bf34ff6
MDL-17190 "error in code for calculating discrimination index and efficiency for randomly selected questions" Fixed the code for item stats.
2008-11-10 14:42:21 +00:00
jamiesensei
746860479f
MDL-17188 "effective question weight equation cannot cope with negative covariance of question grades" excluding such questions from equation
2008-11-10 11:56:37 +00:00
jamiesensei
af30cd8870
MDL-14209 "quiz stats report:Seperation of functionality and unit tests for calculations" forgot to remove this, now redundant, piece of code.
2008-11-10 08:12:28 +00:00
jamiesensei
2685ec17ea
MDL-14209 "quiz stats report:Seperation of functionality and unit tests for calculations" Unit tests for the grade stats calculations.
2008-10-29 10:09:55 +00:00
jamiesensei
45cf6fd910
MDL-14209 "quiz stats report:Seperation of functionality and unit tests for calculations" Seperating out call for processing actual student responses from calculation of other grade stats as I want to unit test the grade stats calculations.
2008-10-29 10:00:44 +00:00
jamiesensei
e815151ead
MDL-17002 "unit test to test quiz_report_index_by_keys"
2008-10-24 15:34:19 +00:00
jamiesensei
047c0f78aa
MDL-16952 "after DB field type changes standard deviation and facility index show up as 0% instead of blank" Problem is that question->maxgrade is now 0.0000 and not 0 and $maxgrade now does not evaluate as false, need to use $maxgade!=0 which evaluates as before.
2008-10-21 09:32:24 +00:00
jamiesensei
67710da492
MDL-16951 "kurtosis and skewness equations were wrong" See changes to equations here : http://docs.moodle.org/en/index.php?title=Development%3AQuiz_item_analysis_calculations&diff=45585&oldid=39752
2008-10-21 09:25:02 +00:00
tjhunt
78268862d3
quiz reports: MDL-16948 SQL does not work in Oracle - you are not allowed to refer to output column names in GROUP BY. Fix thanks to Francois Marier.
2008-10-21 05:45:39 +00:00
jamiesensei
0e13019dc4
MDL-16870 "ID is incorrectly labelled"
2008-10-14 15:19:25 +00:00
jamiesensei
ef27e74273
MDL-16869 "Exporting leaves <p> </p> in essay responses" added method to flexible_table class format_text that takes the same parameters as format_text the function in weblib. If the table is not in download mode then this formats the text as html. If it is then it strips the tags or does the right thing depending on the download type. Added methods to download classes to tell flexible_table class what should be done with html.
2008-10-14 15:00:26 +00:00
jamiesensei
1f23bda7f9
MDL-16803 "Questions with score of 0 lead to division by zero warning"
2008-10-07 08:46:24 +00:00
dongsheng
a6344df49a
"MDL-14129, fixed hardcoded print_header in quiz module"
2008-09-25 08:21:59 +00:00
dongsheng
85c30b9c91
"MDL-14129, fix hardcoded print_error"
2008-09-25 01:55:39 +00:00
jamiesensei
8cc901371a
MDL-16612 "Response report : Long group names need shortening"
2008-09-24 10:55:55 +00:00
jamiesensei
04299b1f19
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
...
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 10:45:05 +00:00
jamiesensei
8968f51fab
MDL-16610 "Warnings when a question has a grade of 0" not seeing this issue in HEAD but committing some code to make code for generating html for response cell more robust.
2008-09-24 10:43:45 +00:00
jamiesensei
1c88737ffa
MDL-16653 "Adding colour highlighting of correct / incorrect / partially correct answers and tick / cross marks to overview report"
2008-09-24 10:22:57 +00:00
jamiesensei
bfcaf5e684
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
...
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 09:10:43 +00:00
jamiesensei
14133ad913
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form"
2008-09-23 10:39:12 +00:00
jamiesensei
e84cb61554
MDL-16532 "Can width of column for Essay questions be varied?" Concatenate the answers displayed in all responses in responses report for answers above a certain character count (now set to 150). Also added a link to all responses to display a review of the question response. Both the concatenation and links are only showed in the report on the Moodle site and effects are not exported.
2008-09-23 10:21:32 +00:00
jamiesensei
8b92c1e3f6
MDL-16529 "Only include closed attempts in manual grade counts"
2008-09-23 09:52:55 +00:00
tjhunt
739b07112e
MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
...
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
e1d2278b51
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" should not style response or add feedback image if the response is not yet graded.
2008-09-22 09:20:13 +00:00
jamiesensei
452351550b
MDL-16567 "Quiz statistics report does not work when the quiz contains descriptions" slightly more elegant and efficient solution to issue.
2008-09-19 10:12:54 +00:00
tjhunt
a1f6db1775
Nasty hack fix for MDL-16567 - I am hoping Jamie will come up with a proper fix soon, but I am about to demo this.
2008-09-18 12:47:12 +00:00
tjhunt
766df8f72b
MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
...
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
2008-09-18 07:39:10 +00:00
tjhunt
8033d8423f
Minor bug fixes.
2008-09-18 04:33:38 +00:00
jamiesensei
74b40fadd5
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" better not make styles dependent on question type. Just use overall styles.
2008-09-16 10:30:06 +00:00
jamiesensei
2ea2c1f57a
MDL-16528 "responses report : improve efficiency of sql" moved the querying for state data all into one big query rather than an individual query for each question in each attempt.
2008-09-16 09:50:24 +00:00
jamiesensei
199b946f04
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles"
2008-09-16 09:46:57 +00:00
jamiesensei
3d6de8770d
MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up.
2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476
MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0.
2008-09-15 13:38:31 +00:00
jamiesensei
3b51802063
MDL-16125 "Improvement to Detailled Responses Report : Format of csv export" Fixed missing format string problem when downloading.
2008-09-15 11:39:15 +00:00
jamiesensei
d3e99e85d4
MDL-16502 "highlight questions that appear not to be working very well according to statistics"
...
There is a function is_dubious_question on the statistics table passed all the stats for that question and other question data and that returns a bool.
2008-09-15 11:13:31 +00:00
jamiesensei
3db543284b
MDL-16501 "moving key to colours on graph to the bottom of the graph gives more horizontal screen space for the graph itself"
2008-09-15 09:16:57 +00:00
jamiesensei
9176976151
MDL-16463 "Long group names can make drop down box too wide" added an if condition to test the length of the group name. If it is more than 20 characters then we use the string 'this group' instead of the group name.
2008-09-12 08:33:40 +00:00
jamiesensei
c308138f89
MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." Removing Quiz Item Analysis report
2008-09-11 12:59:33 +00:00
jamiesensei
869309b8d8
MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." finished statistics report. This patch includes some changes to lib/tablelib.php so that it is possible to export the content of a table as part of a multi table export - with mutliple tables / multiple worksheets.
2008-09-11 12:48:08 +00:00
jamiesensei
ca2f6fc795
MDL-16110 "Improvement to Overview Report - Columns in csv file do not line up"
2008-09-01 08:30:14 +00:00
jamiesensei
02cd0be02e
MDL-16125 "Improvement to Detailed Responses Report - Format of csv export" removing commas from table content which throw the csv export.
2008-09-01 08:24:25 +00:00
tjhunt
337fa7a0ef
MDL-16263 - followup - fix notices.
2008-08-29 11:30:16 +00:00
jamiesensei
a3668b25c0
MDL-16121 "Manual Grading Doesn't Work" grades where not getting saved. Fixed that now.
2008-08-25 07:44:20 +00:00
skodak
775f811a66
MDL-16002 rewritten upgrade locking and better upgrade progress tracking; MDL-16070 Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes
2008-08-16 12:16:01 +00:00
tjhunt
f9a2cf86a9
MDL-7308 - Check all the DB columns used to store grades, and make sure they all use a consistent type.
2008-08-15 11:15:08 +00:00
