194 Commits

Author SHA1 Message Date
Rajesh Taneja
ae90dec5c2 MDL-44070 core_completion: Fixed behat 2014-04-09 14:24:55 +02:00
Dan Poltawski
5f3b4694b3 Merge branch 'wip-MDL-42870-master' of git://github.com/marinaglancy/moodle 2014-03-11 11:37:44 +08:00
David Monllao
759b323e0e MDL-43236 behat: Updating references to deprecated methods 2014-03-07 16:05:21 +08:00
Marina Glancy
30a32f147a MDL-42870 completion: performance and readability code refactoring 2014-03-07 10:21:49 +08:00
Dan Poltawski
3be87d897d Merge branch 'MDL-41248' of git://github.com/timhunt/moodle 2014-03-05 12:39:53 +08:00
Tim Hunt
8d3debf360 MDL-41248 completion: fix non-translatable text.
There were two hard-coded strings. Thanks to Guido Hornig for the suggested fix.
2014-02-28 08:10:54 +01:00
David Monllao
f083d6145e MDL-43738 behat: Updating features files
The following used steps were replaced by the ones
added in this issue:
- I fill the moodle form with
- I fill in with
- I select from
- I select radio button
- I check
- I uncheck
- the field should match

Also removing test for deprecated steps:
- the ASD checkbox should be checked
- the ASD checkbox should not be checked
2014-02-27 18:22:05 +08:00
David Monllao
8ef423433d MDL-43717 behat: Replacing 2050 for a date eariler than the max timestamp 32bit limit
All credit goes to Michael de Raadt.
2014-01-17 10:37:59 +08:00
David Monllao
d1e55a47be MDL-42625 behat: Step definitions + related changes in features
In general aiming for compatibility with multiple browsers,
firefox, chrome and phantomjs to be more specific.

* Removing hardcoded waits
* Adding @_alert, @_switch_window and @_switch_frame tags,
  to label actions that different drivers have problems with.
* Adding missing @_files_upload and @_only_local tags to features that
  uploads files.
* Fixing a few wait for page ready what specified miliseconds.
* New methods to ensure elements (usual selectors), sections and editors
  are ready to interact with
* Changing the select an option implementation to deal with the different
  drivers implementations when listening to JS events.
2013-12-06 13:10:24 +08:00
David Monllao
333db2e9b9 MDL-42625 behat: Editing .feature files 2013-12-06 12:13:39 +08:00
David Monllao
047a8800f4 MDL-40975 course: Adapt behat tests to the new course editing interface 2013-11-06 11:41:00 +08:00
Dan Poltawski
b0d92c0cec Merge branch 'wip-mdl-42282' of git://github.com/rajeshtaneja/moodle 2013-10-29 11:31:32 +08:00
Dan Poltawski
0e9b076973 Merge branch 'wip-mdl-42281' of git://github.com/rajeshtaneja/moodle 2013-10-29 11:08:45 +08:00
Rajesh Taneja
e21ae3ebdc MDL-42281 Behat: Automated test for MDLQA-510
MDLQA-510: A teacher can set grade conditions to restrict availability
of an activity
2013-10-28 16:48:19 +08:00
Rajesh Taneja
3f038d6d97 MDL-42283 Behat: Automated MDLQA-1777
MDLQA-1777: A teacher can set grade conditions to restrict availability of a section
2013-10-23 15:57:53 +08:00
Rajesh Taneja
932fa0157d MDL-42282 Behat: Automated test for MDLQA-509
MDLQA-509: A teacher can prevent students from accessing an activity
between specified dates
2013-10-21 14:12:31 +08:00
Rajesh Taneja
06f8ea7bf4 MDL-39955 completion: Added course_completed event 2013-08-13 09:43:38 +08:00
David Monllao
3897608152 MDL-39635 behat: XPath cleanups
- Escaping steps arguments redirected to other steps
- Adding normalized-space() in all contains() assertions
- General xpaths review
- Convering provided xpath text strings to xpath literals
  to avoid problems with arguments containing both single
  quotes and double quotes
2013-07-19 10:02:36 +02:00
David Monllao
dedb973878 MDL-39635 behat: Replacing hardcoded language strings
Using get_string() instead.
2013-07-19 10:02:10 +02:00
Eloy Lafuente (stronk7)
7942df199b Merge branch 'MDL-38559-completion-ui' of git://github.com/mudrd8mz/moodle 2013-05-10 02:37:54 +02:00
David Mudrák
870a4f8119 MDL-38559 Fix the ability to disable the grade condition in the course completion settings form 2013-05-09 23:24:49 +02:00
David Mudrák
6e5a473c47 MDL-38559 Reorganise course completion settings form
This is a result of a pretty intensive effort to make the form less
sucky, given the completion strings mess around. It partially solves
MDL-39419 too as it clarifies the course completion link in the course
administration block.

I must admit and record here that I'm pretty desperate by the current
state of the core_completion and how strings from it are inconsistently
used at various places with different meanings. For example the 'Completion
tracking' may mean the mode of how activities are tracked within the
course as well as the overall feature of course and activities tracking.
While a same phrase can be used in English for both this meanings, not
all languages have such luck and translating it is a pain in the ass.

Finally, let me give the credit for wording and UI design suggestions to
Helen Foster and all others who helped with this. This has been one of
the most ugliest forms in Moodle and we believe we made it better
(although we know it's far from perfect).
2013-05-09 23:14:57 +02:00
David Monllao
5d7b6307b1 MDL-39586 behat: Closed list of stackeholders 2013-05-09 18:38:13 +08:00
David Monllao
00ea74cb54 MDL-39348 behat: Chaining strings instead of splitting strings in lines 2013-05-03 10:16:44 +08:00
Dan Poltawski
142fa8c75d Merge branch 'MDL-39438_master' of git://github.com/dmonllao/moodle 2013-05-01 08:32:30 +01:00
David Monllao
5bc7cd922b MDL-39438 behat: Updating tests
According to MDL-38415 changes.
2013-05-01 13:39:06 +08:00
David Monllao
550d842e3c MDL-39232 behat Normalize feature tags according to component names 2013-04-30 11:54:47 +08:00
Dan Poltawski
3cdea44a87 Merge branch 'MDL-38011' of git://github.com/srynot4sale/moodle 2013-04-15 07:58:53 +01:00
Eloy Lafuente (stronk7)
b19e8a1fb9 Merge branch 'MDL-38744-master' of git://github.com/danpoltawski/moodle 2013-04-09 01:13:57 +02:00
Aaron Barnes
ece1f162c3 MDL-38011 completion: Use new localised role names 2013-04-07 00:00:05 +13:00
Dan Poltawski
ebe558acb3 MDL-38744 completion: add missing setType and properly allow float
Now can use correct decimal seperator
2013-04-05 14:13:46 +08:00
Damyon Wiese
b64a05b996 MDL-26644 Course - Remove completion tracking begins on enrolment setting from behat. 2013-04-03 15:30:49 +08:00
David Monllao
f076b0d43f MDL-38805 behat: Steps definitions to check students completed activities 2013-04-01 12:32:25 +08:00
David Monllao
abc38a9738 MDL-38805 behat: New test
According to MDLQA-511, a teacher can
enable students to manually mark an activity
as complete.
2013-04-01 12:32:25 +08:00
David Monllao
4569bc7ce8 MDL-38804 behat: New test
According to MDLQA-1780, a teacher can
set completion conditions to restrict
the availability of a section
2013-04-01 12:31:47 +08:00
Dan Poltawski
ae8530e854 MDL-35717|NOBUG - fix trailing whitespace problems 2012-11-26 15:01:31 +08:00
Dan Poltawski
926f51436b Revert "MDL-34332 completion: timeenrolled not always set correctly"
This reverts commit 154a72b0024761f8fe57ede5aa1b2255a1c2babd.
2012-11-01 12:02:49 +08:00
Dan Poltawski
639a2868c3 Merge branch 'MDL-34332c' of git://github.com/srynot4sale/moodle 2012-10-30 16:20:39 +08:00
Aaron Barnes
154a72b002 MDL-34332 completion: timeenrolled not always set correctly 2012-08-20 16:51:51 +12:00
Aaron Barnes
66b23db417 MDL-34795 completion: Add course_completed event 2012-08-10 16:06:11 +12:00
Ankit Agarwal
bf0f06b1be MDL-34471 libraries: Replace all uses of get_context_instance() with respective context_XXXX::instance() method 2012-08-02 15:37:38 +08:00
Sam Hemelryk
395b805f97 Merge branch 'MDL-34225' of git://github.com/nebgor/moodle 2012-07-23 14:04:09 +12:00
Aparup Banerjee
60829d8094 MDL-34225 course completion : moved criteria classes into criteria subdir 2012-07-12 12:04:36 +08:00
Aparup Banerjee
7534234322 MDL-34225 course completion : move /lib/completion/* up to /completion 2012-07-10 11:06:41 +08:00