David Mudrák
2615e429f4
MDL-68753 lang: Remove a redundant okay string and use "OK" everywhere
...
The "Ok" (with lower-case "k") string was added in MDL-68409 to keep
backwards compatibility with YUI alerts that had it hard-coded. But we
should not need to explain to translators why we have two OK strings
like this and why they use different wording.
Additionally, there would be inconsistency in Behat tests and everywhere
depending on which "OK" or "Ok" string is used for buttons.
So instead, this patch changes the hard-coded 'Ok' string in the YUI and
we should stick to "OK" from now on everywhere.
2020-05-27 09:59:44 +02:00
Shamim Rezaie
99cac46162
MDL-67970 output: use div for content wraping instead of span
...
span is not a valid content wrapper tag.
Moreover, according to W3C validation service report, it is not valid to
have div elements as children of a span element.
We can safely replace span with div here because the element's css class
is .action and display of .action is set to flex in both boost and
classic themes.
2020-03-17 18:16:25 +11:00
Alexander Bias
d6cea5ccd9
MDL-65056 completion: Hide checkboxes on course page for teachers
2019-04-19 11:40:00 +02:00
Dmitrii Metelkin
34945fa35f
MDL-64898 core_completion: no progress for untracked users
2019-03-15 14:32:50 +11:00
Jun Pataleta
c18f59e155
Merge branch 'MDL-64644_master' of git://github.com/markn86/moodle
2019-02-11 15:29:04 +08:00
Mark Nelson
ed6ac4634a
MDL-64644 completion: fixed assertions in privacy test
2019-01-23 17:12:04 +08:00
Mark Nelson
aaf7228fb4
MDL-64644 completion: ensure we return array for provider
2019-01-23 13:41:20 +08:00
Mark Johnson
7672471236
MDL-64123 webservices: Add valueused to completion data
2018-12-19 16:26:35 +00:00
Michael Hawkins
543c465579
MDL-63668 core_completion: Add get and delete by approved userlist.
...
This issue is a part of the MDL-62560 Epic.
2018-10-23 10:06:26 +08:00
Neill Magill
3f560e80ed
MDL-62944 completion: Test that completion dates add events to calendar
...
When a user does not have calendar capabilities completion dates should
still be created correctly.
2018-08-31 10:15:35 +01:00
Víctor Déniz Falcón
02fda279ed
MDL-57281 behat: deprecated step definition I navigate to node in
...
Definition step deprecated and affected tests modified.
2018-08-20 12:53:26 +01:00
Adrian Greeve
d8eec7ee38
MDL-62384 core_completion: Update to sql to improve performance.
2018-05-11 09:15:27 +08:00
Adrian Greeve
ebab932f71
MDL-62137 core_completion: Privacy files for core_completion.
2018-05-07 14:28:16 +08:00
Jake Dallimore
fdae6f77d6
MDL-61859 core_completion: fix unit tests expecting exceptions twice
...
We can't expectException twice in the same test, so split this out into
another test.
2018-04-06 17:30:31 +08:00
Juan Leyva
0e8b3d929d
MDL-61312 completion: Return completion for teachers via WS
...
core_completion_get_activities_completion_status was not returning
completion information for users with the teacher role only (when it
wasn’t a role allowed to track completion).
2018-01-30 12:19:52 +01:00
Pau Ferrer Ocaña
15ead7a176
MDL-60835 completion: Add overrideby field to completion status WS
2017-11-16 16:35:43 +01:00
Damyon Wiese
a66de3ca70
MDL-59909 calendar: Try hard not to fail the adhoc task.
...
Triggering a fatal error in an adhoc task is bad. It will be retried indefinitely.
Even though we are not sure how to get a module instance without a course module record,
it is possible and should not kill the Moodle site.
2017-10-25 15:42:14 +08:00
Jake Dallimore
b08337c35e
MDL-37361 completion: Consolidate icon logic and clarify web service
...
- Icon generation logic moved to the course renderer.
- Web service should return the completion info only, not HTML.
- JS modified to handle icon rendering in relevant cases.
2017-10-10 17:12:22 +08:00
Jake Dallimore
8fbc41d8d5
MDL-37361 completion: minor code fixes.
2017-10-10 17:12:09 +08:00
Jake Dallimore
86f359bf68
MDL-37361 completion: automatic completion disabled when overridden
...
Changes:
- Activities with auto completion and a completion status overridden to
COMPLETION_COMPLETE are no longer processed by normal completion
triggers.
- All activities can still be completed by students when their
completion status has been overridden to COMPLETION_INCOMPLETE, via
either auto or manual triggers.
- Completion unit tests updated
2017-10-10 17:10:49 +08:00
Eiz Eddin Al Katrib
60a6b36cd5
MDL-37361 completion: Modified and Added phpunit tests
2017-10-10 17:10:37 +08:00
Mark Nielsen
197e2bca5b
MDL-59602 behat: make use of new course nav steps
2017-07-21 13:50:47 -07:00
Adrian Greeve
190646bd75
MDL-59287 core_completion: Update to unit tests.
2017-07-10 09:40:02 +08:00
Eloy Lafuente (stronk7)
2df7f223b8
MDL-58749 lang: fix couple of scenarios to use new lang string
2017-05-04 23:46:46 +02:00
Marina Glancy
6c48135896
MDL-58138 completion: mform wants 0-based indexes for arrays
2017-04-20 13:49:56 +08:00
Jake Dallimore
273d310601
MDL-58138 completion: Fixes for a number of small issues.
2017-04-19 11:41:57 +08:00
Marina Glancy
32b93ea7f8
MDL-58138 completion: changes after rebasing
...
The defaults for the completion have been changed in MDL-55611
2017-04-19 08:56:11 +08:00
Marina Glancy
61167c16d0
MDL-58460 mod_data: work with bulk completion API
...
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
22002ed74b
MDL-58138 completion: consolidate bulk edit notifications to single call
...
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
b17ee68202
MDL-58138 completion: Assorted linting fixes.
...
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
8db355c58f
MDL-58138 tests: unit and behat tests covering bulk and default tabs
...
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy
7f53e8aa22
MDL-58267 completion: allow to set default activity completion
...
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy
06cdda468a
MDL-58139 completion: bulk update completion
...
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Mark Nelson
7925aab94f
MDL-57878 core_completion: added unit tests for new API
...
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Jun Pataleta
2c1a1b15b1
MDL-58102 completion: Behat fix
...
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze
fdeeaff954
MDL-58265 core_test: replace I turn editing on steps
...
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
c987d1b2ef
MDL-58265 core_test: replace all uses of I follow course steps
...
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Mark Nelson
5b3c691fd5
MDL-57443 core_completion: added API to retrieve completion progress
...
Part of MDL-55611 epic.
2017-04-03 11:36:07 +08:00
Damyon Wiese
8857c715d1
MDL-40759 icons: Behat fixes for font-awesome
2017-03-17 15:52:18 +08:00
Marina Glancy
3f9503468f
MDL-4782 course: Behat tests for stealth mode support
2017-02-14 16:38:08 +08:00
gthomas2
3982685a3c
MDL-57452 behat: Make completion check work with manual completion input
2017-01-12 11:45:21 +00:00
Marina Glancy
e5287f9b3b
MDL-56614 behat: navigate without navigation and admin blocks
2016-12-06 11:49:14 +08:00
Rajesh Taneja
f4565e7147
MDL-56994 behat: Fixed activity selector to find proper li
...
Previous to this patch, only 1 activity was
expected and if there are more than 1 activities
then it will fail. Improved step to find the
correct activity node by name
2016-11-22 11:02:52 +08:00
Rajesh Taneja
dc90838aaa
MDL-56630 behat: Click on link in specificed block/region
2016-11-08 14:45:43 +08:00
Andrew Nicols
4ceed4dfa6
MDL-55981 core: Remove site:accessallgroups from teacher
2016-10-21 08:55:58 +08:00
Mark Nielsen
2b509dbc01
MDL-55316 core_completion: Expand fields for Behat
...
This only happens if you create the course with
one user and then try to enable completion
with another user.
2016-07-22 11:29:27 -07:00
Rajesh Taneja
442a3651ec
MDL-54640 behat: add 1 sec delay before running tasks
...
Also just execute task, as running whole cron is not
required
2016-05-20 09:02:11 +08:00
Damyon Wiese
821ab1bf9b
MDL-52954 assign: Behat fixes because the assign grading ui has changed
2016-04-15 15:57:56 +08:00
Rajesh Taneja
921faad9ad
MDL-53571 behat: Use Escaper for escaping
...
xpathLiteral has been depreacted, use Escaper instead
2016-04-06 15:38:31 +08:00
Rajesh Taneja
eb9ca848fa
MDL-53381 behat: Replaced chained steps with api.
...
Behat 3.x doesn't support chained steps and hence
this is first step to get rid of chained steps in core.
2016-04-06 11:32:49 +08:00