32668 Commits

Author SHA1 Message Date
Shamim Rezaie
60aa3614f4 MDL-78885 comboboxsearch: Remove the redundant rtl context variable 2024-03-22 04:24:23 +11:00
Shamim Rezaie
a320dff736 MDL-78885 aria: Add support for data-short-text 2024-03-22 04:24:23 +11:00
Shamim Rezaie
50eeafeb7d MDL-78885 comboboxsearch: Improve user search and keyboard handling
- Prevent rerendering of the menu when it's already open to preserve the
  selected/highlighted option.
- Allow ArrowUp and ArrowDown to trigger the user search dropdown for
  improved keyboard navigation.

This commit ensures that the menu is not re-rendered when it's already
open, preserving the selected option to enhance the user experience.
Additionally, ArrowUp and ArrowDown keys now trigger the dropdown,
improving keyboard navigation and user interactions.
2024-03-22 04:24:20 +11:00
Shamim Rezaie
8e2555dc48 MDL-78885 comboboxsearch: Switch event listener from 'click' to 'change'
Move from listening to 'click' to listening to 'change'
2024-03-22 04:23:55 +11:00
Shamim Rezaie
bff7c88878 MDL-78885 comboboxsearch: .dropdown() calls should be on toggle element
Introduced the toggle property.
2024-03-22 04:23:26 +11:00
Shamim Rezaie
b4bb1cde97 MDL-78885 comboboxesearch: Comboboxes should have a name and value
- core_grades_renderer::group_selector() was changed previously, but it
  was providing redundant context data to
core_group/comboboxsearch/group_selector and on the other hand, it was
not providing 'name' and 'value' for core/comboboxsearch
- The $groupactionbaseurl parameter of
  core_grades_renderer::group_selector() is now deprecated as it was not
used.
- a bug is fixed: if only a lastname initial was set, the clear search
  button was not being displayed.
2024-03-22 04:23:25 +11:00
Shamim Rezaie
d886cba9d3 MDL-78885 comboboxsearch: Enable aria.js for auto handling
- Added the `dropdown` class to ensure toggle element focus when the
  dropdown is closed.
- Improved keyboard handling by adding the `dropdown` class.
  aria.js will automatically handle keyboard interactions.
- Removed redundant keyboard handling.
- The "view all results" option is just a normal option in a combobox.
  It should not be treated as the default action for a combobox.
- Ensured correct markup for 'Esc' key handling. aria.js automatically
  focuses on the toggle element if the dropdown's toggle and the
  dropdown menu are wrapped within a .dropdown element.
- Implemented menu closure for outside clicks and when leaving the edit
  box.
- Manually focused on the user search element when opening the search
 dropdown due to a focusLock issue.
- Fix the issue of another dropdown staying open
- Clicking on the clearSearchButton should not close the dropdown
2024-03-22 04:22:24 +11:00
Shamim Rezaie
e0d2a3924e MDL-78885 aria: Automatically trap focus inside dialog dropdowns
- there is no need to set the focus after a dropdown is opened. It is
automatically set as the result of trapping focus.
2024-03-22 04:00:18 +11:00
Shamim Rezaie
d18f7bf5cd MDL-78885 core: combobox should have a valid aria-controls
- The aria-controls attribute cannot refer to an element that doesn't
  exist
- Also update filterDataset so it returns [] when searchTerm is empty
2024-03-22 04:00:15 +11:00
Mathew May
e4083441ec MDL-78885 core_user: A11y fixes for user combobox search
Co-authored-by: Shamim Rezaie <shamim@moodle.com>
2024-03-22 03:26:19 +11:00
Sara Arjona
1e1d6d8be8
Merge branch 'MDL-71734' of https://github.com/paulholden/moodle 2024-03-21 16:11:40 +01:00
Sara Arjona
3e2b8eed3c
Merge branch 'MDL-80636-main' of https://github.com/laurentdavid/moodle 2024-03-21 15:40:24 +01:00
Sara Arjona
f54c1b9293
Merge branch 'MDL-69688' of https://github.com/stronk7/moodle 2024-03-21 15:29:47 +01:00
Sara Arjona
484e52f6ae
Merge branch 'MDL-80245' of https://github.com/paulholden/moodle 2024-03-21 15:01:18 +01:00
Amaia Anabitarte
e0a482e3b3 MDL-81023 core_course: Move deprecated behat steps to course directory 2024-03-21 12:47:58 +01:00
Eloy Lafuente (stronk7)
7013339ce4
MDL-81319 install: update the list of stale files for 4.4 2024-03-21 10:46:01 +01:00
Paul Holden
011619dbd3
MDL-71734 lang: final removal of deprecated 400 strings. 2024-03-21 09:44:15 +00:00
Eloy Lafuente (stronk7)
0f3775088f
MDL-69688 phpunit: Improve test_context_not_used
This adds a few changes to the old test_context_not_used test:

- Move it to become an advanced_test, because its mission
  is to verify that the assertEventContextNotUsed() assertion
  works as expected.
- For consistency, also move the fixtures to own phpunit fixtures.
- Add proper coverage tags, to verify that the assertion is being
  covered.
- Add a data provider to provide all the current cases and ease
  any future case that may be needed in the future. One by one
  because previously there was code never executed with the
  warning expectation causing the test to stop.
- Run them in isolation, while this is not strictly required, it's
  including external fixtures and, we'll need that isolation soon
  (for changes coming when moving the test to PHPUnit 9.6 in MDL-81266).
2024-03-21 08:31:08 +01:00
Ilya Tregubov
1e13aa23b6 Merge branch 'MDL-80850-main' of https://github.com/HuongNV13/moodle 2024-03-21 14:24:42 +08:00
Huong Nguyen
b0220f27cb MDL-80850 Javascript: Add new core/dropzone module 2024-03-21 12:45:55 +07:00
Ilya Tregubov
cd2fb2fe78 Merge branch 'MDL-79668-main' of https://github.com/kevpercy/moodle 2024-03-21 12:22:58 +08:00
Jake Dallimore
0255500247
MDL-81313 core: Revert "Merge branch 'MDL-80338'
This reverts commit 40f501fb4e8ccad7eaacde873bf8fa809df192c5, reversing
changes made to 3061024726abdd5581d90e3a589c38b01eb533a2.
2024-03-21 11:03:25 +08:00
Ilya Tregubov
45750b413e Merge branch 'MDL-81050-main' of https://github.com/roland04/moodle 2024-03-21 10:52:39 +08:00
Ferran Recio
fbbb86a2a6 MDL-80715 core_courseformat: delegate section and cm rename 2024-03-20 16:51:12 +01:00
Mark Johnson
788556f652
MDL-80099 hooks: Add mechanism to deprecate class callbacks 2024-03-20 14:58:16 +00:00
Mikel Martín
dba1efa28e MDL-81050 navigation: Add data attributes to sections in breadcrumbs
- Add a new method 'add_attribute' to navigation nodes to add HTML attributes to nodes.
- Add data-attribute to section nodes and include them in breadcrumb mustache to automatically update section titles
 when sections are renamed.
2024-03-19 08:53:49 +01:00
Mikel Martín
b73a685ef7 MDL-81050 output: Add new 'attributes' parameter to container 2024-03-19 08:53:49 +01:00
Ilya Tregubov
ef34a20e06 Merge branch 'MDL-79669' of https://github.com/Chocolate-lightning/moodle 2024-03-19 11:09:38 +08:00
Ilya Tregubov
a4099ff9e3 Merge branch 'MDL-81188-main' of https://github.com/roland04/moodle 2024-03-19 09:22:10 +08:00
Jun Pataleta
4c802f72c3
Merge branch 'MDL-81066-main' of https://github.com/sammarshallou/moodle 2024-03-19 07:23:32 +08:00
Laurent David
2292a50356 MDL-80636 lib: Upgrade HTML purifier moodle files
* Update thirdpartylibs.xml and readme_moodle.txt documentation
2024-03-18 19:35:55 +01:00
Laurent David
0079ba38f2 MDL-80636 lib: Upgrade HTML purifier to 4.17.0 2024-03-18 19:34:36 +01:00
Sara Arjona
5879fa62d6
Merge branch 'MDL-81259' of https://github.com/paulholden/moodle 2024-03-18 16:19:01 +01:00
sam marshall
79038ab3a3 MDL-81066 core_form: Validate form fields on submit only 2024-03-18 13:25:39 +00:00
Mikel Martín
9733ccc381 MDL-81188 form: Fix password element layout
MDL-75670 generated a regression in forms password element layout that was not
being displayed in a single line as before.

- Modify the password element template to display the input and the password
unmask icon in a single line.
- Change the password unmask button styles to be consistent with other
focus states.
- Modify passwordunmask behat form field to work with the new password element
layout changes.
2024-03-18 09:19:35 +01:00
Huong Nguyen
b82dbf002a Merge branch 'MDL-80566' of https://github.com/marinaglancy/moodle 2024-03-18 10:54:36 +07:00
Jun Pataleta
b7cf80a244
Merge branch 'MDL-80279' of https://github.com/pedrojordao/moodle 2024-03-18 11:22:57 +08:00
Huong Nguyen
d3e4821bc7 Merge branch 'MDL-80206-main' of https://github.com/andrewnicols/moodle 2024-03-18 09:42:06 +07:00
Matt Porritt
66349bad3a MDL-81172 Administration: Add recommended custom check
Add support for custom environment checks to have a recommended
option in addition to required an optional.
2024-03-18 12:02:54 +11:00
Matt Porritt
5d74f366a0 MDL-81172 Backup: Async Backup on by default from install
Enable asynchronous backup and restore on new site install.
Existing behaviour is not changed for sites being upgraded.
Behat tests have been set to use synchronous mode.
2024-03-18 12:01:50 +11:00
Paul Holden
ac4487efd2
MDL-81259 auth: always load password toggle module when required. 2024-03-17 20:35:36 +00:00
Marina Glancy
6fdeabd5b5 MDL-80566 user: convert callback 'bulk_user_actions' to hook 2024-03-15 17:00:00 +00:00
Pedro Jordao
da16de2496 MDL-80279 core: Set new attributes for user profile initials
When the user does not have a profile photo and initials are displayed,
there is no alt text for the initials which causes accessibility
issues, so with this change I added the user's full name to the title
and aria-label attributes and I set a role='img' when the element span
is rendered.
2024-03-15 07:31:56 -03:00
Jake Dallimore
e97ce38e18
Merge branch 'MDL-80167-main-int' of https://github.com/HuongNV13/moodle 2024-03-15 12:54:24 +08:00
Huong Nguyen
388cc303f9 MDL-81246 dml: Check the statement resource before freeing it 2024-03-15 11:07:51 +07:00
Jake Dallimore
93aa177f11
Merge branch 'MDL-81180-main' of https://github.com/andrewnicols/moodle 2024-03-15 10:27:51 +08:00
Huong Nguyen
699a0e9328 MDL-80167 core: Skip Oracle for Oracle environment in unit tests 2024-03-15 08:45:42 +07:00
Huong Nguyen
6a19d3289b MDL-80167 admin: Add environment check for Oracle database 2024-03-14 17:41:56 +07:00
Andrew Nicols
e3ea78e043
MDL-81222 core: Show all tags for a hook in summary page 2024-03-13 22:05:46 +08:00
Jun Pataleta
a0e333fb7c
Merge branch 'MDL-80896-main' of https://github.com/andrewnicols/moodle 2024-03-12 11:38:26 +08:00