78 Commits

Author SHA1 Message Date
Dan Poltawski
5c46aee8fd Revert "MDL-32379: Fix memory leak in session_set_user"
This reverts commit 22dc32042a92f1ed521afaf4352cd931c20b11ea.

This integrator didn't properly read the diff, sorry.
2012-05-07 14:39:43 +08:00
Tony Levi
22dc32042a MDL-32379: Fix memory leak in session_set_user
session_set_user mistakingly sets the session user to be a reference to the passed object.

This is a problem when alot of data is attached to the session user object,
as any process holding a list of these users will use more memory each time it changes user.
2012-04-10 14:07:59 +09:30
Petr Skoda
458b33866d MDL-32149 reset all globals in PHPUnit tests, fix setting of $USER 2012-04-03 22:30:54 +02:00
Adrian Greeve
40fe364713 MDL-31248 - lib - Retaining the old password key and creating a new cookie prefix. 2012-03-09 13:38:51 +08:00
Eloy Lafuente (stronk7)
12dfd6df01 MDL-30026 improve session lock - unit tests & minor comment fixup 2011-11-13 19:05:57 +01:00
Petr Skoda
2b0e3941e9 MDL-30026 improve session lock acquire timeouts and other minor cleanup
This is partially based on original patch by Tony Levi.
2011-11-06 17:52:15 +01:00
Petr Skoda
e922fe23b6 MDL-29602 accesslib improvements
Refactoring and improvements of the accesslib.php library including prevention of access for not-logged-in users when forcelogin enabled, improved context caching, OOP refactoring of contexts, fixed context loading, deduplication of role definitions in user sessions, installation improvements, decoupling of enrolment checking from capability loading, added detection of deleted and non-existent users in has_capability(), new function accesslib test, auth and enrol upgrade notes.

More details are available in tracker subtasks.
2011-10-16 14:05:18 +02:00
Petr Skoda
988fc20eef MDL-28630 prevent session breakage caused by incorrect cookie settings 2011-08-06 22:22:52 +02:00
Eloy Lafuente (stronk7)
21ba26e814 Merge branch 'w27_MDL-28158_m22_cookies' of git://github.com/skodak/moodle 2011-07-11 15:33:03 +02:00
Petr Skoda
98eaf27e3c MDL-28280 remove obsolete unmaintained $CFG->usesid 2011-07-10 13:44:41 +02:00
Petr Skoda
0342fc3609 MDL-28158 add optional "Remember username" checkbox in login forms 2011-07-10 13:22:55 +02:00
Petr Skoda
81b58cc227 MDL-26389 improve profile and search engine privacy 2011-02-14 15:42:26 +01:00
Petr Skoda
673a8f7781 MDL-26031 purge timed-out sessions of guest user 2011-01-17 18:25:00 +01:00
Sam Hemelryk
3b15d04013 sessions MDL-25907 Fixed typo prior to integration 2011-01-17 10:48:00 +08:00
Ashley Holman
d0c3f54770 MDL-25907 purge sessions of not-logged-in users 2011-01-12 20:14:00 +01:00
Petr Skoda
8a8f1c7cd6 MDL-10137 rewritten cookie test on login page, username cookie is not required any more - hopefully this will be more reliable test 2010-10-10 17:30:28 +00:00
Petr Skoda
927b2e7bc7 MDL-24313 standardising general object instantiation to use sdtClass instead our object 2010-09-21 06:59:09 +00:00
Petr Skoda
7c25ee0f73 fixed multiple missing globals causing regressions especially for opentogoogle access 2010-09-17 08:11:47 +00:00
Petr Skoda
f0d531ad4c standardized PHPDocs package info + fixed copyrights to reflect real author of classes (if anybody wants to change anything I would like to be contacted) 2010-09-06 11:49:46 +00:00
Petr Skoda
4031f6a27c MDL-23984 improved check_dir_exists() and make_upload_directory() incorrect permissions throw fatal exceptions by default; it is possible to create dirs outside of dataroot (necessary for custom dir locations); fixed Win32 compatibility in session_exists method 2010-08-29 14:33:39 +00:00
Petr Skoda
492a55e7f2 MDL-23949 fixed use of invalid $USER before linked to session 2010-08-26 17:19:09 +00:00
Petr Skoda
b3df176457 MDL-23927 do not use = 'guest' because we have CFG->siteguest AND it matches any other username with accents and different case in MySQL 2010-08-25 08:56:07 +00:00
Petr Skoda
e884f63a0c MDL-23911 login as session can be only terminated by logout, this should improve security on pages where user may enter JS that only he/she can see - such as the /my/index.php 2010-08-24 08:50:53 +00:00
Petr Skoda
df92ba9a43 MDL-23797 minor session refactoring necessary for setting of default context on pages that do not use cookies 2010-08-16 17:47:36 +00:00
Petr Skoda
428540d174 MDL-19774 fixed incorrect session init in cron - credit goes to Jay Knight 2010-08-09 07:40:26 +00:00
Petr Skoda
78bfb562a0 MDL-21249 improved php docs and adding direct access prevention in core libs 2010-07-25 13:35:05 +00:00
Petr Skoda
df997f841f MDL-21782 reworked enrolment framework, the core infrastructure is in place, the basic plugins are all implemented; see the tracker issue for list of unfinished bits, expect more changes and improvements during the next week
AMOS START
    MOV [sendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage,enrol_self]
    MOV [configsendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage_desc,enrol_self]
    MOV [enrolstartdate,core],[enrolstartdate,enrol_self]
    MOV [enrolenddate,core],[enrolenddate,enrol_self]
    CPY [welcometocourse,core],[welcometocourse,enrol_self]
    CPY [welcometocoursetext,core],[welcometocoursetext,enrol_self]
    MOV [notenrollable,core],[notenrollable,core_enrol]
    MOV [enrolenddaterror,core],[enrolenddaterror,enrol_self]
    MOV [enrolmentkeyhint,core],[passwordinvalidhint,enrol_self]
    MOV [coursemanager,core_admin],[coursecontact,core_admin]
    MOV [configcoursemanager,core_admin],[coursecontact_desc,core_admin]
    MOV [enrolledincourserole,core],[enrolledincourserole,enrol_manual]
    MOV [enrolme,core],[enrolme,core_enrol]
    MOV [unenrol,core],[unenrol,core_enrol]
    MOV [unenrolme,core],[unenrolme,core_enrol]
    MOV [enrolmentnew,core],[enrolmentnew,core_enrol]
    MOV [enrolmentnewuser,core],[enrolmentnewuser,core_enrol]
    MOV [enrolments,core],[enrolments,core_enrol]
    MOV [enrolperiod,core],[enrolperiod,core_enrol]
    MOV [unenrolroleusers,core],[unenrolroleusers,core_enrol]
AMOS END
2010-06-21 15:30:49 +00:00
Petr Skoda
ed149942a6 fixed more silly typos in comments 2010-05-21 19:31:17 +00:00
Petr Skoda
38549d6396 MDL-21579 using simple exception handling instead of table_exists - we do this in several other places already 2010-04-30 15:38:58 +00:00
Martin Dougiamas
0bedd3c797 MDL-21579 Improved table checking using the shorthand method 2010-04-29 09:51:35 +00:00
Martin Dougiamas
9c764f9f34 MDL-21579 Adding some table checking to avoid errors on database reinstall 2010-04-29 07:10:00 +00:00
Jamie Pratt
2d0acbd5f9 MDL-21579 "Implement session token for embedded application" implemented a second type of session token linked to a session for use in applications embedded in web pages. 2010-04-28 13:16:58 +00:00
Petr Skoda
59e0ce0ac5 MDL-20625 adding TODO for combination of session and tansactiosn, discussing best solution with Eloy 2009-11-10 14:28:40 +00:00
Tim Hunt
a79ef03fe9 moodlelib: MDL-20702 New require_sesskey function.
Also improve PHPdoc comments to fix my misconceptions.
2009-11-02 16:41:00 +00:00
skodak
3a465d1dc9 MDL-20462 reminder to minimise timemodified indexed column changes 2009-10-06 19:34:40 +00:00
stronk7
1c13ff2330 NOBUG: Just adding some "database" words here and there to help a bit when debugging problems. 2009-10-01 15:02:00 +00:00
tjhunt
43b152f69a cron: MDL-19774 temporary hack so cron does not crash. 2009-07-13 06:08:48 +00:00
samhemelryk
b37eac91cc lib MDL-19236 Added boilerplates and copyrights 2009-05-26 03:57:03 +00:00
fmarier
2d80192857 MDL-19222 lib/setup: work-around the disk_free_space call failing on very large partitions 2009-05-22 03:19:16 +00:00
fmarier
5505925383 MDL-19222 sessionlib: add a check and error message when initialising file sessions in case there is no free space on the partition 2009-05-18 04:47:58 +00:00
tjhunt
c13a5e71cc moodle_page: MDL-12212 start of new moodle_page class
* has course and status fields
* $PAGE->status updated by print_header and footer
* $PAGE->set_course now replace course_setup function
* global $PAGE created in setup.php
* unit tests for functionality so far
* Moodle still seems to work after this commit!
2009-05-06 08:29:22 +00:00
skodak
a91557ae6f MDL-18137 all cookies now secure if configured to be 2009-02-07 22:41:59 +00:00
skodak
34e9457e30 MDL-17942 fixed incorrect mysql setting name 2009-01-19 08:13:56 +00:00
skodak
b9fb71030f MDL-17942 reimplemented detection of mysql max_packet_size problems 2009-01-19 08:03:55 +00:00
skodak
3b50631d7f MDL-17942 fixed session regeneration 2009-01-19 07:25:12 +00:00
skodak
200f26cf18 MDL-17942 improved mysql truncation prevention 2009-01-18 23:12:14 +00:00
skodak
64d69e966c MDL-17942 lot more session refactoring 2009-01-18 23:06:52 +00:00
skodak
ad76d18475 MDL-17942 yet more session refactoring 2009-01-18 20:30:54 +00:00
skodak
e8656befac MDL-17942 more session refactoring 2009-01-18 18:00:44 +00:00
skodak
88fdd846f6 MDL-17942 fixed gc regressions, added gc after deleting users and similar cases 2009-01-18 12:20:55 +00:00