969 Commits

Author SHA1 Message Date
Frederic Massart
62e11d37c2 MDL-46950 gradereport_grader: Prettier styling for base and clean
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:04 +08:00
Frederic Massart
31819e8961 MDL-46950 gradereport_grader: Consolidate styling of the elements
The grader table has been made entirely standalone from core or
theme styling. The floating divs have to share the exact same
rules, and so it was a lot easier and more maintainable to just
style them both using the same selectors, entirely ignoring the
table default styles.

And because the selectors are unique for both the floating elements
and the table cells, a themer can easily re-use them to style both,
without having to dig around to find all the selectors to overwrite.

Working on this highlighted some issues with the positioning. Those
have been fixed within the same patch. And even though it is still
not 100% correct on IE, the result is pretty decent.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:01 +08:00
Frederic Massart
7dc48b4629 MDL-46962 gradereport_grader: Correct positioning when using RTL languages
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:49 +08:00
Frederic Massart
10ce95aae3 MDL-46951 gradereport_grader: Giving some love to IE
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:46 +08:00
Frederic Massart
1da29869aa MDL-46951 gradereport_grader: Handling of user cells when resizing
For some reason, the max-width/min-width/width of the table cell containing
the name of the users did not work, leading to very large columns but a very
narrow floating one. Handling the size of those columsn upon resize was
also necessary after with this fix.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:42 +08:00
Frederic Massart
b6ad809581 MDL-46951 gradereport_grader: Disable floating behaviour when table is empty
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:37 +08:00
Frederic Massart
f79776cb7f MDL-46951 gradereport_grader: Compatibility with base themes
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:32 +08:00
Frederic Massart
569c77e623 MDL-46951 gradereport_grader: Removing broken spinner logic
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:28 +08:00
Andrew Nicols
8c037a917b MDL-46663 gradereport_grader: Remove fixed column support
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:19 +08:00
Andrew Nicols
99b119c166 MDL-46663 gradereport_grader: Remove old scrollview code
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:18 +08:00
Andrew Nicols
feb0014b84 MDL-46731 gradereport_grader: Move tooltips to YUI module
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:16 +08:00
Andrew Nicols
d3eec1584a MDL-46774 gradereport_grader: Move row/column highlight code to YUI module
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:05 +08:00
Andrew Nicols
6ad1af094e MDL-47046 gradereport_grader: Update JS to meet coding style guidelines
This also moves the code into a set of separate files to allow for
additional components of the report to be migrated to the same YUI module,
adjusts some UI components, improves JS performance, and adds appropriate
documentation.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:42:03 +08:00
Alfonso Roman
2c4a3f7525 MDL-47045 gradereport_grader: Improve Grader report user interface
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:12:36 +08:00
Marina Glancy
165cdabacb MDL-47146 core_grades: fix class names (contd)
Part of: MDL-46576
2014-10-03 13:55:25 +08:00
Frederic Massart
0b2e8ae07b MDL-47430 core_grades: Handle negative grademin with natural weighting
Part of: MDL-46576
2014-10-03 13:55:24 +08:00
Damyon Wiese
c529f4b30f MDL-47420 Grades: Get unit tests passing on natural grading branch
Part of: MDL-46576
2014-10-03 13:55:24 +08:00
Damyon Wiese
6077a4d43b MDL-47064 Grades: Final fix - set the grademax from the item, not the cat
Part of: MDL-46576
2014-10-03 13:55:23 +08:00
Damyon Wiese
ee07a54be0 MDL-47064 Grades: Peer review cleanups
Changes include:
 * Search for existing items to reduce DB queries in grade_category::aggregate_grades
 * Comments improvements
 * Move brackets to be part of lang string
 * Convert aggregationhints to be a class variable instead of passing it around

Part of: MDL-46576
2014-10-03 13:55:23 +08:00
Damyon Wiese
6070e53313 MDL-47064 Grades: Add comments to explain this tricky code.
Part of: MDL-46576
2014-10-03 13:55:23 +08:00
Damyon Wiese
446467f0d3 MDL-47064 Grades: Make the contribution to total column work
Part of: MDL-46576
2014-10-03 13:55:23 +08:00
Damyon Wiese
53771c404f MDL-47064 Grades: Fix the contributed weights column for students and teachers.
Part of: MDL-46576
2014-10-03 13:55:23 +08:00
Simey Lameze
3c46f7e1b9 MDL-47064 core_grades: fix the calculation of contribution towards total
Part of: MDL-46576
2014-10-03 13:54:39 +08:00
Damyon Wiese
5a59aeb14e MDL-47078 Grades: Allow users to have different max grades due to exclusions etc.
This is about making this work with natural weightings.

Part of: MDL-46576
2014-10-03 13:53:01 +08:00
Damyon Wiese
a1740d7b48 MDL-46139 Grades: Change usedinaggregation column to 2 columns for status and weight. 2014-10-03 13:48:55 +08:00
Damyon Wiese
dadc9d991d MDL-46139 Grades: Add contibution to course total column to user report 2014-10-03 13:47:42 +08:00
Damyon Wiese
65c2ac9334 MDL-46139 Grades: Show the aggregation details in the user report. 2014-10-03 13:47:42 +08:00
Damyon Wiese
bfe969e8b3 MDL-46139 Grades: Add a column to grade_grades to record how a grade is aggregated 2014-10-03 13:47:42 +08:00
Dan Poltawski
c7ed7235c7 Merge branch 'MDL-47358-master' of git://github.com/FMCorz/moodle 2014-09-29 11:58:14 +01:00
Andrew Davis
0e99979638 MDL-20250 core_grade: added some settings to disable or hide gradebook functionality 2014-09-26 10:19:00 +08:00
Frederic Massart
a5e706e8fe MDL-47358 gradereport_history: Improved default natural sorting by time 2014-09-24 15:41:30 +08:00
Frederic Massart
655e377c45 MDL-47358 gradereport_history: Display history even when there is no grader recorded 2014-09-22 16:28:35 +08:00
Damyon Wiese
5fe74c1bcf Merge branch 'MDL-47127-master' of git://github.com/ankitagarwal/moodle 2014-09-15 16:41:28 +08:00
Rajesh Taneja
54e6e19a47 MDL-46572 behat: Select user dialogue is not visible in phantomjs 2014-09-10 09:14:20 +01:00
Damyon Wiese
0db54b5ba2 MDL-46997 Grades: Fix aggregation when hiding is excluded and items have nested dependencies
Includes a unit test for the dependency flattening function.
2014-09-09 17:11:59 +08:00
Dan Poltawski
fb385cb7af Merge branch 'MDL-46572_master' of https://github.com/markn86/moodle 2014-09-09 09:18:00 +01:00
Ankit Agarwal
d3cd2a5043 MDL-47127 gradereport_user: Update 'datetill' string to make it more clear 2014-09-08 06:56:09 +05:30
Ankit Agarwal
201a8d41b2 MDL-46821 gradereport_user: Fix background color of user report 2014-09-03 12:09:55 +05:30
Mark Nelson
51e0392038 MDL-46572 gradereport_history: added basic functionality behat test
Part of MDL-46191
2014-08-28 13:06:45 -07:00
Frederic Massart
a2bf889706 MDL-46191 gradereport_history: Missing filename when downloading data 2014-08-28 11:21:40 +08:00
Frederic Massart
981c2ee51c MDL-46812 gradereport_grader: Hide vertical scrollbar of scroller 2014-08-27 10:40:56 +08:00
Eloy Lafuente (stronk7)
f438b03fdc Merge branch 'wip-MDL-46874-master' of git://github.com/marinaglancy/moodle 2014-08-25 22:10:09 +02:00
Marina Glancy
cf2d4159b7 Merge branch 'MDL-46191-master' of git://github.com/FMCorz/moodle 2014-08-25 15:43:29 +08:00
Frederic Massart
07f827acd4 MDL-46191 gradereport_history: Final clean up for integration 2014-08-25 14:53:28 +08:00
Ankit Agarwal
5bd36407af MDL-46907 gradereport_history: Refactor user_button class to remove js methods
Part of MDL-46191
2014-08-22 10:52:27 +08:00
Ankit Agarwal
9e7a84e5b2 MDL-46191 gradereport_history: Fix minor issues after the review
Part of MDL-46191
2014-08-22 10:38:27 +08:00
Frederic Massart
4870363dd2 MDL-46573 gradereport_history: Cross DB query relying on timemodified
Part of MDL-46191
2014-08-22 10:38:24 +08:00
Ankit Agarwal
950ac46e2a MDL-46678 gradereport_history: Write unit tests for get_graders api
Part of MDL-46191
2014-08-22 10:38:20 +08:00
Ankit Agarwal
9f3523767e MDL-46678 gradereport_history: Move hardcoded sql from index.php to an api
Part of MDL-46191
2014-08-22 10:38:17 +08:00
Frederic Massart
1f2ebf779f MDL-46571 gradereport_history: Unit tests for helper user methods
Part of MDL-46191
2014-08-22 10:35:31 +08:00