Commit Graph

114 Commits

Author SHA1 Message Date
mark-nielsen
b3b4bc44ce BugFix for MDL-6730: now blank lessons redirect to edit.php where the user is prompted by a menu of options. 2006-09-30 19:00:07 +00:00
mark-nielsen
6707a280a9 Moved endofbranch redirect up to avoid double printing of messages. 2006-09-23 19:32:25 +00:00
mark-nielsen
563106f0a8 Fixed branch table buttons to work with JavaScript turned off. This fix lead to some minor changes to the button output, but hopefully simplified things.
Also, removed .hidden-label class because it was no longer in use due to label fixes earlier.
2006-09-23 18:45:59 +00:00
vyshane
94bcea7983 Removed mod/lesson:view 2006-09-22 02:58:39 +00:00
mark-nielsen
7adb975062 removed some unecessary comments 2006-09-19 02:48:29 +00:00
mark-nielsen
2817bc1aed Fixed a bug when detecting a user as eligible for posting their name for high scores 2006-09-19 02:41:10 +00:00
mark-nielsen
8271e5cec8 Fixed alignment problem with the buttons for password protected lessons 2006-09-19 02:29:42 +00:00
mark-nielsen
07642aef3e Minor changes 2006-09-10 19:09:25 +00:00
mark-nielsen
c94d37997d Removed action set to navigation because view.php no longer uses action 2006-09-10 18:41:38 +00:00
mark-nielsen
5631925a26 Started to separate out logic and presentation in view.php. Decided to wrap the question printing with HTML templates (viewstart.html and viewend.html)
Still needs a lot of work
2006-09-10 18:19:29 +00:00
mark-nielsen
fb992d716a Started to reorganize view.php 2006-09-10 02:38:09 +00:00
mark-nielsen
15f3d44ae7 Moved teacherview (lesson editing) out of view.php into edit.php
No code improvements in edit.php as of now.  Just works ;)
2006-09-10 02:09:14 +00:00
mark-nielsen
d1b025d013 Moved high scores logic out of view.php into highscores.php
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
mark-nielsen
2163c22634 Forgot the lesson_ prefix 2006-09-09 22:23:50 +00:00
mark-nielsen
2cb24b647c Improved clock output and works when javascript is disabled 2006-09-09 22:20:51 +00:00
mark-nielsen
259990d2c6 Lesson buttons should now work with javascript disabled
Also improved the layout of action/continue.html
2006-09-09 21:39:11 +00:00
mark-nielsen
f15eb92c2c Removed essay grading code from view.php into essay.php. 2006-09-09 01:58:48 +00:00
mark-nielsen
6e1ff5c8fb MDL-6477: Added roles support.
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
skodak
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00
skodak
a8ff58dd2c merging changes from MOODLE_16_STABLE 2006-07-31 18:10:02 +00:00
skodak
5109569b69 Bug #5988 - Branch Tables in 1.6+ (Lesson Module); merged from MOODLE_16_STABLE 2006-07-10 22:39:58 +00:00
mark-nielsen
88427c077b [Merged][BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt. This is then used for grading lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.
This new grading algorithm now enforces the lesson setting Max attempts when custom scoring is turned Off

Changed the reporting of minquestions setting to match the help file.  Now it is question based instead of attempt based.

Changed the reporting of ongoing score to use the new grade function.
2006-05-19 01:05:13 +00:00
mark-nielsen
a1d0b3eb81 [BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons. Had to change arguments for this function as well which is the edit in view.php.
lesson.php how checks for teacher editing priv for all actions except for continue.  This is just in case the user hacks the URL.
2006-05-15 19:14:22 +00:00
mark-nielsen
432c2219f5 [BugFix] Bug #5396 - Found that the css float was causing the odd problem. Removed extra styles for the button layout and changed the divs around the buttons to spans
Also improved some logic in the button processing for branch tables
2006-05-02 17:05:29 +00:00
mark-nielsen
31eb5b5335 [Removed] the Delete user attempts option in the Lesson settings (changes to mod and lib)
[Added] new functionality to report.php to delete individual student attempts
[Fixed] High scores text in view.php when no high scores were recorded needed to be centered
2006-04-29 01:37:50 +00:00
mark-nielsen
31f6b26d4f [BugFix] Action was using global variables - now is fetched with optional_param 2006-04-06 23:03:08 +00:00
michaelpenne
a7ae1ad3fd [BugFix] Multiple essays were not showing for grading: http://moodle.org/mod/forum/discuss.php?d=41999#195580 2006-03-28 00:30:24 +00:00
mark-nielsen
97d2756c65 [New Feature] Tabbed navigation added to lesson (similar to quiz)
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
mark-nielsen
aeade7e227 cleaned up the left menu feature output by removing an unused form and several unnecessary string concatenations 2006-03-19 02:08:37 +00:00
mark-nielsen
289218844a [Changed] The print_simple_box_start/stop changes conflicted greatly with the display of branch table buttons (the box printed above the buttons some how :( ) To fix this, the tables were taken out and divs were used instead to display and arrange the buttons. This turns out to be a good thing because now the user has more control over the buttons via style sheet. Also did some extra clean up in the section of code printing the branch table.
[Added] new styles to styles.php to help display the buttons correctly.
2006-03-19 01:53:50 +00:00
mark-nielsen
0646963948 [Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy 2006-03-17 03:37:31 +00:00
michaelpenne
1ae43a52f9 [BugFix] Bug #4174 - Lesson Essay Question Can't be Graded when attempt not finished 2006-02-24 20:17:08 +00:00
michaelpenne
8e7cf8d4c9 [Fixed] Activity linking was not useing the course module id correctly. 2006-02-06 20:49:03 +00:00
michaelpenne
6ef1c83de6 [Fixed] Display error in Windows IE. Slideshow div would move on link rollover. This is now fixed. 2006-01-13 21:24:52 +00:00
michaelpenne
aeb8148a57 [Changed] Now when a teacher edits a page with the "Edit page contents" button and then saves or cancels, s/he gets redirected back to the lesson navigation. This will help to streamline the editing
[Fixed] The cancel button on the edit page now works.
2006-01-13 18:41:37 +00:00
defacer
7f9def8fa9 XHTML fix 2005-11-23 22:31:52 +00:00
michaelpenne
acab90991a BUG FIX: progress bar now does not break when student reviews the lesson.
BUG FIX: matching question type upgrade script now supports quotes.

CHANGED: Improved labels for form elements to improve accessibility.

NEW: added a skip navigation link for left menu.
2005-11-16 22:35:46 +00:00
michaelpenne
114f47a79e NEW FEATURE: Activity Link allows the teacher to display a link to another activity, which is in the same course,
at the end of the Lesson.
2005-11-07 19:56:08 +00:00
michaelpenne
3eca6cf1bf NEW FEATURE: Media file now works with web pages and with text and html files. Also, the pop-up
window size is configurable as well as an optional close button at the bottom of the window.
2005-10-28 22:45:47 +00:00
michaelpenne
c83dca2287 BUG FIX: Double print of content in branch tables with slide show on 2005-10-28 18:55:58 +00:00
michaelpenne
3c34ce6802 reverted back some divs, minor change 2005-10-26 21:48:24 +00:00
michaelpenne
fb0f70908b BUG FIX: if one is a teacher, the left menu is always displayed. 2005-10-26 21:43:48 +00:00
michaelpenne
62eda6ea18 NEW: Progress bar option. Now a progress bar can be optionally displayed at the bottom of the lesson page.
NEW: Display Left Menu IF.  The left menu will only display if the student has a grade better than the one set in the lesson settings.  This is nice to allow only students who are reviewing the lesson to have access to the left menu.

BUG FIX: In Windows IE, the content was being aligned center.  Now, the content is explicitly aligned to left as default.
BUG FIX: High Scores variable was not spelled correctly at the End of Lesson.

ADDED: Div tags around branch tables.  This will allow users to choose to display them or not or move them around

CHANGED: converted more of the links to the stylized button.  Also, removed a lot of forms and javascript and replaced it with links with the variables in the href.
CHANGED: the slide show styles have been moved to the style sheet.
CHANGED: removed the CDC comments

Other minor changes have been made to the code as well.
2005-10-24 23:06:43 +00:00
michaelpenne
b6a64b0295 Removed a notice warning when lessons are created in a course with no category (eg: home page) 2005-10-14 19:25:11 +00:00
michaelpenne
4e644e8d50 Reverted grading back to 1.4.X for when custom scoring is turned OFF 2005-10-07 20:33:39 +00:00
michaelpenne
d6941aff55 Recoded most of the left menu:
Got rid of a table
Restructured and added more div tags in the left menu (much more logical)
Reworked the styles for the left menu in the styles sheet (everything should be customizable via style sheet)
More compatible with MacIE5
Added styles to the individual links in the menu (allows styling the for currently selected page and for all the rest)
Cleaned up the left menu link generation in locallib.php
2005-10-05 22:45:38 +00:00
michaelpenne
b8437c1cbc Removed filtering on page contents, answers and responses for lesson pages and their answers (this includes removing parameter cleaning and noclean in format_text).
Also, fixed some warning errors in action/updatepage.php.
2005-10-03 21:29:05 +00:00
michaelpenne
8b87bbde6c BIG FIX: "Edit Page Contents" button for when $pageid is empty (first page) 2005-10-03 19:46:44 +00:00
michaelpenne
544121b12d Switched buttons in lesson navigation to stylized links similar (well, the same rather for default) to the home button in the footer. This will allow for easy (hopefully) personalized customization of the buttons in lesson (ex: background images, colors, etc).
styles.php: added new styles, added comments and cleaned it up
view.php: converted the buttons for each question type to the new button standard.  Also recoded branch table button layout generation.
action/continue.php: updated the buttons there as well.
2005-09-28 21:55:05 +00:00
michaelpenne
b46d9213ba Added styles to the next and previous buttons on branch tables to allow customization 2005-09-21 21:00:36 +00:00