105352 Commits

Author SHA1 Message Date
Cameron Ball
29df52af19 MDL-74548 backup: Refactor course copies
This patch modifies the way copy data is shared in order to mitigate potential race conditions
and ensure that the serialised controller stored in the DB is always in a valid state.

The restore controller is now considered the "source of truth" for all information about the
copy operation. Backup controllers can no longer contain information about course copies.

As copy creation is not atomic, it is still possible for copy controllers to become orphaned or
exist in an invalid state. To mitigate this the backup cleanup task has been modified to call
a new helper method copy_helper::cleanup_orphaned_copy_controllers.

Summary of changes in this patch:

    - Copy data must now be passed through the restore controller's constructor
    - base_controller::get_copy has been deprecated in favour of restore_controller::get_copy
    - base_controller::set_copy has been deprecated without replacement
    - core_backup\copy\copy has been deprecated, use copy_helper.class.php's copy_helper instead
    - backup_cleanup_task will now clean up orphaned controllers from copy operations that went awry

Thanks to Peter Burnett for assiting with testing this patch.
2022-06-29 09:13:29 +08:00
Jun Pataleta
ceb41588d2 weekly release 4.1dev 2022-06-24 11:59:02 +08:00
Jun Pataleta
9c61045945 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2022-06-24 11:58:59 +08:00
Jun Pataleta
fc76c284b1 Merge branch 'MDL-74623_master_v2' of https://github.com/TomoTsuyuki/moodle 2022-06-23 11:55:30 +08:00
Jun Pataleta
24b826f38d Merge branch 'MDL-69939' of https://github.com/paulholden/moodle 2022-06-23 09:53:44 +08:00
Jun Pataleta
79b54a59a4 Merge branch 'MDL-74713' of https://github.com/paulholden/moodle 2022-06-23 09:51:50 +08:00
Jun Pataleta
626d0fe77f Merge branch 'MDL-73156-master' of https://github.com/michael-milette/moodle 2022-06-23 09:50:41 +08:00
Jun Pataleta
271c69fd84 Merge branch 'MDL-74785' of https://github.com/danmarsden/moodle 2022-06-23 09:48:47 +08:00
Jun Pataleta
8ff58878e7 Merge branch 'MDL-72948' of https://github.com/NeillM/moodle 2022-06-22 23:16:16 +08:00
Neill Magill
6fb4a3b56e MDL-72948 messaging: Minimise fields used in query
Most of the fields in the query are not needed and are discarded
soon after visibility checks are made.
2022-06-22 10:11:18 +01:00
Shamim Rezaie
1296d39194 Merge branch 'master-MDL-71468-v4' of https://github.com/golenkovm/moodle 2022-06-22 14:54:01 +10:00
Víctor Déniz
ed249020ea Merge branch 'MDL-72486-unproxied-logging' of https://github.com/brendanheywood/moodle 2022-06-21 19:23:06 +01:00
Jun Pataleta
8059552597 Merge branch 'MDL-73212' of https://github.com/stronk7/moodle 2022-06-21 23:50:51 +08:00
Eloy Lafuente (stronk7)
b4a86ff674 MDL-73212 gha: Allow parameters to be passed via secret
We are disabling the -v (verbose) option, used by default. Still,
now we support a secret (that can be added to everyone's repository)
to accept any PHPUnit's command line options and run the tests with
them.

Some examples:

phpunit_options = -v (to keep the verbose option enabled)
phpunit_options = --testdox (to print information about every test...)

... (basically anything supported by the CLI).

Also, we are raising here the environment from Ubuntu 18.04 to 20.04

(self tested by GHA, heh)
2022-06-21 16:54:13 +02:00
Jun Pataleta
0999f65f71 Merge branch 'MDL-74630-master' of https://github.com/aanabit/moodle 2022-06-21 10:12:33 +08:00
Tomo Tsuyuki
bd6fdd70d6 MDL-74623 mod_forum: Add course full name option for notification 2022-06-21 11:28:44 +10:00
AMOS bot
0e57e16eba Automatically generated installer lang files 2022-06-21 00:09:45 +00:00
Jun Pataleta
09410d2f91 Merge branch 'MDL-74715' of https://github.com/paulholden/moodle 2022-06-20 21:57:39 +08:00
Paul Holden
f961443652 MDL-74715 reportbuilder: switch event for adding filters/conditions.
Switch the select element event listener to that provided by custom
events helper, for adding report filters and conditions. This improves
cross-platform support.
2022-06-20 09:09:10 +01:00
Jun Pataleta
240d7f6054 Merge branch 'MDL-74358' of https://github.com/stronk7/moodle 2022-06-20 14:40:07 +08:00
Jun Pataleta
9182cb11c7 Merge branch 'MDL-74716-master' of https://github.com/aanabit/moodle 2022-06-20 10:25:20 +08:00
Brendan Heywood
9fa26ed911 MDL-72486 core: Add unsafe log and fix options to proxy settings 2022-06-20 11:18:42 +10:00
Ilya Tregubov
70fb867346 Merge branch 'MDL-74694' of https://github.com/paulholden/moodle 2022-06-17 15:07:04 +04:00
Paul Holden
3eeaf49c8c MDL-69939 webservice: correct AJAX bool value in services definition. 2022-06-17 11:03:47 +01:00
Eloy Lafuente (stronk7)
ed0913d45b MDL-74358 availability: Avoid php8 problem with array_values(null) 2022-06-17 11:09:46 +02:00
Ilya Tregubov
be63f1c2ed Merge branch 'MDL-74296-master' of https://github.com/call-learning/moodle 2022-06-17 12:54:38 +04:00
Mikhail Golenkov
e4784db136 MDL-71468 assignfeedback_editpdf: Convert submissions via adhoc tasks 2022-06-17 18:04:17 +10:00
Jun Pataleta
b81fb00f25 weekly release 4.1dev 2022-06-17 15:30:26 +08:00
Eloy Lafuente (stronk7)
2231b73953 Merge branch 'MDL-72324-master-fix' of https://github.com/junpataleta/moodle 2022-06-17 08:38:30 +02:00
Jun Pataleta
fb0d963562 MDL-72324 core: Add upgrade.txt note about $plugin->incompatible 2022-06-17 10:33:49 +08:00
Jun Pataleta
19c6eccf47 Merge branch 'MDL-74529' of https://github.com/paulholden/moodle 2022-06-17 10:17:12 +08:00
Jun Pataleta
8f947b8ebd Merge branch 'MDL-74533-master' of https://github.com/BruceGoodGuy/moodle 2022-06-17 10:17:12 +08:00
Jun Pataleta
efbb07aeb6 Merge branch 'MDL-72555-master' of https://github.com/laurentdavid/moodle 2022-06-17 10:17:11 +08:00
Ferran Recio
31b4535695 MDL-74716 core_my: Fix My course user tour for admins 2022-06-16 19:10:33 +02:00
Michael Milette
416527fd73 MDL-73156 user: Custom user profile field names now filtered. 2022-06-15 11:48:50 -04:00
Jun Pataleta
5b6d6ffc36 Merge branch 'MDL-74565' of https://github.com/paulholden/moodle 2022-06-15 23:21:52 +08:00
Jun Pataleta
b184248c47 Merge branch 'MDL-72324-incompatible-check' of https://github.com/Peterburnett/moodle 2022-06-15 23:04:30 +08:00
Jun Pataleta
b0da5072f6 Merge branch 'MDL-72699' of https://github.com/paulholden/moodle 2022-06-15 22:53:22 +08:00
Ilya Tregubov
85463a83f6 Merge branch 'MDL-73726' of https://github.com/paulholden/moodle 2022-06-15 14:36:16 +04:00
Jun Pataleta
dfca2aad61 Merge branch 'MDL-73966' of https://github.com/paulholden/moodle 2022-06-15 18:06:30 +08:00
Paul Holden
b6f4ec679f MDL-72699 course: link to profile of user who requested course. 2022-06-15 10:57:50 +01:00
Jun Pataleta
c6d752bb83 Merge branch 'MDL-74871' of https://github.com/paulholden/moodle 2022-06-15 17:16:57 +08:00
Jun Pataleta
c3d4845de2 Merge branch 'MDL-74634' of https://github.com/paulholden/moodle 2022-06-15 16:42:21 +08:00
Jun Pataleta
985fd305c6 Merge branch 'MDL-73293-patch' of https://github.com/ilyatregubov/moodle 2022-06-15 15:48:59 +08:00
Ilya Tregubov
41cf7a58f1 MDL-73293 core_task: patch for undefined propety. 2022-06-15 11:31:31 +04:00
Jun Pataleta
1776903721 Merge branch 'MDL-73110' of https://github.com/paulholden/moodle 2022-06-15 14:36:36 +08:00
Jun Pataleta
86676d6811 Merge branch 'MDL-72184' of https://github.com/paulholden/moodle 2022-06-15 10:27:56 +08:00
Jun Pataleta
9eafcc2b41 Merge branch 'MDL-73236-M41v2' of https://github.com/sbourget/moodle 2022-06-15 10:23:57 +08:00
Stephen Bourget
407c950573 MDL-73236 block_myprofile: add idnumber support 2022-06-14 15:36:19 -04:00
Paul Holden
e0b0908ba9 MDL-74713 admin: format custom profile fields in identify config. 2022-06-14 17:19:39 +01:00