Andrew Nicols
2b4c86e251
Merge branch 'MDL-77299-master' of https://github.com/meirzamoodle/moodle
2023-03-01 11:14:36 +08:00
Meirza
f228e373cc
MDL-77299 mod_quiz: Added missing class properties.
...
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
Co-authored-by: Tim Hunt <t.j.Hunt@open.ac.uk>
2023-03-01 10:09:19 +07:00
Andrew Nicols
427659d202
Merge branch 'MDL-58945' of https://github.com/timhunt/moodle
2023-03-01 10:54:13 +08:00
Luca Bösch
3d59f5073c
MDL-77288 quiz: Horizontally align feedback to the border & full width.
...
Probably from historical reasons and because of layout of former Moodle
versions the container the feedback is situated in has 70% width and is
indented. In nowadays themes this looks weird and gives visual inconsistency.
2023-02-24 10:44:19 +01:00
Andrew Nicols
d8f6c76400
Merge branch 'MDL-76843' of https://github.com/timhunt/moodle
2023-02-23 19:04:29 +01:00
Andrew Nicols
d7d5b417b6
Merge branch 'MDL-77210' of https://github.com/timhunt/moodle
2023-02-23 09:22:40 +08:00
Tim Hunt
dd1385b80d
MDL-76843 quiz: add test to verify random essay stats now work
2023-02-22 14:30:23 +00:00
Tim Hunt
4484757021
MDL-76843 quiz: fix statistics questions for missing questions
2023-02-22 14:30:23 +00:00
Tim Hunt
3088bc6600
MDL-58945 qbank: showing q text should give option of plain or full
2023-02-22 11:15:02 +00:00
Tim Hunt
b7a67f8896
MDL-77210 quiz: fix regrade for attempts with redone questions
2023-02-13 16:55:52 +00:00
Anupama Sarjoshi
05d51c15ca
MDL-63608 quiz: Fix Access order when manually grading quizzes
...
Changes done to fix access order of attempts that need manual grading.
Changed button text from 'Save and go to next page' to 'Save and show next' to improve UI.
2023-02-10 17:42:10 +00:00
Andrew Nicols
9890d88107
Merge branch 'MDL-77057' of https://github.com/paulholden/moodle
2023-02-09 10:19:22 +08:00
Luca Bösch
dda015f855
MDL-77112 quiz: Align some elements in quiz reports better.
2023-02-03 11:52:44 +01:00
Paul Holden
fdc9bd1a76
MDL-77057 group: format group names in module override pages.
2023-01-27 11:50:58 +00:00
Tim Hunt
34ca197526
MDL-77024 quiz: fix metatdata on log events
...
Some had the wrong edulevel or crud
2023-01-27 11:30:28 +00:00
Sara Arjona
47fd608156
Merge branch 'MDL-76968-master' of https://github.com/junpataleta/moodle
2023-01-25 08:22:23 +01:00
Jun Pataleta
f3c29eab3d
Merge branch 'MDL-76967-master' of https://github.com/lucaboesch/moodle
2023-01-25 08:57:24 +08:00
Jun Pataleta
ce9f6db2ff
Merge branch 'MDL-76899' of https://github.com/timhunt/moodle
2023-01-24 23:19:43 +08:00
Sara Arjona
ae53d04144
Merge branch 'MDL-75337-master' of https://github.com/laurentdavid/moodle
2023-01-24 16:07:35 +01:00
Jun Pataleta
e742e21800
Merge branch 'MDL-76639-master' of https://github.com/andelacruz/moodle
2023-01-24 18:59:38 +08:00
Laurent David
fc72a1d7b1
MDL-75337 core: Single button - core changes
...
* Change all core calls toward single_button to use single_button::BUTTON_PRIMARY
when needed
2023-01-24 06:01:35 +01:00
Andrew Nicols
ecc2a8775a
Merge branch 'MDL-69164-master' of https://github.com/JBThong/moodle
2023-01-24 11:45:27 +08:00
Marina Glancy
b0a83aa7bd
MDL-76362 various: Avoid passing nulls to functions that don't allow nulls
...
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
2023-01-23 09:15:54 +08:00
Jun Pataleta
a479c1854b
MDL-76968 mod_quiz: Use proper external_api reference
2023-01-20 17:06:17 +08:00
Luca Bösch
a4eee48b49
MDL-76967 questions: Questions last used line height
2023-01-20 09:56:55 +01:00
Ilya Tregubov
89b722402e
Merge branch 'MDL-76766-master' of https://github.com/aanabit/moodle
2023-01-19 11:03:40 +08:00
Jun Pataleta
fad05d7929
Merge branch 'MDL-76583-master-withoutrename' of https://github.com/andrewnicols/moodle
2023-01-19 09:44:48 +08:00
Andrew Nicols
a3cc26f8bb
MDL-76583 core: Update uses of external_* classes
2023-01-19 07:34:09 +08:00
Tim Hunt
ec0a2dd85b
MDL-76899 quiz: Fix PHPdocs issues
2023-01-18 12:14:37 +00:00
Tien Nguyen
5863659d79
MDL-69164 Question: Convert question/qengine.js to AMD modules
2023-01-18 11:24:38 +07:00
Tim Hunt
28f090d975
MDL-76899 quiz: fix whitespace around operators
2023-01-16 19:07:08 +00:00
Tim Hunt
2bb6c8b281
MDL-76899 quiz: bulk fix all array literals array() -> []
...
This was done with PHPStorm's automated tool. No manual editing
2023-01-16 17:12:45 +00:00
Tim Hunt
17e11dd9d5
MDL-76899 quiz: Bulk fix object -> stdClass in PHPdoc
2023-01-16 17:12:44 +00:00
Tim Hunt
450e55e79d
MDL-76899 quiz: remove unneeded tearDown from a unit test
2023-01-16 17:12:34 +00:00
Tim Hunt
f4099bcd78
MDL-76899 quiz: basic cleanup of the structure and repaginate classes
2023-01-16 17:12:23 +00:00
Tim Hunt
6e7c63b36f
MDL-76898 quiz: Move deprecated functions deprecatedlib.php
...
These were already deprecated, but in the wrong file.
2023-01-16 17:12:15 +00:00
Tim Hunt
03cf2ce782
MDL-76898 quiz: final deprecation of things deprecated long ago
2023-01-16 17:12:02 +00:00
Angelia Dela Cruz
320218633a
MDL-76639 behat: Add Behat test coverage for quiz with limited attempts
2023-01-13 16:10:00 +08:00
Jun Pataleta
71b3f9c39f
MDL-76649 mod_quiz: Use correct quizid attribute from attempt
2023-01-12 15:17:35 +08:00
Jun Pataleta
e0d857f39f
Merge branch 'MDL-76649' of https://github.com/timhunt/moodle
2023-01-12 12:06:35 +08:00
David Mudrák
50ba9dc72c
MDL-76739 lang: Use the fixed strings in the tests, too
2023-01-12 09:17:27 +08:00
Helen Foster
975a127325
MDL-76739 lang: Import fixed English strings (en_fix)
2023-01-12 09:17:27 +08:00
Amaia Anabitarte
bbd7aa78b2
MDL-76766 mod_quiz: Allow shuffling quizes with no questions
2023-01-11 11:15:35 +01:00
Andrew Nicols
6f1c9d3b53
Merge branch 'MDL-76614' of https://github.com/timhunt/moodle
2023-01-11 10:32:42 +08:00
Tim Hunt
7e4972a4a8
fixup! MDL-76614 quiz: deprecate class moodle_quiz_exception
2023-01-09 17:48:26 +00:00
Tim Hunt
192f993906
MDL-76649 quiz statistics task: output more useful trace info
...
At the moment, quiz_statistics\task\recalculate gives no useful
information about what it is doing, which makes it hard to investigate
if the task fails. This commit makes it more usefully verbose.
Also, following this change, one instance of this task will not
run for more than one hour at a time.
As part of this commit, I have added a new helper mtrace_exception.
to consistently log exceptions in scheduled tasks. It is sad to
add a new function to moodlelib.php, but that seemed the logical place.
Looking at other tasks, this method is badly needed. Many are just
logging the ->getMessage() which is normaly insufficient for proper
debugging. However, swiching all existing tasks to use the new function
will need to wait for a future MDL.
2023-01-09 13:26:41 +00:00
Jun Pataleta
7927374af9
MDL-76597 mod_quiz: Add a default heading name for Behat tests
2023-01-09 15:41:27 +08:00
Jun Pataleta
08a2781607
MDL-76597 mod_quiz: Set presentation role for the question list
...
Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
The aria-label for the <li> element is inappropriate and can also cause
confusion to screen reader users. Better to remove this. Though this is
being used in the confirmation modal so better to just change it to a
data attribute.
2023-01-06 22:37:54 +08:00
Jun Pataleta
317dd19f02
MDL-76597 mod_quiz: Set presentation role for the question list
...
Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
2023-01-06 22:37:54 +08:00
Jun Pataleta
f7bcd8304f
MDL-76597 mod_quiz: Add label for question checkboxes
2023-01-06 22:37:54 +08:00