mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-05 00:22:43 +01:00
Code Issues Projects Releases Wiki Activity
103,986 Commits 36 Branches 523 Tags
Commit Graph

76 Commits

Author SHA1 Message Date
Andrew Nicols
68ae89ccc4 Merge branch 'MDL-73631' of https://github.com/paulholden/moodle 2022-02-08 12:03:42 +08:00
Paul Holden
108feb6ffa MDL-73631 reportbuilder: singular, pivoted Behat data generators. 2022-02-03 08:31:01 +00:00
Paul Holden
a73d989a65 MDL-73682 reportbuilder: allow columns to define how they're sorted. 2022-02-02 10:17:56 +00:00
Ilya Tregubov
c94d463afa Merge branch 'MDL-73706' of git://github.com/paulholden/moodle 2022-01-31 16:59:15 +02:00
Ilya Tregubov
2708e7ef60 Merge branch 'MDL-72756' of git://github.com/paulholden/moodle 2022-01-31 15:12:21 +02:00
Paul Holden
eb2e261df4 MDL-73706 reportbuilder: fix count for columns with multiple fields. 
When using the "Count distinct" aggregation type on a column that
selects multiple fields, we should account for each of them in the
returned SQL.

Move helper method to facilitate this to the base aggregation class
so it can be re-used between all types.
 2022-01-28 15:38:40 +00:00
Jun Pataleta
fd452f2fa2 Merge branch 'MDL-73470' of https://github.com/roland04/moodle 2022-01-28 11:02:01 +08:00
Paul Holden
9626002d56 MDL-72756 reportbuilder: implement tests covering privacy updates. 2022-01-27 12:04:05 +00:00
Mikel Martín
795087462f MDL-73470 core: Move toggle template to core 2022-01-25 18:04:58 +01:00
Jun Pataleta
fbc3e7568e Merge branch 'MDL-73493' of git://github.com/paulholden/moodle 2022-01-24 17:32:32 +08:00
Andrew Nicols
6bec1964cc Merge branch 'MDL-73598' of https://github.com/paulholden/moodle 2022-01-24 11:29:48 +08:00
Paul Holden
628541b5e1 MDL-73493 reportbuilder: correct handling of empty string in filters. 
This is specifically for Oracle, which treats empty strings and NULL
in an inconsistent manner unless passed as query parameters. Increase
test coverage of the same.

Co-authored-by: Carlos Castillo <carlos.castillo@moodle.com>
 2022-01-21 15:43:01 +00:00
Paul Holden
335012580b MDL-73598 reportbuilder: feature switch for custom reports. 2022-01-19 23:20:52 +00:00
Paul Holden
a844d885b2 MDL-73180 reportbuilder: improve relative date filter definitions. 
Changes since the original implementation in e55abd71 mean that
relative date filtering (by last/next day/week, etc) is now based
on the actual current time, rather than the start or end of the
current time unit.
 2022-01-19 08:22:03 +00:00
Shamim Rezaie
c4706a93ea Merge branch 'MDL-72757-master' of https://github.com/dravek/moodle 2022-01-13 18:29:28 +11:00
Paul Holden
ee566b88a8 MDL-72757 reportbuilder: improve model event tests. 
Remove some boilerplate/duplication in the current test methods
using @depends annotation to pass persistents between them.
 2022-01-10 17:21:23 +01:00
David Matamoros
39b90208e1 MDL-72757 reportbuilder: Events for CRUD operations on report models 2022-01-05 09:55:36 +01:00
Paul Holden
98e7d99720 MDL-73468 reportbuilder: observe configured sorting when editing. 
Users preferred sorting (via clicking on column headers) should only
take effect when pre/viewing the report, not when editing it.
 2021-12-30 11:35:07 +00:00
Jun Pataleta
80c17cd2a0 Merge branch 'MDL-72701-master' of https://github.com/andrewnicols/moodle 2021-12-23 12:10:46 +08:00
Paul Holden
335f608abb MDL-72598 reportbuilder: tasks and API for report schedule delivery. 2021-12-21 09:44:43 +00:00
Paul Holden
a05683d027 MDL-72598 reportbuilder: interface elements for creating schedules. 
Add new tab to the report editor, with system report, external API
and Javascript modules for managing report schedules.
 2021-12-21 08:57:17 +00:00
Andrew Nicols
3a70983d53 MDL-72701 unit tests: Generate default coverage 2021-12-21 09:24:00 +08:00
Paul Holden
d064a93d29 MDL-72598 reportbuilder: elements to allow audiences to be renamed. 
This allows the user to give the audience more context, particularly
when they are used for selection on the forthcoming schedule form
editing.
 2021-12-17 14:33:27 +00:00
Paul Holden
eb460d93aa MDL-72598 reportbuilder: schema and model updates for schedules. 2021-12-17 14:33:27 +00:00
Víctor Déniz
3eafc7a1bc Merge branch 'MDL-73280' of git://github.com/paulholden/moodle 2021-12-13 18:44:10 +00:00
Paul Holden
8bed417833 MDL-73280 reportbuilder: format checkbox profile fields correctly. 2021-12-09 14:09:44 +00:00
Eloy Lafuente (stronk7)
deb0e76eee MDL-73278 phpunit: Rename already namespaced classes to match file name 
These are the only cases 100% safe to apply the renaming of the
testcase class names to match the file names.

All other cases are not safe, because they are missing namespace
and may enter into name conflicts. Adding namespaces is not as
simple as imagined because it implies to, also, add a good number
of modifications to core. See the issue for more details.
 2021-12-07 23:54:29 +01:00
Jun Pataleta
f95cc84aa5 Merge branch 'MDL-72770' of https://github.com/roland04/moodle 2021-12-02 11:08:50 +08:00
Mikel Martín
6a6ebbac63 MDL-72770 reportbuilder: Display editor in full screen layout 
- use 'popup' layout in editor page and create a custom navbar
- remove 'Settings' toggle button and show settings right sidebar with fixed position
- add 'Edit details' button on navbar that opens a modal to modify report basic settings
 2021-12-01 17:12:45 +01:00
Paul Holden
171c615a1b MDL-73149 reportbuilder: update sorting options after aggregation. 
Aggregation types can disable column sorting, e.g. both the current
group concatenation types. If such a type is selected for a column
we should update the report sorting options, ensuring that only those
columns that can be sorted are available for selection.
 2021-12-01 09:12:07 +00:00
Mikel Martín
8e25d534b4 MDL-72822 core_reportbuilder: Accessibility improvements 
- Add sr-only headings to tabs
- Change role to 'presentation' in tab <li> elements
- Remove unnecessary aria-labelledby
- Fix heading levels
- Avoid duplicated IDs in audiences
- Replace empty links with buttons
- Fix mustache comments
- Fix mustache contexts
 2021-11-24 10:26:14 +01:00
Paul Holden
881dccaa7d MDL-73069 reportbuilder: filter/condition for selecting user. 
This allows a report creator to create personalised reports
according to the user who is viewing the report.
 2021-11-22 09:17:52 +00:00
Jun Pataleta
357ddcaff6 Merge branch 'MDL-72826' of git://github.com/paulholden/moodle 2021-11-19 11:07:03 +08:00
Paul Holden
80dd297a62 MDL-73090 reportbuilder: confirmation before resetting conditions. 
Also prefetch all lang strings used by conditions editor.
 2021-11-17 16:27:50 +00:00
Paul Holden
be11216d30 MDL-72826 reportbuilder: per-report option to show only unique rows. 
This option allows report creators to avoid duplicate data being
displayed in their report. It is applied only when no columns in the
report currently have aggregation methods applied.
 2021-11-16 13:59:16 +00:00
Paul Holden
c0ceaef772 MDL-73011 reportbuilder: remove workarounds for tab switching. 2021-11-11 23:54:56 +00:00
Mikel Martín
68eb55b8e6 MDL-72565 reportbuilder: Add card view functionality 
Use card view settings to show a 'card view' for custom reports in small devices
 2021-11-11 13:55:32 +01:00
Mikel Martín
aaa7a5a445 MDL-72565 reportbuilder: Add 'Card view' settings to custom reports 
- Create a new 'settings' column in reportbuilder_report table and provide an API to manage it
- Add new card view settings to custom reports
 2021-11-11 13:55:29 +01:00
Mikel Martín
f2582cc823 MDL-72565 reportbuilder: Use same template for system/custom reports 
- rename 'system_report' template to 'report'
- view.php now uses 'report' template

Co-authored-by: Paul Holden <paulh@moodle.com>
 2021-11-11 13:44:23 +01:00
Shamim Rezaie
d038fd822d Merge branch 'MDL-72952' of https://github.com/roland04/moodle 2021-11-11 10:38:26 +11:00
Eloy Lafuente (stronk7)
2b18fad922 Merge branch 'MDL-72696' of https://github.com/paulholden/moodle 2021-11-10 19:20:39 +01:00
Mikel Martín
5a2624c472 MDL-72952 reportbuilder: UX behaviour improvements in audiences 
- Show a toast notification when saving an audience
- Add form change checker when adding a new audience to prevent user from navigating away if it is not saved
- Remove expand/collapse animation in audience sidebar to be consistent with editor

Co-authored-By: Paul Holden <paulh@moodle.com>
 2021-11-10 17:22:00 +01:00
Ilya Tregubov
90b40b99fd Merge branch 'MDL-73001-master' of https://github.com/dravek/moodle 2021-11-09 14:55:30 +02:00
Paul Holden
7a7375df4d MDL-72696 behat: support inplace editable fields of type select. 
If an inplace editable field is using the "select" type, we should
treat it as a select field when setting it's value during scenarios.
 2021-11-08 13:09:05 +00:00
David Matamoros
aaa041a9bd MDL-73001 reportbuilder: Allow to set custom title to fullname columns 2021-11-08 13:54:41 +01:00
Sara Arjona
2a0c4a8a73 Merge branch 'MDL-72978-master' of https://github.com/dravek/moodle 2021-11-08 09:59:47 +01:00
Ilya Tregubov
6b0b757124 Merge branch 'MDL-72961' of https://github.com/paulholden/moodle 2021-11-04 14:40:26 +02:00
Paul Holden
628fcdee55 MDL-72962 reportbuilder: format editable element names for output. 2021-11-02 15:43:07 +00:00
David Matamoros
741f47ea7a MDL-72978 reportbuilder: Report name can't have only blank spaces 
- Don't allow to set a report name containing only blank spaces when
creating a new report or editing an existing report name.
- Removed TODO from code related to MDL-71086
 2021-11-02 16:27:20 +01:00
Paul Holden
cac0068d88 MDL-72961 reportbuilder: move category elements to correct entity. 2021-11-01 15:44:14 +00:00