9 Commits

Author SHA1 Message Date
tjhunt
8ed5dd63ee course categories: Fix many bugs with category editing and permissions. Clean up code.
Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.
2008-12-04 08:53:10 +00:00
tjhunt
16851b22ad MDL-16676 All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html 2008-09-25 10:04:01 +00:00
poltawski
f62cb19d89 MDL-10886 - Category edit: use 'save changes', enable cancel button to allow us
to get back from where we came from & refine where we are returned to when cancelled.
merged from MOODLE_19_STABLE
2008-01-09 10:49:59 +00:00
nicolasconnault
39536381d5 MDL-11543 Printing nice list of categories for parent category drop-down 2007-10-10 06:21:37 +00:00
nicolasconnault
2c23af9d87 MDL-11543 format_string(parent category name) 2007-10-10 06:04:14 +00:00
nicolasconnault
9c536df7c4 MDL-11543 Refactored editcategory and form 2007-10-10 06:01:54 +00:00
nicolasconnault
cd405db239 MDL-11543 Replacing "Site" with "Top" in the list of available parent categories 2007-10-10 04:53:32 +00:00
moodler
09deab0661 Miscellaneous fixes for MDL-11543
- added button to edit current category
 - removed old mini-forms to do the same
 - tidied up various things and CSS as well
2007-10-10 04:05:46 +00:00
nicolasconnault
1f682581a7 MDL-11543 Temporary solution originally proposed by Martin 2007-10-09 17:22:10 +00:00