409 Commits

Author SHA1 Message Date
Ruslan Kabalin
72e6af0344 MDL-27171 messages: fix static variable filtering bug in get_message_processors
Static $processors should contain the full list of processors only, when
filtering is required, the $processors variable should not be updated.

Lambda function refactoring is made as well.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-31 11:18:11 +01:00
Ruslan Kabalin
e8fc7940a8 MDL-27171 messages: $defaultpreferences is an object, use isset instead.
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-31 09:46:22 +01:00
Ruslan Kabalin
ebe0c008ca MDL-27171 messages: commenting style changes and extra comments
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
Signed-off-by: Dan Poltawski <dan.poltawski@luns.net.uk>
2011-05-27 14:07:06 +01:00
Ruslan Kabalin
7a04c476a2 MDL-27171 messages: implement new syntax in messages.php and update processing
The new messaging default settings can be set in messages.php and deployed
during installation. This also ensures the removing of settings on plugin
uninstallation and contains the update script to populate current default
settings on the existing system when the new feature is introduced.

For security reason we have to avoid using library functions in upgrade
function, so we set defaults the blind way. At this point we do not expect
plugins to have individual messaging defaults presets anyway. The site
defaults are the same as were set for each user using
message_set_default_message_preferences function.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 14:06:56 +01:00
Ruslan Kabalin
f15097b5a3 MDL-27171 messages: remove excessive check from jabber send_message function
the parent send_message in messagelib.php does user/system configuration
checks before calling this method using the plugin instance.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
f8351d0927 MDL-27171 messages: do not keep empty messging configuration strings in user preferences
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
814e373576 MDL-27171 messages: upgrade user profile messaging preferences interface
Existing user messaging preferences should accomodate default settings and
permissions.  This also includes some changes to default outputs preferences.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
1d72e9d441 MDL-27171 messages: add default message outputs management interface
This introduces the new page where admin may change the permissions and
defaults for particular combination of message processors and providers.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
2f2137fca4 MDL-27171 messages: admin settings reordering
This includes:
 * most email settings go from general admin setings to email plugin settings
 * digestmailtime goes to mod/forum/settings.php
 * supportname, supportemail and supportpage go to Support contact page
 * all jabber settings go from general admin setings to jabber plugin settings

AMOS BEGIN
 MOV [jabberhost,admin],[jabberhost,message_jabber]
 MOV [configjabberhost,admin],[configjabberhost,message_jabber]
 MOV [jabberserver,admin],[jabberserver,message_jabber]
 MOV [configjabberserver,admin],[configjabberserver,message_jabber]
 MOV [jabberusername,admin],[jabberusername,message_jabber]
 MOV [configjabberusername,admin],[configjabberusername,message_jabber]
 MOV [jabberpassword,admin],[jabberpassword,message_jabber]
 MOV [configjabberpassword,admin],[configjabberpassword,message_jabber]
 MOV [jabberport,admin],[jabberport,message_jabber]
 MOV [configjabberport,admin],[configjabberport,message_jabber]
 MOV [digestmailtime,admin],[digestmailtime,forum]
 MOV [configdigestmailtime,admin],[configdigestmailtime,forum]
 MOV [allowusermailcharset,admin],[allowusermailcharset,message_email]
 MOV [configallowusermailcharset,admin],[configallowusermailcharset,message_email]
 MOV [mailnewline,admin],[mailnewline,message_email]
 MOV [configmailnewline,admin],[configmailnewline,message_email]
 MOV [noreplyaddress,admin],[noreplyaddress,message_email]
 MOV [confignoreplyaddress,admin],[confignoreplyaddress,message_email]
 MOV [sitemailcharset,admin],[sitemailcharset,message_email]
 MOV [configsitemailcharset,admin],[configsitemailcharset,message_email]
 MOV [smtphosts,admin],[smtphosts,message_email]
 MOV [configsmtphosts,admin],[configsmtphosts,message_email]
 MOV [smtpmaxbulk,admin],[smtpmaxbulk,message_email]
 MOV [configsmtpmaxbulk,admin],[configsmtpmaxbulk,message_email]
 MOV [smtpuser,admin],[smtpuser,message_email]
 MOV [configsmtpuser,admin],[configsmtpuser,message_email]
 MOV [smtppass,admin],[smtppass,message_email]
AMOS END

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
75c34c23a4 MDL-27171 messages: add message outputs management interface page
This introduces the page for management message outputs (processors) where
admin may enable/disable them and jump to configuration pages.
2011-05-27 13:49:28 +01:00
Ruslan Kabalin
21e6c82282 MDL-27643 messages: message_output_jabber should not send messges to emails
Jabber message should only be send if destination user has Jabber ID specified
in the profile. It should not use email if jabber id is not provided as it is
a performance breach.

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:44:49 +01:00
Ruslan Kabalin
cd8f78c88f MDL-27171 messages: add new methods on the message_output class
This introduces the new methods to the abstract class: is_system_configured
and is_user_configured that are supposed to return boolean depending whether
required configuration has been made on both system or user level
respectively. These methods return true by default and and be overriden by
being declared in the plugin class itself

Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>
2011-05-27 13:44:49 +01:00
Eloy Lafuente (stronk7)
b47dcdf0de MDL-27471 minor fixups 2011-05-23 12:42:15 +02:00
Andrew Davis (andyjdavis)
19c5532b5d MDL-26436 message: reviewed use of recordsets in messaging 2011-05-10 16:37:06 +08:00
Andrew Davis (andyjdavis)
d3a8184239 message MDL-26185 fixed the logic around email addy in user profile Vs in messaging preferences 2011-04-07 15:58:33 +08:00
Sam Hemelryk
62f7ce7989 PULL-574 MDL-26185 Reverted changes due failed testing + review 2011-04-06 16:33:47 +08:00
Sam Hemelryk
bbb79f47a7 messaging MDL-26185 Last minute fix of bug during integration, empty user preference causing error 2011-04-05 16:52:07 +08:00
Rossiani Wijaya
9d61d9ac6d MDL-26185: simplify the logic of email message output and removing email address cache 2011-04-01 16:55:37 +08:00
Andrew Davis (andyjdavis)
7e98f60bfb message MDL-26077 fixed up a problem with html tags being stripped out 2011-03-24 11:30:12 +08:00
Sam Hemelryk
9d61397181 Merge branch 'MDL-26607_search_error' of git://github.com/andyjdavis/moodle 2011-03-21 11:54:20 +08:00
Andrew Davis (andyjdavis)
b6e526585a message MDL-26607 fixed sql error when searching for users and limiting search to your courses 2011-03-16 10:58:07 +08:00
andyjdavis
25bd5c75ab message MDL-26433 refactored the constants in messaging 2011-03-06 22:03:49 +08:00
Petr Skoda
431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Eloy Lafuente (stronk7)
a8ccca5325 MDL-26404 messages - move textlib instance out from loop 2011-02-28 10:35:21 +01:00
Andrew
b2bce32ff0 message MDL-26404 trimming course short to prevent long names messing up the UI 2011-02-23 11:00:41 +08:00
Eloy Lafuente (stronk7)
d6211dce9a Merge branch 'MDL-25816_jabber_preference' of git://github.com/andyjdavis/moodle 2011-02-22 16:51:49 +01:00
Andrew Davis (andyjdavis)
6c0f13a5bc message MDL-25816 added safety checks in form processing 2011-02-22 16:05:01 +08:00
andyjdavis
731f8516bc message MDL-26435 removed commented out code 2011-02-17 11:03:18 +08:00
Eloy Lafuente (stronk7)
c04c06dc8e Merge branch 'MDL-25616_recent_messages' of git://github.com/andyjdavis/moodle
Conflicts fixed:
	message/index.php
	message/lib.php
2011-02-15 19:26:21 +01:00
andyjdavis
3a00a167c6 message MDL-26119 fixed up the logged URL 2011-02-15 14:24:13 +08:00
andyjdavis
bcab42daf2 message MDL-25616 adding recent conversations and recent notifications screens 2011-02-15 11:17:38 +08:00
Sam Hemelryk
ada93b58fb Revert "message MDL-26119 now logs when a user sends a message" because the log URL generated is incorrect
This reverts commit 88c9987e8909d345e72c31a93cbfda61005a3cc5.
2011-02-09 16:25:39 +08:00
andyjdavis
88c9987e89 message MDL-26119 now logs when a user sends a message 2011-02-03 13:37:01 +08:00
Eloy Lafuente (stronk7)
9f58e26db6 Merge branch 'w05_MDL-26046_20_noemailever' of git://github.com/skodak/moodle 2011-01-31 18:02:02 +01:00
Petr Skoda
8afc38bd39 Merge branch 'MDL-25708' of git://github.com/stronk7/moodle 2011-01-31 14:21:53 +01:00
Sam Hemelryk
2c1aa96042 MDL-26158 fixed xhtml problem 2011-01-31 12:09:43 +08:00
Petr Skoda
38d93cb0ff MDL-26046 prevent jabber messages wehn noemailever active
Standardise also the debug when emailing message.
2011-01-30 11:01:27 +01:00
Petr Skoda
31da70cce4 MDL-26158 fix form printing and processing 2011-01-29 18:04:50 +01:00
Eloy Lafuente (stronk7)
20222a3d7b MDL-25708 recordsets - fix message/lib.php 2011-01-25 19:59:00 +01:00
Andrew Davis
323409c54c message MDL-25240 switched personal messages from FORMAT_PLAIN to FORMAT_MOODLE 2010-12-09 06:39:53 +00:00
Andrew Davis
156205fc97 message MDL-25380 preventing html tags appearing in emailed messages when a message is sent to course participants 2010-11-24 04:17:52 +00:00
Andrew Davis
536a56e771 message MDL-25359 now specifying message recipient in IM email notification footer link to avoid weirdness on servers with autologin as guest turned on 2010-11-22 01:44:10 +00:00
Andrew Davis
35eed0ca48 message MDL-25267 improved the test for Jabber configuration 2010-11-18 07:17:19 +00:00
Andrew Davis
0d447fe634 message MDL-25264 removed another reference to $USER 2010-11-18 07:05:47 +00:00
Andrew Davis
fa8f03efbb message MDL-25264 made it possible to edit another user's message preferences 2010-11-18 05:28:51 +00:00
Andrew Davis
861fa9120d message MDL-25267 made jabber processor detect if it hasnt been configured 2010-11-18 02:59:23 +00:00
Andrew Davis
2846b9a6a2 message MDL-25240 made filters work when displaying messages 2010-11-17 06:36:26 +00:00
Andrew Davis
affefa8cc3 message MDL-25240 corrected index.php's description 2010-11-17 06:34:59 +00:00
Andrew Davis
943630292a message MDL-25148 fixed a bug with my popup availability bug fix 2010-11-11 09:17:47 +00:00
Andrew Davis
d38755249d message MDL-25148 using method on $PAGE to allow or disallow popup notifications 2010-11-11 06:11:43 +00:00