231 Commits

Author SHA1 Message Date
Tim Hunt
2daffca554 MDL-20636 Fix 30 TODOs 2011-02-24 17:47:51 +00:00
Tim Hunt
f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt
a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt
0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt
ba6438471b MDL-20636 Fix top of file boilerplate in mod/quiz. 2011-02-21 16:13:25 +00:00
Tim Hunt
e24ee794b2 MDL-20636 Convert the overview report. 2011-02-16 17:33:51 +00:00
Tim Hunt
2a3bdbf98e MDL-20636 Fix some minor bugs. 2011-02-16 14:06:12 +00:00
Tim Hunt
7ee80cab53 MDL-20636 Manual comment popup comment.php now works. 2011-02-09 20:29:59 +00:00
Tim Hunt
b2607ccc19 MDL-20636 Now the quiz review page works. 2011-02-09 20:18:24 +00:00
Helen Foster
82b15e2811 MDL-21250 capital letters removal
Also some spotted leading and trailing whitespace was removed from some
strings.
2011-01-27 16:24:30 +01:00
Tim Hunt
6577832390 quiz reports MDL-25206 Make it more obvious how to review the students responses. 2010-11-15 16:41:42 +00:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Tim Hunt
e09ca95eba quiz reports MDL-24603 columns in the overview report should be collapsible. 2010-11-01 14:36:58 +00:00
Sam Hemelryk
9db1789832 mod-quiz MDL-24418 Overflow fix allow horizontal scrolling of quiz results. 2010-09-29 03:02:18 +00:00
Petr Skoda
39790bd805 MDL-24321 switching to stdClass in /mod/ 2010-09-21 08:37:36 +00:00
Eloy Lafuente
8ad6765887 NOBUG quiz - overview & responses reports fixes 2010-09-17 01:07:17 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
d39ba35c34 quiz overview report MDL-17569 you should be see essay questions that need grading in the report. 2010-08-06 18:09:48 +00:00
Tim Hunt
ea906bb45c quiz reports MDL-21111 Quiz duration is reported in years if Time Finish is before Time Start
Suppose you have two load-balanced servers with badly-synchronised clocks, and
a student does a really quick quiz attempt.

Then it is possible that quiz_attemtp.timestart is greater than quiz_attemtp.timefinish.
And these columns are unsigned (on MySQL) so timefinish - timestart is compulted as
a number close to 2^64, which is about 42 times the age of the universe.

Do the subtraction in PHP instead. (But we still need to compute a duration columnin PHP
because sometimes we sort on it.)
2010-08-05 12:43:13 +00:00
Tim Hunt
f6c7f15883 quiz reports MDL-17388 tweak layout so more useful stuff fits on the first page.
In particular, I think you should be able to see at least the top of the table or results without scrolling, if your monitor is not too small.
2010-08-04 18:45:05 +00:00
Tim Hunt
f05fedc84d quiz overview report MDL-23377 can't delete attempts when there are no students.
Actually, reviewing this, I noticed some other security checks were missing, for
example we should ensure the users can only delete attempts belonging to this quiz!
2010-08-03 13:15:27 +00:00
Tim Hunt
07a2b2f0f0 quiz overview MDL-23377 whitespace cleanup, before doing the real fix. 2010-08-03 12:54:23 +00:00
Tim Hunt
a49cb927fd NOBUG more consistent use of URLs for the quiz reports. 2010-07-28 15:08:34 +00:00
Petr Skoda
3a11c09f5b MDL-21676 user_picture refactoring, reenabling email requirement - towards Gravatar support 2010-07-04 18:36:34 +00:00
Petr Skoda
a4cdd6d2c8 MDL-23068 removing obsolete $result and removing empty upgrade files that would be probably never used at all + minor cleanup/fixing 2010-07-04 10:27:56 +00:00
Tim Hunt
cd0a2ed882 quiz reports MDL-22847 Cannot delete quiz attempts when a group is selected. 2010-06-23 20:09:09 +00:00
Rossiani Wijaya
942308b74d Change the fields value (3rd parameter) from 'id' to 'u.id' 2010-05-21 03:50:00 +00:00
Rossiani Wijaya
ef7700377b fixed typo for parameter value from treu to true. 2010-05-21 02:33:43 +00:00
Tim Hunt
37b5b69f2e quiz reports MDL-22257: was loading the complete user record, when it only wanted userid.
On a coures with 16000 users, that is a very bad idea ;-)
2010-04-30 13:15:42 +00:00
David Mudrak
30c8dd34f7 MDL-15252 Re-committing all English strings exported from AMOS
From now on, all English strings use the new syntax. They are not
eval()'ed any more and the only valid placeholders are {$a} and
{$a->foobar}. No extra quotes escaping, dollar sign escaping and putting
double percent signs.

The modified files were exported from AMOS database repository in the
new syntax and were re-ordered by stringid. Standard GNU/GPL and PHPdoc
blocks are added. Where there was no copyright note so far, I added the
default one with Martin Dougiamas as the copyright holder.

Live long and prosper.
2010-04-10 14:01:45 +00:00
Petr Skoda
3a915b0667 MDL-21693 Dropping _utf8 suffix from language codes and folder names; enabling new string managers - please note the transition is not yet fully complete because we need to wait for git to recognize the renames in cvs 2010-04-10 07:24:56 +00:00
Tim Hunt
db77f4103c quiz reports: MDL-21688 Add missing sesskey checks. 2010-04-07 11:26:02 +00:00
David Mudrak
2064cbaa0f MDL-21694 Moving quiz language files into plugin scope 2010-03-29 15:22:08 +00:00
Petr Skoda
45c6bf6c89 MDL-21723 fixed rression, thanks Ben Dailey 2010-02-25 07:48:57 +00:00
Petr Skoda
9bf163146b MDL-20204 more html_link converstions 2010-02-11 18:50:55 +00:00
Petr Skoda
b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda
eb7880654f MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead 2010-01-17 09:37:30 +00:00
Petr Skoda
6ea66ff36c MDL-21233 obviously input tag writing does not belong into the moodle_url class, moving to html_writer instead + simplifying api 2010-01-17 09:06:55 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
812dbaf7d5 MDL-21198 improved/simplified $OUTPUT->user_picture() + regression fixes, performance fixes and detected performance problems when printing user avatars 2009-12-27 19:47:21 +00:00
Petr Skoda
3fac41f8dd MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:54 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
tjhunt
1dc12a6475 quiz reports: MDL-20316 per-question averages not shown with the quiz only allows one attempt.
Problem found thanks to OU testing. Fix thanks to Mahmoud Kassaie.
2009-09-18 13:42:23 +00:00
samhemelryk
7f7b8cdf26 quiz-report-overview MDL-20260 Fixed misnamed upgrade function and bumped version number 2009-09-14 04:19:28 +00:00
nicolasconnault
ca4b4f8f7c MDL-19813 Upgraded calls to link_to_popup_window() 2009-08-20 13:17:07 +00:00
nicolasconnault
39e3701904 MDL-19813 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:45:47 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
nicolasconnault
90cd54cb2a MDL-19813 Migrated calls to print_heading 2009-08-06 08:23:24 +00:00
nicolasconnault
e42f153c33 MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p 2009-07-31 09:30:11 +00:00
tjhunt
084f4c15be MDL-19882 Add remaining missing require_login-s before require_capability. 2009-07-20 09:46:53 +00:00