4399 Commits

Author SHA1 Message Date
Safat Shahin
3008edd366 MDL-71696 core_question: Implement question status change
This commit implements the status change pop up for a question
in the base view. This feature update will allow the change of
status of a question without creating a new version.
This commit also implements the status as a char rather than
an int value.
2022-02-03 22:22:50 +11:00
Marc-Alexandre Ghaly
b1ad75aef5 MDL-71696 qbank_preview: previewquestion plugin update
This commit implements versioning and associated features
in the previewquestion plugin. There have been some major
changes in the random question and version selection for
questions. This commit made those changes as well as added
some more features in the preview for version selection
and adds more behat coverage.
2022-02-03 22:22:50 +11:00
Safat Shahin
111951d861 MDL-71696 mod_quiz: quiz updates and behat coverage
The versioning changes will require some major changes
in the backup and restore of question bank and its
elements. This change introduces those changes to make
it compatible with the new world of versioning in question
bank. This commit also removes quiz_slots fields and
quiz_slot_tags table.
This commit will also introduce the versioning db
structure and some major changes to the quiz
and quiz attempts for the question, random
question and the view.
This commit implements the behat changes for versioning
in core question and associated locations.
2022-02-03 22:22:44 +11:00
Guillermo Gomez
c6cfca2a08 MDL-71696 core_question: Changes for versioning
This commit adds the changes in questiontype base
to work with new question tables and the new structure in the
databse. Also needed for versioning.
This implementation will also introduct the question status
which allows a question to be in draft and ready status.
I also introduces changes to the base view where it shows
the latest version of the questions. The view of versions
for a question is not implemented in this commit.
This implementation will also introduce changes in the core
qtype plugins to support versioning and the changed
db schema.
2022-02-03 22:22:44 +11:00
Guillermo Gomez
c34b89a3c2 MDL-71696 core_question: Implement new database schema
This commit implements the new database structure for
versioning in question. It also does the migration of
current data to the new structure.

Co-Authored-By: Safat Shahin <safatshahin@catalyst-au.net>
Co-Authored-By: Guillermo Gomez Arias <guillermogomez@catalyst-au.net>
2022-02-03 22:22:38 +11:00
Shamim Rezaie
05e5488b54 Merge branch 'MDL-73638' of https://github.com/paulholden/moodle 2022-01-25 13:15:26 +11:00
Eloy Lafuente (stronk7)
100bc51f1d MDL-73485 phpunit: externallib, generator and filter tescase names
All externallib_test, generator_test and filter_test classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to tests under testing/tests:

1) The core_testing component doesn't exist.
2) But testing/tests are allowed because there is a suite pointing to it (phpunit.xml).
3) So, the only possible namespace for them is "core".
4) And to avoid problems with other core testcases (under lib/tests)
   they have been renamed to have testing_xxxx as prefix.

Finally, also modified calendar/tests/events/events_test.php because it uses
some renamed (core_calendar_externallib_testcase => \core_calendar\externallib_test)
classes.
2022-01-21 19:48:23 +01:00
Paul Holden
d84e84b509 MDL-73638 qbank_usage: format activity/course names in usage modal. 2022-01-20 17:07:40 +00:00
Andrew Nicols
6670c04c23 Merge branch 'MDL-73476' of https://github.com/stronk7/moodle 2022-01-18 09:31:44 +08:00
Andrew Nicols
4f0b70ba6d Merge branch 'MDL-73316' of https://github.com/Chocolate-lightning/moodle 2022-01-17 14:16:12 +08:00
Eloy Lafuente (stronk7)
0c53a3dec8 MDL-73476 phpunit: events, external and search tescase names
All events_test, external_test and search_test classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to lib/external/tests/external_test.php:
- external is not a valid component
- hence, its only valid namespace is "core"
- also, it's testing lib/external/externallib.php
- hence, the file (and class) have been renamed to external_externallib_test.php
  (to avoid conflicts with other external_test that may exist in core)
2022-01-14 16:18:39 +01:00
Paul Holden
3c90926f05 MDL-69624 question: add missing test required library. 2022-01-13 15:08:02 +00:00
Mathew May
a9952cfe4c MDL-73316 navigation: Add homepagesecondary nav 2022-01-12 13:54:57 +08:00
Shamim Rezaie
7595736c9e Merge branch 'MDL-73456-master' of https://github.com/HuongNV13/moodle 2022-01-06 02:08:27 +11:00
Huong Nguyen
c789e1f4f0 MDL-73456 Questions: Question bank tertiary navigation is not correct
"Questions" is always selected even the user is editing the question category
2022-01-05 09:02:35 +07:00
Jun Pataleta
c0ec69a3aa Merge branch 'MDL-73352' of https://github.com/stronk7/moodle 2022-01-04 21:25:53 +08:00
abgreeve
f56ecc27f9 MDL-72930 navigation: Update to quiz and questionbank navigation.
Alterations here allowed the removal of renderables, and mustache
templates for quiz report navigation. The questionbank was also
updated to show injected navigation nodes from third party plugins.
2022-01-04 15:58:52 +08:00
Eloy Lafuente (stronk7)
511801cb46 MDL-73352 phpunit: lib_test and locallib_test testcase names
All lib_test and locallib_test classes:

- Namespaced with component (and API whenever makes sense).
- Fixed incorrect use statements with leading backslash.
- Changed code to point to global scope when needed or add new uses.
- All them passing individually.
- Complete runs passing too.

Special mention to tests under login/tests:

1) The core_login component doesn't exist.
2) But login/tests are allowed because there is a suite pointing to it (phpunit.xml).
3) So, the only possible namespace for them is "core".
4) And to avoid problems with other core testcases (under lib/tests)
   they have been renamed to have login_xxxx as prefix.
2021-12-30 16:21:42 +01:00
Shamim Rezaie
3baf9b8564 Merge branch 'master_MDL-73440' of https://github.com/mattporritt/moodle 2021-12-29 22:14:47 +11:00
Jun Pataleta
80c17cd2a0 Merge branch 'MDL-72701-master' of https://github.com/andrewnicols/moodle 2021-12-23 12:10:46 +08:00
Sara Arjona
ed0b14cbc4 Merge branch 'master_MDL-73350-statistics-column' of https://github.com/catalyst/moodle-MDL-70329 2021-12-22 16:07:36 +01:00
Matt Porritt
3101f3c7ca MDL-73440 qbank_customfields: Fix behat tags
Remove erroneous behat tag that was accidentally
left in after development was complete.
2021-12-22 06:52:48 +00:00
Andrew Nicols
bb9741d472 MDL-72701 unit tests: Fix broken @covers annotations 2021-12-21 09:24:00 +08:00
Eloy Lafuente (stronk7)
e4a2d9c1d4 MDL-73348 phpunit: normalize all privacy provider tests
As far as now all them have correct privacy level2 namespace:
- Move them to "privacy" subdir.
- Rename the files to "provider_test.php", this includes old
  privacy_test.php and privacy_provider_test.php files
- Rename the testcase to provider_test too (to match file name)

Also, change some relative paths and comments to point to new
locations.
2021-12-17 14:21:02 +01:00
Eloy Lafuente (stronk7)
57e6fb7ad9 MDL-73348 phpunit: privacy and privacy_provider testcase names
All privacy_test and privacy_provider_test classes:

- Namespaced with component\privacy.
- Fixed incorrect use statements with leading backslash.
- Changed code to point to global scope when needed.
- Renamed a few files to make all be privacy_test or privacy_provider_test.php
- All them passing individually.
- Complete runs passing too.
2021-12-17 14:21:02 +01:00
Safat Shahin
750fafeedd MDL-73350 qbank_statistics: Discrimination index column update
This implementation changes a little logic where the
discrimination index shows an empty row if there is
no attempts been made to a question rather than showing
very likely.
2021-12-15 15:02:16 +11:00
Ilya Tregubov
16a7c3a698 Merge branch 'MDL-72413-master-dec13' of https://github.com/peterRd/moodle 2021-12-13 09:35:14 +02:00
Peter Dias
4c3f5b8541 MDL-72413 questions: Disable the common activity header 2021-12-13 09:49:35 +08:00
Ilya Tregubov
6f44f008d8 Merge branch 'MDL-73278' of https://github.com/stronk7/moodle 2021-12-10 18:51:40 +02:00
Safat Shahin
3011aa5226 MDL-72553 qbank_customfields: object issues with customfield form validation 2021-12-10 09:46:38 +02:00
Eloy Lafuente (stronk7)
de66ba356e t checkout MOODLE_311_STABLE && git fetch https://github.com/mudrd8mz/moodle.git MDL-73201-311-enfix && git merge --no-ff FETCH_HEAD
Merge branch 'MDL-73201-master-enfix' of https://github.com/mudrd8mz/moodle
2021-12-09 23:18:03 +01:00
David Mudrák
46e2e2020d MDL-73201 lang: Use fixed strings in the tests, too 2021-12-09 19:56:02 +01:00
Helen Foster
558b4c826d MDL-73201 lang: Import fixed English strings (en_fix) 2021-12-09 19:53:10 +01:00
Ilya Tregubov
4de7faf7f1 Merge branch 'master_MDL-72553_qbank_quiz' of https://github.com/catalyst/moodle-MDL-70329 2021-12-08 09:58:00 +02:00
Eloy Lafuente (stronk7)
deb0e76eee MDL-73278 phpunit: Rename already namespaced classes to match file name
These are the only cases 100% safe to apply the renaming of the
testcase class names to match the file names.

All other cases are not safe, because they are missing namespace
and may enter into name conflicts. Adding namespaces is not as
simple as imagined because it implies to, also, add a good number
of modifications to core. See the issue for more details.
2021-12-07 23:54:29 +01:00
Matt Porritt
556e2f1aec MDL-72553 qbank_customfields: Add custom fields for question types
Custom fields can now be added to question types.
Site administrators can configure the custom fields and
filed types available. Teachers and question creators can
then use these fields for extra question metadata when
creating questions. Question creators can control if
the fields are displayed to students when they are
taking a quiz or not.
This features uses the core Moodle custom field API.

Co-Authored-By: Matt Porritt <mattp@catalyst-au.net>
Co-Authored-By: Safat Shahin <safatshahin@catalyst-au.net>
Co-Authored-By: Marc-Alexandre Ghaly <marc-alexandreghaly@catalyst-ca.net>
2021-12-07 18:32:41 +11:00
Sujith Haridasan
f000755ba1 MDL-71915 question: Update the behat tests
Update the behat tests to accommodate the
changes made for the tertiary navigation.
2021-12-06 10:26:40 +05:30
Sujith Haridasan
26eabeccf4 MDL-71915 question: Update the tertiary nav
Update the tertiary navigation activity for
question.
2021-12-06 10:26:40 +05:30
Andrew Nicols
c2a9fcfb18 MDL-73155 qtype_essay: Coding style fix 2021-12-02 14:41:55 +08:00
Andrew Nicols
ce7530053e Merge branch 'MDL-73155' of https://github.com/mkassaei/moodle 2021-12-02 14:41:52 +08:00
Luca Bösch
ff95ec1150 MDL-73147 questions: remove modulespecificbuttonscontainer class.
Also, in the bulk actions ui this aligns the bulk action button
properly.
2021-11-30 20:53:34 +01:00
Mathew May
f65b92577a MDL-70197 navigation: Update classic goutte tests 2021-11-30 08:13:49 +02:00
Mathew May
b983003e2e MDL-70197 navigation: Remove old navigation elements and migrate behat 2021-11-29 15:47:42 +08:00
Mahmoud Kassaei
66766eec24 MDL-73155 qtype_essay: Errors when Allow attachments is reset to 'No' 2021-11-26 13:51:05 +00:00
Safat Shahin
0805e387b7 MDL-72076 bulk actions ui: Implement bulk actions in qbank API
This implementation will introduce bulk actions qbank
plugins which can grab the selected question and perform
actions according to the selected option from dropdown
in the base view.

Co-Authored-By: Safat Shahin <safatshahin@catalyst-au.net>
Co-Authored-By: Matt Porritt <mattp@catalyst-au.net>
2021-11-22 11:35:21 +11:00
Safat Shahin
7ee798f679 MDL-72074 qbank_usage: Oracle phpunit issues resolve 2021-11-05 14:18:14 +02:00
Safat Shahin
8c004839c7 MDL-72074 qbank_usage: Behat issues resolve 2021-11-05 14:18:10 +02:00
Jun Pataleta
d690997151 Merge branch 'MDL-72679-master' of git://github.com/HuongNV13/moodle 2021-11-05 12:40:50 +08:00
Ilya Tregubov
73863ef3d9 Merge branch 'master_MDL-72074-usage' of https://github.com/catalyst/moodle-MDL-70329 2021-11-04 16:12:35 +02:00
Safat Shahin
8f06aa01dc MDL-72074 qbank_usage: Add usage plugin to core
This implementation will introduce the usage plugin
which shows qhich quizes are using this question,
number of attmpts and other information.

Co-Authored-By: Safat Shahin <safatshahin@catalyst-au.net>
Co-Authored-By: Matt Porritt <mattp@catalyst-au.net>
2021-11-05 00:36:36 +11:00