619 Commits

Author SHA1 Message Date
Tim Hunt
c159b07046 MDL-26767 responses report has the same unsigned subtract issue as overview (MDL-26416) 2011-03-11 07:37:29 +00:00
Tim Hunt
c26b7f0cfb MDL-20636 Fix upgrade problems. Thanks to James Brisland for his help. 2011-03-02 17:42:58 +00:00
Tim Hunt
7916ea127e MDL-20636 Fix install breakage. 2011-03-02 17:42:56 +00:00
Tim Hunt
3c6185e979 MDL-20636 Move restart preview button into the quiz nav block & remove unnecessary titles.
Also, remove automatic redirects to the quiz edit page. Show a message and a button instead.
2011-02-25 12:12:09 +00:00
Tim Hunt
2daffca554 MDL-20636 Fix 30 TODOs 2011-02-24 17:47:51 +00:00
Tim Hunt
446166a628 MDL-20636 Minor bug-fixes 2011-02-24 12:01:37 +00:00
Tim Hunt
f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt
a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt
0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt
ba6438471b MDL-20636 Fix top of file boilerplate in mod/quiz. 2011-02-21 16:13:25 +00:00
Tim Hunt
05d2a8b7f1 MDL-26416 avoid subtracting two unsigned ints, which breaks MySQL since 5.5.5. 2011-02-18 16:27:49 +00:00
Tim Hunt
19a9f1124d MDL-26416 avoid subtracting two unsigned ints, which breaks MySQL since 5.5.5. 2011-02-18 14:10:06 +00:00
Tim Hunt
bbc2d0ba31 MDL-26416 quiz overview report, clean up the code before making the real bug fix.
Cleaning up the code like this will make the real bug-fix easier to understand.
2011-02-18 14:10:04 +00:00
Tim Hunt
e24ee794b2 MDL-20636 Convert the overview report. 2011-02-16 17:33:51 +00:00
Tim Hunt
2a3bdbf98e MDL-20636 Fix some minor bugs. 2011-02-16 14:06:12 +00:00
Tim Hunt
04853f273a MDL-20636 Convert quiz statistics report. 2011-02-15 17:22:31 +00:00
Tim Hunt
9b40c540ee MDL-20636 Responses report mostly working. 2011-02-14 17:57:47 +00:00
Tim Hunt
cf3b65686a MDL-20636 Finished conversion of the manual grading report. 2011-02-14 17:57:44 +00:00
Tim Hunt
adaad5f224 MDL-20636 Fix install 2011-02-13 07:34:32 +00:00
Tim Hunt
2709ee45d3 MDL-20636 Working on converting the reports, starting with the manual grading report. Very much a work-in-progress.
Also, some random bug-fixing.
2011-02-11 18:47:08 +00:00
Tim Hunt
dc3826eed7 MDL-26338 fix mixed types in quiz reports SQL. This was breaking Oracle 2011-02-09 20:48:21 +00:00
Tim Hunt
7ee80cab53 MDL-20636 Manual comment popup comment.php now works. 2011-02-09 20:29:59 +00:00
Tim Hunt
b2607ccc19 MDL-20636 Now the quiz review page works. 2011-02-09 20:18:24 +00:00
Tim Hunt
f255782339 MDL-20636 You can now create a quiz, and edit the settings.
Little else works, but this is just the first step.
2011-02-09 20:18:06 +00:00
Tim Hunt
74c479f212 MDL-20636 Merge branch 'master' into qe2_wip
Conflicts:
	lib/questionlib.php
	question/type/calculated/lang/en/qtype_calculated.php
	question/type/questiontype.php
2011-02-03 11:18:40 +00:00
Tim Hunt
5f11e00db1 MDL-26242 quiz reports. No students in course => get_in_or_equal doesn't like empty arrays error 2011-02-02 16:40:14 +00:00
Helen Foster
82b15e2811 MDL-21250 capital letters removal
Also some spotted leading and trailing whitespace was removed from some
strings.
2011-01-27 16:24:30 +01:00
Petr Skoda
99d19c13ae MDL-25855 some more missing filelib includes 2011-01-23 18:34:41 +01:00
Tim Hunt
cce1b6556c MDL-20636 Fix a bunch of minor errors in the truefalse preview.
Most significantly, all behaviours now work.
2011-01-13 18:35:46 +00:00
Tim Hunt
6577832390 quiz reports MDL-25206 Make it more obvious how to review the students responses. 2010-11-15 16:41:42 +00:00
Tim Hunt
a9efae50e3 question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.
There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
2010-11-11 17:32:25 +00:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Tim Hunt
e09ca95eba quiz reports MDL-24603 columns in the overview report should be collapsible. 2010-11-01 14:36:58 +00:00
Tim Hunt
fde29fa59c quiz & qbank MDL-24453 some more return URLs that I missed the first time.
Also, fix a double-escaping bug when cancelling the form.
2010-10-18 15:53:54 +00:00
Sam Hemelryk
9db1789832 mod-quiz MDL-24418 Overflow fix allow horizontal scrolling of quiz results. 2010-09-29 03:02:18 +00:00
Tim Hunt
4033062b33 quiz statistics report NOBUG   was not being escaped twice in Analysis of responses of some qtypes. 2010-09-22 15:35:27 +00:00
Petr Skoda
39790bd805 MDL-24321 switching to stdClass in /mod/ 2010-09-21 08:37:36 +00:00
Eloy Lafuente
8ad6765887 NOBUG quiz - overview & responses reports fixes 2010-09-17 01:07:17 +00:00
Petr Skoda
0f21a964a5 MDL-24079 fixing recent regressions caused by api changes in tablelib; sorry I did not find the problem earlier 2010-09-05 12:35:51 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
d39ba35c34 quiz overview report MDL-17569 you should be see essay questions that need grading in the report. 2010-08-06 18:09:48 +00:00
Sam Hemelryk
73eba4be68 navigation MDL-20276 Fixed use of override_active_url. 2010-08-06 05:49:47 +00:00
Tim Hunt
c68287a928 mod_quiz / navigation MDL-20276 replace make_active with override_active_url
It doesn't work, but I am committing it, so Sam H can take a look.
2010-08-05 18:15:17 +00:00
Tim Hunt
fc3472d5ed quiz manual grading NOBUG fix performance issue with printing the user picture. 2010-08-05 15:35:45 +00:00
Tim Hunt
ea906bb45c quiz reports MDL-21111 Quiz duration is reported in years if Time Finish is before Time Start
Suppose you have two load-balanced servers with badly-synchronised clocks, and
a student does a really quick quiz attempt.

Then it is possible that quiz_attemtp.timestart is greater than quiz_attemtp.timefinish.
And these columns are unsigned (on MySQL) so timefinish - timestart is compulted as
a number close to 2^64, which is about 42 times the age of the universe.

Do the subtraction in PHP instead. (But we still need to compute a duration columnin PHP
because sometimes we sort on it.)
2010-08-05 12:43:13 +00:00
Tim Hunt
f6c7f15883 quiz reports MDL-17388 tweak layout so more useful stuff fits on the first page.
In particular, I think you should be able to see at least the top of the table or results without scrolling, if your monitor is not too small.
2010-08-04 18:45:05 +00:00
Tim Hunt
7383c63398 quiz statistics report NOBUG remove debug code. Sorry. 2010-08-04 16:25:24 +00:00
Tim Hunt
24f17d7588 quiz responses report MDL-23377 responses report needs to be fixed in HEAD as well as overview. 2010-08-04 15:05:31 +00:00
Tim Hunt
f05fedc84d quiz overview report MDL-23377 can't delete attempts when there are no students.
Actually, reviewing this, I noticed some other security checks were missing, for
example we should ensure the users can only delete attempts belonging to this quiz!
2010-08-03 13:15:27 +00:00
Tim Hunt
07a2b2f0f0 quiz overview MDL-23377 whitespace cleanup, before doing the real fix. 2010-08-03 12:54:23 +00:00