473 Commits

Author SHA1 Message Date
Michael Hawkins
0be294c005 MDL-59429 roles: Log add/remove admin users. 2018-06-15 10:22:54 +08:00
Mark Nelson
df1714f25a MDL-62228 core: remove unnecessary context check in privacy providers 2018-05-14 18:33:29 +08:00
David Monllao
5d2dd881e3 Merge branch 'MDL-61943-master' of git://github.com/cescobedo/moodle 2018-05-08 16:43:50 +02:00
cescobedo
a69de9ba05 MDL-61943 core_role: Add privacy implementation for core_role 2018-05-08 13:40:30 +02:00
Bas Brands
29587cc9da MDL-62274 Theme boost: bootstrap classes define roles form 2018-05-07 14:36:48 +02:00
Jun Pataleta
6a51b279ec MDL-61462 admin_roles: Point back to roles link to the correct URL 2018-02-16 10:32:44 +08:00
Mark Nelson
e4d9eff640 MDL-61224 core_role: prevent short name from exceeding 100 chars 2018-01-16 18:14:42 +08:00
Andrew Hancox
64cd459648 MDL-50666 core: Rename allow_ACTION to core_role_set_ACTION_allowed 2017-12-19 13:53:23 +13:00
Andrew Hancox
a63cd3e2ca MDL-50666 core: Add function get_viewable_roles to set role visibility 2017-12-19 13:53:23 +13:00
Andrew Nicols
5ded18d5a8 MDL-60031 admin: Move risk longtext to pix title 2017-09-06 10:23:48 +08:00
Jean-Roch Meurisse - University of Namur - Belgium
509679e203 MDL-59263 roles: Wrong order of parameters in calls to pix_icon function 2017-06-16 10:02:52 +08:00
Simey Lameze
fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Damyon Wiese
663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Rajesh Taneja
ccb2a6a5f8
MDL-56581 behat: Use proper steps to navigate to Permissions 2016-12-21 12:51:17 +08:00
Jes Ackland-Snow
e985a29cdf MDL-56581 Roles: Permissions override screen not inherited styling 2016-12-20 12:09:01 +00:00
Marina Glancy
b1e5624ad9 MDL-56586 blocks: Fix mess with links to permissions
problem 1: links to blocks permissions changes were missing in boost
problem 2: when modifying link from dashboard user is returned to profile ('returnurl' passed but not respected)
problem 3: link to check permissions missing from category management page
fix: instead of respecting both 'return' and 'returnurl' parameter use only 'returnurl'
fix: use 'popup' layout when modifying permissions for a block
2016-11-24 14:24:59 +08:00
Damyon Wiese
2f3f8e45da MDL-56657 admin: Style all admin/role pages for boost 2016-11-14 15:11:15 +08:00
Simey Lameze
2e1c739a28 MDL-56652 core_roles: Add BS4 styling to define roles form 2016-11-10 16:46:54 +08:00
David Monllao
1370e6ca52 Merge branch 'MDL-56149-master' of git://github.com/damyon/moodle 2016-11-07 07:47:27 +08:00
Dan Poltawski
f99e7ef116 Merge branch 'mdl55456-master' of https://github.com/tlock/moodle 2016-11-01 21:26:05 +00:00
Simey Lameze
0051b08560 MDL-56651 core_role: add styling to submit buttons 2016-11-01 09:40:53 +08:00
Damyon Wiese
a2d9a89f5a MDL-56149 permissions: Alignment of icons should not wrap
/admin/roles/permissions.php?contextid=2 the icons should not wrap.
2016-10-31 16:24:11 +08:00
Tim Lock
0ee41475ae MDL-55456 course: set context for category ajax requests 2016-10-18 12:50:21 +10:30
Mark Johnson
4d9036d6eb MDL-55041 roles: Fix JSON parsing in permission manager 2016-07-01 14:54:01 +01:00
Russell Smith
1fcf0ca8a5 MDL-35628 performance: Remove dirname() where possible.
dirname() is a slow function compared with __DIR__ and using
'/../'.  Moodle has a large number of legacy files that are included
each time a page loads and is not able to use an autoloader as it is
functional code.  This allows those required includes to perform as
best as possible in this situation.
2016-06-10 08:06:49 +10:00
Cameron Ball
bb30944f49 MDL-54010 roles: Specify encoding for escaped export data 2016-05-26 10:31:28 +08:00
Nigel Cunningham
d50a9a9d30 MDL-54010 roles: Fix missing HTMLspecialchars in role export code.
Role name and description fields are currently not escaped when
exporting a role. This results in an unusable file when characters
such as ampersands are used in a name or description. Fix this by
using htmlspecialchars on both fields.

Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>
2016-05-26 10:31:28 +08:00
Andrew Nicols
d5f05f77f3 Merge branch 'MDL-53010-master' of git://github.com/lameze/moodle 2016-03-08 14:34:17 +08:00
David Monllao
f53b50e628 Merge branch 'MDL-52984' of https://github.com/rushi963/moodle 2016-03-08 14:04:07 +08:00
Simey Lameze
73ea963215 MDL-53010 core_role: add missing coursecatlib include 2016-02-29 14:25:45 +08:00
Rajesh Taneja
660b0f0eed MDL-50484 core_lib: No need to cache action_icons
action_icons should not be cached as they
have a unique id and if cache is used then
all icons will have same id.
Other solution is to replace id with some static
but it's not worth a cache for a page, so
removing cache
2016-02-19 14:00:04 +08:00
Rushikesh
ea4f8f9e49 MDL-52984 Roles : Logs store newly created role's id 2016-02-16 00:45:26 +05:30
Dan Poltawski
8f2c99d610 MDL-52370 role: purge coursecontacts when role is edited
This is perhaps a bit more brutal purge than you'd like, but it only
affects coursecat role edits.
2015-12-01 13:14:14 +00:00
Marina Glancy
2ff1f05183 MDL-51357 roles: fix table layout after MDL-38763 2015-09-09 13:07:11 +08:00
Martin Mastny
2493568970 MDL-38763 core_role: AMD module for managing permissions 2015-09-01 07:31:58 +02:00
Marina Glancy
2bf60e22f7 MDL-50222 admin: do not use deprecated print_textarea() 2015-06-08 17:10:58 +08:00
Damyon Wiese
46a2fbc4b7 MDL-49412 Navigation: Remaining behat fixed for nav branch
Behat is passing after this change.

Part of MDL-45774.
2015-04-10 17:19:28 +08:00
Adrian Greeve
45367bdf0c MDL-49688 navigation: First review fixes and version bump.
Part of MDL-45774.
2015-04-10 17:18:03 +08:00
Adrian Greeve
f495187da7 MDL-48935 navigation: Update the user nav breadcrumbs.
Part of MDL-45774.
2015-04-10 17:17:07 +08:00
Adrian Greeve
880c50731f MDL-48930 navigation: Using user headers in user pages.
Pages that are percieved to be in a user context are now
using a user context for the header.

Part of MDL-45774
2015-04-10 17:17:07 +08:00
Rod Norfor
2350e7f24d MDL-48914 admin: check maxuserperpage in existingroleholders->find_users 2015-01-23 16:02:27 +00:00
Brian Barnes
ae00e55a00 MDL-48532 core_roles: Set correct heading on user roles page 2014-12-09 14:28:29 +13:00
Andrew Nicols
64e7aa4de1 MDL-28286 JavaScript: Convert all uses of M.str to M.util.get_string 2014-12-01 08:32:04 +13:00
Tim Hunt
482ca72089 MDL-47426 assign local roles: rewrite query for better performance.
This is an extremely dangerous query, because it includes the user
table twice, along-side two other potentially large tables,
role_assignments and user_enrolments.

The solution is to rewrite the query so that:

1. The subquery is JOINed, not WHERE ... INed. Typically query
   optimisers handle the JOIN case better.

2. Before the join was role-assignments <-> users <-> subquery.
   That is, everything was linked to u.id.

   Now the linking is role-assignments <-> subquery <-> users,
   so the SELECT DISTINT eu1_u.id FROM {enrolled users} is central.
   That seems to send a strong hint to the query optimiser about
   a good order to execute the query.
2014-10-02 17:10:40 +01:00
Dan Poltawski
772d658f1d Merge branch 'MDL-45596-master' of git://github.com/FMCorz/moodle 2014-07-08 10:50:55 +01:00
Frederic Massart
af2a1e4e33 MDL-45596 roles: Escape filter value before using it in form field 2014-07-04 11:49:11 +08:00
David Monllao
c16970ead0 MDL-45833 event: Removing courseid as the context is higher than course context 2014-06-27 11:25:14 +08:00
Sam Hemelryk
bba9c3bcf8 Merge branch 'master_MDL-45623' of git://github.com/totara/moodle 2014-05-26 09:58:48 +12:00
Simon Coggins
9811cb650c MDL-45623: Fix assigned users count on role delete confirmation page 2014-05-20 10:01:00 +12:00