84 Commits

Author SHA1 Message Date
Petr Skoda
9aa09d8fed MDL-32251 more E_STRCT fixes 2012-03-29 16:29:29 +02:00
Petr Skoda
e2bb3c9275 MDL-32094 some more E_STRICT fixes 2012-03-18 20:40:20 +01:00
Tim Hunt
9d0ac0ffbb MDL-27143 question bank: questions not saved when deleting a category.
Based on a fix by Nikhil Gupta.
2011-12-09 18:03:52 +00:00
Tim Hunt
e0736817f0 MDL-20636 fix some more coding style issues in the question code. 2011-05-20 18:50:41 +01:00
Tim Hunt
9c197f4445 MDL-20636 Fix some more codechecker issues. 2011-05-14 22:53:25 +01:00
Tim Hunt
5e8a85aa64 MDL-20636 Massively reduce the number of references to quiz in the question code.
This mostly involves moving lang strings around, but I don't have time to do an AMOS script now.
2011-02-23 18:53:50 +00:00
Tim Hunt
a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt
017bc1d9f3 MDL-20636 Fix @package names in question/behaviour, question/engine and question top level. 2011-02-22 20:50:18 +00:00
Tim Hunt
d3603157bf MDL-20636 Add @package and GPL boiler-plate to files in /question. 2011-02-22 19:59:12 +00:00
Tim Hunt
0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt
f9b0500f7f MDL-20636 Quiz editing now works, as does the random question type.
However, all this needs more testing.

Also, a bit of a purge of training whitespace and global .
2011-02-10 20:50:18 +00:00
Tim Hunt
94dbfb3a82 quiz editing MDL-24750 The Add random button should also let you add questions from an existing category.
Also includes a fix for MDL-24749 by Sam Hemelryk. Thanks Sam.

This commit also includes a certain amount of code cleaning up.
2010-11-22 09:52:42 +00:00
Tim Hunt
5d548d3e0a question bank MDL-24995 clean up a lot of deprecated code to do with moving questions around.
This should also fix MDL-25172, MDL-23021 and MDL-23073. In other words, moving questions between categories should now work.
2010-11-11 21:54:22 +00:00
Tim Hunt
20d891228f MDL-24256 question category editing was messed up.
The unerlying problem seemed to be too many uses of pass-by-reference in listlib, where it was not necessary.
In investigating this code, I ended up doing a fair bit of cleaning up. Apologies that it leads to an unclear changeset.
2010-11-02 18:38:50 +00:00
Petr Skoda
7f38934243 MDL-24321 switching to stdClass in /question/ - I am sure Tim will be very happy 2010-09-21 08:20:46 +00:00
David Mudrak
5fcefc9728 MDL-21695 question: replaced help files with new help strings
AMOS BEGIN
 HLP question/categoryparent.html,[parentcategory_help,core_question]
 HLP question/categories.html,[editcategories_help,core_question]
 HLP quiz/export.html,[exportquestions_help,core_question]
 HLP quiz/exportcategory.html,[exportcategory_help,core_question]
 HLP quiz/exportcategory.html,[exportcategory_help,core_question]
 HLP quiz/importcategory.html,[importcategory_help,core_question]
 HLP quiz/matchgrades.html,[matchgrades_help,core_question]
 HLP quiz/quiz/stoponerror.html,[stoponerror_help,core_question]
 HLP qtype_multichoice/multichoiceshuffle.html,[shuffleanswers_help,qtype_multichoice]
 HLP quiz/matchshuffle.html,[shuffle_help,qtype_match]
 HLP quiz/generalfeedback.html,[generalfeedback_help,mod_quiz]
AMOS END
2010-08-02 21:24:32 +00:00
Petr Skoda
3e0e25efd1 MDL-22060 fixed $a in string to match new rules
AMOS START
 REM fixed $a[] in [cannotinsertquestioncatecontext, core_question]
AMOS END
2010-04-11 16:45:55 +00:00
Petr Skoda
8afba50b84 MDL-21233 get_query_string() is definitely not recommended in new code, instead use moodle_url constructors with proper parameters; removed some more legacy url concatenation operations; realized out_action is not needed often, because we shoudl pass arounf moodle_url instances instead of old url strings 2010-01-17 10:54:13 +00:00
Petr Skoda
b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda
eb7880654f MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead 2010-01-17 09:37:30 +00:00
Petr Skoda
4bcc51185c MDL-21217, MDL-21198 simplified/improved outputlib help icon related apis + several fixed regresions 2009-12-30 15:19:55 +00:00
Petr Skoda
b5d0cafc6f MDL-20787 final switch to new $OUTPUT->pix_url() - yay! 2009-12-16 21:50:45 +00:00
Tim Hunt
85edde5c90 question bank - MDL-20545 need a separate language string for edit question category, as opposed to edit course category. 2009-11-19 17:46:15 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
samhemelryk
7f09335135 output MDL-19799 Fixed up some set_url calls as well as fixing some regressions caused by recent upgrades 2009-10-21 04:23:35 +00:00
samhemelryk
1d58b567be question MDL-19820 Replaced deprecated functions 2009-09-25 04:16:27 +00:00
nicolasconnault
beb677cda6 MDL-19820 Converted print_box* to $OUTPUT->box* 2009-08-10 05:01:23 +00:00
nicolasconnault
723d610c91 MDL-19820 Migrated calls to print_heading 2009-08-06 08:26:06 +00:00
nicolasconnault
e42f153c33 MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p 2009-07-31 09:30:11 +00:00
tjhunt
6acbb3192b Remove deprecated function call. 2009-07-22 07:05:57 +00:00
tjhunt
42d5737a94 MDL-19690 fix some breakage. 2009-07-02 12:35:13 +00:00
tjhunt
c8873c496b MDL-19690 - eliminate the $OUTPUT->initialise_deprecated_cfg_pixpath horrible hack.
Replace $CFG->pixpath with $OUPTUT->old_icon_url(...) instead.
2009-07-02 11:23:47 +00:00
tjhunt
a5cb8d6987 MDL-19077 - Finish eliminating customcorners-specific code in core.
The custom-corners-specific code now in theme/customcornser/renderers.php
and lib/deprecatedlib.php.

Also, $CFG->pixpath is now causing more problems than ever. If it is
giving your problems, please call $OUTPUT->initialise_deprecated_cfg_pixpath()
as a temporary fix. As you can imagine, we are thinking about a better
long-term fix, which is why that method as a silly, and easy to grep name.
2009-06-29 08:17:31 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
c65921d422 Question categories. Move code to a more appropriate place. 2009-03-05 04:19:33 +00:00
tjhunt
3cac440b76 quiz editing: MDL-18173 Make clear in the UI whether a random question selects from subcategories or not. 2009-02-24 05:16:23 +00:00
tjhunt
df4e224454 question bank: MDL-14434 Cannot edit the only question category in a context. 2008-11-27 11:50:29 +00:00
tjhunt
21cbf9da8b question bank: MDL-17078 Error after deleting a question category. 2008-11-27 07:30:17 +00:00
pilpi
4070210d93 quiz editing: MDL-17293 Added a default value to avoid error messages
Added a default value  to the function that passes a page number to avoid error messages.
2008-11-22 17:30:12 +00:00
pilpi
5c8505d034 quiz editing: MDL-17293 changed how the page number to add on is passed to the form for creating a random question 2008-11-22 16:32:36 +00:00
pilpi
9fa363896e quiz editing: MDL-17293 removed two lines of code that did nothing good but some bad, showing an extra form where it should have not been. 2008-11-22 15:52:17 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
tjhunt
41c96651b5 question bank category editing: To be honest, I can't rememeber exactly what bug this fixes, but it was a problem I found and fixed while preparing to demo stuff at the Brisbane Moodle Moot. In the process of fixing whatever issue it was (I think it was something to do with the permissions checks in some cases) I cleaned to code up and made it easier to understand, and I trust myself, so I am checking this in. 2008-10-23 09:23:52 +00:00
tjhunt
9fc523e0be MDL-12814 typo in CSS class name. 2008-09-05 03:38:42 +00:00
skodak
294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
nicolasconnault
f34488b2e6 MDL-15102 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing. 2008-06-06 14:43:15 +00:00
skodak
534792cd82 MDL-14679 removed all instances of get_records_select_menu() 2008-06-01 15:52:12 +00:00
dongsheng
64e71d27b6 "MDL-14129, fix print_error" 2008-05-21 06:04:30 +00:00
tjhunt
949c59ace0 MDL-14928 - Adding random questions from a category with an apostrophe in the name does not work. Stupid bloody addslashes. Roll on dmllib 2.0. 2008-05-20 17:09:40 +00:00
tjhunt
e4cdf3fb2c MDL-10899 - followup - need to move random questions too. 2008-05-12 15:59:05 +00:00