Add the `.nofilter` class for activity icons when the icon URL's
`filtericon` parameter is not set, so they get rendered as they are on
the context header on the activity page.
* Apply the filter CSS property only to activity icons
that don't have the ".nofilter" class. This will allow
activities with non-SVG icons to be rendered as they are.
- It was a mistake to assume the listbox is always within
combobox.parentElement
- Take into account that the popup of the combobox is not necessarily a
listbox
- Update combobox fix so that it also work with comboboxes that are not
select-menu
- Update combobox fix so that it also support editable comboboxes
- Update click listener to take into account that the event's target
might be one of the option element
- Having a hidden input element for comboboxes was not an ARIA
requirement and was added by us. I added data-input-element to the
combobox element to specify the input element related to it.
The new Font Awesome version needs some changes in the way icons
are displayed from SCSS files:
- The atribute 'content: "\xxx"' needs to be converted to
'content: fa-content("\xxx")'
- The style must be declared. The regular is used by default, so all the
solid icons needs to add '@extend .fa-solid'
- @include fa-icons() is not required anymore (if used, the icons
are not displayed properly).
This patch updates the Font Awesome library version from 4.7 to 6.3.0.
The readme_moodle.txt has been updated properly because the new version
works slightly different.
There is a file to add backward compatibily to version 6 files (shim).
More information about how to upgrade from 4 to 6 can be found in
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4
Although a few icons have been renamed in Moodle 6, as the new version
is compatible with v4 icons, for now the references to the old icons
(fa fa-xxxx --> fa-solid fa-xxxx) haven't been changed yet.
A separate issue will be created to update them in the future and
review if some new icons can be used too.