Tim Hunt
37b5b69f2e
quiz reports MDL-22257: was loading the complete user record, when it only wanted userid.
...
On a coures with 16000 users, that is a very bad idea ;-)
2010-04-30 13:15:42 +00:00
Tim Hunt
db77f4103c
quiz reports: MDL-21688 Add missing sesskey checks.
2010-04-07 11:26:02 +00:00
Petr Skoda
b9bc201962
MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!)
2010-01-17 09:50:55 +00:00
Petr Skoda
eb7880654f
MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead
2010-01-17 09:37:30 +00:00
Petr Skoda
6ea66ff36c
MDL-21233 obviously input tag writing does not belong into the moodle_url class, moving to html_writer instead + simplifying api
2010-01-17 09:06:55 +00:00
Petr Skoda
a685593466
MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions
2010-01-16 15:39:56 +00:00
Petr Skoda
3fac41f8dd
MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup
2009-11-04 11:57:54 +00:00
Petr Skoda
aeb15530b8
MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup
2009-11-04 11:57:52 +00:00
nicolasconnault
825116fb22
MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify
2009-08-18 05:16:08 +00:00
nicolasconnault
90cd54cb2a
MDL-19813 Migrated calls to print_heading
2009-08-06 08:23:24 +00:00
nicolasconnault
e42f153c33
MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p
2009-07-31 09:30:11 +00:00
tjhunt
eacb462e38
quiz reports: MDL-19205 Improved tooltips on individual question grades.
2009-06-05 06:54:42 +00:00
Francois Marier
200164446a
Fix drift with CVS
2009-03-11 13:16:54 +00:00
tjhunt
96c7d771df
quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt. Merged from MOODLE_19_STABLE.
2009-01-14 07:08:02 +00:00
jamiesensei
bbf4f440ee
MDL-15326 "allow for per report capabilities to replace mod/quiz:viewreports"
2008-11-25 12:11:27 +00:00
tjhunt
9101efd312
cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.
...
For something that has been deprecated for over two years, they were still used in a lot of places!
2008-11-13 08:40:57 +00:00
tjhunt
739b07112e
MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
...
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
3d6de8770d
MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up.
2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476
MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0.
2008-09-15 13:38:31 +00:00
tjhunt
337fa7a0ef
MDL-16263 - followup - fix notices.
2008-08-29 11:30:16 +00:00
jamiesensei
570e5e029a
MDL-16041 "Grade of new tests are zero!" no longer displaying graphs of grades for ungraded quizzes.
2008-08-15 10:24:04 +00:00
jamiesensei
f29e6691a7
MDL-15972 "Make ability to list regrades dependent on permission" fixed a problem showing some of the regrade interface to users who do not have permission to regrade.
...
MDL-15960 "Overview report does not work correctly with groups" Fixed a problem that group mode was not working as the logic selecting the attempts mode was erroneously showing the all attempts mode.
MDL-15958 "Error on selecting to hide marks for each question" problem with trying to sort on question grades when grades not displayed fixed.
MDL-15953 "Summary chart to show in 5% ranges please" allowed the graph to show up to or equal to 20 bands, instead of just up to 20.
MDL-14201 "Summary graph" showing two graphs now as it was felt that when there were few students in a group compared with all the students who took a quiz then it would be difficult to see the data for the group.
2008-08-15 09:59:55 +00:00
tjhunt
f88fb62c40
MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors.
2008-08-15 06:42:38 +00:00
jamiesensei
daae98e118
MDL-14216 "change query to work on Postgres." - some adjustments to make it work on mysql again too.
2008-07-24 16:10:26 +00:00
tjhunt
1e98b864e5
MDL-14216 - change query to work on Postgres.
2008-07-24 15:34:15 +00:00
tjhunt
23277af8f1
MDL-14216 - change query to work on Postgres.
2008-07-24 12:58:05 +00:00
jamiesensei
16de0ed32b
MDL-15732 "question_load_questions has changed in HEAD and expects an array instead of a comma seperated list of question ids"
2008-07-21 13:06:57 +00:00
jamiesensei
6559096f2c
MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code."
2008-07-21 09:06:46 +00:00
jamiesensei
55caa1d5dc
MDL-15198 "non-standard sql in reportlib.php" using CASE statement to wrap logic in fields list
2008-07-20 12:52:14 +00:00
jamiesensei
375381a006
MDL-15718 "overview report slow for large data sets - print_user_picture queries the db if only provided with a userid"
2008-07-20 11:56:35 +00:00
jamiesensei
b6943d3731
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" if condition around buttons to not output them when downloading table data.
2008-07-15 07:22:26 +00:00
jamiesensei
57d6a267a6
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" oops. Fixing notice about $this->context not being set in overview report table.
2008-07-11 07:48:25 +00:00
jamiesensei
314b8a20d4
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" added some if conditions to not display regrade buttons if the user doesn't have the permission to grade.
2008-07-11 07:39:11 +00:00
jamiesensei
98f38217bb
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade"
2008-07-11 07:27:14 +00:00
jamiesensei
334edb71c1
MDL-15198 "non-standard sql in reportlib.php" fixed this with new sql that does not require a limit clause.
2008-06-30 11:53:47 +00:00
jamiesensei
7660aa80e0
MDL-15393 "show group name in drop down select for what to show in report" AND MDL-15394 "disable showing 'all attempts' and remove option from drop down box in form if there is a group selected"
2008-06-24 16:36:44 +00:00
jamiesensei
d86bbdd6f7
MDL-15309 "Switch role to student, take quiz, can't delete attempt" switching default of overview report to show all attempts whether or not the attempt is for a currently enrolled student.
...
Merged from 1.9 branch.
2008-06-24 12:32:23 +00:00
jamiesensei
abe67b24a7
MDL-15378 "Quizz: sql error if not student in the group" now have extra logic to not display the table if there are no students at all or in current group - still displaying form and graph were appropriate.
...
Merged from 1.9 branch
2008-06-24 12:18:47 +00:00
jamiesensei
c386eaa3df
MDL-15384 'change name of quiz report classes to "quiz_{reportname}_report"' easy to do, changed class name of all reports and changed the code in report.php which instantiates the correct class.
2008-06-24 08:59:29 +00:00
jamiesensei
8b2f8253ad
MDL-15264 "Bar graph image missed when group with no attempts selected" added a query to check for sure that there are some grades there to display in the graph. Also now displaying grades for all groups a user has permission to view - but only if that is up to 4 groups and only if there are less than 500 grades total.
...
Merged from 1.9 branch
2008-06-19 14:03:24 +00:00
jamiesensei
8673a56615
MDL-15113 "quiz dml conversion" - fixing some sql broken during the conversion and removing unnecessary comma seperated list of ids where there are arrays of ids that can be used instead.
2008-06-09 13:27:31 +00:00
nicolasconnault
9cf4a18b41
MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
...
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
jamiesensei
9575899294
MDL-15180 "moved form to the top of the page"
2008-06-07 13:56:42 +00:00
jamiesensei
aa17ea53c4
MDL-15150 "Quiz Report broken in course without students" also now displaying a message when there are no attempts.
2008-06-06 14:59:24 +00:00
jamiesensei
a4ee9a602d
MDL-15150 "Quiz Report broken in course without students" added warning message if there are no students in course yet.
2008-06-06 14:03:55 +00:00
jamiesensei
181608b708
MDL-15092 "Quiz overview report won't display if there are more than 29 questions" fixed this by going back to the old way of fetching data for display in the table. However still use table JOINs when user wants to sort by question grade. The user can sort by a maximum of two columns at once so the JOINs will not exceed the limit.
2008-06-06 13:21:50 +00:00
jamiesensei
c35f3afcf1
MDL-15170 "convert to use new tablelib api"
2008-06-06 12:09:14 +00:00
skodak
fd0e6640cc
MDL-14679 fixed some more $db's
2008-05-31 22:18:41 +00:00
jamiesensei
f198d0bda7
MDL-15047 "Quiz overview report download is broken - patch" fixed.
...
Merged from 1.9 stable branch.
2008-05-30 12:23:10 +00:00
skodak
f33e1ed4ae
MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs
2008-05-15 21:40:00 +00:00
