7586 Commits

Author SHA1 Message Date
Andrew Nicols
c083d1ad1e MDL-63960 dataprivacy: Do not perform strict type checks for id
When inherit is specified in the data registry it is stored as a
string and we cannot perform a strict comparison with it.

We should still compare strict comparison checks against null, or false,
but not for the NOTSET (0) or INHERIT values (-1).
2018-11-10 15:34:21 +08:00
Eloy Lafuente (stronk7)
baf3fd4177 MDL-63919 tool_dataprivacy: admin & notify fixes
This includes the following:

1) Replace $ADMIN->id by get_admin()->id. The former doesn't exist.
2) Only change the notify parameter when it has not been specified
   at creation time (null). If specified, observe it.
3) Set the current user in tests to admin, able to create those
   requests.
2018-11-10 02:22:12 +01:00
Andrew Nicols
56c2b941df MDL-63919 tool_dataprivacy: Notify by default 2018-11-09 18:39:42 +08:00
Eloy Lafuente (stronk7)
ba999160b4 Merge branch 'MDL-62564-master-fix' of git://github.com/andrewnicols/moodle 2018-11-09 10:59:04 +01:00
Andrew Nicols
b26c5e031b MDL-62564 tool_dataprivacy: Do not delete deleted user
This also ensures that we do not call delete_user on an already deleted
user.
2018-11-09 17:34:47 +08:00
Jun Pataleta
012fa6abc3 Merge branch 'MDL-63867-master' of git://github.com/mickhawkins/moodle 2018-11-09 15:31:28 +08:00
Michael Hawkins
95a3f78058 MDL-63867 tool_dataprivacy: Add site purpose checks to tasks
If a site purpose is not defined, requests cannot be processed.
2018-11-09 15:20:12 +08:00
Michael Hawkins
0646c8514b MDL-63867 tool_dataprivacy: Fix context expired/unprotected user check
It now checks the system context has been defined, since that is
required for data privacy to be set up correctly, and the check
to be valid. This also fixes an error being thrown when checking
pending delete requests in cron.
2018-11-09 14:19:31 +08:00
Jun Pataleta
1d2adca39b Merge branch 'MDL-63924-master' of git://github.com/andrewnicols/moodle 2018-11-09 11:57:38 +08:00
Jun Pataleta
66e83fc0cc Merge branch 'MDL-63942-master' of git://github.com/andrewnicols/moodle 2018-11-09 11:44:02 +08:00
Andrew Nicols
8bb3c0d0c5 fixup! MDL-63897 dataprivacy: Kill the preprocess stage 2018-11-09 11:26:21 +08:00
Andrew Nicols
03acfa408a MDL-63897 tool_dataprivacy: Send notifications for new requests 2018-11-09 11:25:57 +08:00
Andrew Nicols
b838d85cbc MDL-63897 dataprivacy: Kill the preprocess stage 2018-11-09 11:08:07 +08:00
Andrew Nicols
b627565e9b Merge branch 'MDL-63919-master' of git://github.com/mihailges/moodle 2018-11-09 10:51:48 +08:00
Jun Pataleta
120edbe65f Merge branch 'MDL-62589-master' of git://github.com/andrewnicols/moodle 2018-11-09 10:36:52 +08:00
Andrew Nicols
a10b512021 MDL-63942 dataprivacy: Disable deleted user task by default 2018-11-09 09:29:13 +08:00
Damyon Wiese
d3fdd7442b Merge branch 'MDL-63671-master-2' of git://github.com/mihailges/moodle 2018-11-09 09:12:49 +08:00
Jun Pataleta
3bc9a0b2e2 Merge branch 'MDL-63836-master' of git://github.com/damyon/moodle 2018-11-09 00:21:19 +08:00
Eloy Lafuente (stronk7)
3aa0cfe33e Merge branch 'MDL-62564-integration-master-1' of git://github.com/mihailges/moodle 2018-11-08 16:38:38 +01:00
Andrew Nicols
c96cd71102 MDL-63924 privacy: Add shared user providers to subsytsems 2018-11-08 21:26:18 +08:00
Eloy Lafuente (stronk7)
5b3f4bbb12 MDL-63927 performance: Update the plan to support the new login token 2018-11-08 10:25:08 +01:00
Mihail Geshoski
a128601eb3 MDL-63671 tool_cohortroles: Limit data to the system context in provider 2018-11-08 16:06:43 +08:00
Mihail Geshoski
f39b579de1 MDL-63919 privacy: Store the creation method of the data request 2018-11-08 14:13:31 +08:00
Mihail Geshoski
77c21518f2 MDL-63919 privacy: Disable notifications for auto created data requests 2018-11-08 14:08:43 +08:00
Jun Pataleta
67bceccd4a Merge branch 'MDL-63902-master' of git://github.com/andrewnicols/moodle 2018-11-08 13:39:05 +08:00
Andrew Nicols
50208b5ca5 MDL-62589 dataprivacy: Add ability to resubmit a request 2018-11-08 11:45:36 +08:00
Mihail Geshoski
673d2c58fb MDL-62564 privacy: Create request for deleted users when setting enabled 2018-11-08 09:29:38 +08:00
Mihail Geshoski
b4ecfa38c2 MDL-62564 privacy: Improve bulk deletion 2018-11-08 09:28:36 +08:00
Andrew Nicols
66a47d23fa MDL-63902 dataprivacy: Check course children not the course
When checking the expiry and protected state of a context, we need to do
so knowing what kind of use that context has.

If it is used in the user context, then only the user context matters.
If it is used within a course, then that child context must be checked
in relation to the course.
2018-11-08 09:13:15 +08:00
Damyon Wiese
f41207400b MDL-63836 course: No course header images
This feature may be added in future, but for now we are not going to include it.
2018-11-08 08:59:35 +08:00
Mihail Geshoski
4bd598cbc9 MDL-62564 privacy: Add unit tests 2018-11-08 08:59:31 +08:00
Andrew Nicols
4c1fc0b6d6 MDL-62589 dataprivacy: Correct not in sql 2018-11-07 19:24:07 +08:00
Juan Leyva
c1720141fd MDL-63708 tool_mobile: Add options for disabling blocks
Now that we are supporting the new dashboard and site home blocks on the mobile app,
we need options to allow admin to forbid certain blocks to be displayed on the app.
2018-11-07 00:32:32 +01:00
Andrew Nicols
74238c1c18 Merge branch 'MDL-62563-master-3' of git://github.com/mihailges/moodle 2018-11-06 09:37:23 +08:00
Mihail Geshoski
c13c4569a9 MDL-62563 privacy: Create delete data request for existing deleted users 2018-11-05 16:20:37 +08:00
Mihail Geshoski
9fade7ff13 MDL-62563 privacy: Add unit tests 2018-11-05 16:20:06 +08:00
Juan Leyva
818d40a922 MDL-63717 tool_mobile: Ensure URLs are valid
We need to clean the URLs returned by the get_public_config WS because some old plugins didn't validate the stored data.
2018-11-02 14:37:29 +01:00
Andrew Nicols
91071ad785 Merge branch 'MDL-63666-master' of git://github.com/mihailges/moodle 2018-11-02 10:46:33 +08:00
Mihail Geshoski
d638ab7c50 MDL-63666 logging: Rename delete_data_for_all_users() function 2018-11-02 09:17:24 +08:00
Adrian Greeve
ac7d086d1d MDL-63666 logging: Add support for removal of context users.
This creates a new interface for the logging subplugins to
implement for the users to be deleted separately.
2018-11-02 08:57:43 +08:00
Andrew Nicols
ec859d9f4b Merge branch 'MDL-63703-master-1' of git://github.com/mihailges/moodle 2018-11-02 08:56:40 +08:00
Mihail Geshoski
8420c3bbc2 MDL-63703 core_role: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
2018-11-01 12:12:49 +08:00
Andrew Nicols
e146e1133b Merge branch 'MDL-63566-master' of git://github.com/mickhawkins/moodle 2018-11-01 10:11:33 +08:00
Adrian Greeve
7a35413d16 MDL-63566 tool_dataprivacy: New interface check for userlist.
This adds another check to see if the plugins are implementing the
new core_userlist_provider.
2018-11-01 10:06:45 +08:00
David Monllao
07a64c681a Merge branch 'MDL-63726-master' of https://github.com/lucaboesch/moodle 2018-10-31 10:17:29 +01:00
Damyon Wiese
554c7916c0 Merge branch 'MDL-58943-master-revised' of github.com:damyon/moodle 2018-10-31 14:39:36 +08:00
Andrew Nicols
7f56f4bfba Merge branch 'MDL-63624-master' of git://github.com/mihailges/moodle 2018-10-31 11:15:24 +08:00
Mihail Geshoski
3c0290a9fb MDL-63624 tool_cohortroles: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
2018-10-31 11:08:49 +08:00
Tobias Reischmann
3e3e120d3a MDL-58943 oauth2: Added nextcloud to standard issuers
* New button allows to create standard issuer for nextcloud
* Since the endpoints url has to be https and nextcloud relys on the
baseurl to create the endpoints, the baseurl of issuers has now to be
https as well (or empty).
* Google's baseurl was changed to https (there was no reason not to),
whereas Facebook and Microsoft baseurls remain empty.
* In case of the creation of a nextcloud issuer, the baseurl is
required.
* Nextcloud requires the baseurl, therefore a parameter is added to
create_standard_issuer($type, $baseurl = false). That parameter not
required (or used) for anything but Nextcloud.
2018-10-31 10:42:58 +08:00
Tobias Reischmann
fa6cd89b24 MDL-58943 oauth2: Split issuer initialization from endpoint creation
* Splitted the initialization of default values for issuers, the
creation of the issuer, and the creation of its endpoints. This is
a fix for following use case:
 1. A user creates a standard issuer.
 2. She cancels the form.
 3. However, the issuer was already created. Thus, the cancel had no
effect.
* The function create_standard_issuer($type) can still be used to create
issuers programmatically if all required data is known beforehand (e.g.,
during upgrade or in tests).
2018-10-31 10:42:57 +08:00