jamiesensei
3d6de8770d
MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up.
2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476
MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0.
2008-09-15 13:38:31 +00:00
tjhunt
337fa7a0ef
MDL-16263 - followup - fix notices.
2008-08-29 11:30:16 +00:00
jamiesensei
570e5e029a
MDL-16041 "Grade of new tests are zero!" no longer displaying graphs of grades for ungraded quizzes.
2008-08-15 10:24:04 +00:00
jamiesensei
f29e6691a7
MDL-15972 "Make ability to list regrades dependent on permission" fixed a problem showing some of the regrade interface to users who do not have permission to regrade.
...
MDL-15960 "Overview report does not work correctly with groups" Fixed a problem that group mode was not working as the logic selecting the attempts mode was erroneously showing the all attempts mode.
MDL-15958 "Error on selecting to hide marks for each question" problem with trying to sort on question grades when grades not displayed fixed.
MDL-15953 "Summary chart to show in 5% ranges please" allowed the graph to show up to or equal to 20 bands, instead of just up to 20.
MDL-14201 "Summary graph" showing two graphs now as it was felt that when there were few students in a group compared with all the students who took a quiz then it would be difficult to see the data for the group.
2008-08-15 09:59:55 +00:00
tjhunt
f88fb62c40
MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors.
2008-08-15 06:42:38 +00:00
jamiesensei
daae98e118
MDL-14216 "change query to work on Postgres." - some adjustments to make it work on mysql again too.
2008-07-24 16:10:26 +00:00
tjhunt
1e98b864e5
MDL-14216 - change query to work on Postgres.
2008-07-24 15:34:15 +00:00
tjhunt
23277af8f1
MDL-14216 - change query to work on Postgres.
2008-07-24 12:58:05 +00:00
jamiesensei
16de0ed32b
MDL-15732 "question_load_questions has changed in HEAD and expects an array instead of a comma seperated list of question ids"
2008-07-21 13:06:57 +00:00
jamiesensei
6559096f2c
MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code."
2008-07-21 09:06:46 +00:00
jamiesensei
55caa1d5dc
MDL-15198 "non-standard sql in reportlib.php" using CASE statement to wrap logic in fields list
2008-07-20 12:52:14 +00:00
jamiesensei
375381a006
MDL-15718 "overview report slow for large data sets - print_user_picture queries the db if only provided with a userid"
2008-07-20 11:56:35 +00:00
jamiesensei
b6943d3731
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" if condition around buttons to not output them when downloading table data.
2008-07-15 07:22:26 +00:00
jamiesensei
57d6a267a6
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" oops. Fixing notice about $this->context not being set in overview report table.
2008-07-11 07:48:25 +00:00
jamiesensei
314b8a20d4
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" added some if conditions to not display regrade buttons if the user doesn't have the permission to grade.
2008-07-11 07:39:11 +00:00
jamiesensei
98f38217bb
MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade"
2008-07-11 07:27:14 +00:00
jamiesensei
334edb71c1
MDL-15198 "non-standard sql in reportlib.php" fixed this with new sql that does not require a limit clause.
2008-06-30 11:53:47 +00:00
jamiesensei
7660aa80e0
MDL-15393 "show group name in drop down select for what to show in report" AND MDL-15394 "disable showing 'all attempts' and remove option from drop down box in form if there is a group selected"
2008-06-24 16:36:44 +00:00
jamiesensei
d86bbdd6f7
MDL-15309 "Switch role to student, take quiz, can't delete attempt" switching default of overview report to show all attempts whether or not the attempt is for a currently enrolled student.
...
Merged from 1.9 branch.
2008-06-24 12:32:23 +00:00
jamiesensei
abe67b24a7
MDL-15378 "Quizz: sql error if not student in the group" now have extra logic to not display the table if there are no students at all or in current group - still displaying form and graph were appropriate.
...
Merged from 1.9 branch
2008-06-24 12:18:47 +00:00
jamiesensei
c386eaa3df
MDL-15384 'change name of quiz report classes to "quiz_{reportname}_report"' easy to do, changed class name of all reports and changed the code in report.php which instantiates the correct class.
2008-06-24 08:59:29 +00:00
jamiesensei
8b2f8253ad
MDL-15264 "Bar graph image missed when group with no attempts selected" added a query to check for sure that there are some grades there to display in the graph. Also now displaying grades for all groups a user has permission to view - but only if that is up to 4 groups and only if there are less than 500 grades total.
...
Merged from 1.9 branch
2008-06-19 14:03:24 +00:00
jamiesensei
8673a56615
MDL-15113 "quiz dml conversion" - fixing some sql broken during the conversion and removing unnecessary comma seperated list of ids where there are arrays of ids that can be used instead.
2008-06-09 13:27:31 +00:00
nicolasconnault
9cf4a18b41
MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
...
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
jamiesensei
9575899294
MDL-15180 "moved form to the top of the page"
2008-06-07 13:56:42 +00:00
jamiesensei
aa17ea53c4
MDL-15150 "Quiz Report broken in course without students" also now displaying a message when there are no attempts.
2008-06-06 14:59:24 +00:00
jamiesensei
a4ee9a602d
MDL-15150 "Quiz Report broken in course without students" added warning message if there are no students in course yet.
2008-06-06 14:03:55 +00:00
jamiesensei
181608b708
MDL-15092 "Quiz overview report won't display if there are more than 29 questions" fixed this by going back to the old way of fetching data for display in the table. However still use table JOINs when user wants to sort by question grade. The user can sort by a maximum of two columns at once so the JOINs will not exceed the limit.
2008-06-06 13:21:50 +00:00
jamiesensei
c35f3afcf1
MDL-15170 "convert to use new tablelib api"
2008-06-06 12:09:14 +00:00
skodak
fd0e6640cc
MDL-14679 fixed some more $db's
2008-05-31 22:18:41 +00:00
jamiesensei
f198d0bda7
MDL-15047 "Quiz overview report download is broken - patch" fixed.
...
Merged from 1.9 stable branch.
2008-05-30 12:23:10 +00:00
skodak
f33e1ed4ae
MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs
2008-05-15 21:40:00 +00:00
jamiesensei
ca35974827
MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory.
...
merged from 1.9 branch
2008-05-15 13:59:52 +00:00
jamiesensei
e649d4b120
MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade.
...
Merged from 1.9 branch.
2008-05-15 12:54:01 +00:00
jamiesensei
aad5b0fca9
MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code.
...
Merged from 1.9 branch.
2008-05-15 12:27:27 +00:00
jamiesensei
c5fedf065c
MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports"
...
The quiz overview report now respect the settings for the gradebook - whether to display idnumbers and user pictures.
Also re-factored the code to build table / download content a little to reduce code duplication.
2008-05-09 13:59:36 +00:00
jamiesensei
44eb3b6e9e
For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is.
...
Merged from 1.9 branch.
2008-05-08 09:53:31 +00:00
jamiesensei
b621e1a006
MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" adding a message about the highlighting above the table.
...
Merged from 1.9 branch.
2008-05-08 09:35:08 +00:00
jamiesensei
2fecd85ba6
MDL-14734 "improve interface for deleting attempts"
...
* The control for deleting attempts is a drop down box with onchange javascript to submit the form, you cannot see the label to say what the drop down box does. Better to use a button. The button label is visible so you can see what it does.
* Checkboxes should be displayed when there is no attempt to delete.
* The whole column for checkboxes should be removed when no attempts are displayed ie. when showing students with no attempts.
2008-05-07 16:00:56 +00:00
jamiesensei
8b87ab0000
MDL-14201 "Summary graph" included a summary graph at the bottom of overview report page. Shows the distribution of grades achieved by students. If a group is selected the grades from the group are compared with the grades for all participants.
2008-05-07 14:38:18 +00:00
jamiesensei
f4ed09faae
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" fixed a small problem I noticed in this patch.
2008-05-06 18:04:03 +00:00
jamiesensei
4469159e2d
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score"
2008-05-06 17:34:39 +00:00
jamiesensei
0217f93275
For overview report - MDL-14185 "Switch to using formslib and improve the interface" and MDL-14186 "Switch to using moodle_url and eliminate the use of $SESSION global"
2008-05-05 13:12:11 +00:00
jamiesensei
1a85336b79
non consequential, little typo.
2008-05-03 13:56:32 +00:00
jamiesensei
2badf2e6ec
MDL-14677 "should rescale the grades displayed for each question in the detailed marks view of the overview report so that all grades add up to the sum total grade" used quiz_rescale_grades function to rescale the grade properly before displaying it. Also this patch includes some general clean up and refactoring of overview report.
2008-05-03 13:06:49 +00:00
jamiesensei
e49906d3b1
MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row."
2008-05-02 15:26:47 +00:00
jamiesensei
92c5499a84
MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." Made a new query outside the loop for adding rows.
2008-05-02 15:11:59 +00:00
jamiesensei
e0b01669ce
MDL-14664 "sorting by question mark when viewing detailled mark in overview quiz report not working" Found that the problem ocurred when attempt.id != attempt.uniqueid as the sql was using the wrong field to join the question records.
2008-05-02 14:21:33 +00:00
jamiesensei
85a8704fe2
MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text."
...
Solved this by formatting the grade using number_format to display the grade with a number of decimal places. So for 0 we display something like 0.00 and this displays OK in link_to_popup_window.
2008-05-02 13:27:49 +00:00
