220 Commits

Author SHA1 Message Date
David Monllao
1bd2c8ad01 Merge branch 'MDL-49611' of git://github.com/srynot4sale/moodle-fixes 2015-05-27 08:49:23 +08:00
Aaron Barnes
03f3f7180f MDL-49611 completion: Update dangling err_nocriteria lang strings 2015-05-19 22:41:19 +12:00
Marina Glancy
bdbe385cc2 MDL-49061 reports: call format_string on activities names 2015-05-13 12:14:13 +08:00
Rajesh Taneja
0fe86bbdbb MDL-49799 behat: replaced asd.com with example.com
asd.com is a valid domain, we should use reserved domain names for testing
2015-04-20 11:21:20 +08:00
Simey Lameze
39030d8de3 MDL-49412 core_completion: Fix behat failures
Part of MDL-45774
2015-04-10 17:18:24 +08:00
Juan Leyva
b5e6063803 MDL-49313 webservices: Unit tests for the external function
core_completion_get_course_completion_status
2015-04-02 21:58:14 +02:00
Costantino Cito
90c326640d MDL-49313 webservices: New WS get_course_completion_status 2015-04-02 21:58:13 +02:00
Andrew Nicols
df15759724 Merge branch 'wip-mdl-49513' of https://github.com/rajeshtaneja/moodle 2015-04-02 11:06:27 +02:00
Juan Leyva
ea2f0e3e87 MDL-49314 webservices: Fix unit tests for handling hidden activities 2015-04-01 12:22:08 +02:00
Juan Leyva
9cd1093c33 MDL-49314 webservices: Check groups using groups_user_groups_visible 2015-04-01 10:21:17 +02:00
Juan Leyva
f578820b3b MDL-49314 webservices: Unit tests for the new external function 2015-04-01 10:19:25 +02:00
Juan Leyva
604afeff1c MDL-49314 webservices: Add the new function to the mobile service
The commit also include some clean-up
2015-04-01 10:19:25 +02:00
Costantino Cito
5f2406c94a MDL-49314 webservices: New WS get_activities_completion_status 2015-04-01 10:19:25 +02:00
Rajesh Taneja
bed97c39eb MDL-49513 behat: Set admin config using php api
Added a new set to set config using set_config() api
to make steps faster and more efficient
2015-04-01 14:25:23 +08:00
Juan Leyva
1490586ea8 MDL-49444 webservices: Tests for update_activity_completion_status 2015-03-24 09:50:02 +01:00
Juan Leyva
b9d17109e2 MDL-49444 webservices: New WS update_activity_completion_status 2015-03-24 09:50:01 +01:00
David Monllao
8666706bf3 MDL-47232 completion: Adding completion upgrade.txt 2015-01-08 15:41:02 +08:00
Ray Morris
2cc8d5624a MDL-47232 completion: Completed and failed activities count as completed 2015-01-08 15:30:54 +08:00
Aaron Barnes
129e786cf4 MDL-40097 completion: Make restoring grade criteria more robust 2015-01-05 10:14:03 +08:00
Eloy Lafuente (stronk7)
38ea5e0a39 MDL-21724 course: change remaining tests to new "Save and display" 2014-12-04 12:14:31 +00:00
David Monllao
95d1a366ea MDL-40241 core_completion: Minor fixes to provided patch
Thanks to Aaron Barnes and Jon Sharp for working on this issue.
2014-12-01 15:03:18 +08:00
Aaron Barnes
37ee40f3e0 MDL-40241 completion: Default roles unable to manually complete course
Thanks to Jon Sharp for authoring the original patch!
2014-11-28 16:50:50 +08:00
Rajesh Taneja
955118d831 MDL-43835 behat: Fixed matches for select form field 2014-06-25 12:54:52 +08:00
Petr Skoda
8b233bdacd MDL-43557 fix BC issue in \core\event\course_completed and incorrect description 2014-04-30 14:59:45 +08:00
Mark Nelson
02a5a4b2ff MDL-43557 events: fixed minor issues in existing events 2014-04-29 19:16:11 -07:00
sam marshall
3e9c7420d3 MDL-44070 Behat: Fixed restrict_activity_by_date.feature 2014-04-09 17:51:59 +02:00
Rajesh Taneja
ae90dec5c2 MDL-44070 core_completion: Fixed behat 2014-04-09 14:24:55 +02:00
Dan Poltawski
5f3b4694b3 Merge branch 'wip-MDL-42870-master' of git://github.com/marinaglancy/moodle 2014-03-11 11:37:44 +08:00
David Monllao
759b323e0e MDL-43236 behat: Updating references to deprecated methods 2014-03-07 16:05:21 +08:00
Marina Glancy
30a32f147a MDL-42870 completion: performance and readability code refactoring 2014-03-07 10:21:49 +08:00
Dan Poltawski
3be87d897d Merge branch 'MDL-41248' of git://github.com/timhunt/moodle 2014-03-05 12:39:53 +08:00
Tim Hunt
8d3debf360 MDL-41248 completion: fix non-translatable text.
There were two hard-coded strings. Thanks to Guido Hornig for the suggested fix.
2014-02-28 08:10:54 +01:00
David Monllao
f083d6145e MDL-43738 behat: Updating features files
The following used steps were replaced by the ones
added in this issue:
- I fill the moodle form with
- I fill in with
- I select from
- I select radio button
- I check
- I uncheck
- the field should match

Also removing test for deprecated steps:
- the ASD checkbox should be checked
- the ASD checkbox should not be checked
2014-02-27 18:22:05 +08:00
David Monllao
8ef423433d MDL-43717 behat: Replacing 2050 for a date eariler than the max timestamp 32bit limit
All credit goes to Michael de Raadt.
2014-01-17 10:37:59 +08:00
David Monllao
d1e55a47be MDL-42625 behat: Step definitions + related changes in features
In general aiming for compatibility with multiple browsers,
firefox, chrome and phantomjs to be more specific.

* Removing hardcoded waits
* Adding @_alert, @_switch_window and @_switch_frame tags,
  to label actions that different drivers have problems with.
* Adding missing @_files_upload and @_only_local tags to features that
  uploads files.
* Fixing a few wait for page ready what specified miliseconds.
* New methods to ensure elements (usual selectors), sections and editors
  are ready to interact with
* Changing the select an option implementation to deal with the different
  drivers implementations when listening to JS events.
2013-12-06 13:10:24 +08:00
David Monllao
333db2e9b9 MDL-42625 behat: Editing .feature files 2013-12-06 12:13:39 +08:00
David Monllao
047a8800f4 MDL-40975 course: Adapt behat tests to the new course editing interface 2013-11-06 11:41:00 +08:00
Dan Poltawski
b0d92c0cec Merge branch 'wip-mdl-42282' of git://github.com/rajeshtaneja/moodle 2013-10-29 11:31:32 +08:00
Dan Poltawski
0e9b076973 Merge branch 'wip-mdl-42281' of git://github.com/rajeshtaneja/moodle 2013-10-29 11:08:45 +08:00
Rajesh Taneja
e21ae3ebdc MDL-42281 Behat: Automated test for MDLQA-510
MDLQA-510: A teacher can set grade conditions to restrict availability
of an activity
2013-10-28 16:48:19 +08:00
Rajesh Taneja
3f038d6d97 MDL-42283 Behat: Automated MDLQA-1777
MDLQA-1777: A teacher can set grade conditions to restrict availability of a section
2013-10-23 15:57:53 +08:00
Rajesh Taneja
932fa0157d MDL-42282 Behat: Automated test for MDLQA-509
MDLQA-509: A teacher can prevent students from accessing an activity
between specified dates
2013-10-21 14:12:31 +08:00
Rajesh Taneja
06f8ea7bf4 MDL-39955 completion: Added course_completed event 2013-08-13 09:43:38 +08:00
David Monllao
3897608152 MDL-39635 behat: XPath cleanups
- Escaping steps arguments redirected to other steps
- Adding normalized-space() in all contains() assertions
- General xpaths review
- Convering provided xpath text strings to xpath literals
  to avoid problems with arguments containing both single
  quotes and double quotes
2013-07-19 10:02:36 +02:00
David Monllao
dedb973878 MDL-39635 behat: Replacing hardcoded language strings
Using get_string() instead.
2013-07-19 10:02:10 +02:00
Eloy Lafuente (stronk7)
7942df199b Merge branch 'MDL-38559-completion-ui' of git://github.com/mudrd8mz/moodle 2013-05-10 02:37:54 +02:00
David Mudrák
870a4f8119 MDL-38559 Fix the ability to disable the grade condition in the course completion settings form 2013-05-09 23:24:49 +02:00
David Mudrák
6e5a473c47 MDL-38559 Reorganise course completion settings form
This is a result of a pretty intensive effort to make the form less
sucky, given the completion strings mess around. It partially solves
MDL-39419 too as it clarifies the course completion link in the course
administration block.

I must admit and record here that I'm pretty desperate by the current
state of the core_completion and how strings from it are inconsistently
used at various places with different meanings. For example the 'Completion
tracking' may mean the mode of how activities are tracked within the
course as well as the overall feature of course and activities tracking.
While a same phrase can be used in English for both this meanings, not
all languages have such luck and translating it is a pain in the ass.

Finally, let me give the credit for wording and UI design suggestions to
Helen Foster and all others who helped with this. This has been one of
the most ugliest forms in Moodle and we believe we made it better
(although we know it's far from perfect).
2013-05-09 23:14:57 +02:00
David Monllao
5d7b6307b1 MDL-39586 behat: Closed list of stackeholders 2013-05-09 18:38:13 +08:00
David Monllao
00ea74cb54 MDL-39348 behat: Chaining strings instead of splitting strings in lines 2013-05-03 10:16:44 +08:00