77 Commits

Author SHA1 Message Date
mudrd8mz
081a9b0dad MDL-18644 Bugs found by syntax checker, merged from MOODLE_19_STABLE 2009-03-23 09:53:02 +00:00
iarenaza
eee34307b9 Cache LDAP connections: MDL-18130 Properly handle open LDAP connections.
Both CAS and LDAP auth plugins open new connections to the LDAP server
to get the user account details. While this is the desired behaviour
for regular logins (we probably don't have an already open connection
to the LDAP server), this is a ressource hog when we are doing user
synchronization, as the closed connections remain in the TCP_WAIT
state for a while before the server can reuse them. If we are syncing
a lot of users, we can make the server run out of available TCP
ressources.

So we cache the connection the first time we establish it and return
the same connection handle everytime, unless we've closed all the
'open' connections, or the auth object is destroyed.

In addition to that, there were a few missing calls to ldap_close().
2009-02-15 15:03:33 +00:00
moodler
49f5ec4cfd auth/cas MDL-17121 Upgraded to latest version which is LGPL 2008-11-07 02:01:10 +00:00
iarenaza
5261baf11e MDL-16061 Revert incorrect fix for "Remove 'username' from the $moodleattributes array"
Merged from MOODLE_18_STABLE.

The fix is wrong, as it breaks auth_db_sync_users.php and
auth_ldap_sync_users.php at least. No new users are added to Moodle, as the
username is missing from the new user info record.

The fix needs to go into update_user_record() in lib/moodlelib.php to make it
skip the 'username' key, as we really need get_userinfo() to return the
username as part of the user info array.
2008-08-25 22:44:45 +00:00
iarenaza
19ac43c7a6 MDL-16061 Remove 'username' from the $moodleattributes array.
It doesn't make sense at all (username is not part of the externally mapped
fields) and produces a notice that breaks HTTP headers with debugging enabled.
2008-08-15 11:22:57 +00:00
Francois Marier
6800d78e06 Drift between CVS and git
- large deletions
- lucene updates
- error() => print_error()
- NO_MOODLE_COOKIES define
- various other things
2008-06-25 17:31:23 +00:00
skodak
df884cd852 MDL-15098 dml auth conversion 2008-06-07 15:41:25 +00:00
skodak
185721a498 MDL-14679 towards /admin/auth conversion 2008-05-31 13:57:49 +00:00
skodak
be544ec380 MDL-14679 towards authlib conversion 2008-05-30 20:54:19 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
skodak
59669b63f0 MDL-14543 fixed broken deleting from auth sync - credit goes to Juris Treibahs ; merged from MOODLE_19_STABLE 2008-04-25 13:22:02 +00:00
skodak
864dad5795 MDL-13401 fixed REQUEST_URI test; merged from MOODLE_19_STABLE 2008-04-25 12:24:16 +00:00
dongsheng
16db5bab9c MDL-14312, remove align attribute in table tag, merged from MOODLE_19_STABLE 2008-04-16 02:31:38 +00:00
dongsheng
8beb1216a5 MDL-14311, fix minor html errors 2008-04-15 05:54:59 +00:00
dongsheng
4105cafff9 MDL-12531, make the new member value available to all the affected plugins, thanks, Robert 2008-04-08 05:53:12 +00:00
dongsheng
6f87ef52b9 MDL-14055, change to human-readable strings from hard-coded integer, thanks for Matt's patch. 2008-03-26 01:35:04 +00:00
iarenaza
0baafc173a Fix MDL-11632: Multiple files with emtpy lines outside PHP open/close tags
There are multiple issues with Moodle files containing empty or blank lines
(lines consisting of white spaces or tabs only) and/or white space before or
after the PHP open and close tags, notably with config.php and theme files.
2007-10-09 21:43:28 +00:00
jgutierr25
c39e721374 Pb with autologinguest 2007-09-11 07:54:55 +00:00
jgutierr25
5128f0b3fa problem with autologinguest 2007-08-31 09:49:15 +00:00
skodak
90afcf3280 MDL-10260 added new user_delete() hook into auth plugins; refactored user delete code = new function delete_user() in moodlelib.php + improved cleanup in core tables when deleting user 2007-08-21 20:52:36 +00:00
nicolasconnault
e295df447f MDL-10870 All files updated to new build_navigation() method. 2007-08-17 11:18:58 +00:00
moodler
0c5e6027d2 I merged all changes over from 1.8 to HEAD.
None of it looked too serious but I'VE NOT TESTED THIS AT ALL.

MDL-10366
2007-08-11 12:58:08 +00:00
jgutierr25
6dfddff7ce *** empty log message *** 2007-07-23 11:37:21 +00:00
jgutierr25
df5b8b8895 test if auth cas activated and no parameters 2007-07-17 12:08:26 +00:00
jgutierr25
017f1a617d *** empty log message *** 2007-07-17 11:46:19 +00:00
jgutierr25
f535ea21fd *** empty log message *** 2007-07-09 08:49:47 +00:00
Martin Langhoff
a9b24e489b cvsimport fixups - new files 2007-07-07 14:30:55 +12:00
Martin Langhoff
08103c9364 cvsimport fixups 2007-07-07 14:18:30 +12:00
jgutierr25
74c9f514ab pb case sensitive when get ldap attribute 2007-06-28 09:35:32 +00:00
jgutierr25
209596cb6a automatic authentication when direct access from another CAS application and multiauth 2007-06-05 08:35:57 +00:00
jgutierr25
c8afa50ba5 *** empty log message *** 2007-05-21 07:11:12 +00:00
skodak
e52f2d582e MDL-9642 auth/CAS: Dependence on external PEAR DB; merged from MOODLE_18_STABLE 2007-05-10 12:30:14 +00:00
poltawski
e9e928b68d MDL-9742 Converting tabs to spaces 2007-05-09 00:50:29 +00:00
jgutierr25
0c121d998a patch for bug when you connect from authentication block on main page 2007-05-04 08:06:40 +00:00
nicolasconnault
77a297d274 Fixed many xhtml errors 2007-04-20 07:54:42 +00:00
skodak
f5fd4347dd MDL-8973 auth hooks final cleanup; merged from MOODLE_18_STABLE 2007-03-28 08:28:02 +00:00
skodak
6bc1e5d577 (MDL-8973) Fix OOP model of new multi auth plugins + some other auth related fixes, fixed change_password, ldap updates, etc.; TODO: fix docs 2007-03-22 12:27:52 +00:00
moodler
6ba65fa08d Merged Nicolas' changes from MDL-8582 into HEAD. 2007-02-28 06:25:22 +00:00
skodak
430759a5fe MDL-8590 auth cleanup - part 6 2007-02-21 21:42:10 +00:00
skodak
139ebfdb3b MDL-8590 auth cleanup - part 1 2007-02-20 17:03:36 +00:00
donal72
a9ad3633c7 Auth: Replace hardcoded strings: MDL-8069 2007-01-10 23:17:51 +00:00
donal72
b7b50143f3 Auth: Bugfix: MDL-8131 2007-01-10 00:50:59 +00:00
skodak
741fc7af6f MDL-7861 xhtml strict fixes - added langmenu class 2007-01-05 16:39:02 +00:00
skodak
b7dc225654 MDL-8062 1.3 Remove name attribute from <form> and fix focus everywhere - more changes ahead 2007-01-04 21:32:36 +00:00
martinlanghoff
b9ddb2d5ea multiauth: migrated all files to the new OO API, written new API documentation
Author: Martin Langhoff <martin@catalyst.net.nz>
2007-01-04 04:52:42 +00:00
moodler
dd83687833 Make CAS work MDL-6931 2006-10-25 05:51:18 +00:00
skodak
d8247de55e problem with incorrect redirect url - wwwroot without the trailning slash in not standard compliant MDL-6193 2006-10-08 18:55:18 +00:00
toyomoyo
c26ba25f32 merged, changepassword obsolete 2006-05-31 06:58:51 +00:00
toyomoyo
e79771162c merged, changepassword obsolete 2006-05-31 06:42:35 +00:00
skodak
2c3432e684 fixed problem when set both loginhttps and https in wwwroot, closes bug #5507 and #3848; merged from MOODLE_16_STABLE 2006-05-15 21:36:46 +00:00