4122 Commits

Author SHA1 Message Date
Bas Brands
40d1487bf5 MDL-68761 question_multichoice: show question content inline 2020-06-03 11:02:59 +02:00
Jake Dallimore
cfe32a7caf Merge branch 'MDL-68802-master' of https://github.com/HuongNV13/moodle 2020-05-29 10:53:57 +08:00
Huong Nguyen
81d7fd7a80 MDL-68802 qtype_ddimageortext: issue related to keyboard navigation 2020-05-28 18:03:11 +07:00
Eloy Lafuente (stronk7)
6f56e743ed Merge branch 'MDL-68753-master-enfix' of git://github.com/mudrd8mz/moodle 2020-05-28 13:01:39 +02:00
Helen Foster
026a12ec51 MDL-68753 lang: Import fixed English strings (en_fix) 2020-05-26 19:18:23 +02:00
Adrian Greeve
b2978c1787 Merge branch 'MDL-68757' of https://github.com/timhunt/moodle 2020-05-26 10:33:03 +08:00
Victor Deniz Falcon
a735d4d1d4 Merge branch 'MDL-68252' of https://github.com/timhunt/moodle 2020-05-26 00:55:02 +01:00
Andrew Nicols
35f5bf4abc Merge branch 'MDL-68549' of https://github.com/HuongNV13/moodle 2020-05-25 19:10:21 +08:00
Adrian Greeve
d602189874 Merge branch 'MDL-63812' of https://github.com/timhunt/moodle 2020-05-25 14:40:14 +08:00
Jun Pataleta
20a660f864 MDL-68367 qtype_multichoice: Decrease minimum expected export file size
* Exporting via Oracle trims trailing zeroes in floating numbers which
results to a smaller file size for the exported file. Better to reduce
the minimum expected export file size from 4000 bytes to 3900 bytes.
2020-05-22 14:45:05 +08:00
Andrew Nicols
a15175eab4 Merge branch 'MDL-68446' of https://github.com/timhunt/moodle 2020-05-22 11:32:01 +08:00
Jake Dallimore
77dddebdb9 Merge branch 'MDL-58645-master' of https://github.com/HuongNV13/moodle 2020-05-22 10:35:27 +08:00
Andrew Nicols
f2d33fcc11 Merge branch 'MDL-68439-master' of https://github.com/HuongNV13/moodle 2020-05-21 20:30:13 +08:00
Huong Nguyen
51de017235 MDL-68439 qtype_ddwtos: UI issues
- Fixed cursor for dropped ddwtos
 - Fixed the animation of "flying back to the home position" starts off at the right end of the previous line"
2020-05-21 17:19:40 +07:00
Jun Pataleta
7750dd55e8 Merge branch 'MDL-68367' of https://github.com/mkassaei/moodle 2020-05-21 17:10:16 +08:00
Mahmoud Kassaei
00055ef6ab MDL-68367 Question: Multi-choice Option to hide systemtext 2020-05-21 09:47:15 +01:00
Adrian Greeve
aa1dcabf4c Merge branch 'MDL-68733' of https://github.com/timhunt/moodle 2020-05-21 08:37:52 +08:00
Tim Hunt
64207dab65 MDL-67183 questions: get_question & get_behaviour only init if required
This reviews all the code code, and sets $requirequestioninitialised
whenever possible in these calls, which should improve performance.
2020-05-19 20:52:07 +01:00
Tim Hunt
9cbbb779eb MDL-67183 question engine: allow lazy-init of question_attempts
That is, we don't call apply_attempt_state as soon as a
the data is loaded from the database. Instead, we wait
and only call it if really needed.

This should (especially after the next commit) be a performance win
during quizzes, particularly for people using advanced question
types liks STACK, or people making extensive use of the
'Try another question like this one' feature.
2020-05-19 20:49:33 +01:00
Tim Hunt
89c8a076b2 MDL-68733 quiz editing: behat test for altering random question tags 2020-05-18 23:20:10 +01:00
Tim Hunt
c689726d3f MDL-68733 question behat: question tag generator and use in quiz test 2020-05-18 22:56:33 +01:00
Tim Hunt
4a45b7112c MDL-68757 questions: don't do output in low-level functions 2020-05-18 20:54:27 +01:00
Andrew Nicols
29c5fafff5 MDL-66109 js: Fix Shifter linting issues 2020-05-11 11:07:49 +08:00
Andrew Nicols
149d80e819 MDL-66109 behat: Fix Example usage in feature files
The gherkin-lint package now understands the use of "Examples" and
requries that their indentation be correct and consistent.

This change sets the indentatation for these to:

    "Examples": 4,
    "example": 6,

This is in-line with the examples given in the offical Cucumber/Gherkin
documentation at
https://cucumber.io/docs/gherkin/reference/#scenario-outline whereby the
Examples and individual rows of the Examples table are children of the
Scenario outline.

This is contrary to the default for Gherkin-lint which places them as
top-level nodes with an indentatio of 0, and 2 respectively.
2020-05-11 10:55:58 +08:00
Andrew Nicols
1152df3ec4 MDL-66109 css: Drop use of filter:alpha(opacity)
This CSS statement was an MS-only rule which was never accepted, and
which was abonded some time before IE 10. It has no effect in supported
browsers and can be safely replace with `opacity: [0.0-1.0]`.
2020-05-11 10:55:57 +08:00
Andrew Nicols
f879cc518e MDL-66109 js: Build changes for NodeJS upgrade
This change includes a build to fix all minified file changes in Moodle
as a result of upgrades to our build process.
2020-05-11 10:55:54 +08:00
Huong Nguyen
1937957be3 MDL-68549 Drag-drop into text: minor glitches caused by MDL-68113 2020-05-08 19:37:50 +07:00
Victor Deniz Falcon
45067da068 Merge branch 'MDL-68338' of git://github.com/timhunt/moodle 2020-05-05 22:21:36 +01:00
Jake Dallimore
cd98a57b9f Merge branch 'MDL-68382-master' of https://github.com/HuongNV13/moodle 2020-05-04 10:37:50 +08:00
Huong Nguyen
d0311165a7 MDL-68446 drag to image qtypes: remove hard-coded image size limits 2020-04-29 22:59:53 +01:00
Huong Nguyen
a05ef1307e MDL-58645 Drag and drop onto image questions: responsive support 2020-04-30 00:43:45 +07:00
Helen Foster
1fce3f52ac MDL-68434 lang: Import fixed English strings (en_fix)
Significant string changes:

* pluginnamesummary,qtype_ddimageortext and
  pluginnamesummary,qtype_ddmarker - Note about the question type not
  being accessible to visually impaired users

* addresourceoractivity,core - Removing 'resource' as the new activity
  chooser doesn't have resource types separated
2020-04-28 14:01:20 +02:00
Huong Nguyen
d2fa9e7981 MDL-68382 Drag and drop marker questions: responsive support
These changes also make it possible to print these questions.
2020-04-28 13:52:14 +07:00
Tim Hunt
a196cf5ac1 MDL-66259 qtypes: Add missing comment on get_random_guess_score
A bit off-topic for this issue number, but I noticed it while
working on this, and though it was not worth creating a
separate MDL for.
2020-04-24 15:56:23 +02:00
Tim Hunt
82df13aead MDL-66259 qtype_numerical: remove no-longer relevant todo I noticed 2020-04-24 15:56:23 +02:00
Eloy Lafuente (stronk7)
bb930b7d5b MDL-66259 qtypes: get_question_options() always call parent::
To get the question->options initialised, children must
call parent::get_question_options() always. Also, it is
just general good practice. Subclasses are meant to be
adaptations of the base class, not something completely
different.

Note, there are some changes in the data structure
produced (see changes in the tests) but these changes
are not wrong.
2020-04-24 15:56:23 +02:00
Eloy Lafuente (stronk7)
0447277904 MDL-66259 qtype: add tests to all remaining involved qtypes
That way we get the load_question_data() method covered
and all the main data, options, hints checked.
2020-04-24 15:56:23 +02:00
Tim Hunt
9874e7cdd0 MDL-66259 qtype_truefalse: unit test of loading questions from the DB
This is about to be changes, so we need a test first to catch regressions.
2020-04-24 15:56:23 +02:00
Tim Hunt
fa7431ce50 MDL-68252 question tags: fix tag editing for missingtype questions 2020-04-24 11:26:12 +01:00
Tim Hunt
89692520e8 MDL-68252 question bank: for 'missingtype' questions, hide actions 2020-04-24 09:58:35 +01:00
Tim Hunt
2bfb8d4a3d MDL-63812 qtype_gapselect: fix questions with non-consecutive gap nos 2020-04-23 14:39:52 +01:00
Tim Hunt
fdbff6cecb MDL-63812 qtype_gapselect: test data generator to standard qtype pattern 2020-04-23 14:39:52 +01:00
Jun Pataleta
477ef861a0 Merge branch 'MDL-68113-master' of https://github.com/HuongNV13/moodle 2020-04-16 11:46:50 +08:00
Sara Arjona
43cda51ea1 Merge branch 'MDL-68233' of https://github.com/timhunt/moodle 2020-04-06 12:51:22 +02:00
Huong Nguyen
f389e916f2 MDL-68113 Drag and drop into text questions: better responsive design
These changes also make it possible to print these questions.
2020-04-06 14:28:29 +07:00
Tim Hunt
3d96227305 MDL-68338 qformat_gift: support idnumbers and tags
Hopefully the new format is forwards and backwards compatible.
2020-04-05 17:49:41 +01:00
Eloy Lafuente (stronk7)
d9bb17e696 Merge branch 'MDL-68300' of https://github.com/timhunt/moodle 2020-04-02 13:13:36 +02:00
Tim Hunt
a0f8944305 MDL-68300 question bank: merge duplicate Duplicate Behat tests 2020-04-02 11:18:55 +01:00
Eloy Lafuente (stronk7)
8ba6b97577 Merge branch 'MDL-68265-master' of git://github.com/andrewnicols/moodle 2020-04-01 23:29:13 +02:00
Sara Arjona
677f87e010 Merge branch 'MDL-68277' of https://github.com/timhunt/moodle 2020-04-01 09:14:36 +02:00